blockchainethereumblockchain-walleterc20erc721walletxdaidappdecentralizederc1155erc875iosswifttokens
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
90 lines
3.1 KiB
90 lines
3.1 KiB
const {danger, warn} = require('danger')
|
|
|
|
if (danger.github) {
|
|
} else {
|
|
warnHTMLLocalizationMissing()
|
|
warnStringLocalizationMissing()
|
|
warnClosureStronglyCapturesSelf()
|
|
failUsingNSLocalizedStringWithoutR()
|
|
failIfRemoveAnyRealmSchemaMigrationBlock()
|
|
failIfUseDecimalExactlyInit()
|
|
checkForSpacesInOtherwiseEmptyLines()
|
|
}
|
|
|
|
function warnHTMLLocalizationMissing() {
|
|
const changedHtmlFiles = danger.git.modified_files.filter(f => f.includes("/en.lproj/") && f.includes(".html"))
|
|
changedHtmlFiles.forEach(each =>
|
|
warn("HTML changed. Double check that you have changed it for all languages, or will do so in another PR: " + each)
|
|
)
|
|
}
|
|
|
|
function warnStringLocalizationMissing() {
|
|
const includesLocalizationChanges = danger.git.modified_files.filter(f => f == "AlphaWallet/Localization/en.lproj/Localizable.strings").length > 0
|
|
if (includesLocalizationChanges) {
|
|
warn("Localization file changed. Double check that you have changed it for all languages, or will do so in another PR")
|
|
}
|
|
}
|
|
|
|
function warnClosureStronglyCapturesSelf() {
|
|
modifiedSwiftFiles().forEach(each => {
|
|
danger.git.diffForFile(each).then(diff => {
|
|
if (diff.added.includes("self.")) {
|
|
warn(each + ": added `self.`. Double check if closure strongly captures `self`.")
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
function failUsingNSLocalizedStringWithoutR() {
|
|
modifiedSwiftFiles().forEach(each => {
|
|
danger.git.diffForFile(each).then(diff => {
|
|
if (diff.added.includes("NSLocalizedString")) {
|
|
fail(each + ": added `NSLocalizedString`. Should use `R.string.localizable` instead.")
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
function failIfRemoveAnyRealmSchemaMigrationBlock() {
|
|
modifiedSwiftFiles().forEach(each => {
|
|
danger.git.diffForFile(each).then(diff => {
|
|
if (diff.removed.includes("if oldSchemaVersion <")) {
|
|
fail(each + ": removed `if oldSchemaVersion <`. Migration blocks for previous versions should never be removed.")
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
//Can't use Decimal(exactly: aBigUint). It compiles but crashes at runtime
|
|
function failIfUseDecimalExactlyInit() {
|
|
modifiedSwiftFiles().forEach(each => {
|
|
danger.git.diffForFile(each).then(diff => {
|
|
if (diff.added.includes("Decimal(exactly:")) {
|
|
fail(each + ": Must not use Decimal(exactly:), especially on BigUInt. Use Decimal(string: aBigUint.description) instead")
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
function checkForSpacesInOtherwiseEmptyLines() {
|
|
modifiedSwiftFiles().forEach(each => {
|
|
danger.git.diffForFile(each).then(diff => {
|
|
if (diff.added.includes(" \n")) {
|
|
fail(each + ": leading spaces for otherwise empty lines should be removed.")
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
|
|
function modifiedSwiftFiles() {
|
|
return danger.git.modified_files.filter(f => f.includes(".swift"))
|
|
}
|
|
|
|
function intersect(a, b) {
|
|
var t;
|
|
if (b.length > a.length) t = b, b = a, a = t; // indexOf to loop over shorter
|
|
return a.filter(function (e) {
|
|
return b.indexOf(e) > -1;
|
|
});
|
|
}
|
|
|