update link-check package (#539)

* update link-check package
* confirm the need of exclusion patterns because of cloudflare security check (but with a wildcard)

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>

CI/linkchecker/link_check_conf.json

@@ -13,16 +13,10 @@
             "pattern": "^http(s)?://.+.tokenview.com"
         },
         {
-            "pattern": "https://metamask.zendesk.com/hc/en-us/articles/360015489331-Importing-an-Account-New-UI-"
-        },
-        {
-            "pattern": "https://metamask.zendesk.com/hc/en-us/articles/360015289452-Creating-Additional-MetaMask-Wallets-New-UI-"
-        },
-        {
-            "pattern": "https://metamask.zendesk.com/hc/en-us/articles/360015488991-Sending-Ether-New-UI-"
+            "pattern": "/postman/.+.json"
         },
         {
-            "pattern": "/postman/.+.json"
+            "pattern": "^http(s)?://.+.zendesk.com"
         }
     ],
     "aliveStatusCodes":[200, 206],

package-lock.json

@@ -438,10 +438,9 @@
       }
     },
     "link-check": {
-      "version": "4.5.1",
-      "resolved": "https://registry.npmjs.org/link-check/-/link-check-4.5.1.tgz",
-      "integrity": "sha512-g0tu3Nkj/rpl1b6rQHRlaaSZ16iRqRDNP30jLUfRK0uNN98H56YVZlJXLjWcyjsj4f2+xZdxqeV398dx38MzfQ==",
-      "dev": true,
+      "version": "4.5.2",
+      "resolved": "https://registry.npmjs.org/link-check/-/link-check-4.5.2.tgz",
+      "integrity": "sha512-I5dWK5rl2wq7nYRBrx8kDjp2roXqa6jdHcKTPBkh9/UlhwToAgCMIRdeUGKxichESo9BpHafF1ao+B8Ek6ErJg==",
       "requires": {
         "is-relative-url": "^3.0.0",
         "isemail": "^3.2.0",

package.json

@@ -8,9 +8,8 @@
   },
   "scripts": {
     "test:links:check": "find . -name \\*.md ! -path \"./node_modules/*\" -exec ./node_modules/markdown-link-check/markdown-link-check -v -c CI/linkchecker/link_check_conf.json {} \\; 2>&1 | tee linkchecker.out",
-    "test:links:display": "cat linkchecker.out",
     "test:links:verify": "! grep -n '[✖]\\|ERROR' ./linkchecker.out",
-    "test:links": "npm run test:links:check && npm run test:links:display && npm run test:links:verify",
+    "test:links": "npm run test:links:check && npm run test:links:verify",
     "test:markdown:error": "node ./node_modules/markdownlint-cli/markdownlint.js --ignore 'env' --ignore 'node_modules' --config CI/markdownlint/lint-base-style.yml '**/*.md' 2>&1 | tee ./markdownlint.out",
     "test:markdown:info": "node ./node_modules/markdownlint-cli/markdownlint.js --ignore 'env' --ignore 'node_modules' --config CI/markdownlint/lint-info-style.yml '**/*.md' 2>&1 | tee ./markdownlint_info.out",
     "test:markdown:verify": "! grep -nE 'MD[0-9]+/.+' ./markdownlint.out",