Change to optional orElseGet (#4993)

Fix do not evaluate second expression if the value is present.

Signed-off-by: ħþ <12281088+helderjnpinto@users.noreply.github.com>

Signed-off-by: ħþ <12281088+helderjnpinto@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/TransactionCompleteResult.java

@@ -95,7 +95,9 @@ public class TransactionCompleteResult implements TransactionResult {
         tx.getTransaction().getMaxFeePerGas().map(Wei::toShortHexString).orElse(null);
     this.gasPrice =
         Quantity.create(
-            transaction.getGasPrice().orElse(transaction.getEffectiveGasPrice(tx.getBaseFee())));
+            transaction
+                .getGasPrice()
+                .orElseGet(() -> transaction.getEffectiveGasPrice(tx.getBaseFee())));
     this.hash = transaction.getHash().toString();
     this.input = transaction.getPayload().toString();
     this.nonce = Quantity.create(transaction.getNonce());