From 04b08e34cdccdda6fb076d6eaf72480da5de2fd2 Mon Sep 17 00:00:00 2001 From: "Ratan (Rai) Sur" Date: Tue, 6 Oct 2020 16:47:35 -0400 Subject: [PATCH] Enable Eth/65 by Default (#1420) Enable eth65 by default for the RC period. This commit should be reverted if issues are found before the release date. Signed-off-by: Ratan Rai Sur --- CHANGELOG.md | 2 +- KNOWN_ISSUES.md | 8 -------- .../besu/ethereum/eth/EthProtocolConfiguration.java | 2 +- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bfd5ad3e78..3037a6eae8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ Hyperledger Besu is moving its versioning scheme to [CalVer](https://calver.org/ * Added `debug_standardTraceBadBlockToFile` JSON-RPC API. This API is similar to `debug_standardTraceBlockToFile`, but can be used to obtain info about a block which has been rejected as invalid. [\#1403](https://github.com/hyperledger/besu/pull/1403) * Added support for EIP-2929 to YOLOv2. [#1387](https://github.com/hyperledger/besu/pull/1387) * Added `--start-block` and `--end-block` to the `blocks import` subcommand [\#1399](https://github.com/hyperledger/besu/pull/1399) +* Fixed memory leak in eth/65 subprotocol behavior. It is now enabled by default. [\#1420](https://github.com/hyperledger/besu/pull/1420), [#1348](https://github.com/hyperledger/besu/pull/1348), [#1321](https://github.com/hyperledger/besu/pull/1321) ### Bug Fixes @@ -19,7 +20,6 @@ Hyperledger Besu is moving its versioning scheme to [CalVer](https://calver.org/ #### Previously identified known issues -- [Eth/65 loses peers](KNOWN_ISSUES.md#eth65-loses-peers) - [Fast sync when running Besu on cloud providers](KNOWN_ISSUES.md#fast-sync-when-running-besu-on-cloud-providers) - [Privacy users with private transactions created using v1.3.4 or earlier](KNOWN_ISSUES.md#privacy-users-with-private-transactions-created-using-v134-or-earlier) - [Changes not saved to database correctly causing inconsistent private states](KNOWN_ISSUES.md#Changes-not-saved-to-database-correctly-causing-inconsistent-private-states) diff --git a/KNOWN_ISSUES.md b/KNOWN_ISSUES.md index f1f6d3d0cf..864ff56660 100644 --- a/KNOWN_ISSUES.md +++ b/KNOWN_ISSUES.md @@ -5,14 +5,6 @@ in the current release are provided in the [Changelog](CHANGELOG.md). Known issues are open issues categorized as [Very High or High impact](https://wiki.hyperledger.org/display/BESU/Defect+Prioritisation+Policy). -## Eth/65 loses peers - -From v1.4.4, `eth/65` is [disabled by default](https://github.com/hyperledger/besu/pull/741). - -If enabled, peers will slowly drop off and eventually Besu will fall out of sync or stop syncing. - -A fix for this issue is being actively worked on. - ## Fast sync when running Besu on cloud providers A known [RocksDB issue](https://github.com/facebook/rocksdb/issues/6435) causes fast sync to fail diff --git a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/EthProtocolConfiguration.java b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/EthProtocolConfiguration.java index 48c9b41955..756ea23c64 100644 --- a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/EthProtocolConfiguration.java +++ b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/EthProtocolConfiguration.java @@ -27,7 +27,7 @@ public class EthProtocolConfiguration { public static final int DEFAULT_MAX_GET_RECEIPTS = 256; public static final int DEFAULT_MAX_GET_NODE_DATA = 384; public static final int DEFAULT_MAX_GET_POOLED_TRANSACTIONS = 256; - public static final boolean DEFAULT_ETH_65_ENABLED = false; + public static final boolean DEFAULT_ETH_65_ENABLED = true; private final int maxGetBlockHeaders; private final int maxGetBlockBodies;