From 19cd63315d010c8a0bc742cd570eeb544e38237c Mon Sep 17 00:00:00 2001 From: Adrian Sutton Date: Thu, 11 Oct 2018 06:22:27 +1000 Subject: [PATCH] [NC-1578] EIP-1052 EXTCODEHASH Operation (#19) --- .../ethereum/core/AbstractWorldUpdater.java | 16 +++ .../pantheon/ethereum/core/Account.java | 7 + .../mainnet/ConstantinopleGasCalculator.java | 7 + .../mainnet/FrontierGasCalculator.java | 6 + .../mainnet/MainnetEvmRegistries.java | 2 + .../pantheon/ethereum/vm/GasCalculator.java | 8 ++ .../vm/operations/ExtCodeHashOperation.java | 33 +++++ .../worldstate/DefaultMutableWorldState.java | 5 + .../pantheon/ethereum/core/HashTest.java | 15 ++ .../operations/ExtCodeHashOperationTest.java | 131 ++++++++++++++++++ 10 files changed, 230 insertions(+) create mode 100644 ethereum/core/src/main/java/net/consensys/pantheon/ethereum/vm/operations/ExtCodeHashOperation.java create mode 100644 ethereum/core/src/test/java/net/consensys/pantheon/ethereum/core/HashTest.java create mode 100644 ethereum/core/src/test/java/net/consensys/pantheon/ethereum/vm/operations/ExtCodeHashOperationTest.java diff --git a/ethereum/core/src/main/java/net/consensys/pantheon/ethereum/core/AbstractWorldUpdater.java b/ethereum/core/src/main/java/net/consensys/pantheon/ethereum/core/AbstractWorldUpdater.java index c7b8c22f71..c106fdb77f 100644 --- a/ethereum/core/src/main/java/net/consensys/pantheon/ethereum/core/AbstractWorldUpdater.java +++ b/ethereum/core/src/main/java/net/consensys/pantheon/ethereum/core/AbstractWorldUpdater.java @@ -158,6 +158,7 @@ public abstract class AbstractWorldUpdater val = storageTrie().get(Hash.hash(key.getBytes())); diff --git a/ethereum/core/src/test/java/net/consensys/pantheon/ethereum/core/HashTest.java b/ethereum/core/src/test/java/net/consensys/pantheon/ethereum/core/HashTest.java new file mode 100644 index 0000000000..adecb1341c --- /dev/null +++ b/ethereum/core/src/test/java/net/consensys/pantheon/ethereum/core/HashTest.java @@ -0,0 +1,15 @@ +package net.consensys.pantheon.ethereum.core; + +import static org.assertj.core.api.Assertions.assertThat; + +import org.junit.Test; + +public class HashTest { + + @Test + public void shouldGetExpectedValueForEmptyHash() { + assertThat(Hash.EMPTY) + .isEqualTo( + Hash.fromHexString("c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470")); + } +} diff --git a/ethereum/core/src/test/java/net/consensys/pantheon/ethereum/vm/operations/ExtCodeHashOperationTest.java b/ethereum/core/src/test/java/net/consensys/pantheon/ethereum/vm/operations/ExtCodeHashOperationTest.java new file mode 100644 index 0000000000..b86a7011b5 --- /dev/null +++ b/ethereum/core/src/test/java/net/consensys/pantheon/ethereum/vm/operations/ExtCodeHashOperationTest.java @@ -0,0 +1,131 @@ +package net.consensys.pantheon.ethereum.vm.operations; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.Mockito.mock; + +import net.consensys.pantheon.ethereum.chain.Blockchain; +import net.consensys.pantheon.ethereum.core.Address; +import net.consensys.pantheon.ethereum.core.AddressHelpers; +import net.consensys.pantheon.ethereum.core.BlockHeaderTestFixture; +import net.consensys.pantheon.ethereum.core.Gas; +import net.consensys.pantheon.ethereum.core.Hash; +import net.consensys.pantheon.ethereum.core.Wei; +import net.consensys.pantheon.ethereum.core.WorldUpdater; +import net.consensys.pantheon.ethereum.db.WorldStateArchive; +import net.consensys.pantheon.ethereum.mainnet.ConstantinopleGasCalculator; +import net.consensys.pantheon.ethereum.vm.Code; +import net.consensys.pantheon.ethereum.vm.MessageFrame; +import net.consensys.pantheon.ethereum.vm.MessageFrame.Type; +import net.consensys.pantheon.ethereum.vm.Words; +import net.consensys.pantheon.ethereum.worldstate.KeyValueStorageWorldStateStorage; +import net.consensys.pantheon.services.kvstore.InMemoryKeyValueStorage; +import net.consensys.pantheon.util.bytes.Bytes32; +import net.consensys.pantheon.util.bytes.BytesValue; +import net.consensys.pantheon.util.uint.UInt256; + +import java.util.ArrayDeque; + +import org.junit.Test; + +public class ExtCodeHashOperationTest { + + private static final Address ADDRESS1 = AddressHelpers.ofValue(11111111); + private static final Address REQUESTED_ADDRESS = AddressHelpers.ofValue(22222222); + + private final Blockchain blockchain = mock(Blockchain.class); + + private final WorldStateArchive worldStateArchive = + new WorldStateArchive(new KeyValueStorageWorldStateStorage(new InMemoryKeyValueStorage())); + private final WorldUpdater worldStateUpdater = worldStateArchive.getMutable().updater(); + + private final ExtCodeHashOperation operation = + new ExtCodeHashOperation(new ConstantinopleGasCalculator()); + + @Test + public void shouldCharge400Gas() { + assertThat(operation.cost(createMessageFrame(REQUESTED_ADDRESS))).isEqualTo(Gas.of(400)); + } + + @Test + public void shouldReturnZeroWhenAccountDoesNotExist() { + final Bytes32 result = executeOperation(REQUESTED_ADDRESS); + assertThat(result).isEqualTo(Bytes32.ZERO); + } + + @Test + public void shouldReturnHashOfEmptyDataWhenAccountExistsButDoesNotHaveCode() { + worldStateUpdater.getOrCreate(REQUESTED_ADDRESS); + assertThat(executeOperation(REQUESTED_ADDRESS)).isEqualTo(Hash.EMPTY); + } + + @Test + public void shouldReturnZeroWhenPrecompiledContractHasNoBalance() { + assertThat(executeOperation(Address.ECREC)).isEqualTo(Bytes32.ZERO); + } + + @Test + public void shouldReturnEmptyCodeHashWhenPrecompileHasBalance() { + // Sending money to a precompile causes it to exist in the world state archive. + worldStateUpdater.getOrCreate(Address.ECREC).setBalance(Wei.of(10)); + assertThat(executeOperation(Address.ECREC)).isEqualTo(Hash.EMPTY); + } + + @Test + public void shouldGetHashOfAccountCodeWhenCodeIsPresent() { + final BytesValue code = BytesValue.fromHexString("0xabcdef"); + worldStateUpdater.getOrCreate(REQUESTED_ADDRESS).setCode(code); + assertThat(executeOperation(REQUESTED_ADDRESS)).isEqualTo(Hash.hash(code)); + } + + @Test + public void shouldZeroOutLeftMostBitsToGetAddress() { + // If EXTCODEHASH of A is X, then EXTCODEHASH of A + 2**160 is X. + final BytesValue code = BytesValue.fromHexString("0xabcdef"); + worldStateUpdater.getOrCreate(REQUESTED_ADDRESS).setCode(code); + final Bytes32 value = + Words.fromAddress(REQUESTED_ADDRESS) + .asUInt256() + .plus(UInt256.of(2).pow(UInt256.of(160))) + .getBytes(); + final MessageFrame frame = createMessageFrame(value); + operation.execute(frame); + assertThat(frame.getStackItem(0)).isEqualTo(Hash.hash(code)); + } + + private Bytes32 executeOperation(final Address requestedAddress) { + final MessageFrame frame = createMessageFrame(requestedAddress); + operation.execute(frame); + return frame.getStackItem(0); + } + + private MessageFrame createMessageFrame(final Address requestedAddress) { + final Bytes32 stackItem = Words.fromAddress(requestedAddress); + return createMessageFrame(stackItem); + } + + private MessageFrame createMessageFrame(final Bytes32 stackItem) { + final MessageFrame frame = + new MessageFrame.Builder() + .type(Type.MESSAGE_CALL) + .initialGas(Gas.MAX_VALUE) + .inputData(BytesValue.EMPTY) + .depth(1) + .gasPrice(Wei.ZERO) + .contract(ADDRESS1) + .address(ADDRESS1) + .originator(ADDRESS1) + .sender(ADDRESS1) + .worldState(worldStateUpdater) + .messageFrameStack(new ArrayDeque<>()) + .blockHeader(new BlockHeaderTestFixture().buildHeader()) + .value(Wei.ZERO) + .apparentValue(Wei.ZERO) + .code(new Code(BytesValue.EMPTY)) + .blockchain(blockchain) + .completer(messageFrame -> {}) + .build(); + + frame.pushStackItem(stackItem); + return frame; + } +}