Fix default logging (#47)

Default logging should be 'null' - which means that Besu will do nothing
to the Log4J2 logging levels and rely on the built in or user supplied
log4j2.xml configuration files to set up logging.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
pull/51/head
Danno Ferrin 5 years ago committed by GitHub
parent 231cd71c7b
commit 497e825919
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java
  2. 2
      besu/src/main/java/org/hyperledger/besu/cli/subcommands/RetestethSubCommand.java

@ -538,8 +538,8 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
names = {"--logging", "-l"}, names = {"--logging", "-l"},
paramLabel = "<LOG VERBOSITY LEVEL>", paramLabel = "<LOG VERBOSITY LEVEL>",
description = description =
"Logging verbosity levels: OFF, FATAL, ERROR, WARN, INFO, DEBUG, TRACE, ALL (default: ${DEFAULT-VALUE})") "Logging verbosity levels: OFF, FATAL, ERROR, WARN, INFO, DEBUG, TRACE, ALL (default: INFO)")
private final Level logLevel = Level.INFO; private final Level logLevel = null;
@Option( @Option(
names = {"--miner-enabled"}, names = {"--miner-enabled"},
@ -932,7 +932,7 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
if (!NetworkUtility.isNetworkInterfaceAvailable(p2pInterface)) { if (!NetworkUtility.isNetworkInterfaceAvailable(p2pInterface)) {
throw new ParameterException(commandLine, failMessage); throw new ParameterException(commandLine, failMessage);
} }
} catch (UnknownHostException | SocketException e) { } catch (final UnknownHostException | SocketException e) {
throw new ParameterException(commandLine, failMessage, e); throw new ParameterException(commandLine, failMessage, e);
} }
} }

@ -62,7 +62,7 @@ public class RetestethSubCommand implements Runnable {
paramLabel = "<LOG VERBOSITY LEVEL>", paramLabel = "<LOG VERBOSITY LEVEL>",
description = description =
"Logging verbosity levels: OFF, FATAL, WARN, INFO, DEBUG, TRACE, ALL (default: INFO)") "Logging verbosity levels: OFF, FATAL, WARN, INFO, DEBUG, TRACE, ALL (default: INFO)")
private final Level logLevel = Level.INFO; private final Level logLevel = null;
@SuppressWarnings("FieldMayBeFinal") // Because PicoCLI requires Strings to not be final. @SuppressWarnings("FieldMayBeFinal") // Because PicoCLI requires Strings to not be final.
@Option( @Option(

Loading…
Cancel
Save