Deprecation notice for GoQuorum-compatible privacy and IBFT 1.0 (#4839)

* remove quorum ats task

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* add deprecation notice

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* typo

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

.circleci/config.yml

@@ -37,14 +37,6 @@ executors:
     working_directory: ~/project
     environment:
       GRADLE_OPTS: -Dorg.gradle.daemon=false -Dorg.gradle.parallel=true -Dorg.gradle.workers.max=4
-      
-  quorum_ats_executor:
-    docker:
-      - image: cimg/openjdk:11.0
-    resource_class: xlarge
-    working_directory: ~/project
-    environment:
-      GRADLE_OPTS: -Dorg.gradle.daemon=false
 
   xl_machine_executor:
     machine:
@@ -251,25 +243,6 @@ jobs:
       - capture_test_results
       - capture_test_logs
 
-  acceptanceTestsQuorum:
-    parallelism: 1
-    executor: quorum_ats_executor
-    steps:
-      - attach_workspace:
-          at: ~/project
-      - setup_remote_docker:
-          version: 20.10.14
-          docker_layer_caching: true
-      - run:
-          name: Quorum Acceptance Tests
-          no_output_timeout: 5m
-          command: ./gradlew --no-daemon acceptanceTestsQuorum
-      - store_artifacts:
-          path: build/quorum-at
-          destination: quorum-at-artifacts
-      - store_test_results:
-          path: build/quorum-at/openjdk-latest/reports/xml-report
-
   buildDocker:
     executor: besu_executor_med
     steps:
@@ -469,7 +442,4 @@ workflows:
                 - main
     jobs:
       - assemble
-      - acceptanceTestsQuorum:
-          requires:
-            - assemble
       - dockerScan

CHANGELOG.md

@@ -1,4 +1,10 @@
 # Changelog
+## 23.1
+
+### Breaking Changes
+- GoQuorum-compatible privacy is deprecated and will be removed in 23.4
+- IBFT 1.0 is deprecated and will be removed in 23.4
+
 ## 22.10.4
 
 ### Additions and Improvements
@@ -36,7 +42,7 @@ https://hyperledger.jfrog.io/hyperledger/besu-binaries/besu/22.10.3/besu-22.10.3
 This is a hotfix release to resolve a race condition that results in segfaults, introduced in 22.10.1 release.
 
 ### Bug Fixes
-- bugfix for async operations on Snashot worldstates [#4767](https://github.com/hyperledger/besu/pull/4767)
+- bugfix for async operations on Snapshot worldstates [#4767](https://github.com/hyperledger/besu/pull/4767)
 
 ### Download Links
 https://hyperledger.jfrog.io/hyperledger/besu-binaries/besu/22.10.2/besu-22.10.2.tar.gz  / sha256: cdb36141e3cba6379d35016e0a2de2edba579d4786124b5f7257b1e4a68867a2

build.gradle

@@ -687,41 +687,6 @@ task testDocker {
   }
 }
 
-task acceptanceTestsQuorum {
-  /**
-   * Tags Description
-   *
-   * Basic tests for private and public tx: basic
-   * Start a Besu/EthSigner/Tessera network with IBFT2: networks/typical-besu::ibft2
-   *
-   * Filter only for spam tests supported by Besu: (spam && raw)
-   * Not available features in Besu: privacy-enhancements-disabled, extension, mps
-   * Not available RPC methods in Besu: async, storage-root, personal-api-signed
-   *
-   * Ignored for now (privacy-polishing): eth-api-signed, nosupport
-   *
-   * LOGGING_LEVEL_COM_QUORUM_GAUGE=DEBUG -- enables HTTP JSON-RPC logging
-   */
-  def tags = "(basic && !nosupport && !mps && !(spam && !raw) && !eth-api-signed && !privacy-enhancements-disabled && !async && !extension && !storage-root && !personal-api-signed) || networks/typical-besu::ibft2"
-
-  doLast {
-    exec {
-      def variant = "openjdk-latest"
-      def variantDirectory = "${buildDir}/quorum-at/${variant}"
-      def dataDirectory = "${variantDirectory}/data"
-      def reportsDirectory = "${variantDirectory}/reports"
-      new File(dataDirectory).mkdirs()
-      new File(reportsDirectory).mkdirs()
-
-      def image = project.hasProperty('release.releaseVersion') ? "${dockerImageName}:" + project.property('release.releaseVersion') : "${dockerImageName}:${project.version}"
-      def dockerEnv = "--env LOGGING_LEVEL_COM_QUORUM_GAUGE=DEBUG --env TF_VAR_besu_docker_image='{name=\"${image}-${variant}\",local=true}'"
-      def dockerVolumes = "-v ${reportsDirectory}:/workspace/target/gauge/reports/ -v /var/run/docker.sock:/var/run/docker.sock -v ${dataDirectory}:${dataDirectory}"
-      executable "sh"
-      args "-c", "docker run ${dockerEnv} --rm --network host ${dockerVolumes} quorumengineering/acctests:latest test -PgaugeFailSafe -Pauto -Dtags=\"${tags}\" -Dauto.outputDir=${dataDirectory} -Dnetwork.forceDestroy=true -Dauto.jobid=${variant}"
-    }
-  }
-}
-
 task dockerUpload {
   dependsOn distDocker
   def architecture = System.getenv('architecture')