From 61c7e18ab446a7383bafc2e10d96a88595cf1986 Mon Sep 17 00:00:00 2001 From: Sally MacFarlane Date: Wed, 14 Feb 2024 15:42:12 +1000 Subject: [PATCH] Add tests for user profiles (#6568) * test each profile * removed duplicated line * use non-deprecated name for sync mode Signed-off-by: Sally MacFarlane --------- Signed-off-by: Sally MacFarlane --- .../cli/CascadingDefaultProviderTest.java | 2 - .../hyperledger/besu/cli/ProfilesTest.java | 37 +++++++++++++++++++ .../resources/profiles/minimalist-staker.toml | 2 +- 3 files changed, 38 insertions(+), 3 deletions(-) create mode 100644 besu/src/test/java/org/hyperledger/besu/cli/ProfilesTest.java diff --git a/besu/src/test/java/org/hyperledger/besu/cli/CascadingDefaultProviderTest.java b/besu/src/test/java/org/hyperledger/besu/cli/CascadingDefaultProviderTest.java index e9707f1dfd..fcba28bd61 100644 --- a/besu/src/test/java/org/hyperledger/besu/cli/CascadingDefaultProviderTest.java +++ b/besu/src/test/java/org/hyperledger/besu/cli/CascadingDefaultProviderTest.java @@ -182,8 +182,6 @@ public class CascadingDefaultProviderTest extends CommandTestAbstract { assertThat(syncConfig.getSyncMode()).isEqualTo(SyncMode.FAST); assertThat(syncConfig.getFastSyncMinimumPeerCount()).isEqualTo(5); - assertThat(commandErrorOutput.toString(UTF_8)).isEmpty(); - assertThat(commandOutput.toString(UTF_8)).isEmpty(); assertThat(commandErrorOutput.toString(UTF_8)).isEmpty(); } diff --git a/besu/src/test/java/org/hyperledger/besu/cli/ProfilesTest.java b/besu/src/test/java/org/hyperledger/besu/cli/ProfilesTest.java new file mode 100644 index 0000000000..3c1a5f75cf --- /dev/null +++ b/besu/src/test/java/org/hyperledger/besu/cli/ProfilesTest.java @@ -0,0 +1,37 @@ +/* + * Copyright Hyperledger Besu Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on + * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the + * specific language governing permissions and limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + */ +package org.hyperledger.besu.cli; + +import static java.nio.charset.StandardCharsets.UTF_8; +import static org.assertj.core.api.Assertions.assertThat; + +import org.hyperledger.besu.cli.config.ProfileName; + +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.EnumSource; + +public class ProfilesTest extends CommandTestAbstract { + + /** Test if besu will validate the combination of options within the given profile. */ + @ParameterizedTest + @EnumSource(ProfileName.class) + public void testProfileWithNoOverrides_doesNotError(final ProfileName profileName) { + + parseCommand("--profile", profileName.name()); + + assertThat(commandOutput.toString(UTF_8)).isEmpty(); + assertThat(commandErrorOutput.toString(UTF_8)).isEmpty(); + } +} diff --git a/config/src/main/resources/profiles/minimalist-staker.toml b/config/src/main/resources/profiles/minimalist-staker.toml index f465b00bf4..fcdbf64363 100644 --- a/config/src/main/resources/profiles/minimalist-staker.toml +++ b/config/src/main/resources/profiles/minimalist-staker.toml @@ -1,4 +1,4 @@ -sync-mode="X_CHECKPOINT" +sync-mode="CHECKPOINT" data-storage-format="BONSAI" bonsai-historical-block-limit=128 max-peers=25 \ No newline at end of file