Merge pull request from GHSA-7pg2-p5vj-xp5h

Shift operation expect the shift amount to be an unsigned int 256, even
though only 8 bits provides meaningful value. Besu optimized this by
casting this to an int, but it was signed, resulting in a bad shift
amount. To ensure that such errors don't cause issues again test the
binary data types as a potentially negative along the major int
types (8,16,32,64,128,256).

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>

ethereum/core/src/test/java/org/hyperledger/besu/ethereum/vm/operations/SarOperationTest.java

@@ -143,6 +143,66 @@ public class SarOperationTest {
       "0x100",
       "0x0000000000000000000000000000000000000000000000000000000000000000"
     },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x80",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x80000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000000000000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x80000000000000000000000000000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000000000000000000000000000000000000000000000000000000000000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x8000000000000000000000000000000000000000000000000000000000000400",
+      "0x80",
+      "0xffffffffffffffffffffffffffffffff80000000000000000000000000000000"
+    },
+    {
+      "0x8000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000",
+      "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
+    },
+    {
+      "0x8000000000000000000000000000000000000000000000000000000000000400",
+      "0x80000000",
+      "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
+    },
+    {
+      "0x8000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000000000000000",
+      "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
+    },
+    {
+      "0x8000000000000000000000000000000000000000000000000000000000000400",
+      "0x80000000000000000000000000000000",
+      "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
+    },
+    {
+      "0x8000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000000000000000000000000000000000000000000000000000000000000000",
+      "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
+    },
   };
 
   @Parameterized.Parameters(name = "{index}: {0}, {1}, {2}")

ethereum/core/src/test/java/org/hyperledger/besu/ethereum/vm/operations/ShlOperationTest.java

@@ -92,6 +92,36 @@ public class ShlOperationTest {
       "0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff",
       "0x01",
       "0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x80",
+      "0x0000000000000000000000000000040000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x80000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000000000000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x80000000000000000000000000000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000000000000000000000000000000000000000000000000000000000000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
     }
   };
 

ethereum/core/src/test/java/org/hyperledger/besu/ethereum/vm/operations/ShrOperationTest.java

@@ -112,6 +112,36 @@ public class ShrOperationTest {
       "0x01",
       "0x0000000000000000000000000000000000000000000000000000000000000000"
     },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x80",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x80000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000000000000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x80000000000000000000000000000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    },
+    {
+      "0x0000000000000000000000000000000000000000000000000000000000000400",
+      "0x8000000000000000000000000000000000000000000000000000000000000000",
+      "0x0000000000000000000000000000000000000000000000000000000000000000"
+    }
   };
 
   @Parameterized.Parameters(name = "{index}: {0}, {1}, {2}")