Move log entry to specific places where it is useful (#6873)

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>

consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/statemachine/BftFinalState.java

@@ -28,14 +28,9 @@ import org.hyperledger.besu.datatypes.Address;
 import java.time.Clock;
 import java.util.Collection;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 /** This is the full data set, or context, required for many of the aspects of BFT workflows. */
 public class BftFinalState {
 
-  private static final Logger LOG = LoggerFactory.getLogger(BftFinalState.class);
-
   private final ValidatorProvider validatorProvider;
   private final NodeKey nodeKey;
   private final Address localAddress;
@@ -133,7 +128,6 @@ public class BftFinalState {
    */
   public boolean isLocalNodeValidator() {
     final boolean isValidator = getValidators().contains(localAddress);
-    LOG.debug(isValidator ? "Local node is a validator" : "Local node is a non-validator");
     return isValidator;
   }
 

consensus/ibft/src/main/java/org/hyperledger/besu/consensus/ibft/statemachine/IbftBlockHeightManagerFactory.java

@@ -20,9 +20,14 @@ import org.hyperledger.besu.consensus.ibft.payload.MessageFactory;
 import org.hyperledger.besu.consensus.ibft.validation.MessageValidatorFactory;
 import org.hyperledger.besu.ethereum.core.BlockHeader;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /** The Ibft block height manager factory. */
 public class IbftBlockHeightManagerFactory {
 
+  private static final Logger LOG = LoggerFactory.getLogger(IbftBlockHeightManagerFactory.class);
+
   private final IbftRoundFactory roundFactory;
   private final BftFinalState finalState;
   private final MessageValidatorFactory messageValidatorFactory;
@@ -55,8 +60,10 @@ public class IbftBlockHeightManagerFactory {
    */
   public BaseIbftBlockHeightManager create(final BlockHeader parentHeader) {
     if (finalState.isLocalNodeValidator()) {
+      LOG.debug("Local node is a validator");
       return createFullBlockHeightManager(parentHeader);
     } else {
+      LOG.debug("Local node is a non-validator");
       return createNoOpBlockHeightManager(parentHeader);
     }
   }

consensus/qbft/src/main/java/org/hyperledger/besu/consensus/qbft/statemachine/QbftBlockHeightManagerFactory.java

@@ -21,9 +21,14 @@ import org.hyperledger.besu.consensus.qbft.validation.MessageValidatorFactory;
 import org.hyperledger.besu.consensus.qbft.validator.ValidatorModeTransitionLogger;
 import org.hyperledger.besu.ethereum.core.BlockHeader;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /** The Qbft block height manager factory. */
 public class QbftBlockHeightManagerFactory {
 
+  private static final Logger LOG = LoggerFactory.getLogger(QbftBlockHeightManagerFactory.class);
+
   private final QbftRoundFactory roundFactory;
   private final BftFinalState finalState;
   private final MessageValidatorFactory messageValidatorFactory;
@@ -62,8 +67,10 @@ public class QbftBlockHeightManagerFactory {
     validatorModeTransitionLogger.logTransitionChange(parentHeader);
 
     if (finalState.isLocalNodeValidator()) {
+      LOG.debug("Local node is a validator");
       return createFullBlockHeightManager(parentHeader);
     } else {
+      LOG.debug("Local node is a non-validator");
       return createNoOpBlockHeightManager(parentHeader);
     }
   }