removed unnecessary use of static temp dir (#6251)

* don't use static tempdir

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

besu/src/test/java/org/hyperledger/besu/PrivacyReorgTest.java

@@ -81,7 +81,7 @@ import org.junit.jupiter.api.io.TempDir;
 @SuppressWarnings("rawtypes")
 public class PrivacyReorgTest {
 
-  @TempDir private static Path folder;
+  @TempDir private Path folder;
 
   private static final Supplier<SignatureAlgorithm> SIGNATURE_ALGORITHM =
       Suppliers.memoize(SignatureAlgorithmFactory::getInstance);

besu/src/test/java/org/hyperledger/besu/RunnerTest.java

@@ -122,7 +122,7 @@ public final class RunnerTest {
     vertx.close();
   }
 
-  @TempDir private static Path temp;
+  @TempDir private Path temp;
 
   @Test
   public void getFixedNodes() {

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/AbstractEthGraphQLHttpServiceTest.java

@@ -56,7 +56,7 @@ import org.mockito.ArgumentMatchers;
 import org.mockito.Mockito;
 
 public abstract class AbstractEthGraphQLHttpServiceTest {
-  @TempDir private static Path tempDir;
+  @TempDir private Path tempDir;
 
   private static BlockchainSetupUtil blockchainSetupUtil;
 

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpServiceCorsTest.java

@@ -41,7 +41,7 @@ import org.junit.jupiter.api.io.TempDir;
 import org.mockito.Mockito;
 
 public class GraphQLHttpServiceCorsTest {
-  @TempDir private static Path folder;
+  @TempDir private Path folder;
 
   private final Vertx vertx = Vertx.vertx();
   private final OkHttpClient client = new OkHttpClient();

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpServiceHostWhitelistTest.java

@@ -46,7 +46,7 @@ import org.mockito.Mockito;
 
 public class GraphQLHttpServiceHostWhitelistTest {
 
-  @TempDir private static Path folder;
+  @TempDir private Path folder;
 
   protected static Vertx vertx;
 

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpServiceTest.java

@@ -59,6 +59,7 @@ import org.mockito.Mockito;
 
 public class GraphQLHttpServiceTest {
 
+  // this tempDir is deliberately static
   @TempDir private static Path folder;
 
   private static final Vertx vertx = Vertx.vertx();

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceCorsTest.java

@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
 public class JsonRpcHttpServiceCorsTest {
-  @TempDir private static Path folder;
+  @TempDir private Path folder;
 
   private final Vertx vertx = Vertx.vertx();
   private final OkHttpClient client = new OkHttpClient();

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceLoginTest.java

@@ -90,6 +90,7 @@ import org.mockito.junit.jupiter.MockitoExtension;
 @ExtendWith(MockitoExtension.class)
 public class JsonRpcHttpServiceLoginTest {
 
+  // this tempDir is deliberately static
   @TempDir private static Path folder;
 
   private static final Vertx vertx = Vertx.vertx();

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceRpcApisTest.java

@@ -88,7 +88,7 @@ import org.mockito.junit.jupiter.MockitoExtension;
 @ExtendWith(MockitoExtension.class)
 public class JsonRpcHttpServiceRpcApisTest {
 
-  @TempDir private static Path folder;
+  @TempDir private Path folder;
 
   private final Vertx vertx = Vertx.vertx();
   private final OkHttpClient client = new OkHttpClient();

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceTestBase.java

@@ -67,6 +67,7 @@ import org.junit.jupiter.api.io.TempDir;
 
 public class JsonRpcHttpServiceTestBase {
 
+  // this tempDir is deliberately static
   @TempDir private static Path folder;
   protected final JsonRpcTestHelper testHelper = new JsonRpcTestHelper();
 

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceTlsClientAuthTest.java

@@ -79,6 +79,7 @@ import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
 public class JsonRpcHttpServiceTlsClientAuthTest {
+  // this tempDir is deliberately static
   @TempDir private static Path folder;
 
   protected static final Vertx vertx = Vertx.vertx();

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/DebugStandardTraceBlockToFileTest.java

@@ -44,6 +44,7 @@ import org.mockito.Answers;
 
 public class DebugStandardTraceBlockToFileTest {
 
+  // this tempDir is deliberately static
   @TempDir private static Path folder;
 
   private final WorldStateArchive archive =

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/processor/TransactionTracerTest.java

@@ -66,7 +66,7 @@ import org.mockito.quality.Strictness;
 @MockitoSettings(strictness = Strictness.LENIENT)
 public class TransactionTracerTest {
 
-  @TempDir private static Path traceDir;
+  @TempDir private Path traceDir;
 
   @Mock private ProtocolSchedule protocolSchedule;
   @Mock private Blockchain blockchain;

ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/query/BlockchainQueriesLogCacheTest.java

@@ -58,6 +58,7 @@ import org.mockito.quality.Strictness;
 @MockitoSettings(strictness = Strictness.LENIENT)
 public class BlockchainQueriesLogCacheTest {
 
+  // this tempDir is deliberately static
   @TempDir private static Path cacheDir;
 
   private static LogsQuery logsQuery;

ethereum/core/src/integration-test/java/org/hyperledger/besu/ethereum/mainnet/precompiles/privacy/PrivacyPrecompiledContractIntegrationTest.java

@@ -72,6 +72,7 @@ import org.junit.jupiter.api.io.TempDir;
 
 public class PrivacyPrecompiledContractIntegrationTest {
 
+  // this tempDir is deliberately static
   @TempDir private static Path folder;
 
   private static final Bytes VALID_PRIVATE_TRANSACTION_RLP =

ethereum/core/src/test/java/org/hyperledger/besu/ethereum/util/RawBlockIteratorTest.java

@@ -38,7 +38,7 @@ import org.junit.jupiter.api.io.TempDir;
 
 public class RawBlockIteratorTest {
 
-  @TempDir private static Path tmp;
+  @TempDir private Path tmp;
   private BlockDataGenerator gen;
 
   @BeforeEach

ethereum/p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/peers/StaticNodesParserTest.java

@@ -68,7 +68,7 @@ public class StaticNodesParserTest {
               .discoveryAndListeningPorts(30306)
               .build());
 
-  @TempDir private static Path testFolder;
+  @TempDir private Path testFolder;
 
   @Test
   public void validFileLoadsWithExpectedEnodes() throws IOException, URISyntaxException {