removed unnecessary use of static temp dir (#6251)

* don't use static tempdir

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
pull/6255/head
Sally MacFarlane 11 months ago committed by GitHub
parent b6e73ae080
commit d69b89a915
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      besu/src/test/java/org/hyperledger/besu/PrivacyReorgTest.java
  2. 2
      besu/src/test/java/org/hyperledger/besu/RunnerTest.java
  3. 2
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/AbstractEthGraphQLHttpServiceTest.java
  4. 2
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpServiceCorsTest.java
  5. 2
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpServiceHostWhitelistTest.java
  6. 1
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpServiceTest.java
  7. 2
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceCorsTest.java
  8. 1
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceLoginTest.java
  9. 2
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceRpcApisTest.java
  10. 1
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceTestBase.java
  11. 1
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceTlsClientAuthTest.java
  12. 1
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/DebugStandardTraceBlockToFileTest.java
  13. 2
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/processor/TransactionTracerTest.java
  14. 1
      ethereum/api/src/test/java/org/hyperledger/besu/ethereum/api/query/BlockchainQueriesLogCacheTest.java
  15. 1
      ethereum/core/src/integration-test/java/org/hyperledger/besu/ethereum/mainnet/precompiles/privacy/PrivacyPrecompiledContractIntegrationTest.java
  16. 2
      ethereum/core/src/test/java/org/hyperledger/besu/ethereum/util/RawBlockIteratorTest.java
  17. 2
      ethereum/p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/peers/StaticNodesParserTest.java

@ -81,7 +81,7 @@ import org.junit.jupiter.api.io.TempDir;
@SuppressWarnings("rawtypes")
public class PrivacyReorgTest {
@TempDir private static Path folder;
@TempDir private Path folder;
private static final Supplier<SignatureAlgorithm> SIGNATURE_ALGORITHM =
Suppliers.memoize(SignatureAlgorithmFactory::getInstance);

@ -122,7 +122,7 @@ public final class RunnerTest {
vertx.close();
}
@TempDir private static Path temp;
@TempDir private Path temp;
@Test
public void getFixedNodes() {

@ -56,7 +56,7 @@ import org.mockito.ArgumentMatchers;
import org.mockito.Mockito;
public abstract class AbstractEthGraphQLHttpServiceTest {
@TempDir private static Path tempDir;
@TempDir private Path tempDir;
private static BlockchainSetupUtil blockchainSetupUtil;

@ -41,7 +41,7 @@ import org.junit.jupiter.api.io.TempDir;
import org.mockito.Mockito;
public class GraphQLHttpServiceCorsTest {
@TempDir private static Path folder;
@TempDir private Path folder;
private final Vertx vertx = Vertx.vertx();
private final OkHttpClient client = new OkHttpClient();

@ -46,7 +46,7 @@ import org.mockito.Mockito;
public class GraphQLHttpServiceHostWhitelistTest {
@TempDir private static Path folder;
@TempDir private Path folder;
protected static Vertx vertx;

@ -59,6 +59,7 @@ import org.mockito.Mockito;
public class GraphQLHttpServiceTest {
// this tempDir is deliberately static
@TempDir private static Path folder;
private static final Vertx vertx = Vertx.vertx();

@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
public class JsonRpcHttpServiceCorsTest {
@TempDir private static Path folder;
@TempDir private Path folder;
private final Vertx vertx = Vertx.vertx();
private final OkHttpClient client = new OkHttpClient();

@ -90,6 +90,7 @@ import org.mockito.junit.jupiter.MockitoExtension;
@ExtendWith(MockitoExtension.class)
public class JsonRpcHttpServiceLoginTest {
// this tempDir is deliberately static
@TempDir private static Path folder;
private static final Vertx vertx = Vertx.vertx();

@ -88,7 +88,7 @@ import org.mockito.junit.jupiter.MockitoExtension;
@ExtendWith(MockitoExtension.class)
public class JsonRpcHttpServiceRpcApisTest {
@TempDir private static Path folder;
@TempDir private Path folder;
private final Vertx vertx = Vertx.vertx();
private final OkHttpClient client = new OkHttpClient();

@ -67,6 +67,7 @@ import org.junit.jupiter.api.io.TempDir;
public class JsonRpcHttpServiceTestBase {
// this tempDir is deliberately static
@TempDir private static Path folder;
protected final JsonRpcTestHelper testHelper = new JsonRpcTestHelper();

@ -79,6 +79,7 @@ import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
public class JsonRpcHttpServiceTlsClientAuthTest {
// this tempDir is deliberately static
@TempDir private static Path folder;
protected static final Vertx vertx = Vertx.vertx();

@ -44,6 +44,7 @@ import org.mockito.Answers;
public class DebugStandardTraceBlockToFileTest {
// this tempDir is deliberately static
@TempDir private static Path folder;
private final WorldStateArchive archive =

@ -66,7 +66,7 @@ import org.mockito.quality.Strictness;
@MockitoSettings(strictness = Strictness.LENIENT)
public class TransactionTracerTest {
@TempDir private static Path traceDir;
@TempDir private Path traceDir;
@Mock private ProtocolSchedule protocolSchedule;
@Mock private Blockchain blockchain;

@ -58,6 +58,7 @@ import org.mockito.quality.Strictness;
@MockitoSettings(strictness = Strictness.LENIENT)
public class BlockchainQueriesLogCacheTest {
// this tempDir is deliberately static
@TempDir private static Path cacheDir;
private static LogsQuery logsQuery;

@ -72,6 +72,7 @@ import org.junit.jupiter.api.io.TempDir;
public class PrivacyPrecompiledContractIntegrationTest {
// this tempDir is deliberately static
@TempDir private static Path folder;
private static final Bytes VALID_PRIVATE_TRANSACTION_RLP =

@ -38,7 +38,7 @@ import org.junit.jupiter.api.io.TempDir;
public class RawBlockIteratorTest {
@TempDir private static Path tmp;
@TempDir private Path tmp;
private BlockDataGenerator gen;
@BeforeEach

@ -68,7 +68,7 @@ public class StaticNodesParserTest {
.discoveryAndListeningPorts(30306)
.build());
@TempDir private static Path testFolder;
@TempDir private Path testFolder;
@Test
public void validFileLoadsWithExpectedEnodes() throws IOException, URISyntaxException {

Loading…
Cancel
Save