From db410621b0b6c1e424bd92a6878a02cbd93f487a Mon Sep 17 00:00:00 2001 From: Sally MacFarlane Date: Wed, 31 May 2023 06:52:44 +1000 Subject: [PATCH] PR checklist - remove checkbox for non-mainnet ATs (#5514) * removed non-mainnetATs line Signed-off-by: Sally MacFarlane --------- Signed-off-by: Sally MacFarlane --- .github/workflows/pr-checklist-on-open.yml | 2 +- .../besu/ethereum/api/jsonrpc/internal/methods/EthCall.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr-checklist-on-open.yml b/.github/workflows/pr-checklist-on-open.yml index e068d0147d..d89748a943 100644 --- a/.github/workflows/pr-checklist-on-open.yml +++ b/.github/workflows/pr-checklist-on-open.yml @@ -16,5 +16,5 @@ jobs: issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, - body: '- [ ] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation).\n- [ ] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules.\n- [ ] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog).\n- [ ] If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests' + body: '- [ ] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation).\n- [ ] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog).\n- [ ] If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests' }) diff --git a/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCall.java b/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCall.java index ee1a540f64..fe8550fc66 100644 --- a/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCall.java +++ b/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCall.java @@ -140,7 +140,7 @@ public class EthCall extends AbstractBlockParameterOrBlockHashMethod { // be decided according to the provided parameters if (callParams.isMaybeStrict().isEmpty()) { transactionValidationParams.isAllowExceedingBalance( - isAllowExeedingBalanceAutoSelection(header, callParams)); + isAllowExceedingBalanceAutoSelection(header, callParams)); } else { transactionValidationParams.isAllowExceedingBalance( !callParams.isMaybeStrict().orElse(Boolean.FALSE)); @@ -148,7 +148,7 @@ public class EthCall extends AbstractBlockParameterOrBlockHashMethod { return transactionValidationParams.build(); } - private boolean isAllowExeedingBalanceAutoSelection( + private boolean isAllowExceedingBalanceAutoSelection( final BlockHeader header, final JsonCallParameter callParams) { boolean isZeroGasPrice =