Cleanup logging statements (#1500)

A few logging statements had errors in the log statement.  Either the
parameter wasn't used or it was expecting a formatted logger for errors.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
pull/1525/head
Danno Ferrin 4 years ago committed by GitHub
parent 83e03706b2
commit f14f28b977
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      consensus/ibft/src/main/java/org/hyperledger/besu/consensus/ibft/EventMultiplexer.java
  2. 2
      ethereum/permissioning/src/main/java/org/hyperledger/besu/ethereum/permissioning/TomlConfigFileParser.java
  3. 3
      nat/src/main/java/org/hyperledger/besu/nat/NatService.java

@ -57,7 +57,7 @@ public class EventMultiplexer {
throw new RuntimeException("Illegal event in queue."); throw new RuntimeException("Illegal event in queue.");
} }
} catch (final Exception e) { } catch (final Exception e) {
LOG.error("State machine threw exception while processing event {" + ibftEvent + "}", e); LOG.error("State machine threw exception while processing event \\{" + ibftEvent + "\\}", e);
} }
} }
} }

@ -68,7 +68,7 @@ public class TomlConfigFileParser {
} }
if (!tomlConfigFile.canWrite()) { if (!tomlConfigFile.canWrite()) {
LOG.warn( LOG.warn(
"Write access denied for file at: %s. Configuration modification operations will not be permitted.", "Write access denied for file at: {}. Configuration modification operations will not be permitted.",
filename); filename);
} }
return tomlConfigFile; return tomlConfigFile;

@ -192,7 +192,8 @@ public class NatService {
final NatManager natManager = getNatManager().orElseThrow(); final NatManager natManager = getNatManager().orElseThrow();
return Optional.of(natManager.getPortMapping(serviceType, networkProtocol)); return Optional.of(natManager.getPortMapping(serviceType, networkProtocol));
} catch (Exception e) { } catch (Exception e) {
LOG.warn("Caught exception while trying to query port mapping (ignoring): {}", e); LOG.warn(
"Caught exception while trying to query port mapping (ignoring): {}", e.toString());
} }
} }
return Optional.empty(); return Optional.empty();

Loading…
Cancel
Save