From ffef4d5844c3f6c2e4fb4b1cb5314dd087870ce6 Mon Sep 17 00:00:00 2001
From: Fabio Di Fabio <fabio.difabio@consensys.net>
Date: Mon, 30 Sep 2024 07:46:35 +0200
Subject: [PATCH] Fix for zombie invalid and penalized txs (#7659)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
---
 .../eth/transactions/layered/LayeredPendingTransactions.java  | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/LayeredPendingTransactions.java b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/LayeredPendingTransactions.java
index 21c75b364a..a79c05e3e6 100644
--- a/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/LayeredPendingTransactions.java
+++ b/ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/layered/LayeredPendingTransactions.java
@@ -351,9 +351,7 @@ public class LayeredPendingTransactions implements PendingTransactions {
                     }
                   });
               logDiscardedTransaction(candidatePendingTx, selectionResult);
-            }
-
-            if (selectionResult.penalize()) {
+            } else if (selectionResult.penalize()) {
               ethScheduler.scheduleTxWorkerTask(
                   () -> {
                     synchronized (this) {