Gabriel Fukushima
8601438d58
[LOGGING] snap pipeline errors and peer reputation ( #6924 )
...
* add logs for snap errors
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
* add logs for requests that are returning with errors
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
* spotless
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
* turn down the logging
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* transaction message sender logging
Signed-off-by: Jason Frame <jason.frame@consensys.net>
* log peer with peer reputation event
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* formatting
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Jason Frame <jason.frame@consensys.net>
7 months ago
garyschulte
0a24acccc2
Default bonsai to fully flat db and code storage by codehash ( #6894 )
...
* change to full flat db and code stored by code hash by default
* deprecate --Xsnapsync-synchronizer-flat-db-healing-enabled, add DataStorageOption for --Xbonsai-full-flat-db-enabled
Signed-off-by: garyschulte <garyschulte@gmail.com>
7 months ago
Jason Frame
bbbfc4c822
World state halt and chain halt fixes ( #7027 )
...
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
7 months ago
Fabio Di Fabio
690a2ea81e
Refactor genesis config file and options ( #7012 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
7 months ago
Usman Saleem
482498177c
Apply Hyperledger license header to `ethereum/eth/` ( #7035 )
...
* Apply Hyperledger license header to `ethereum/eth/`
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
7 months ago
Usman Saleem
70813fc0ca
build - Update license headers formatting (6) ( #7020 )
...
Fix license headers formatting under: ethereum/ services/
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
7 months ago
Usman Saleem
a98dfff4f6
build - Update license headers formatting ( #7018 )
...
Fix license headers formatting under: ethereum/
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
7 months ago
Lucas Saldanha
9cd50e1405
EIP-7220: Updates (Exit -> Withdrawal Request) ( #6967 )
...
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
7 months ago
Fabio Di Fabio
3d5f45c35f
Layered txpool tuning for blob transactions ( #6940 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
7 months ago
Jason Frame
e4e9f670fe
Fix worldstate halt with snap sync during initial sync ( #6981 )
...
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
7 months ago
StevenMia
2bb0a59860
chore: fix some typos in comments ( #6951 )
...
* chore: fix some typos in comments
Signed-off-by: StevenMia <flite@foxmail.com>
* Apply suggestions from code review
fix typo
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: StevenMia <flite@foxmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
02754e8136
Use tx effective gas price when comparing with min mineable gas price configuration ( #6958 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
b5b7b9f5f0
Peer disconnect message - add client info ( #6947 )
...
* add client info to disconnect message
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* exclude disconnect reason message since it makes it harder to analyse
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Danno Ferrin
27ade870ea
Consistent nonce handling ( #6941 )
...
Make handling of absurdly large nonces
more consistent across txpool and EVM.
Signed-off-by: Danno Ferrin <danno@numisight.com>
8 months ago
Gabriel Fukushima
3c54da63dd
fix npe on trace msg ( #6934 )
...
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
8 months ago
Sally MacFarlane
909b6ca355
added an else and extra logging ( #6931 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
2a74ea1f1b
richness for breach of protocol reasons ( #6925 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
5ae2823792
add peer count ( #6911 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Danno Ferrin
001080a72b
Upgrade spotless to 1.22.0 ( #6898 )
...
Upgrade spotless to 1.22.0 and reformat.
This is required for Java21 support.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
e8e1e4c449
Expose transaction count by type metrics for the layered txpool ( #6903 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 months ago
Fabio Di Fabio
f26f3f5224
Correctly initialize the txpool as disabled on creation ( #6890 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
d753b2a5d6
added richness to useless peer disconnect reasons ( #6899 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Jason Frame
758adc7d74
Improve logging of peer disconnects due to subprotocol triggered reason ( #6886 )
...
Signed-off-by: Jason Frame <jason.frame@consensys.net>
8 months ago
Simon Dudley
d9bb7a6022
Add debug logging to see why we stop downloading from peer ( #6885 )
...
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Lucas Saldanha
1e77a6c419
EIP-7002: Add exits/exits_root to block/block_header ( #6801 )
...
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
8 months ago
Jason Frame
a7b10dbece
Bws internal error fix ( #6806 )
...
Signed-off-by: Jason Frame <jason.frame@consensys.net>
8 months ago
garyschulte
9ae52a97cd
align PeerReputation timout threshold with peer max outstanding requests ( #6877 )
...
Signed-off-by: garyschulte <garyschulte@gmail.com>
8 months ago
garyschulte
336ebe93b7
remove check for snap server in controller builder ( #6876 )
...
Signed-off-by: garyschulte <garyschulte@gmail.com>
8 months ago
Fabio Di Fabio
c93cfbeb87
Blob transaction replacement rule ( #6874 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 months ago
Sally MacFarlane
b04e82a4c2
[MINOR] nuke those extra ellipses ( #6870 )
...
* no extra ellipses
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* no extra ellipses
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* spurious semicolon
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* duplicated word
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
ed678f1cc5
make test use threshold values explicitly ( #6843 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
1aabba1474
removed extra ... ( #6849 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
5e93b69503
Log at debug the first error when adding a tx for the sender fails ( #6846 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 months ago
garyschulte
34fc5eed58
Snap server rebase ( #6640 )
...
* initial snap server implementation
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
garyschulte
deaea9b34d
Snap client fixes ( #6847 )
...
* manage empty range for storage
* round rather than floor on max remote connections so that maxpeers=1 still can accept remote connections
---------
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Karim Taam <karim.t2am@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
9b3a219210
increase timeout ( #6852 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
d8e1e1710c
Remove deprecated Forest pruning ( #6810 )
...
* Remove deprecated Forest pruning
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Update CHANGELOG.md
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
---------
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
1679525ae2
Dedicated log marker for invalid txs removed from the txpool ( #6826 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
8 months ago
Sally MacFarlane
a2ef6c49da
refactor to check for null peer ( #6841 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
3a2eb4e71e
Fix to avoid broadcasting full blob txs ( #6835 )
...
* separate queue for tx hashes
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
* Refinements
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Update tests
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Update CHANGELOG
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Refinements
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
---------
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
8 months ago
Karim TAAM
f2c2512ef6
storage format refactor for preparing verkle trie integration ( #6721 )
...
Splitting Bonsai code: This commit aims to divide Bonsai into two packages
- Common Classes with a Prefix: The common part will include classes prefixed with "DiffBased." These classes are designed to provide a base for both Bonsai and any future storage format that might use this diff-based approach.
- Bonsai's Specifics: Bonsai will retain its unique features in its own package. This means that while it shares the diff-based infrastructure with the common part, it also has its own specific functionalities that are not shared with other storage format.
- Extension to Verkle: this modification add the possibility of adding "Verkle" as a new storage format based on the diff-based architecture. Like Bonsai, Verkle would use the common diff-based classes but also have its own specific features.
---------
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
8 months ago
Usman Saleem
e954537fcc
build - Refactor Besu custom error prone dependency ( #6692 )
...
Move Besu custom error-prone checks into its own repository and use it as an external dependency. This allows to move to a newer version of Google errorprone checks as well while cleaning up build.gradle file.
Key changes resulted due to this change:
* String toLowerCase and toUpperCase to use Locale.ROOT as argument
* Use interface such as List,Map or NavigatableMap instead of concrete class where appropriate.
* Simplify StringBuilder to plain String
* Suppress warnings where appropriate.
-----
Signed-off-by: Usman Saleem <usman@usmans.info>
8 months ago
Karim TAAM
15cbd8423b
Fix issues during snap sync ( #6802 )
...
The purpose of this commit is to fix some bugs detected in the snap sync. This should allow for greater stability with the snap sync and the healing of the flat DB.
---------
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
8 months ago
Jason Frame
15d54afdf9
Reduce receipt size ( #6602 )
...
Signed-off-by: Jason Frame <jason.frame@consensys.net>
8 months ago
Simon Dudley
bb9ba13cf8
Refactor BackwardsSyncAlgorithm.pickNextStep for readability ( #6775 )
...
* Refactor BackwardsSyncAlgorithm.pickNextStep for readability
...mostly extracting methods
- Result null check
- Remove redundant BannedMethod suppressions
- Add sonar config back in that was removed by mistake
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Stefan Pingel
42f4748ab9
Fix "Backward sync stuck in a loop" #6749 ( #6756 )
...
* minimal change to fix BWS
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Suraneti
feb1764199
feat: add fixed basefee options ( #6562 )
...
* feat: add fixed basefee options
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* Refactor zero base fee to be extension of fixed base fee
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* feat: use MiningParameters to fixed base fee
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add mining parameters arg on protocol schedule builder
* feat: add miningParameters on gray glacier and prague
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add miningParameters on gray glacier and prague
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add miningParameters on paris,shanghai,future,experimental
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
---------
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Suraneti <suraneti.rod@gmail.com>
Co-authored-by: Matthew Whitehead <matthew1001@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Usman Saleem
22daf346ee
Refactor StorageRangeDataRequest to fix nodes saved variable ( #6726 )
...
* Refactor StorageRangeDataRequest
-- Remove ununsed nbNodesSaved
Signed-off-by: Usman Saleem <usman@usmans.info>
* Fix import
Signed-off-by: Usman Saleem <usman@usmans.info>
* fix: Increment nodes saved variable
Signed-off-by: Usman Saleem <usman@usmans.info>
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
9 months ago
Matt Whitehead
b239fb6099
Add comments to a couple of the the EthPeer methods to clarify their behaviour ( #6733 )
...
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Fabio Di Fabio
efd1bc7070
Fix txpool dump/restore race condition ( #6665 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago