Constructor of the RoundChangeManager now accepts a
RoundChangeMessageValidator rather than creating it from inputs.
This removes complexity from this class, pushes creation back to the
validator factory, and simplifies the IbftBlockHeightManagerFactory.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
Ibft is required to validate a block upon reception, but not import
it until a later time.
As such, IBFT will require validation and importing to be separated.
The validator has been exposed as part of the ProtocolSpecification.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* Implement a new endpoint for privacy (#PRIV-5)
Create new package for implement privacy isolate, add new EeaSendSawTransaction.java and EeaSendSawTransactionTest.java
Create a new RpcApis category: EEA
Make changes to expose the endpoint in JsonRpcMethodsFactory.java, RpcApis.java and PatheonCommand.java
Create basic unit tests to call and get the response of the endpoint and call manualy and get the response
* Fix tests build failure and run gradlew spotlessApply
Also resolve merge duplication
* Remove the EEA from default APIs
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
node-priveate-key is a path and not a key. The everything_config.toml
should blatently look like a valid path
The old value was a valid path, but gave the wrong impression.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* Quick typo fix on Private-Network-Quickstart.md
* Seeded azure quickstart ready to be improved by technical writers
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* Gradle 5.1.1
Artemis went to Gradle 5.1 and it seems to be doing fine.
This upgrades to Gradle 5.1.1 and removes the two deprecation warnings in the build script.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
Integration tests have been added to determine the IBFT components
response to the reception of RoundChange messages.
Through the course of creating these tests the following changes were
made to the RoundChangeManager:
* Stores RoundChangeMessages in the order of arrival
* Discards subsequent RoundChange messages from the same node,
targeting a specific round.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* NewRoundMessageValidator ignores Round Number when comparing blocks
NewRoundMessageValidator previously ensured the block in the newest
PreparedCertificate was the same as that in the Proposal by comparing
block hashes.
However, the hash-function for received IBFT blocks includes round
number - thus the blocks will never be deemed 'equal'.
As such, the blocks must be compared using a hash function which
ignores the round number - i.e. the OnChain function.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* initial change
* Fixed spinner gif image
* Fixed MD formatting typos
* Adding images for style guide
* Word and grammar changes from review
* Changed references to CLI in titles to Command Line Interface (CLI) and changed command-line to commane line (no hypen to be consistent)
* Typo fixes
* More typo fixes...
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
tmohay
Chris Mckay
Adrian Sutton
PegaSys Admin
Danno Ferrin
Vinicius Stevam
Jason Frame
CJ Hare
MadelineMurray
Nicolas MASSART
mbaxter
Donn Trenton
mark-terry
Sally MacFarlane
Rob Dawson
Jake Haugen