With the advent of Clique, some JSON RPCs pertaining to mining are
no longer going to produce appropriate results.
The Get/Set coinbase RPCs cannot affect a Clique based miner, as such
the miner throws an "Unsupported Operation" exception. The JSON
handler is responsible for catching this, and returning an
appropriate error code.
On the transition to the EthHash/Clique Mining Coordinator a change
was lost whereby the EthHashMiningCoordinator is to capture the
current Hashrate on cancellation of a mining operation.
* [NC-1685] Fix BlockHashOperation so it handles blocks being added on forks and gets the hash of the block at the requested number on that fork rather than on the current canonical chain.
* [NC-1644] Cache block hashes across all transactions in a block.
* NC-1026 Make Framer#frame Throw on Excessively Large messages
Note that this is
* NC-1026 Make Framer#frame Throw on Excessively Large messages
It is impossible to receive an uncompressed message < 16MiB because the length field in the header is 3 bytes. So this test will never pass.
* NC-1026 Make Framer#frame Throw on Excessively Large messages
review changes
* NC-1026 Make Framer#frame Throw on Excessively Large messages
Missed change in exception type. Added Null uncompressedLength test.
The MiningCoordinator has been split into common, and ethhash
specific funcationality.
This adversely affects the JSON RPC, in that all mining related
RPCs are now generic based on the type of miner being used.
The EthHashMinerExecutor is comprised of both EthHash specific
functions as well as common functions which will be useful to other
consensus mechanisms.
As such the common functionality has been extracted to a parent class,
leaving ethhash specific functionality in the child.
Responsible for mining a block if the local node address
is a validator, and has not recently mined a block.
This has necessitated a slight rework of helper functions,
and shuffling of tests.
The EthHashBlockMiner contains both the generic mining capabilities
and the EthHash JSON specific API.
The generic capabilities have been extracted into a base class which
can be reused for Clique (or other) consensus mechanisms.
S. Matthew English
Adrian Sutton
mbaxter
Christopher Mckay
Jason Frame
tmohay
Danno Ferrin
Lucas Saldanha
PegaSys Admin