* seems like a reasonable use for TRACE level instead of DEBUG
* hint to user they should adjust logging if they really want to see the body of the corrupt HELLO
* include actual nodeId length in error message
Signed-off-by: Justin Florentine <jflorentine@gmail.com>
Co-authored-by: Justin Florentine <jflorentine@gmail.com>
Co-authored-by: matkt <karim.t2am@gmail.com>
Co-authored-by: garyschulte <garyschulte@gmail.com>
Since there are no separate gas budgets for eip-1559 and non-eip-1559 txs,
we can return to the simpler method of just comparing against the gas limit.
This is a non-functional change.
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
* refactor: isolate send raw on/off chain
Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>
* Move responsibility of checking restriction type into JsonRpcMethod
Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>
* Refactor: Make use of privacy vs private consistent
Rename s/privacyMarkerTransaction/privateMarkerTransaction/g
Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>
This takes care of the current requirements as well as provide the possibility of adding other channel handlers before that like for example a TLS handler
Signed-off-by: Saravana Perumal Shanmugam <perusworld@linux.com>
* eth_getCode try to get from private state first
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
* add container test for eth_getCode
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
* allow transaction pool to accept transactions with maxFeePerGas less than base fee
* make 1559 fields return short hex format instead of 8 bytes zero padded
* update reference tests to latest
Signed-off-by: garyschulte <garyschulte@gmail.com>
* run the estimate gas test
* Revert "Modify Gas estimation logic for GoQuorum mode (#2282)"
This reverts commit 3627662f82.
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Co-authored-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
* address assumption that if 1559 is enabled there is a london fork block config
fixes#2192
Signed-off-by: garyschulte <garyschulte@gmail.com>
* omit null chainId from transaction json serialization, and fix merge regression
Signed-off-by: garyschulte <garyschulte@gmail.com>
* update json-rpc responses for 1559, use current feeCap and gasPremium field names
Signed-off-by: garyschulte <garyschulte@gmail.com>
* add pr number to changelog
Signed-off-by: garyschulte <garyschulte@gmail.com>
* fix transaction decoder
Signed-off-by: Gary Schulte <garyschulte@gmail.com>
* rebase and fix merge conflicts
Signed-off-by: garyschulte <garyschulte@gmail.com>
* remove null chainId from json-rpc test fixtures
Signed-off-by: garyschulte <garyschulte@gmail.com>
* the great 1559 rename
Signed-off-by: garyschulte <garyschulte@gmail.com>
* re-remove gasTarget
Signed-off-by: garyschulte <garyschulte@gmail.com>
* add serialization tests for 1559 transaction fields
Signed-off-by: garyschulte <garyschulte@gmail.com>
* add json property ordering annotations to Transaction*Result and spotless
Signed-off-by: garyschulte <garyschulte@gmail.com>
* rebase on master, update error message feedback from Karim
Signed-off-by: garyschulte <garyschulte@gmail.com>