Fabio Di Fabio
c93cfbeb87
Blob transaction replacement rule ( #6874 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 months ago
Sally MacFarlane
b04e82a4c2
[MINOR] nuke those extra ellipses ( #6870 )
...
* no extra ellipses
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* no extra ellipses
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* spurious semicolon
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* duplicated word
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
ed678f1cc5
make test use threshold values explicitly ( #6843 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
1aabba1474
removed extra ... ( #6849 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
5e93b69503
Log at debug the first error when adding a tx for the sender fails ( #6846 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 months ago
garyschulte
34fc5eed58
Snap server rebase ( #6640 )
...
* initial snap server implementation
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
garyschulte
deaea9b34d
Snap client fixes ( #6847 )
...
* manage empty range for storage
* round rather than floor on max remote connections so that maxpeers=1 still can accept remote connections
---------
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Karim Taam <karim.t2am@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
9b3a219210
increase timeout ( #6852 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
d8e1e1710c
Remove deprecated Forest pruning ( #6810 )
...
* Remove deprecated Forest pruning
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Update CHANGELOG.md
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
---------
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
1679525ae2
Dedicated log marker for invalid txs removed from the txpool ( #6826 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
8 months ago
Sally MacFarlane
a2ef6c49da
refactor to check for null peer ( #6841 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Fabio Di Fabio
3a2eb4e71e
Fix to avoid broadcasting full blob txs ( #6835 )
...
* separate queue for tx hashes
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
* Refinements
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Update tests
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Update CHANGELOG
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Refinements
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
---------
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
8 months ago
Karim TAAM
f2c2512ef6
storage format refactor for preparing verkle trie integration ( #6721 )
...
Splitting Bonsai code: This commit aims to divide Bonsai into two packages
- Common Classes with a Prefix: The common part will include classes prefixed with "DiffBased." These classes are designed to provide a base for both Bonsai and any future storage format that might use this diff-based approach.
- Bonsai's Specifics: Bonsai will retain its unique features in its own package. This means that while it shares the diff-based infrastructure with the common part, it also has its own specific functionalities that are not shared with other storage format.
- Extension to Verkle: this modification add the possibility of adding "Verkle" as a new storage format based on the diff-based architecture. Like Bonsai, Verkle would use the common diff-based classes but also have its own specific features.
---------
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
8 months ago
Usman Saleem
e954537fcc
build - Refactor Besu custom error prone dependency ( #6692 )
...
Move Besu custom error-prone checks into its own repository and use it as an external dependency. This allows to move to a newer version of Google errorprone checks as well while cleaning up build.gradle file.
Key changes resulted due to this change:
* String toLowerCase and toUpperCase to use Locale.ROOT as argument
* Use interface such as List,Map or NavigatableMap instead of concrete class where appropriate.
* Simplify StringBuilder to plain String
* Suppress warnings where appropriate.
-----
Signed-off-by: Usman Saleem <usman@usmans.info>
8 months ago
Karim TAAM
15cbd8423b
Fix issues during snap sync ( #6802 )
...
The purpose of this commit is to fix some bugs detected in the snap sync. This should allow for greater stability with the snap sync and the healing of the flat DB.
---------
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
8 months ago
Jason Frame
15d54afdf9
Reduce receipt size ( #6602 )
...
Signed-off-by: Jason Frame <jason.frame@consensys.net>
8 months ago
Simon Dudley
bb9ba13cf8
Refactor BackwardsSyncAlgorithm.pickNextStep for readability ( #6775 )
...
* Refactor BackwardsSyncAlgorithm.pickNextStep for readability
...mostly extracting methods
- Result null check
- Remove redundant BannedMethod suppressions
- Add sonar config back in that was removed by mistake
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Stefan Pingel
42f4748ab9
Fix "Backward sync stuck in a loop" #6749 ( #6756 )
...
* minimal change to fix BWS
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Suraneti
feb1764199
feat: add fixed basefee options ( #6562 )
...
* feat: add fixed basefee options
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* Refactor zero base fee to be extension of fixed base fee
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* feat: use MiningParameters to fixed base fee
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add mining parameters arg on protocol schedule builder
* feat: add miningParameters on gray glacier and prague
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add miningParameters on gray glacier and prague
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add miningParameters on paris,shanghai,future,experimental
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
---------
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Suraneti <suraneti.rod@gmail.com>
Co-authored-by: Matthew Whitehead <matthew1001@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Usman Saleem
22daf346ee
Refactor StorageRangeDataRequest to fix nodes saved variable ( #6726 )
...
* Refactor StorageRangeDataRequest
-- Remove ununsed nbNodesSaved
Signed-off-by: Usman Saleem <usman@usmans.info>
* Fix import
Signed-off-by: Usman Saleem <usman@usmans.info>
* fix: Increment nodes saved variable
Signed-off-by: Usman Saleem <usman@usmans.info>
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
9 months ago
Matt Whitehead
b239fb6099
Add comments to a couple of the the EthPeer methods to clarify their behaviour ( #6733 )
...
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Fabio Di Fabio
efd1bc7070
Fix txpool dump/restore race condition ( #6665 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
garyschulte
c39ca6d44f
Support pruned chain history in peer validators ( #6698 )
...
* dao fork block presence is optional in peer validator to support peers with pruned chain history
Signed-off-by: garyschulte <garyschulte@gmail.com>
* Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
---------
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Karim TAAM
2360908cf5
worldstate refactor ( #6209 )
...
* worldstate storage refactor
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
9 months ago
garyschulte
610927511e
fix for txpool inSync listener to honor initial sync state ( #6696 )
...
Signed-off-by: garyschulte <garyschulte@gmail.com>
9 months ago
Fabio Di Fabio
2b8d44ec77
Refactor and extend PluginTransactionPoolValidatorService ( #6636 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
mbaxter
240edd4d66
[ #6301 ] Track bad block cause ( #6622 )
...
Signed-off-by: mbaxter <mbaxter.dev@gmail.com>
9 months ago
Karim TAAM
02406ba6f9
Remove an unnecessary persist during the backwardsync ( #6570 )
...
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
9 months ago
Sally MacFarlane
828af89021
revert 6499 flat-db-healing-enabled false by default ( #6642 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Fabio Di Fabio
0c8dcfcde4
Make layered txpool aware of minGasPrice and minPriorityFeePerGas dynamic options ( #6611 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
9 months ago
Fabio Di Fabio
2c1733c8f7
Refactor `TransactionSelectionService` ( #6595 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Fabio Di Fabio
e0bedff962
Database metadata refactor ( #6555 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
9 months ago
mbaxter
5adad6a1be
[Issue 6301] Refactor BadBlockManager ( #6559 )
...
Signed-off-by: mbaxter <mbaxter.dev@gmail.com>
10 months ago
Fabio Di Fabio
1d2d0375cd
Extend BesuConfiguration service ( #6584 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
10 months ago
Sally MacFarlane
24f92019ed
Default storage format now Bonsai ( #6536 )
...
* default bonsai
* be explicit about config in tests
* default forest storage for fast sync tests
* added upcoming breaking changes section
* added db mismatch message
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
10 months ago
Justin Florentine
8b64023a12
Blob gas fee checking ( #6546 )
...
* invalidate txs below blob base fee
* updates tests to provide blob prices
* correction to reftests
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
10 months ago
Danno Ferrin
9ef48d4399
Remove uses of org.jetbrains annotations ( #6558 )
...
* Remove uses of org.jetbrains annotations
We have a mix of org.jetbrains.annotations.NotNull and
javax.annotations.Nonnull. Change all to the latter. Add an errorprone
check to enforce this.
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
* spotless
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
* spdx
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
---------
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
10 months ago
ahamlat
40d1e7632d
Add a sender cache to Transaction ( #6375 )
...
Add a sender cache to Transaction.java, the senders and transactions' hashes are calculated when the transactions are decoded from the newPayload.
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
10 months ago
Jason Frame
2ae6c739ee
Bonsai code storage by hash ( #6505 )
...
Add a storage mode for Bonsai that can store the code by hash instead of account hash
Signed-off-by: Jason Frame <jason.frame@consensys.net>
10 months ago
Jason Frame
c45a863280
Ensure that Bonsai tests with Key Value storage are using Bonsai data configuration ( #6441 )
...
Signed-off-by: Jason Frame <jason.frame@consensys.net>
10 months ago
Sally MacFarlane
dbea838ba2
SNAP and CHECKPOINT sync modes - now production ready ( #6405 )
...
* removed X flag from SNAP sync mode
* and X_CHECKPOINT sync-mode
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
10 months ago
Sally MacFarlane
2077bb78c4
Deprecate --Xp2p-peer-lower-bound ( #6501 )
...
* deprecate p2p-peer-lower-bound
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
10 months ago
Sally MacFarlane
8fb503eba7
Flat db heal - deprecate CLI option and set to always true ( #6499 )
...
* flat db heal always set to true
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* changelog
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
10 months ago
Fabio Di Fabio
38161c9f60
Test that peers are not disconnected in `RetryingSwitchingPeerMessageTaskTest::failsWhenAllPeersFail` ( #6508 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
10 months ago
Jason Frame
4252e47cf7
Revert "Bonsai code storage by hash ( #5889 )" ( #6504 )
...
This reverts commit 9c02518f01
.
Signed-off-by: Jason Frame <jason.frame@consensys.net>
10 months ago
Stefan Pingel
497faef833
Disconnect worst peer ( #6443 )
...
* When refreshing, only disconnect a peer if we have max peers
* If we are disconnecting a peer, disconnect the least useful peer
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
10 months ago
Sally MacFarlane
d47e52664a
standardize on length of truncated peer ID logging ( #6485 )
...
* add a method for the loggable id to standardise the length
* use same length as peer id for short enode method
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
10 months ago
Jason Frame
9c02518f01
Bonsai code storage by hash ( #5889 )
...
Add a storage mode for Bonsai that can store the code by hash instead of account hash
Signed-off-by: Jason Frame <jason.frame@consensys.net>
10 months ago
garyschulte
8972d6707c
info level log for pipeline abort ( #6459 )
...
* info level log for pipeline abort
* add depth protection
Signed-off-by: garyschulte <garyschulte@gmail.com>
10 months ago
Stefan Pingel
06406ce108
only do 2 retries ( #6482 )
...
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
10 months ago