Danno Ferrin
7df1732b89
Expose `v` field in JSON-RPC in some transaction types ( #6819 )
...
* Expose `v` field in JSON-RPC in some transaction types
The execution API marks the `v` field as optional for EIP-2930 and
EIP-1559 transactions, preferring the `yParity` feld. However, some
tooling still depends on the presence of the `v` field. For those two
transaction types both `v` and `yParity` will be returned now.
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
8 months ago
Usman Saleem
e954537fcc
build - Refactor Besu custom error prone dependency ( #6692 )
...
Move Besu custom error-prone checks into its own repository and use it as an external dependency. This allows to move to a newer version of Google errorprone checks as well while cleaning up build.gradle file.
Key changes resulted due to this change:
* String toLowerCase and toUpperCase to use Locale.ROOT as argument
* Use interface such as List,Map or NavigatableMap instead of concrete class where appropriate.
* Simplify StringBuilder to plain String
* Suppress warnings where appropriate.
-----
Signed-off-by: Usman Saleem <usman@usmans.info>
8 months ago
ahamlat
bb647d1443
Modify the message when the selection of transactions is interrupted because it reached the maximum configured duration ( #6814 )
...
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
8 months ago
Karim TAAM
15cbd8423b
Fix issues during snap sync ( #6802 )
...
The purpose of this commit is to fix some bugs detected in the snap sync. This should allow for greater stability with the snap sync and the healing of the flat DB.
---------
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
8 months ago
Simon Dudley
2222bb197b
Set noisy TransactionLogBloomCacher debug log to trace ( #6808 )
...
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Jason Frame
15d54afdf9
Reduce receipt size ( #6602 )
...
Signed-off-by: Jason Frame <jason.frame@consensys.net>
8 months ago
Simon Dudley
bb9ba13cf8
Refactor BackwardsSyncAlgorithm.pickNextStep for readability ( #6775 )
...
* Refactor BackwardsSyncAlgorithm.pickNextStep for readability
...mostly extracting methods
- Result null check
- Remove redundant BannedMethod suppressions
- Add sonar config back in that was removed by mistake
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Lucas Saldanha
2eca4d5a4e
Adding engine_getPayloadV4 and engine_newPayloadV4 ( #6783 )
...
Moved engine_newPayload6110 and engine_getPayload6110 to V4
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
9 months ago
Fabio Di Fabio
7abb29cdc8
Improve PluginRpcEndpointException log ( #6789 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Stefan Pingel
42f4748ab9
Fix "Backward sync stuck in a loop" #6749 ( #6756 )
...
* minimal change to fix BWS
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
9 months ago
Sally MacFarlane
380c0c93f7
for fcu v2 use correct invalid params error code ( #6766 )
...
* fcu v2 use invalid params error code per spec
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Justin Florentine
97d88d1365
Artifactory publish ( #6781 )
...
* correcting env vars
* removes conditionals which result in skipped tasks being considered success
* spotless fix
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
9 months ago
Danno Ferrin
da4be733e3
GraphQL serializes BlobVersionedHashes ( #6769 )
...
Fix error where GraphQL fails to serialize the versioned hash of a
blob transaction.
Signed-off-by: Danno Ferrin (shemnon) <danno.ferrin@shemnon.com>
9 months ago
Fabio Di Fabio
010f947836
Fix for `Method input parameters must be final` compilation error ( #6778 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Fabio Di Fabio
86cc6cb19e
Extend error handling of plugin RPC methods ( #6759 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Danno Ferrin
2bfd510785
Log blob count ( #6761 )
...
Current blog logging shows blob transaction count. The blob count is
more relevant and reflects the label better.
Signed-off-by: Danno Ferrin (shemnon) <danno.ferrin@shemnon.com>
9 months ago
Matt Whitehead
42b32d2531
Log an info message on startup to indicate if IPv6 peer connectivity is possible ( #6750 )
...
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
9 months ago
Sally MacFarlane
cc201691f9
allow empty maxFeePerBlobGas for eth_call ( #6731 )
...
* allow empty blob gas for eth_call
* handle empty maxFeePerBlobGas by setting to blobBaseFee if empty
* set allowExceedingBalance if blobGas not specified
* added a test case for strict with zero blob gas
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
9 months ago
Usman Saleem
5c1e1e1879
Suppress ComparisonOutOfRange error-prone warning in AbstractGasLimitSpecification ( #6727 )
...
* Add suppression for ComparisonOutOfRange
* test: Add unit test to cover max gas limit
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
9 months ago
Andrew Davis
4bd8733367
fix(build): docker git ref ( #6744 )
...
Signed-off-by: Andrew Davis <1709934+Savid@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
standstaff
9439a1cb60
chore: fix some typos ( #6741 )
...
Signed-off-by: standstaff <zhengxingru@yeah.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Suraneti
feb1764199
feat: add fixed basefee options ( #6562 )
...
* feat: add fixed basefee options
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* Refactor zero base fee to be extension of fixed base fee
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* feat: use MiningParameters to fixed base fee
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add mining parameters arg on protocol schedule builder
* feat: add miningParameters on gray glacier and prague
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add miningParameters on gray glacier and prague
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add miningParameters on paris,shanghai,future,experimental
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
---------
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Suraneti <suraneti.rod@gmail.com>
Co-authored-by: Matthew Whitehead <matthew1001@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Usman Saleem
22daf346ee
Refactor StorageRangeDataRequest to fix nodes saved variable ( #6726 )
...
* Refactor StorageRangeDataRequest
-- Remove ununsed nbNodesSaved
Signed-off-by: Usman Saleem <usman@usmans.info>
* Fix import
Signed-off-by: Usman Saleem <usman@usmans.info>
* fix: Increment nodes saved variable
Signed-off-by: Usman Saleem <usman@usmans.info>
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
9 months ago
Matt Whitehead
b239fb6099
Add comments to a couple of the the EthPeer methods to clarify their behaviour ( #6733 )
...
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
MASDXI
9bf542732b
Change`txpool_beusPendingTransactions`:`numResults` from a required parameter to an optional parameter ( #6708 )
...
Signed-off-by: MASDXI <sirawitt42@gmail.com>
9 months ago
Simon Dudley
6dd3c84052
Move potentially spammy peer discovery warn log to debug ( #6728 )
...
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
9 months ago
Usman Saleem
3db07568ae
Refactor PluginPrivacyController ( #6725 )
...
fix parameter name to match overridden method
Signed-off-by: Usman Saleem <usman@usmans.info>
9 months ago
Fabio Di Fabio
4cc6b744cf
Transaction simulation service ( #6686 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Fabio Di Fabio
efd1bc7070
Fix txpool dump/restore race condition ( #6665 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Usman Saleem
602999f4cf
Refactor BadBlockReason enum out of BadBlockCause ( #6716 )
...
* Refactor BadBlockReason enum out of BadBlockCause
Signed-off-by: Usman Saleem <usman@usmans.info>
* Deleting ununsed enum value
Signed-off-by: Usman Saleem <usman@usmans.info>
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
garyschulte
c39ca6d44f
Support pruned chain history in peer validators ( #6698 )
...
* dao fork block presence is optional in peer validator to support peers with pruned chain history
Signed-off-by: garyschulte <garyschulte@gmail.com>
* Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
---------
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Fabio Di Fabio
65f8880fb7
Make block txs selection max time aware of PoA transitions ( #6676 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Sally MacFarlane
246cce41e1
eth_call with blobs - added more spec tests ( #6687 )
...
* added more spec tests
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* fixed typo
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* fixed error message
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Friedemann Fürst
8becd5a3a8
Transaction call object to accept both input and data field if equal ( #6702 )
...
* relax JsonCallParameter constructor to allow for both input and data being set if equal
Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com>
* fix: format
Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com>
* add changelog entry
Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com>
---------
Signed-off-by: Friedemann Fürst <friedemann.fuerst@smartcontract.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Simon Dudley
7324710ac4
[MINOR] Remove unused method ( #6713 )
...
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
9 months ago
Karim TAAM
2360908cf5
worldstate refactor ( #6209 )
...
* worldstate storage refactor
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
9 months ago
Simon Dudley
c622213b97
Add logging for newer FCU payload parameter details ( #6693 )
...
Move assembledBlock log to trace and only print short block string for debug level
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
9 months ago
garyschulte
610927511e
fix for txpool inSync listener to honor initial sync state ( #6696 )
...
Signed-off-by: garyschulte <garyschulte@gmail.com>
9 months ago
Fabio Di Fabio
854d35b490
Update Vert.x to 4.5.4 ( #6666 )
...
* Update Vert.x to 4.5.4
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* Enable websocket write handlers
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
---------
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
mbaxter
4982285e58
Bugfix - only track intrinsically bad blocks ( #6678 )
...
Signed-off-by: mbaxter <mbaxter.dev@gmail.com>
9 months ago
Fabio Di Fabio
2b8d44ec77
Refactor and extend PluginTransactionPoolValidatorService ( #6636 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Sally MacFarlane
cea20992a4
Eth call with 4844 params ( #6661 )
...
* use accessList in hash and equals
* add blob fields to callParams
* blob fields from callParam used in transaction simulator
* don't zero maxFeePerBlobs if not present
* add roundtrip callParam verification
* added a failure case test
* error conversion
* added some spec tests
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Gabriel-Trintinalia
95ae4af2ed
Add blobs to `eth_feeHistory` ( #6679 )
...
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
9 months ago
mbaxter
240edd4d66
[ #6301 ] Track bad block cause ( #6622 )
...
Signed-off-by: mbaxter <mbaxter.dev@gmail.com>
9 months ago
Karim TAAM
02406ba6f9
Remove an unnecessary persist during the backwardsync ( #6570 )
...
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
9 months ago
Sally MacFarlane
828af89021
revert 6499 flat-db-healing-enabled false by default ( #6642 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Simon Dudley
0e3d2f47d7
Clique block period transition ( #6596 )
...
Add BFT-style transitions to Clique, modelled with ForksSchedule<CliqueConfigOptions>
Add ability to transition the blockperiodseconds config.
---------
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Jason Frame <jason.frame@consensys.net>
9 months ago
Fabio Di Fabio
0c8dcfcde4
Make layered txpool aware of minGasPrice and minPriorityFeePerGas dynamic options ( #6611 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
9 months ago
Fabio Di Fabio
2c1733c8f7
Refactor `TransactionSelectionService` ( #6595 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Fabio Di Fabio
e0bedff962
Database metadata refactor ( #6555 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
9 months ago