fixes NC-2120 --discovery-enabled option refactoring
now able to have --discovery-enabled option with true as default
and --discovery-enabled=true or --discovery-enabled=false on CLI
and discovery-enabled=true or discovery-enabled=false in YAML config file.
updates doc
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
fixes NC-2026 adds a `--network` option instead of separated options
Networks are now defined using a `--network` option that takes the case insensitive
name of an enum values as input : MAINNET, RINKEBY, ROPSTEN, GOERLI, DEV
These presets are a set of network-id, genesis file and boonodes list.
If the `--genesis-file` is provided with a valid JSON genesis file,
Pantheon uses it instead of the default network. An empty bootnodes list is then
the default value and network id is the chain id found in the genesis file.
`--network-id` and `--bootnodes` options can override these defaults.
You can of course also override the `--network-id` and `--bootnodes` for a
predefined known network (using `--network`).
User have no reason to set `--network` and `--genesis-file` options at the same
time that would lead to misunderstandings so we raise an error to prevent both
options to be defined at the same time on the command line.
Also fixes NC-2189 renaming --private-genesis-file to --genesis-file
Updates a lot of doc according to the options changes
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
fixes NC-2104 remove Clique and iBFT defaults and centralise default values
As toString() is used to display default values in CLI description and this is
not used anywhere else for RpcApi objects, it may have been used for debug long
ago, but now we can use the simple string value as return from toString.
Then we are able to use the DEFAULT_JSON_RPC_APIS constant as default value
directly instead of hard coded defaults string in option that was probably used
because previous toString was not outputting correct representation. It may be
interesting to comment when some does this sort of hack.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* fixes#522 remove mention of gas setting from eth_estimateGas
* fixes#522 clarify that gasLimit is irrelevant to estimation
* fixes#522 clarifications on estimation process
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* fix doc site footer colors
colours were parameterised but this doesn't seem to work in css files
* removed colour config extras
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* Quick typo fix on Private-Network-Quickstart.md
* Seeded azure quickstart ready to be improved by technical writers
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* initial change
* Fixed spinner gif image
* Fixed MD formatting typos
* Adding images for style guide
* Word and grammar changes from review
* Changed references to CLI in titles to Command Line Interface (CLI) and changed command-line to commane line (no hypen to be consistent)
* Typo fixes
* More typo fixes...
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* Added Creating Private Network tutorial. Updated bootnodes examples to specify data directory and genesis file.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
Fixes#440 as RTD rewrites the GA scripts, was not expected, and we missed the
site verification meta tag to enable GA search console link
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
IMHO most contributors will appreciate the lower case file name as that tends to be most common with directory names.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
* Fixes#440 add analytics
and move scripts and css to header by overriding blocks in main
* Fixes domain namenow that we have doc.pantheon.pegasys.tech
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
Readthedoc migration, still some content to update from the wiki that were updated after I made the last diff
- fixes#406 by configuring readthedocs
- fixes#407 by configuring material theme
- fixes#408 by adding footer with jQuery to enable readthedocs.org versions
- fixes#409
- fixes#410
- fixes#411
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
- Created CLA.md
- Updated Gitter URLs
- Updated Role definitions
- deleted java-modules.md. If written, it belongs in the JavaDoc package.hmtl
- Removed broken index link to Documentation Style Guide
- Fixed broken link to PR labels
- Converted issue templates to comment out each line individually
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
MadelineMurray
Nicolas MASSART
Donn Trenton
Jake Haugen
Matthew Halpern
Eric Kellstrand
mark-terry