* create separate signature class for code delegations as they have different bound checks
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* test if increasing xmx let's failing acceptance test pass
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* javadoc
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
* shift creation of plugin context to BesuCommand for now
* mock component will provide a no-op metrics sys
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
* Change test to tease NPEs during DefaultBlockchain.<init>() caused by initilization order
* fixup! Change test to tease NPEs during DefaultBlockchain.<init>() caused by initilization order
* move counters into their own method
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
* fix 7702 tx validation in tx pool
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* check that 7702 transactions always have a mandatory to field
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
---------
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
* feat: exported metrics for current finalized and safe block number
Signed-off-by: Jones Ho <jones.ho@consensys.net>
* Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jonesho <81145364+jonesho@users.noreply.github.com>
* Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: jonesho <81145364+jonesho@users.noreply.github.com>
* fix: spotless issue
Signed-off-by: Jones Ho <jones.ho@consensys.net>
---------
Signed-off-by: Jones Ho <jones.ho@consensys.net>
Signed-off-by: jonesho <81145364+jonesho@users.noreply.github.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
* wrapped WorldUpdater into `EVMWorldupdater` to remove the authority code injection from the implementation of the actual world updaters
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* add CHANGELOG entry
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* first draft for 7702 v2
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* change return value of DelegatedCodeGasCostHelper
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fix upfront gas cost calculation, fix setting code multiple times in MutableDelegatedCodeAccount
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fix gas refund for delegated code when account already exists, added gas cost deduction for code delegation resolution to ExtCodeSizeOperation
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* allow accounts with delegated code to send transactions
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* add refund for already existing account after nonce check
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* resolve delegated code only the first time to avoid delegation loops
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* handle invalid authorization signatures properly
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* refactored CodeDelegationProcessor to compute authorizer of a code delegation after the chain id check
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fix canSetDelegatedCode method by checking code how it is in the trie and not the resolved code
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* optimize code hash calculation for empty code, fix check for empty code delegation list
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* check the all code delegation signatures hava a valid s value
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* rename encoder & decoder, handle invalid signature values in T8nExecutor
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* create the signatures for code delegation authorizations in T8nExecutor without checking if they are valid to test them later during the tx execution
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* check that recid is either 0 or 1
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fixed acceptance tests, renamed the the remaining instances of set code to code delegation
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fix delegate encoder & encoder unit tests
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* spotless
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* changed empty check for delegated accounts, fixed test
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fix hasDelegatedCode method when code is null
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* run acceptance tests without deamon
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* disable CodeDelegationTransactionAcceptanceTest to check if it is causing the stuck ci pipeline
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* check if shouldTransferAllEthOfAuthorizerToSponsor is causing pipeline to stall
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* check if shouldCheckNonceAfterNonceIncreaseOfSender is causing pipeline to stall
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* check if closing the cluster after every test is causing pipeline to stall
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* spotless
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
---------
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Co-authored-by: Danno Ferrin <danno@numisight.com>
* Plumb maxCode overriddes into EVM
Restore lost functionality: the maxcodesize and maxinitcodesize should
be plumed into the operations and validation rules when set.
Signed-off-by: Danno Ferrin <danno@numisight.com>
---------
Signed-off-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
* Include Commit-Hash in manifests
* Add commit method in BesuInfo
* Use 8 character hash in EngineGetClientVersionV1 and revert calculateVersion back to original spec
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Co-authored-by: garyschulte <garyschulte@gmail.com>
* EVMTool should respect --genesis option
Update the code so that the genesis file option will be respected when
set. Also, default --fork options should set a rational base fee.
Signed-off-by: Danno Ferrin <danno@numisight.com>
---------
Signed-off-by: Danno Ferrin <danno@numisight.com>
* Reuse HardforkId in EvmSpecVersion
Move the HardforkId into datatypes and re-use the data in
EvmSpecVersion, keeping evm specific details in the evm and merging the
rest into datatypes.
Signed-off-by: Danno Ferrin <danno@numisight.com>
* Update evm/src/main/java/org/hyperledger/besu/evm/EvmSpecVersion.java
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>
---------
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
* wrapped WorldUpdater into `EVMWorldupdater` to remove the authority code injection from the implementation of the actual world updaters
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* add CHANGELOG entry
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
---------
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
* add `ProtocolSchedule::milestoneFor` to retrieve milestones for every hardfork in the genesis file
* add `setMilestones` and `milestoneFor` to TransitionProtocolSchedule
* refactored all checks for hardforks in the engine API to use hard fork ids
* added tests to test that the engine API v2 endpoints return UNSUPPORTED_FORK past Cancun
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
---------
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Add a block processing integration test to verify that sequential and parallel execution have the same behaviour
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
* process the authority list before increasing the sender nonce, make sure that the updated balance of the sender is calculated correctly if they sign an authorization as well
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Also reduce pruning window from 30_000 to 5_000
---------
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Optimistic transaction parallelization execution during block processing to improve the performances. This feature can enabled with a flag --Xbonsai-parallel-tx-processing-enabled=true
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Co-authored-by: Ameziane H <ameziane.hamlat@consensys.net>
Co-authored-by: garyschulte <garyschulte@gmail.com>
* EIP 7702 first draft
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* added CHANGELOG.md entry
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* bug fixes, added first tests
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* container verify GitHub workflow (#7239)
Container verification step in release process automated with the container verify GitHub workflow. New workflow is triggered at the end of the release workflow which will check the release container images starts successfully. Verification test only checks container starts and reach the Ethereum main loop
Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Investigate chain halts when syncing (#7162)
Fix some reasons for chain download halts when syncing
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Check for EOFCreate subcontainer rules (#7232)
Check and test for the unused container rule, and only returncontract
targets can have truncated data rule.
Also test the other subcontainer rules in unit tests.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Remove deprecation message for `--Xp2p-peer-lower-bound` (#7247)
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* less invasive code injection approach
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* added missing java doc & fixed test
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* added (currently non-working) acceptance test, some bug fixes in the transaction validation and tx pool logic
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fix spotless
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* updated acceptance test, still not working, newPayload request seems to be necessary before final fork choice update
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* use correct world state to inject temporary code, inject code in existing accounts as well
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* renamed test service to prague, because the engine versions used are only available in the prague hard fork
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fixed acceptance test, some bug fixes if authorized account does not yet exist
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Add build version option to prefix git hash with custom version property (#7222)
* Add build version option to prefix git hash with custom version property
* Refactor to make appending the git hash a boolean property. Include a commented-out example of how to use the properties in the gradle file
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Handle invalid snap getTrieNode requests with empty paths gracefully (#7221)
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fix typos in CHANGELOG (#7226)
Signed-off-by: Ties <71668189+TiesD@users.noreply.github.com>
Co-authored-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* feat: Add network option for LUKSO Mainnet (#7223)
* Add option for LUKSO network
Signed-off-by: Wolmin <lamonos123@gmail.com>
* Add tests for LUKSO
Signed-off-by: Wolmin <lamonos123@gmail.com>
* Apply spotless
Signed-off-by: Wolmin <lamonos123@gmail.com>
* Add changelog entry
Signed-off-by: Wolmin <lamonos123@gmail.com>
* Fix duplicate func
Signed-off-by: Wolmin <lamonos123@gmail.com>
* Fix changelog
Signed-off-by: Wolmin <lamonos123@gmail.com>
* Add bootnodes to genesis
Signed-off-by: Wolmin <lamonos123@gmail.com>
---------
Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Wolmin <44748271+Wolmin@users.noreply.github.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Update Docker base image to Ubuntu 24.04 (#7251)
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Reconfigure how Protocol Specs are created WRT EVM condiguration (#7245)
Make the max code size and max initcode size a part of the EVM
configuration. As part of the change we need to move the tasks
CodeFactory once handled as a static class and move it into the EVM.
This has a nice follow on effect that we don't need to pass in max EOF
versions or max code sizes anymore.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Fix the wrong 'Identifier' and 'Synchronizer' usage (#7252)
* fix the synchronizer usage
Signed-off-by: Leni <leniram159@gmail.com>
* fix Identifier usage
Signed-off-by: Leni <leniram159@gmail.com>
---------
Signed-off-by: Leni <leniram159@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Fix flaky SECP256R1 test (#7249)
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* update to work with the new max retries value (#7253)
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Temporary CancunEOF fork for EOF testing. (#7227)
Add Genesis ("CancunEOFTime") and reference test ("CancunEOF") support
for a temporary Cancun+EOF fork, in anticipation of potential devnets.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fixed bug introduced through merge of main, made acceptance test easier to understand
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* added missing java docs
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* removed unnecessary tag
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* make encodeSingleSetCode public again
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Snapserver responses to return at least one response (#7190)
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* copy setCodeTransactionPayloads as well
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fixed bug during tests with forrest db
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Snapserver GetTrieNodes request to handle short hash for storage (#7264)
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* javadoc: Adding javadoc for ethstats module (#7269)
* javadoc: Adding javadoc for ethstats module
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Fix javadoc for ethereum:core top level package (#7270)
* javadoc - Apply javadoc to ethereum core top level package
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Disable Flaky tests - permissioning (#7256)
* disable some flaky tests
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* correct name for test
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* formatting
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* disable some flaky tests
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Add bootnodes to the maintained peer list (#7257)
* Add bootnodes to the maintained peer list
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Update unit tests
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Add entry in changelog
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Tweak unit test
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Refactor to keep common steps the same for both cases
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Add debug log, call sanitizePeers() only once
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
---------
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Fix javadoc for ethereum api module, graphql package (#7272)
* javadoc - Adding missing javadocs ethereum:api graphql package
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* T8n support for isStateTest and empty accounts (#7275)
Update t8n executor to support new isStateTest env flag that will
disable extra-transactional processing such as block rewards and beacon
root.
Also, make sure such extra-transactional commits don't create empty
accounts.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Promote storage x-trie-log subcommand to trie-log (#7278)
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Evm tool readme update (#7274)
* update paths to binary. update docker build to use java 21
* updated suggested jdk
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* javadoc - Add missing javadoc for evmtool module (#7277)
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Rename ValidatorPublicKey to ValidatorPubKey (#7280)
Adapt to EIP-7002 name change for validator public key in all places.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Add info-level diagnostic logs to aid with resolving stalled BFT chains (#7271)
* Add info-level diagnostic logs to aid with resolving stalled BFT chains
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Add javadoc
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
---------
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Update EIP-2935 contract (#7281)
Use the updated contract and address for EIP-2539.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* add evmtool compability, fixing bugs related to sender recovery of 7702 txs and handling authorizations to empty accounts
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Deeper tracing of self-destructed accounts (#7284)
Consider previously self-destructed accounts when creating accounts.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* next release version after 24.7.0 (#7285)
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Add experimental `--Xsnapsync-bft-enabled` which enables snap sync for BFT chains (#7140)
* Create a BFT-specific pivot block handler
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Change visibility
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Refactor sync-peer-count internal variable to match name, add experimental flag to enabled snap + BFT
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Merge with main
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Fix uppercase
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Address synchronization issue with trie pruning. Create BFT-specific account range handler. Add pipeline name and logs
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Remove debug log
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* fixing snapsync for empty state
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
* Don't queue up events we can't handle
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Fix timing window where a validator with an empty data dir sometimes falls back to full sync if peer status isn't received quickly enough
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Remove BFT-specific account request class. Not needed
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Refactor some more 'fast' sync variables that are common to all pivot-based sync types
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* In FULL sync mode, disable bonsai-limit-trie-logs-enabled instead of failing to start
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Add javadoc comments, clarify overriding bonsai-limit-trie-logs-enabled
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Add BFT pivot block selector tests
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Fix failure error message
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Remove the unnamed Pipe constructor and update tests to set a pipe name
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Revert some info logs back to debug given the feedback on noise in the logs syncing with holesky
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Refactor fastSyncPivotDistance to syncPivotDistance
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Incomplete refactoring
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Update BFT event queueing tests
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Event queue test fixes
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Remove automatic setting of bonsai-limit-trie-logs-enabled to false if sync-mode = FULL (moving to another PR)
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
---------
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
Co-authored-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Turn off CicleCI for Besu (#7291)
All the CI jobs run in GitHub actions and Circle CI it no longer needed in Besu project
Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Check for snap server (#6609)
* EthPeer add isServingSnap to be able to make sure that we have enough snap servers connected when we are snap syncing
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Implement System Calls (#7263)
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* wrap WorldUpdater inside a WorldUpdaterService to inject the authorized code whenever needed
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Update limit trie logs validation message for sync-mode=FULL (#7279)
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Execute requests before block persist (#7295)
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fixed MainnetTransactionProcessor retrieval of correctn `to` account with injected code, fixed code injection
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* only first authorization is accepted, all the following ones are ignored
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* don't cache account with empty code
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* revert wrapping of world updater, as its `updater()` method creates a type of nesting that is not compatible with wrapping it. Instead a service is injected in the world updater to inject the code into the authorized accounts
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Fixed outdated tech redirect link. (#7297)
* fix wiki link
Signed-off-by: Snazzy <snazzysam933@gmail.com>
* fix format
Signed-off-by: Snazzy <snazzysam933@gmail.com>
* change knownHash
Signed-off-by: Snazzy <snazzysam933@gmail.com>
---------
Signed-off-by: Snazzy <snazzysam933@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Increment private nonce even if transaction failed. (#6593)
Increment private nonce even if transaction failed
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Co-authored-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* feat: Enhance --profile to load external profiles (#7292)
* feat: --profile can load external profiles
* fix external profile name method
* fix ProfilesCompletionCandidate
* test: Add unit tests
* changelog: Update changelog
* test: Fix TomlConfigurationDefaultProviderTest
* test: Fix BesuCommandTest
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Fix status badge for documentation (#7304)
Documentation has been moved to GitHub pages and no longer use readthedocs. Updated the README status badge for docs with correct link
Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* [MINOR] Fixed some typos (#7299)
* typos
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* refactored to share one AuthorizedAccountService between the different instances of the world updater, renamed some classes
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* spotless
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* load code for authorization at the beginning of the transaction
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* ignore authorization if chain id doesn't match
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* cache authority address, evmtool: do not fail if sender address is wrong
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Add evmtool block-test subcommand (#7293)
* Add evmtool block-test subcommand
Add an evmtool subcommand that will run non-hive blockchain tests.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Make the retrying snap tasks switching (#7307)
* make snap tasks switching
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* 6612: Remove deprecated sync modes and related helper methods (#7309)
* 6612: Remove deprecated sync modes and related helper methods
Signed-off-by: Matilda-Clerke <matilda.shay.clerke@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* EOF Reference Test Fixes (#7306)
Fix a number of issues found in reference tests and evmone tests.
- Be tolerant of more nulls in json
- Support ContainerKind in reference tests
- re-order EXTCALL oeprands
- correct return value for REVERT in EXT*CALL
- re-order EOFCREATE code validation
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* test template refactor, bump besu-native to 0.9.2 (#7315)
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Feature/use gnark-crypto for eip-2537 (#7316)
* use gnark-crypto for bls precompiles
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* 6612 update changelog with removed syncmodes (#7320)
* 6612: Update changelog with removal of deprecated sync modes
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
* 6612: Update changelog with removal of deprecated sync modes
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
* 6612: Update changelog with removal of deprecated sync modes
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
---------
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Update datacopy (#7319)
Check for OOG earlier in DataCopy.
Add unit tests to cover operation branches.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* disable flaky test (#7308)
* disable flaky test
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* disable flaky test
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Update unit test (#7317)
* Update parameterized unit tests so the enumerate with --dry-run
* Update the prague-withdrawal.json unit test to handle current code
Signed-off-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* persist accounts that have storage updates, but no nonce, balance nor code
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Revert "persist accounts that have storage updates, but no nonce, balance nor code"
This reverts commit 9c9121a115ecb09f1c3add1fff4da3b102f8b429.
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* removed PKI backed QBFT (#7310)
* removed PKI backed QBFT
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* changelog
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* EIP-7251 add consolidation request type (#7266)
* add request type for consolidations, encoder, decoder and tests
* added raw tx for consolidation
* add consolidation reqs to EngineGetPayloadResultV4
* set storage slot value to 0 initially and value for tx
* updates plugin api
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* fix: `eth_call` deserialization to correctly ignore unknown fields in the transaction object (#7323)
* fix: Use Builder for JsonCallParameter
* changelog
* add additional unit tests
* fix: Update builder to withGas to match the json eth_call
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* Stop transaction selection on TX_EVALUATION_TOO_LONG (#7330)
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* message frame buider will create AuthorizedCodeService by itsef if it isn't set
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* get correct nonce for authorization
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* nonce only returns a vaid nonce, new method nonceList returns all the nonces
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* plugs leaky abstraction
Signed-off-by: Justin Florentine <justin+github@florentine.us>
* some renaming, acceptance tests checks for exact balance of tx sponsor at the end.
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* inject the 7702 code into DiffBasedWorldStateUpdateAccumulator.createAccount
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* spotless
Signed-off-by: Justin Florentine <justin+github@florentine.us>
* spotless fix, removed todos
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* make AuthorityProcessor & chain id for it optional
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
---------
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Ties <71668189+TiesD@users.noreply.github.com>
Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Wolmin <44748271+Wolmin@users.noreply.github.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Leni <leniram159@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Snazzy <snazzysam933@gmail.com>
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: Matilda-Clerke <matilda.shay.clerke@gmail.com>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Co-authored-by: Chaminda Divitotawela <cdivitotawela@users.noreply.github.com>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Co-authored-by: Matt Whitehead <matthew.whitehead@kaleido.io>
Co-authored-by: Jason Frame <jason.frame@consensys.net>
Co-authored-by: Ties <71668189+TiesD@users.noreply.github.com>
Co-authored-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
Co-authored-by: Wolmin <44748271+Wolmin@users.noreply.github.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: leniram159 <leniram159@gmail.com>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Usman Saleem <usman@usmans.info>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Karim Taam <karim.t2am@gmail.com>
Co-authored-by: gringsam <snazzysam933@gmail.com>
Co-authored-by: George Tebrean <99179176+gtebrean@users.noreply.github.com>
Co-authored-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Co-authored-by: Matilda-Clerke <matilda.shay.clerke@gmail.com>
* add request type for consolidations, encoder, decoder and tests
* added raw tx for consolidation
* add consolidation reqs to EngineGetPayloadResultV4
* set storage slot value to 0 initially and value for tx
* updates plugin api
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
* Update parameterized unit tests so the enumerate with --dry-run
* Update the prague-withdrawal.json unit test to handle current code
Signed-off-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
* EthPeer add isServingSnap to be able to make sure that we have enough snap servers connected when we are snap syncing
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
* Create a BFT-specific pivot block handler
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Change visibility
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Refactor sync-peer-count internal variable to match name, add experimental flag to enabled snap + BFT
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Merge with main
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Fix uppercase
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Address synchronization issue with trie pruning. Create BFT-specific account range handler. Add pipeline name and logs
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Remove debug log
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* fixing snapsync for empty state
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
* Don't queue up events we can't handle
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Fix timing window where a validator with an empty data dir sometimes falls back to full sync if peer status isn't received quickly enough
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Remove BFT-specific account request class. Not needed
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Refactor some more 'fast' sync variables that are common to all pivot-based sync types
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* In FULL sync mode, disable bonsai-limit-trie-logs-enabled instead of failing to start
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Add javadoc comments, clarify overriding bonsai-limit-trie-logs-enabled
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Add BFT pivot block selector tests
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Fix failure error message
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Remove the unnamed Pipe constructor and update tests to set a pipe name
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Revert some info logs back to debug given the feedback on noise in the logs syncing with holesky
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Refactor fastSyncPivotDistance to syncPivotDistance
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Incomplete refactoring
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Update BFT event queueing tests
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Event queue test fixes
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* Remove automatic setting of bonsai-limit-trie-logs-enabled to false if sync-mode = FULL (moving to another PR)
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
---------
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
Co-authored-by: Karim Taam <karim.t2am@gmail.com>
Add Genesis ("CancunEOFTime") and reference test ("CancunEOF") support
for a temporary Cancun+EOF fork, in anticipation of potential devnets.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Make the max code size and max initcode size a part of the EVM
configuration. As part of the change we need to move the tasks
CodeFactory once handled as a static class and move it into the EVM.
This has a nice follow on effect that we don't need to pass in max EOF
versions or max code sizes anymore.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Sally MacFarlane
daniellehrner
Jason Frame
Justin Florentine
Gabriel-Trintinalia
Luis Pinto
jonesho
Stefan Pingel
Danno Ferrin
Matilda-Clerke
Fabio Di Fabio
Nischal Sharma
sirawt
ahamlat
Simon Dudley
Karim Taam
garyschulte
George Tebrean
Matt Whitehead
Usman Saleem