From 4c3317820ce7aff6faa4536097fb5132298b6fbb Mon Sep 17 00:00:00 2001 From: Ayrat Badykov Date: Wed, 14 Aug 2019 16:09:11 +0300 Subject: [PATCH 1/2] do not fetch emission rewards for transactions csv exporter --- apps/explorer/lib/explorer/chain.ex | 2 +- .../lib/explorer/chain/address_transaction_csv_exporter.ex | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/apps/explorer/lib/explorer/chain.ex b/apps/explorer/lib/explorer/chain.ex index 424636f005..0b09fadc7d 100644 --- a/apps/explorer/lib/explorer/chain.ex +++ b/apps/explorer/lib/explorer/chain.ex @@ -248,7 +248,7 @@ defmodule Explorer.Chain do end end - defp address_to_transactions_without_rewards(address_hash, paging_options, options) do + def address_to_transactions_without_rewards(address_hash, paging_options, options) do direction = Keyword.get(options, :direction) necessity_by_association = Keyword.get(options, :necessity_by_association, %{}) diff --git a/apps/explorer/lib/explorer/chain/address_transaction_csv_exporter.ex b/apps/explorer/lib/explorer/chain/address_transaction_csv_exporter.ex index 64df1c7e59..0196de3bc0 100644 --- a/apps/explorer/lib/explorer/chain/address_transaction_csv_exporter.ex +++ b/apps/explorer/lib/explorer/chain/address_transaction_csv_exporter.ex @@ -42,9 +42,8 @@ defmodule Explorer.Chain.AddressTransactionCsvExporter do end defp fetch_all_transactions(address_hash, paging_options, acc \\ []) do - options = Keyword.merge(@necessity_by_association, paging_options: paging_options) - - transactions = Chain.address_to_transactions_with_rewards(address_hash, options) + transactions = + Chain.address_to_transactions_without_rewards(address_hash, paging_options, @necessity_by_association) new_acc = transactions ++ acc From 522c2292db36046e71f81622cad69277d9fb6b84 Mon Sep 17 00:00:00 2001 From: Ayrat Badykov Date: Wed, 14 Aug 2019 16:10:59 +0300 Subject: [PATCH 2/2] add CHANGELOG entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d165881076..530ae0add0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ### Features ### Fixes +- [#2569](https://github.com/poanetwork/blockscout/pull/2569) - do not fetch emission rewards for transactions csv exporter - [#2564](https://github.com/poanetwork/blockscout/pull/2564) - fix first page button for uncles and reorgs - [#2563](https://github.com/poanetwork/blockscout/pull/2563) - Fix view less transfers button - [#2538](https://github.com/poanetwork/blockscout/pull/2538) - fetch the last not empty coin balance records