Merge pull request #2204 from poanetwork/ab-fix-large-smart-contract-verification

fix large contract verification

CHANGELOG.md

@@ -45,6 +45,7 @@
 - [#2173](https://github.com/poanetwork/blockscout/pull/2173) - handle correctly empty transactions
 - [#2174](https://github.com/poanetwork/blockscout/pull/2174) - fix reward channel joining
 - [#2186](https://github.com/poanetwork/blockscout/pull/2186) - fix net version test
+- [#2204](https://github.com/poanetwork/blockscout/pull/2204) - fix large contract verification
 - [#2167](https://github.com/poanetwork/blockscout/pull/2168) - feat: document eth rpc api mimicking endpoints 
 
 ### Chore

apps/explorer/lib/explorer/smart_contract/solidity/code_compiler.ex

@@ -91,7 +91,7 @@ defmodule Explorer.SmartContract.Solidity.CodeCompiler do
           "node",
           [
             Application.app_dir(:explorer, "priv/compile_solc.js"),
-            code,
+            create_source_file(code),
             compiler_version,
             optimize_value(optimize),
             optimization_runs,
@@ -162,4 +162,12 @@ defmodule Explorer.SmartContract.Solidity.CodeCompiler do
 
   defp optimize_value(true), do: "1"
   defp optimize_value("true"), do: "1"
+
+  defp create_source_file(source) do
+    {:ok, path} = Briefly.create()
+
+    File.write!(path, source)
+
+    path
+  end
 end

apps/explorer/mix.exs

@@ -66,6 +66,7 @@ defmodule Explorer.Mixfile do
       # CSV output for benchee
       {:benchee_csv, "~> 0.8.0", only: :test},
       {:bypass, "~> 1.0", only: :test},
+      {:briefly, "~> 0.4", github: "CargoSense/briefly"},
       {:comeonin, "~> 4.0"},
       {:credo, "1.0.0", only: :test, runtime: false},
       # For Absinthe to load data in batches

apps/explorer/priv/compile_solc.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 
-var sourceCode = process.argv[2];
+var sourceCodePath = process.argv[2];
 var version = process.argv[3];
 var optimize = process.argv[4];
 var optimizationRuns = parseInt(process.argv[5], 10);
@@ -13,6 +13,9 @@ var solc = require('solc')
 var compilerSnapshot = require(compilerVersionPath);
 var solc = solc.setupMethods(compilerSnapshot);
 
+var fs = require('fs');
+var sourceCode = fs.readFileSync(sourceCodePath, 'utf8');
+
 const input = {
   language: 'Solidity',
   sources: {

apps/explorer/test/explorer/smart_contract/solidity/code_compiler_test.exs

@@ -268,6 +268,20 @@ defmodule Explorer.SmartContract.Solidity.CodeCompilerTest do
 
       assert Enum.any?(abi, fn el -> el["type"] == "constructor" end)
     end
+
+    test "can compile a large file" do
+      path = File.cwd!() <> "/test/support/fixture/smart_contract/large_smart_contract.sol"
+      contract = File.read!(path)
+
+      assert {:ok, %{"abi" => abi}} =
+               CodeCompiler.run(
+                 name: "HomeWorkDeployer",
+                 compiler_version: "v0.5.9+commit.e560f70d",
+                 code: contract,
+                 evm_version: "constantinople",
+                 optimize: true
+               )
+    end
   end
 
   describe "get_contract_info/1" do

mix.lock

@@ -11,6 +11,7 @@
   "benchee": {:hex, :benchee, "0.13.2", "30cd4ff5f593fdd218a9b26f3c24d580274f297d88ad43383afe525b1543b165", [:mix], [{:deep_merge, "~> 0.1", [hex: :deep_merge, repo: "hexpm", optional: false]}], "hexpm"},
   "benchee_csv": {:hex, :benchee_csv, "0.8.0", "0ca094677d6e2b2f601b7ee7864b754789ef9d24d079432e5e3d6f4fb83a4d80", [:mix], [{:benchee, "~> 0.12", [hex: :benchee, optional: false]}, {:csv, "~> 2.0", [hex: :csv, optional: false]}]},
   "binary": {:hex, :binary, "0.0.5", "20d816f7274ea34f1b673b4cff2fdb9ebec9391a7a68c349070d515c66b1b2cf", [:mix], []},
+  "briefly": {:git, "https://github.com/CargoSense/briefly.git", "2526e9674a4e6996137e066a1295ea60962712b8", []},
   "bunt": {:hex, :bunt, "0.2.0", "951c6e801e8b1d2cbe58ebbd3e616a869061ddadcc4863d0a2182541acae9a38", [:mix], []},
   "bypass": {:hex, :bypass, "1.0.0", "b78b3dcb832a71aca5259c1a704b2e14b55fd4e1327ff942598b4e7d1a7ad83d", [:mix], [{:plug, "~> 1.7", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 1.0 or ~> 2.0", [hex: :plug_cowboy, repo: "hexpm", optional: false]}], "hexpm"},
   "certifi": {:hex, :certifi, "2.5.1", "867ce347f7c7d78563450a18a6a28a8090331e77fa02380b4a21962a65d36ee5", [:rebar3], [{:parse_trans, "~>3.3", [hex: :parse_trans, repo: "hexpm", optional: false]}], "hexpm"},