From 62ad8d094abae397ee6444e9bfcfe0b28fba8d3f Mon Sep 17 00:00:00 2001
From: jimmay5469 <jimmay5469@gmail.com>
Date: Mon, 25 Jun 2018 16:29:41 -0400
Subject: [PATCH] Always show filter dropdown

Co-authored-by: Stamates <stamates@hotmail.com>
---
 .../index.html.eex                            |  78 ++++++-----
 .../address_transaction/index.html.eex        | 121 +++++++++---------
 2 files changed, 98 insertions(+), 101 deletions(-)

diff --git a/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex
index 34438e7718..79f7c717b5 100644
--- a/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex
@@ -37,47 +37,45 @@
         </ul>
       </div>
       <div class="card-body">
-
-        <%= if Enum.count(@internal_transactions) > 0 do %>
-          <div class="dropdown float-right u-push-sm">
-            <button data-test="filter_dropdown" class="button button--secondary button--xsmall dropdown-toggle" type="button"
-              id="dropdownMenu2" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
-              Filter: <%= format_current_filter(@filter) %>
-            </button>
-            <div class="dropdown-menu dropdown-menu-right filter" aria-labelledby="dropdownMenu2">
-              <%= link(
-                gettext("All"),
-                to: address_internal_transaction_path(@conn, :index, @conn.assigns.locale, @conn.params["address_id"]),
-                class: "address__link address__link--active dropdown-item",
-                "data-test": "filter_option"
-              ) %>
-              <%= link(
-                gettext("To"),
-                to: address_internal_transaction_path(
-                  @conn,
-                  :index,
-                  @conn.assigns.locale,
-                  @conn.params["address_id"],
-                  filter: "to"
-                ),
-                class: "address__link address__link--active dropdown-item",
-                "data-test": "filter_option"
-              ) %>
-              <%= link(
-                gettext("From"),
-                to: address_internal_transaction_path(
-                  @conn,
-                  :index,
-                  @conn.assigns.locale,
-                  @conn.params["address_id"],
-                  filter: "from"
-                ),
-                class: "address__link address__link--active dropdown-item",
-                "data-test": "filter_option"
-              ) %>
-            </div>
+        <div class="dropdown float-right u-push-sm">
+          <button data-test="filter_dropdown" class="button button--secondary button--xsmall dropdown-toggle" type="button"
+            id="dropdownMenu2" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+            Filter: <%= format_current_filter(@filter) %>
+          </button>
+          <div class="dropdown-menu dropdown-menu-right filter" aria-labelledby="dropdownMenu2">
+            <%= link(
+              gettext("All"),
+              to: address_internal_transaction_path(@conn, :index, @conn.assigns.locale, @conn.params["address_id"]),
+              class: "address__link address__link--active dropdown-item",
+              "data-test": "filter_option"
+            ) %>
+            <%= link(
+              gettext("To"),
+              to: address_internal_transaction_path(
+                @conn,
+                :index,
+                @conn.assigns.locale,
+                @conn.params["address_id"],
+                filter: "to"
+              ),
+              class: "address__link address__link--active dropdown-item",
+              "data-test": "filter_option"
+            ) %>
+            <%= link(
+              gettext("From"),
+              to: address_internal_transaction_path(
+                @conn,
+                :index,
+                @conn.assigns.locale,
+                @conn.params["address_id"],
+                filter: "from"
+              ),
+              class: "address__link address__link--active dropdown-item",
+              "data-test": "filter_option"
+            ) %>
           </div>
-
+        </div>
+        <%= if Enum.count(@internal_transactions) > 0 do %>
           <table class="table table-responsive-sm table-font">
             <thead>
               <th><%= gettext "Parent Tx Hash" %></th>
diff --git a/apps/explorer_web/lib/explorer_web/templates/address_transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/address_transaction/index.html.eex
index 1a76c8398b..64a2ff5dd0 100644
--- a/apps/explorer_web/lib/explorer_web/templates/address_transaction/index.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/address_transaction/index.html.eex
@@ -40,68 +40,67 @@
         <div data-selector="channel-disconnected-message" style="display:none;">
           <%= gettext "channel disconnected" %>
         </div>
-        <%= if Enum.count(@transactions) > 0 do %>
-          <div class="dropdown float-right u-push-sm">
-            <button data-test="filter_dropdown" class="button button--secondary button--xsmall dropdown-toggle" type="button"
-                    id="dropdownMenu2" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
-              Filter: <%= format_current_filter(@filter) %>
-            </button>
-            <div class="dropdown-menu dropdown-menu-right filter" aria-labelledby="dropdownMenu2">
-              <%= link(
-                    gettext("All"),
-                    to: address_transaction_path(@conn, :index, @conn.assigns.locale, @conn.params["address_id"]),
-                    class: "address__link address__link--active dropdown-item",
-                    "data-test": "filter_option"
-                  ) %>
-              <%= link(
-                    gettext("To"),
-                    to: address_transaction_path(
-                      @conn,
-                      :index,
-                      @conn.assigns.locale,
-                      @conn.params["address_id"],
-                      filter: "to"
-                    ),
-                    class: "address__link address__link--active dropdown-item",
-                    "data-test": "filter_option"
-                  ) %>
-              <%= link(
-                    gettext("From"),
-                    to: address_transaction_path(
-                      @conn,
-                      :index,
-                      @conn.assigns.locale,
-                      @conn.params["address_id"],
-                      filter: "from"
-                    ),
-                    class: "address__link address__link--active dropdown-item",
-                    "data-test": "filter_option"
-                  ) %>
-            </div>
+        <div class="dropdown float-right u-push-sm">
+          <button data-test="filter_dropdown" class="button button--secondary button--xsmall dropdown-toggle" type="button"
+                  id="dropdownMenu2" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+            Filter: <%= format_current_filter(@filter) %>
+          </button>
+          <div class="dropdown-menu dropdown-menu-right filter" aria-labelledby="dropdownMenu2">
+            <%= link(
+                  gettext("All"),
+                  to: address_transaction_path(@conn, :index, @conn.assigns.locale, @conn.params["address_id"]),
+                  class: "address__link address__link--active dropdown-item",
+                  "data-test": "filter_option"
+                ) %>
+            <%= link(
+                  gettext("To"),
+                  to: address_transaction_path(
+                    @conn,
+                    :index,
+                    @conn.assigns.locale,
+                    @conn.params["address_id"],
+                    filter: "to"
+                  ),
+                  class: "address__link address__link--active dropdown-item",
+                  "data-test": "filter_option"
+                ) %>
+            <%= link(
+                  gettext("From"),
+                  to: address_transaction_path(
+                    @conn,
+                    :index,
+                    @conn.assigns.locale,
+                    @conn.params["address_id"],
+                    filter: "from"
+                  ),
+                  class: "address__link address__link--active dropdown-item",
+                  "data-test": "filter_option"
+                ) %>
           </div>
-
-        <table class="table table-responsive-sm table-font">
-          <thead>
-            <tr>
-              <th class="transactions__column-header transactions__column-header--status">
-                <span class="transactions__column-title transactions__column-title--status"><%= gettext "Status" %></span>
-              </th>
-              <th><%= gettext "Hash" %></th>
-              <th><%= gettext "Block" %></th>
-              <th><%= gettext "Age" %></th>
-              <th><%= gettext "From" %></th>
-              <th></th>
-              <th><%= gettext "To" %></th>
-              <th><%= gettext "Value" %> (<%= gettext "Ether" %>)</th>
-              <th><%= gettext "Fee" %></th>
-            </tr>
-          </thead>
-          <tbody data-selector='transactions-list'>
-            <%= for transaction <- @transactions do %>
-              <%= render "_transaction.html", locale: @locale, transaction: transaction %>
-            <% end %>
-          </tbody>
-        </table>
+        </div>
+        <%= if Enum.count(@transactions) > 0 do %>
+          <table class="table table-responsive-sm table-font">
+            <thead>
+              <tr>
+                <th class="transactions__column-header transactions__column-header--status">
+                  <span class="transactions__column-title transactions__column-title--status"><%= gettext "Status" %></span>
+                </th>
+                <th><%= gettext "Hash" %></th>
+                <th><%= gettext "Block" %></th>
+                <th><%= gettext "Age" %></th>
+                <th><%= gettext "From" %></th>
+                <th></th>
+                <th><%= gettext "To" %></th>
+                <th><%= gettext "Value" %> (<%= gettext "Ether" %>)</th>
+                <th><%= gettext "Fee" %></th>
+              </tr>
+            </thead>
+            <tbody data-selector='transactions-list'>
+              <%= for transaction <- @transactions do %>
+                <%= render "_transaction.html", locale: @locale, transaction: transaction %>
+              <% end %>
+            </tbody>
+          </table>
         <% else %>
           <p data-selector="empty-transactions-list"><%= gettext "There are no Transactions" %></p>
         <% end %>