From a90909b506002486365ae21c1a119aff052d5099 Mon Sep 17 00:00:00 2001 From: Tim Mecklem Date: Tue, 19 Jun 2018 14:14:25 -0400 Subject: [PATCH] Rename helper function to `create?` --- .../templates/address_internal_transaction/index.html.eex | 2 +- .../transaction_internal_transaction/index.html.eex | 2 +- .../lib/explorer_web/views/internal_transaction_view.ex | 4 ++-- .../explorer_web/views/internal_transaction_view_test.exs | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex index 80db35c435..713b18a161 100644 --- a/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex +++ b/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex @@ -103,7 +103,7 @@ <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: internal_transaction.from_address %> - <%= if ExplorerWeb.InternalTransactionView.contract?(internal_transaction) do %> + <%= if ExplorerWeb.InternalTransactionView.create?(internal_transaction) do %> <%= link( gettext("Contract Creation"), diff --git a/apps/explorer_web/lib/explorer_web/templates/transaction_internal_transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/transaction_internal_transaction/index.html.eex index c5b44b4d68..5d017d1d00 100644 --- a/apps/explorer_web/lib/explorer_web/templates/transaction_internal_transaction/index.html.eex +++ b/apps/explorer_web/lib/explorer_web/templates/transaction_internal_transaction/index.html.eex @@ -41,7 +41,7 @@ <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: internal_transaction.from_address %> - <%= if ExplorerWeb.InternalTransactionView.contract?(internal_transaction) do %> + <%= if ExplorerWeb.InternalTransactionView.create?(internal_transaction) do %> <%= link( gettext("Contract Creation"), diff --git a/apps/explorer_web/lib/explorer_web/views/internal_transaction_view.ex b/apps/explorer_web/lib/explorer_web/views/internal_transaction_view.ex index 68084933a4..c7972efa47 100644 --- a/apps/explorer_web/lib/explorer_web/views/internal_transaction_view.ex +++ b/apps/explorer_web/lib/explorer_web/views/internal_transaction_view.ex @@ -4,6 +4,6 @@ defmodule ExplorerWeb.InternalTransactionView do alias Explorer.Chain.InternalTransaction - def contract?(%InternalTransaction{type: :create}), do: true - def contract?(_), do: false + def create?(%InternalTransaction{type: :create}), do: true + def create?(_), do: false end diff --git a/apps/explorer_web/test/explorer_web/views/internal_transaction_view_test.exs b/apps/explorer_web/test/explorer_web/views/internal_transaction_view_test.exs index ba118f5bd1..4effc5564d 100644 --- a/apps/explorer_web/test/explorer_web/views/internal_transaction_view_test.exs +++ b/apps/explorer_web/test/explorer_web/views/internal_transaction_view_test.exs @@ -3,17 +3,17 @@ defmodule ExplorerWeb.InternalTransactionViewTest do alias ExplorerWeb.InternalTransactionView - describe "contract?/1" do + describe "create?/1" do test "with internal transaction of type create returns true" do internal_transaction = build(:internal_transaction_create) - assert InternalTransactionView.contract?(internal_transaction) + assert InternalTransactionView.create?(internal_transaction) end test "with non-create type internal transaction returns false" do internal_transaction = build(:internal_transaction) - refute InternalTransactionView.contract?(internal_transaction) + refute InternalTransactionView.create?(internal_transaction) end end end