From b816543851c47b6b3c93eb535c2643c5b6af1338 Mon Sep 17 00:00:00 2001
From: Lucas Narciso <lucasnar@gmail.com>
Date: Wed, 1 Aug 2018 15:39:57 -0300
Subject: [PATCH] Change Transaction Details redirection behaviour

Redirects to Token Transfers if the transaction contains token
transfers, otherwise keeps the old way of redirecting to Internal
Transactions.
---
 .../controllers/transaction_controller.ex     |  8 ++++++-
 .../index.html.eex                            |  4 ++--
 .../templates/transaction_log/index.html.eex  |  2 +-
 .../transaction_controller_test.exs           | 23 +++++++++++++++----
 4 files changed, 28 insertions(+), 9 deletions(-)

diff --git a/apps/block_scout_web/lib/block_scout_web/controllers/transaction_controller.ex b/apps/block_scout_web/lib/block_scout_web/controllers/transaction_controller.ex
index af08d2c01c..1bfc278e1c 100644
--- a/apps/block_scout_web/lib/block_scout_web/controllers/transaction_controller.ex
+++ b/apps/block_scout_web/lib/block_scout_web/controllers/transaction_controller.ex
@@ -34,6 +34,12 @@ defmodule BlockScoutWeb.TransactionController do
   end
 
   def show(conn, %{"id" => id, "locale" => locale}) do
-    redirect(conn, to: transaction_internal_transaction_path(conn, :index, locale, id))
+    {:ok, transaction_hash} = Chain.string_to_transaction_hash(id)
+
+    if Chain.transaction_has_token_transfers?(transaction_hash) do
+      redirect(conn, to: transaction_token_transfer_path(conn, :index, locale, id))
+    else
+      redirect(conn, to: transaction_internal_transaction_path(conn, :index, locale, id))
+    end
   end
 end
diff --git a/apps/block_scout_web/lib/block_scout_web/templates/transaction_internal_transaction/index.html.eex b/apps/block_scout_web/lib/block_scout_web/templates/transaction_internal_transaction/index.html.eex
index 1c6322c3fb..0254272148 100644
--- a/apps/block_scout_web/lib/block_scout_web/templates/transaction_internal_transaction/index.html.eex
+++ b/apps/block_scout_web/lib/block_scout_web/templates/transaction_internal_transaction/index.html.eex
@@ -19,7 +19,7 @@
               <%= link(
                     gettext("Internal Transactions"),
                     class: "nav-link active",
-                    to: transaction_path(@conn, :show, @conn.assigns.locale, @transaction)
+                    to: transaction_internal_transaction_path(@conn, :index, @conn.assigns.locale, @transaction)
                   ) %>
             </li>
             <li class="nav-item">
@@ -48,7 +48,7 @@
                 <%= link(
                       gettext("Internal Transactions"),
                       class: "dropdown-item",
-                      to: transaction_path(@conn, :show, @conn.assigns.locale, @transaction)
+                      to: transaction_internal_transaction_path(@conn, :index, @conn.assigns.locale, @transaction)
                     ) %>
                     <%= link(
                           gettext("Logs"),
diff --git a/apps/block_scout_web/lib/block_scout_web/templates/transaction_log/index.html.eex b/apps/block_scout_web/lib/block_scout_web/templates/transaction_log/index.html.eex
index 2b24ab7e0a..e0319fbd65 100644
--- a/apps/block_scout_web/lib/block_scout_web/templates/transaction_log/index.html.eex
+++ b/apps/block_scout_web/lib/block_scout_web/templates/transaction_log/index.html.eex
@@ -20,7 +20,7 @@
             <%= link(
                   gettext("Internal Transactions"),
                   class: "nav-link",
-                  to: transaction_path(@conn, :show, @conn.assigns.locale, @transaction)
+                  to: transaction_internal_transaction_path(@conn, :index, @conn.assigns.locale, @transaction)
                 ) %>
           </li>
           <li class="nav-item">
diff --git a/apps/block_scout_web/test/block_scout_web/controllers/transaction_controller_test.exs b/apps/block_scout_web/test/block_scout_web/controllers/transaction_controller_test.exs
index c3aa1850c2..90106238ce 100644
--- a/apps/block_scout_web/test/block_scout_web/controllers/transaction_controller_test.exs
+++ b/apps/block_scout_web/test/block_scout_web/controllers/transaction_controller_test.exs
@@ -2,7 +2,8 @@ defmodule BlockScoutWeb.TransactionControllerTest do
   use BlockScoutWeb.ConnCase
   alias Explorer.Chain.{Block, Transaction}
 
-  import BlockScoutWeb.Router.Helpers, only: [transaction_path: 4, transaction_internal_transaction_path: 4]
+  import BlockScoutWeb.Router.Helpers,
+    only: [transaction_path: 4, transaction_internal_transaction_path: 4, transaction_token_transfer_path: 4]
 
   describe "GET index/2" do
     test "returns a collated transactions", %{conn: conn} do
@@ -98,12 +99,24 @@ defmodule BlockScoutWeb.TransactionControllerTest do
   end
 
   describe "GET show/3" do
-    test "redirects to transactions/:transaction_id/internal_transactions", %{conn: conn} do
+    test "redirects to transactions/:transaction_id/token_transfers when there are token transfers", %{conn: conn} do
       locale = "en"
-      hash = "0x9"
-      conn = get(conn, transaction_path(BlockScoutWeb.Endpoint, :show, locale, hash))
+      transaction = insert(:transaction)
+      insert(:token_transfer, transaction: transaction)
+      conn = get(conn, transaction_path(BlockScoutWeb.Endpoint, :show, locale, transaction))
 
-      assert redirected_to(conn) =~ transaction_internal_transaction_path(BlockScoutWeb.Endpoint, :index, locale, hash)
+      assert redirected_to(conn) =~ transaction_token_transfer_path(BlockScoutWeb.Endpoint, :index, locale, transaction)
+    end
+
+    test "redirects to transactions/:transaction_id/internal_transactions when there are no token transfers", %{
+      conn: conn
+    } do
+      locale = "en"
+      transaction = insert(:transaction)
+      conn = get(conn, transaction_path(BlockScoutWeb.Endpoint, :show, locale, transaction))
+
+      assert redirected_to(conn) =~
+               transaction_internal_transaction_path(BlockScoutWeb.Endpoint, :index, locale, transaction)
     end
   end
 end