From bb026b18120a993e01cf38042676ebbacd63737f Mon Sep 17 00:00:00 2001
From: Ayrat Badykov <ayratin555@gmail.com>
Date: Fri, 24 May 2019 16:29:49 +0300
Subject: [PATCH] fix block transaction tests

---
 .../block_transaction_controller_test.exs     | 75 +++++++++++++------
 1 file changed, 54 insertions(+), 21 deletions(-)

diff --git a/apps/block_scout_web/test/block_scout_web/controllers/block_transaction_controller_test.exs b/apps/block_scout_web/test/block_scout_web/controllers/block_transaction_controller_test.exs
index b8f6233e49..5b1ae46705 100644
--- a/apps/block_scout_web/test/block_scout_web/controllers/block_transaction_controller_test.exs
+++ b/apps/block_scout_web/test/block_scout_web/controllers/block_transaction_controller_test.exs
@@ -39,10 +39,15 @@ defmodule BlockScoutWeb.BlockTransactionControllerTest do
       |> with_block(block)
       |> with_contract_creation(insert(:contract_address))
 
-      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block.number))
+      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block), %{type: "JSON"})
 
-      assert html_response(conn, 200)
-      assert 2 == Enum.count(conn.assigns.transactions)
+      assert json_response(conn, 200)
+
+      {:ok, %{"items" => items}} =
+        conn.resp_body
+        |> Poison.decode()
+
+      assert Enum.count(items) == 2
     end
 
     test "non-consensus block number without consensus blocks is treated as consensus number above tip", %{conn: conn} do
@@ -77,10 +82,15 @@ defmodule BlockScoutWeb.BlockTransactionControllerTest do
       |> insert()
       |> with_block(block)
 
-      conn = get(conn, block_transaction_path(conn, :index, block.hash))
+      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block), %{type: "JSON"})
+
+      assert json_response(conn, 200)
 
-      assert html_response(conn, 200)
-      assert Enum.count(conn.assigns.transactions) == 1
+      {:ok, %{"items" => items}} =
+        conn.resp_body
+        |> Poison.decode()
+
+      assert Enum.count(items) == 1
     end
 
     test "does not return transactions for non-consensus block hash", %{conn: conn} do
@@ -89,10 +99,15 @@ defmodule BlockScoutWeb.BlockTransactionControllerTest do
       transaction = insert(:transaction)
       insert(:transaction_fork, hash: transaction.hash, uncle_hash: block.hash)
 
-      conn = get(conn, block_transaction_path(conn, :index, block.hash))
+      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block), %{type: "JSON"})
+
+      assert json_response(conn, 200)
+
+      {:ok, %{"items" => items}} =
+        conn.resp_body
+        |> Poison.decode()
 
-      assert html_response(conn, 200)
-      assert Enum.count(conn.assigns.transactions) == 0
+      assert Enum.empty?(items)
     end
 
     test "does not return transactions for invalid block hash", %{conn: conn} do
@@ -111,44 +126,62 @@ defmodule BlockScoutWeb.BlockTransactionControllerTest do
       insert(:transaction)
       block = insert(:block)
 
-      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block))
+      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block), %{type: "JSON"})
 
-      assert html_response(conn, 200)
-      assert Enum.empty?(conn.assigns.transactions)
+      assert json_response(conn, 200)
+
+      {:ok, %{"items" => items}} =
+        conn.resp_body
+        |> Poison.decode()
+
+      assert Enum.empty?(items)
     end
 
     test "does not return related transactions without a block", %{conn: conn} do
       block = insert(:block)
       insert(:transaction)
 
-      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block))
+      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block), %{type: "JSON"})
+
+      assert json_response(conn, 200)
 
-      assert html_response(conn, 200)
-      assert Enum.empty?(conn.assigns.transactions)
+      {:ok, %{"items" => items}} =
+        conn.resp_body
+        |> Poison.decode()
+
+      assert Enum.empty?(items)
     end
 
-    test "next_page_params exist if not on last page", %{conn: conn} do
+    test "next_page_path exists if not on last page", %{conn: conn} do
       block = %Block{number: number} = insert(:block)
 
       60
       |> insert_list(:transaction)
       |> with_block(block)
 
-      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block))
+      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block), %{type: "JSON"})
+
+      {:ok, %{"next_page_path" => next_page_path}} =
+        conn.resp_body
+        |> Poison.decode()
 
-      assert %{"block_number" => ^number, "index" => 10} = conn.assigns.next_page_params
+      assert next_page_path
     end
 
-    test "next_page_params are empty if on last page", %{conn: conn} do
+    test "next_page_path is empty if on last page", %{conn: conn} do
       block = insert(:block)
 
       :transaction
       |> insert()
       |> with_block(block)
 
-      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block))
+      conn = get(conn, block_transaction_path(BlockScoutWeb.Endpoint, :index, block), %{type: "JSON"})
+
+      {:ok, %{"next_page_path" => next_page_path}} =
+        conn.resp_body
+        |> Poison.decode()
 
-      refute conn.assigns.next_page_params
+      refute next_page_path
     end
 
     test "displays miner primary address name", %{conn: conn} do