From e6dc4e073c68c4c248db88fb283fb6a8450fd48c Mon Sep 17 00:00:00 2001
From: Vadim <varasev@gmail.com>
Date: Thu, 21 Nov 2019 15:49:37 +0300
Subject: [PATCH] Rename some DB fields

---
 .../channels/stakes_channel.ex                |  6 ++---
 .../controllers/stakes_controller.ex          |  4 ++--
 .../templates/stakes/_rows.html.eex           |  4 ++--
 .../_stakes_modal_delegators_list.html.eex    | 10 ++++-----
 .../stakes/_stakes_modal_move.html.eex        |  2 +-
 .../stakes/_stakes_modal_pool_info.html.eex   |  2 +-
 apps/explorer/lib/explorer/chain.ex           | 22 +++++++++----------
 .../import/runner/staking_pools_delegators.ex |  6 ++---
 .../lib/explorer/chain/staking_pool.ex        |  2 +-
 .../explorer/chain/staking_pools_delegator.ex | 14 ++++++------
 .../lib/explorer/staking/contract_state.ex    |  4 ++--
 .../explorer/staking/stake_snapshotting.ex    |  4 ++--
 ...112839_create_staking_pools_delegators.exs |  8 +++----
 ...0190807111216_remove_duplicate_indexes.exs |  4 ++--
 .../chain/staking_pools_delegator_test.exs    |  2 +-
 apps/explorer/test/support/factory.ex         |  4 ++--
 16 files changed, 49 insertions(+), 49 deletions(-)

diff --git a/apps/block_scout_web/lib/block_scout_web/channels/stakes_channel.ex b/apps/block_scout_web/lib/block_scout_web/channels/stakes_channel.ex
index 4045608014..7c11511d6d 100644
--- a/apps/block_scout_web/lib/block_scout_web/channels/stakes_channel.ex
+++ b/apps/block_scout_web/lib/block_scout_web/channels/stakes_channel.ex
@@ -62,7 +62,7 @@ defmodule BlockScoutWeb.StakesChannel do
       pool_staking_address
       |> Chain.staking_pool_delegators()
       |> Enum.sort_by(fn staker ->
-        staker_address = to_string(staker.delegator_address_hash)
+        staker_address = to_string(staker.address_hash)
 
         cond do
           staker_address == pool_staking_address -> 0
@@ -148,7 +148,7 @@ defmodule BlockScoutWeb.StakesChannel do
     token = ContractState.get(:token)
 
     min_from_stake =
-      if delegator_from.delegator_address_hash == delegator_from.pool_address_hash do
+      if delegator_from.address_hash == delegator_from.staking_address_hash do
         ContractState.get(:min_candidate_stake)
       else
         ContractState.get(:min_delegator_stake)
@@ -201,7 +201,7 @@ defmodule BlockScoutWeb.StakesChannel do
     delegator = Chain.staking_pool_delegator(staking_address, socket.assigns.account)
 
     min_stake =
-      if delegator.delegator_address_hash == delegator.pool_address_hash do
+      if delegator.address_hash == delegator.staking_address_hash do
         ContractState.get(:min_candidate_stake)
       else
         ContractState.get(:min_delegator_stake)
diff --git a/apps/block_scout_web/lib/block_scout_web/controllers/stakes_controller.ex b/apps/block_scout_web/lib/block_scout_web/controllers/stakes_controller.ex
index f28519102f..6ca15827e9 100644
--- a/apps/block_scout_web/lib/block_scout_web/controllers/stakes_controller.ex
+++ b/apps/block_scout_web/lib/block_scout_web/controllers/stakes_controller.ex
@@ -25,7 +25,7 @@ defmodule BlockScoutWeb.StakesController do
     account =
       if account_address = conn.assigns[:account] do
         account_address
-        |> Chain.get_total_staked()
+        |> Chain.get_total_staked_and_ordered()
         |> Map.merge(%{
           address: account_address,
           balance: Chain.fetch_last_token_balance(account_address, token.contract_address_hash),
@@ -141,7 +141,7 @@ defmodule BlockScoutWeb.StakesController do
   end
 
   defp stake_allowed?(pool, delegator) do
-    Decimal.positive?(pool.self_staked_amount) or delegator.delegator_address_hash == pool.staking_address_hash
+    Decimal.positive?(pool.self_staked_amount) or delegator.address_hash == pool.staking_address_hash
   end
 
   defp move_allowed?(nil), do: false
diff --git a/apps/block_scout_web/lib/block_scout_web/templates/stakes/_rows.html.eex b/apps/block_scout_web/lib/block_scout_web/templates/stakes/_rows.html.eex
index 8ac2afb7c7..2aa0b50325 100644
--- a/apps/block_scout_web/lib/block_scout_web/templates/stakes/_rows.html.eex
+++ b/apps/block_scout_web/lib/block_scout_web/templates/stakes/_rows.html.eex
@@ -36,7 +36,7 @@
       <span class="stakes-td-banned-info">
         <%= gettext("Banned until block #%{banned_until} (%{estimated_unban_day})", banned_until: @pool.banned_until, estimated_unban_day: estimated_unban_day(@pool.banned_until, @average_block_time)) %>
         <%= if @delegator &&
-               @delegator.delegator_address_hash != @pool.staking_address_hash &&
+               @delegator.address_hash != @pool.staking_address_hash &&
                @pool.are_delegators_banned &&
                @pool.banned_until != @pool.banned_delegators_until do %>
           <%= raw(".<br />") %>
@@ -47,7 +47,7 @@
     <%= if !@pool.is_banned ||
            (!@pool.are_delegators_banned &&
             @delegator &&
-            @delegator.delegator_address_hash != @pool.staking_address_hash
+            @delegator.address_hash != @pool.staking_address_hash
             ) do %>
       <div class="stakes-controls">
         <%= if @buttons.move do %>
diff --git a/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_delegators_list.html.eex b/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_delegators_list.html.eex
index 61b0e3f3df..bb9824bf7b 100644
--- a/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_delegators_list.html.eex
+++ b/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_delegators_list.html.eex
@@ -63,13 +63,13 @@
                     <span class="stakes-address">
                       <%=
                         link(
-                          BlockScoutWeb.AddressView.trimmed_hash(staker.delegator_address_hash),
-                          to: address_path(@conn, :show, staker.delegator_address_hash),
+                          BlockScoutWeb.AddressView.trimmed_hash(staker.address_hash),
+                          to: address_path(@conn, :show, staker.address_hash),
                           target: "_blank"
                         )
                       %>
                     </span>
-                    <%= if staker.delegator_address_hash == @pool.staking_address_hash do %>
+                    <%= if staker.address_hash == @pool.staking_address_hash do %>
                       <%=
                         render(
                           BlockScoutWeb.CommonComponentsView,
@@ -78,7 +78,7 @@
                         )
                       %>
                     <% end %>
-                    <%= if to_string(staker.delegator_address_hash) == @account do %>
+                    <%= if to_string(staker.address_hash) == @account do %>
                       <div
                           class="me-tooltip"
                           data-boundary="window"
@@ -110,7 +110,7 @@
                 <div class="col-3 stakes-td stakes-cell">
                   <%
                     reward =
-                      if staker.delegator_address_hash == @pool.staking_address_hash do
+                      if staker.address_hash == @pool.staking_address_hash do
                         %{
                           reward_ratio: @pool.validator_reward_ratio,
                           snapshotted_reward_ratio: @pool.snapshotted_validator_reward_ratio
diff --git a/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_move.html.eex b/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_move.html.eex
index 7283a66111..84cc730e97 100644
--- a/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_move.html.eex
+++ b/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_move.html.eex
@@ -22,7 +22,7 @@
                 <option disabled <%= unless @pool_to do "selected" end %>><%= gettext("Choose Pool") %></option>
                 <%= for %{pool: pool} <- @pools,
                       pool.staking_address_hash != @pool_from.staking_address_hash,
-                      Decimal.positive?(pool.self_staked_amount) or pool.staking_address_hash == @delegator_from.delegator_address_hash do %>
+                      Decimal.positive?(pool.self_staked_amount) or pool.staking_address_hash == @delegator_from.address_hash do %>
                   <option
                     value="<%= pool.staking_address_hash %>"
                     <%= if @pool_to && pool.staking_address_hash == @pool_to.staking_address_hash do "selected" end %>
diff --git a/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_pool_info.html.eex b/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_pool_info.html.eex
index bf011701d5..ece74027c6 100644
--- a/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_pool_info.html.eex
+++ b/apps/block_scout_web/lib/block_scout_web/templates/stakes/_stakes_modal_pool_info.html.eex
@@ -15,7 +15,7 @@
           <%= gettext("This pool is banned until block #%{banned_until} (%{estimated_unban_day})", banned_until: @validator.banned_until, estimated_unban_day: estimated_unban_day(@validator.banned_until, @average_block_time)) %><br />
           <%= gettext("Reason for Ban: %{ban_reason}", ban_reason: String.capitalize(@validator.ban_reason)) %>
           <%= if @delegator &&
-                 @delegator.delegator_address_hash != @validator.staking_address_hash &&
+                 @delegator.address_hash != @validator.staking_address_hash &&
                  @validator.are_delegators_banned &&
                  @validator.banned_until != @validator.banned_delegators_until do %>
             <br />
diff --git a/apps/explorer/lib/explorer/chain.ex b/apps/explorer/lib/explorer/chain.ex
index c4fc454fba..c8d768e073 100644
--- a/apps/explorer/lib/explorer/chain.ex
+++ b/apps/explorer/lib/explorer/chain.ex
@@ -4727,14 +4727,14 @@ defmodule Explorer.Chain do
   @spec staking_pools(
           filter :: :validator | :active | :inactive,
           paging_options :: PagingOptions.t() | :all,
-          delegator_address_hash :: Hash.t() | nil,
+          address_hash :: Hash.t() | nil,
           filter_banned :: boolean() | nil,
           filter_my :: boolean() | nil
         ) :: [map()]
   def staking_pools(
         filter,
         paging_options \\ @default_paging_options,
-        delegator_address_hash \\ nil,
+        address_hash \\ nil,
         filter_banned \\ false,
         filter_my \\ false
       ) do
@@ -4745,11 +4745,11 @@ defmodule Explorer.Chain do
       |> staking_pools_paging_query(paging_options)
 
     delegator_query =
-      if delegator_address_hash do
+      if address_hash do
         base_query
         |> join(:left, [p], pd in StakingPoolsDelegator,
           on:
-            p.staking_address_hash == pd.pool_address_hash and pd.delegator_address_hash == ^delegator_address_hash and
+            p.staking_address_hash == pd.staking_address_hash and pd.address_hash == ^address_hash and
               not pd.is_deleted
         )
         |> select([p, pd], %{pool: p, delegator: pd})
@@ -4766,7 +4766,7 @@ defmodule Explorer.Chain do
       end
 
     filtered_query =
-      if delegator_address_hash && filter_my do
+      if address_hash && filter_my do
         where(banned_query, [..., pd], not is_nil(pd))
       else
         banned_query
@@ -4824,22 +4824,22 @@ defmodule Explorer.Chain do
 
   def staking_pool_delegators(staking_address_hash) do
     StakingPoolsDelegator
-    |> where(pool_address_hash: ^staking_address_hash, is_active: true)
+    |> where(staking_address_hash: ^staking_address_hash, is_active: true)
     |> order_by(desc: :stake_amount)
     |> Repo.all()
   end
 
-  def staking_pool_delegator(pool_address_hash, delegator_address_hash) do
+  def staking_pool_delegator(staking_address_hash, address_hash) do
     Repo.get_by(StakingPoolsDelegator,
-      pool_address_hash: pool_address_hash,
-      delegator_address_hash: delegator_address_hash,
+      staking_address_hash: staking_address_hash,
+      address_hash: address_hash,
       is_deleted: false
     )
   end
 
-  def get_total_staked(address_hash) do
+  def get_total_staked_and_ordered(address_hash) do
     StakingPoolsDelegator
-    |> where([delegator], delegator.delegator_address_hash == ^address_hash and not delegator.is_deleted)
+    |> where([delegator], delegator.address_hash == ^address_hash and not delegator.is_deleted)
     |> select([delegator], %{
       stake_amount: coalesce(sum(delegator.stake_amount), 0),
       ordered_withdraw: coalesce(sum(delegator.ordered_withdraw), 0)
diff --git a/apps/explorer/lib/explorer/chain/import/runner/staking_pools_delegators.ex b/apps/explorer/lib/explorer/chain/import/runner/staking_pools_delegators.ex
index f1fa186643..0e09a2f349 100644
--- a/apps/explorer/lib/explorer/chain/import/runner/staking_pools_delegators.ex
+++ b/apps/explorer/lib/explorer/chain/import/runner/staking_pools_delegators.ex
@@ -85,16 +85,16 @@ defmodule Explorer.Chain.Import.Runner.StakingPoolsDelegators do
     on_conflict = Map.get_lazy(options, :on_conflict, &default_on_conflict/0)
 
     # Enforce StackingPoolDelegator ShareLocks order (see docs: sharelocks.md)
-    ordered_changes_list = Enum.sort_by(changes_list, &{&1.delegator_address_hash, &1.pool_address_hash})
+    ordered_changes_list = Enum.sort_by(changes_list, &{&1.address_hash, &1.staking_address_hash})
 
     {:ok, _} =
       Import.insert_changes_list(
         repo,
         ordered_changes_list,
-        conflict_target: [:pool_address_hash, :delegator_address_hash],
+        conflict_target: [:staking_address_hash, :address_hash],
         on_conflict: on_conflict,
         for: StakingPoolsDelegator,
-        returning: [:pool_address_hash, :delegator_address_hash],
+        returning: [:staking_address_hash, :address_hash],
         timeout: timeout,
         timestamps: timestamps
       )
diff --git a/apps/explorer/lib/explorer/chain/staking_pool.ex b/apps/explorer/lib/explorer/chain/staking_pool.ex
index 189715a5ab..92b97bde5f 100644
--- a/apps/explorer/lib/explorer/chain/staking_pool.ex
+++ b/apps/explorer/lib/explorer/chain/staking_pool.ex
@@ -72,7 +72,7 @@ defmodule Explorer.Chain.StakingPool do
     field(:was_banned_count, :integer)
     field(:was_validator_count, :integer)
     field(:is_deleted, :boolean, default: false)
-    has_many(:delegators, StakingPoolsDelegator, foreign_key: :pool_address_hash)
+    has_many(:delegators, StakingPoolsDelegator, foreign_key: :staking_address_hash)
 
     belongs_to(
       :staking_address,
diff --git a/apps/explorer/lib/explorer/chain/staking_pools_delegator.ex b/apps/explorer/lib/explorer/chain/staking_pools_delegator.ex
index ae9c273bf7..fee81afa61 100644
--- a/apps/explorer/lib/explorer/chain/staking_pools_delegator.ex
+++ b/apps/explorer/lib/explorer/chain/staking_pools_delegator.ex
@@ -13,8 +13,8 @@ defmodule Explorer.Chain.StakingPoolsDelegator do
   }
 
   @type t :: %__MODULE__{
-          pool_address_hash: Hash.Address.t(),
-          delegator_address_hash: Hash.Address.t(),
+          staking_address_hash: Hash.Address.t(),
+          address_hash: Hash.Address.t(),
           max_ordered_withdraw_allowed: Decimal.t(),
           max_withdraw_allowed: Decimal.t(),
           ordered_withdraw: Decimal.t(),
@@ -28,13 +28,13 @@ defmodule Explorer.Chain.StakingPoolsDelegator do
         }
 
   @attrs ~w(
-    pool_address_hash delegator_address_hash max_ordered_withdraw_allowed
+    staking_address_hash address_hash max_ordered_withdraw_allowed
     max_withdraw_allowed ordered_withdraw stake_amount snapshotted_stake_amount ordered_withdraw_epoch
     reward_ratio snapshotted_reward_ratio is_active is_deleted
   )a
 
   @req_attrs ~w(
-    pool_address_hash delegator_address_hash max_ordered_withdraw_allowed
+    staking_address_hash address_hash max_ordered_withdraw_allowed
     max_withdraw_allowed ordered_withdraw stake_amount ordered_withdraw_epoch
   )a
 
@@ -53,7 +53,7 @@ defmodule Explorer.Chain.StakingPoolsDelegator do
     belongs_to(
       :staking_pool,
       StakingPool,
-      foreign_key: :pool_address_hash,
+      foreign_key: :staking_address_hash,
       references: :staking_address_hash,
       type: Hash.Address
     )
@@ -61,7 +61,7 @@ defmodule Explorer.Chain.StakingPoolsDelegator do
     belongs_to(
       :delegator_address,
       Address,
-      foreign_key: :delegator_address_hash,
+      foreign_key: :address_hash,
       references: :hash,
       type: Hash.Address
     )
@@ -74,6 +74,6 @@ defmodule Explorer.Chain.StakingPoolsDelegator do
     staking_pools_delegator
     |> cast(attrs, @attrs)
     |> validate_required(@req_attrs)
-    |> unique_constraint(:pool_address_hash, name: :pools_delegator_index)
+    |> unique_constraint(:staking_address_hash, name: :pools_delegator_index)
   end
 end
diff --git a/apps/explorer/lib/explorer/staking/contract_state.ex b/apps/explorer/lib/explorer/staking/contract_state.ex
index a7ddbdbfbd..59c5237bfb 100644
--- a/apps/explorer/lib/explorer/staking/contract_state.ex
+++ b/apps/explorer/lib/explorer/staking/contract_state.ex
@@ -254,8 +254,8 @@ defmodule Explorer.Staking.ContractState do
         delegator_reward_response = delegator_reward_responses[{pool_address, delegator_address, is_active}]
 
         Map.merge(response, %{
-          delegator_address_hash: delegator_address,
-          pool_address_hash: pool_address,
+          address_hash: delegator_address,
+          staking_address_hash: pool_address,
           is_active: is_active,
           reward_ratio: Float.floor(delegator_reward_response.delegator_share / 10_000, 2)
         })
diff --git a/apps/explorer/lib/explorer/staking/stake_snapshotting.ex b/apps/explorer/lib/explorer/staking/stake_snapshotting.ex
index 62f1bbfd76..4b50f1fc73 100644
--- a/apps/explorer/lib/explorer/staking/stake_snapshotting.ex
+++ b/apps/explorer/lib/explorer/staking/stake_snapshotting.ex
@@ -122,8 +122,8 @@ defmodule Explorer.Staking.StakeSnapshotting do
         delegator_reward_response = delegator_reward_responses[{pool_address, delegator_address, is_active}]
 
         Map.merge(response, %{
-          delegator_address_hash: delegator_address,
-          pool_address_hash: pool_address,
+          address_hash: delegator_address,
+          staking_address_hash: pool_address,
           is_active: is_active,
           snapshotted_reward_ratio: Float.floor(delegator_reward_response.delegator_share / 10_000, 2)
         })
diff --git a/apps/explorer/priv/repo/migrations/20190523112839_create_staking_pools_delegators.exs b/apps/explorer/priv/repo/migrations/20190523112839_create_staking_pools_delegators.exs
index ccf9c8c372..68cc3adbec 100644
--- a/apps/explorer/priv/repo/migrations/20190523112839_create_staking_pools_delegators.exs
+++ b/apps/explorer/priv/repo/migrations/20190523112839_create_staking_pools_delegators.exs
@@ -3,8 +3,8 @@ defmodule Explorer.Repo.Migrations.CreateStakingPoolsDelegator do
 
   def change do
     create table(:staking_pools_delegators) do
-      add(:delegator_address_hash, :bytea)
-      add(:pool_address_hash, :bytea)
+      add(:address_hash, :bytea)
+      add(:staking_address_hash, :bytea)
       add(:stake_amount, :numeric, precision: 100)
       add(:ordered_withdraw, :numeric, precision: 100)
       add(:max_withdraw_allowed, :numeric, precision: 100)
@@ -14,10 +14,10 @@ defmodule Explorer.Repo.Migrations.CreateStakingPoolsDelegator do
       timestamps(null: false, type: :utc_datetime_usec)
     end
 
-    create(index(:staking_pools_delegators, [:delegator_address_hash]))
+    create(index(:staking_pools_delegators, [:address_hash]))
 
     create(
-      index(:staking_pools_delegators, [:delegator_address_hash, :pool_address_hash],
+      index(:staking_pools_delegators, [:address_hash, :staking_address_hash],
         unique: true,
         name: :pools_delegator_index
       )
diff --git a/apps/explorer/priv/repo/migrations/20190807111216_remove_duplicate_indexes.exs b/apps/explorer/priv/repo/migrations/20190807111216_remove_duplicate_indexes.exs
index ae07c8b1e5..5c2ce80691 100644
--- a/apps/explorer/priv/repo/migrations/20190807111216_remove_duplicate_indexes.exs
+++ b/apps/explorer/priv/repo/migrations/20190807111216_remove_duplicate_indexes.exs
@@ -7,8 +7,8 @@ defmodule Explorer.Repo.Migrations.RemoveDuplicateIndexes do
     )
 
     drop_if_exists(
-      index(:staking_pools_delegators, [:delegator_address_hash],
-        name: "staking_pools_delegators_delegator_address_hash_index"
+      index(:staking_pools_delegators, [:address_hash],
+        name: "staking_pools_delegators_address_hash_index"
       )
     )
 
diff --git a/apps/explorer/test/explorer/chain/staking_pools_delegator_test.exs b/apps/explorer/test/explorer/chain/staking_pools_delegator_test.exs
index 222658e92e..c126bc76f0 100644
--- a/apps/explorer/test/explorer/chain/staking_pools_delegator_test.exs
+++ b/apps/explorer/test/explorer/chain/staking_pools_delegator_test.exs
@@ -11,7 +11,7 @@ defmodule Explorer.Chain.StakingPoolsDelegatorTest do
     end
 
     test "with invalid attributes" do
-      changeset = StakingPoolsDelegator.changeset(%StakingPoolsDelegator{}, %{pool_address_hash: 0})
+      changeset = StakingPoolsDelegator.changeset(%StakingPoolsDelegator{}, %{staking_address_hash: 0})
       refute changeset.valid?
     end
   end
diff --git a/apps/explorer/test/support/factory.ex b/apps/explorer/test/support/factory.ex
index 2ec3084f2b..323e337dde 100644
--- a/apps/explorer/test/support/factory.ex
+++ b/apps/explorer/test/support/factory.ex
@@ -674,8 +674,8 @@ defmodule Explorer.Factory do
     wei_per_ether = 1_000_000_000_000_000_000
 
     %StakingPoolsDelegator{
-      pool_address_hash: address_hash(),
-      delegator_address_hash: address_hash(),
+      staking_address_hash: address_hash(),
+      address_hash: address_hash(),
       max_ordered_withdraw_allowed: wei_per_ether * 100,
       max_withdraw_allowed: wei_per_ether * 50,
       ordered_withdraw: wei_per_ether * 600,