From ef92e47c6b9ee703cbfd98fa8d265b2eb5476ca8 Mon Sep 17 00:00:00 2001
From: Tim Mecklem <timothy@mecklem.com>
Date: Mon, 4 Jun 2018 16:06:02 -0400
Subject: [PATCH 1/6] Remove unnecessary joins to blocks table

Co-authored-by: Stamates <stamates@hotmail.com>
---
 apps/explorer/lib/explorer/chain.ex | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/apps/explorer/lib/explorer/chain.ex b/apps/explorer/lib/explorer/chain.ex
index f490dd73f0..b2edd2c412 100644
--- a/apps/explorer/lib/explorer/chain.ex
+++ b/apps/explorer/lib/explorer/chain.ex
@@ -1639,13 +1639,11 @@ defmodule Explorer.Chain do
       {:ok, hash} ->
         from(
           transaction in query,
-          inner_join: block in assoc(transaction, :block),
           join: hash_transaction in Transaction,
           on: hash_transaction.hash == ^hash,
-          inner_join: hash_block in assoc(hash_transaction, :block),
           where:
-            block.number > hash_block.number or
-              (block.number == hash_block.number and transaction.index > hash_transaction.index)
+            transaction.block_number > hash_transaction.block_number or
+              (transaction.block_number == hash_transaction.block_number and transaction.index > hash_transaction.index)
         )
 
       :error ->

From 563273b2b1f3f80bc5e46658dfcee61e073f7063 Mon Sep 17 00:00:00 2001
From: Tim Mecklem <timothy@mecklem.com>
Date: Mon, 4 Jun 2018 22:59:55 -0400
Subject: [PATCH 2/6] Use block_number and index for stable transaction paging

Fix paging to function correctly
Add paging in other direction
Add PagingOptions struct to manage stable paging
---
 apps/explorer/lib/explorer/chain.ex           | 111 ++++++------------
 .../lib/explorer/chain/transaction.ex         |   7 +-
 apps/explorer/lib/explorer/paging_options.ex  |  13 ++
 apps/explorer/test/explorer/chain_test.exs    |  11 ++
 .../controllers/transaction_controller.ex     |  25 ++--
 .../templates/transaction/index.html.eex      |  24 ++--
 .../transaction_controller_test.exs           |  45 +++----
 7 files changed, 114 insertions(+), 122 deletions(-)
 create mode 100644 apps/explorer/lib/explorer/paging_options.ex

diff --git a/apps/explorer/lib/explorer/chain.ex b/apps/explorer/lib/explorer/chain.ex
index b2edd2c412..8cfc469f3d 100644
--- a/apps/explorer/lib/explorer/chain.ex
+++ b/apps/explorer/lib/explorer/chain.ex
@@ -3,7 +3,8 @@ defmodule Explorer.Chain do
   The chain context.
   """
 
-  import Ecto.Query, only: [from: 2, join: 4, or_where: 3, order_by: 2, order_by: 3, preload: 2, where: 2, where: 3]
+  import Ecto.Query,
+    only: [from: 2, join: 4, limit: 2, or_where: 3, order_by: 2, order_by: 3, preload: 2, where: 2, where: 3]
 
   alias Ecto.{Changeset, Multi}
 
@@ -19,7 +20,7 @@ defmodule Explorer.Chain do
   }
 
   alias Explorer.Chain.Block.Reward
-  alias Explorer.Repo
+  alias Explorer.{PagingOptions, Repo}
 
   @typedoc """
   The name of an association on the `t:Ecto.Schema.t/0`
@@ -45,11 +46,11 @@ defmodule Explorer.Chain do
   """
   @type pagination :: map()
 
-  @typep after_hash_option :: {:after_hash, Hash.t()}
   @typep direction_option :: {:direction, direction}
   @typep inserted_after_option :: {:inserted_after, DateTime.t()}
   @typep necessity_by_association_option :: {:necessity_by_association, necessity_by_association}
   @typep pagination_option :: {:pagination, pagination}
+  @typep paging_options :: PagingOptions.t()
   @typep params_option :: {:params, map()}
   @typep timeout_option :: {:timeout, timeout}
   @typep timestamps :: %{inserted_at: DateTime.t(), updated_at: DateTime.t()}
@@ -1261,80 +1262,40 @@ defmodule Explorer.Chain do
   end
 
   @doc """
-  Returns the list of collated transactions that occurred recently (10).
+  Returns the paged list of collated transactions that occurred recently from newest to oldest using `block_number`
+  and `index`.
 
-      iex> 2 |> insert_list(:transaction) |> with_block()
-      iex> insert(:transaction) # unvalidated transaction
-      iex> 8 |> insert_list(:transaction) |> with_block()
-      iex> recent_collated_transactions = Explorer.Chain.recent_collated_transactions()
+      iex> newest_first_transactions = 50 |> insert_list(:transaction) |> with_block() |> Enum.reverse()
+      iex> oldest_seen = Enum.at(newest_first_transactions, 9)
+      iex> paging_options = %Explorer.PagingOptions{page_size: 10, key: {oldest_seen.block_number, oldest_seen.index}}
+      iex> recent_collated_transactions = Explorer.Chain.recent_collated_transactions(paging_options: paging_options)
       iex> length(recent_collated_transactions)
       10
-      iex> Enum.all?(recent_collated_transactions, fn %Explorer.Chain.Transaction{block_hash: block_hash} ->
-      ...>   !is_nil(block_hash)
-      ...> end)
+      iex> hd(recent_collated_transactions).hash == Enum.at(newest_first_transactions, 10).hash
       true
 
-  A `t:Explorer.Chain.Transaction.t/0` `hash` can be supplied to the `:after_hash` option, then only transactions in
-  after the transaction (with a greater index) in the same block or in a later block (with a greater number) will be
-  returned.  This can be used to generate paging for collated transaction.
-
-      iex> first_block = insert(:block, number: 1)
-      iex> first_transaction_in_first_block = :transaction |> insert() |> with_block(first_block)
-      iex> second_transaction_in_first_block = :transaction |> insert() |> with_block(first_block)
-      iex> second_block = insert(:block, number: 2)
-      iex> first_transaction_in_second_block = :transaction |> insert() |> with_block(second_block)
-      iex> after_first_transaciton_in_first_block = Explorer.Chain.recent_collated_transactions(
-      ...>   after_hash: first_transaction_in_first_block.hash
-      ...> )
-      iex> length(after_first_transaciton_in_first_block)
-      2
-      iex> after_second_transaciton_in_first_block = Explorer.Chain.recent_collated_transactions(
-      ...>   after_hash: second_transaction_in_first_block.hash
-      ...> )
-      iex> length(after_second_transaciton_in_first_block)
-      1
-      iex> after_first_transaciton_in_second_block = Explorer.Chain.recent_collated_transactions(
-      ...>   after_hash: first_transaction_in_second_block.hash
-      ...> )
-      iex> length(after_first_transaciton_in_second_block)
-      0
-
-  When there are no collated transactions, an empty list is returned.
-
-     iex> insert(:transaction)
-     iex> Explorer.Chain.recent_collated_transactions()
-     []
-
-  Using an unvalidated transaction's hash for `:after_hash` will also yield an empty list.
-
-     iex> %Explorer.Chain.Transaction{hash: hash} = insert(:transaction)
-     iex> insert(:transaction)
-     iex> Explorer.Chain.recent_collated_transactions(after_hash: hash)
-     []
-
   ## Options
 
     * `:necessity_by_association` - use to load `t:association/0` as `:required` or `:optional`.  If an association is
       `:required`, and the `t:Explorer.Chain.InternalTransaction.t/0` has no associated record for that association,
       then the `t:Explorer.Chain.InternalTransaction.t/0` will not be included in the list.
+    * `:paging_options` - a `t:Explorer.PagingOptions.t/0` used to specify the `:page_size` and
+      `:key` (a tuple of the lowest/oldest {block_number, index}) and. Results will be the transactions older than
+      the block number and index that are passed.
 
   """
-  @spec recent_collated_transactions([after_hash_option | necessity_by_association_option]) :: [
+  @spec recent_collated_transactions([paging_options | necessity_by_association_option]) :: [
           Transaction.t()
         ]
   def recent_collated_transactions(options \\ []) when is_list(options) do
     necessity_by_association = Keyword.get(options, :necessity_by_association, %{})
+    paging_options = Keyword.get(options, :paging_options, %PagingOptions{page_size: 50})
 
-    query =
-      from(
-        transaction in Transaction,
-        where: not is_nil(transaction.block_number) and not is_nil(transaction.index),
-        order_by: [desc: transaction.block_number, desc: transaction.index],
-        limit: 10
-      )
-
-    query
-    |> after_hash(options)
+    Transaction
+    |> where([transaction], not is_nil(transaction.block_number) and not is_nil(transaction.index))
+    |> page_transaction(paging_options)
+    |> limit(^paging_options.page_size)
+    |> order_by([transaction], desc: transaction.block_number, desc: transaction.index)
     |> join_associations(necessity_by_association)
     |> Repo.all()
   end
@@ -1634,23 +1595,6 @@ defmodule Explorer.Chain do
     |> Repo.paginate(pagination)
   end
 
-  defp after_hash(query, options) do
-    case Keyword.fetch(options, :after_hash) do
-      {:ok, hash} ->
-        from(
-          transaction in query,
-          join: hash_transaction in Transaction,
-          on: hash_transaction.hash == ^hash,
-          where:
-            transaction.block_number > hash_transaction.block_number or
-              (transaction.block_number == hash_transaction.block_number and transaction.index > hash_transaction.index)
-        )
-
-      :error ->
-        query
-    end
-  end
-
   @spec changes_list(params :: map, [{:for, module}]) :: {:ok, changes :: map} | {:error, [Changeset.t()]}
   defp changes_list(params, named_arguments) when is_list(named_arguments) do
     ecto_schema_module = Keyword.fetch!(named_arguments, :for)
@@ -1911,6 +1855,19 @@ defmodule Explorer.Chain do
     end)
   end
 
+  defp page_transaction(query, nil), do: query
+
+  defp page_transaction(query, %PagingOptions{key: nil}), do: query
+
+  defp page_transaction(query, %PagingOptions{key: {block_number, index}}) do
+    query
+    |> where(
+      [transaction],
+      transaction.block_number < ^block_number or
+        (transaction.block_number == ^block_number and transaction.index < ^index)
+    )
+  end
+
   defp reverse_chronologically(query) do
     from(q in query, order_by: [desc: q.inserted_at, desc: q.hash])
   end
diff --git a/apps/explorer/lib/explorer/chain/transaction.ex b/apps/explorer/lib/explorer/chain/transaction.ex
index dd789b00cc..98185971ce 100644
--- a/apps/explorer/lib/explorer/chain/transaction.ex
+++ b/apps/explorer/lib/explorer/chain/transaction.ex
@@ -52,6 +52,11 @@ defmodule Explorer.Chain.Transaction do
   """
   @type standard_v :: 0..3
 
+  @typedoc """
+    The index of the transaction in its block.
+  """
+  @type transaction_index :: non_neg_integer()
+
   @typedoc """
   `t:standard_v/0` + `27`
 
@@ -114,7 +119,7 @@ defmodule Explorer.Chain.Transaction do
           gas_price: wei_per_gas,
           gas_used: Gas.t() | nil,
           hash: Hash.t(),
-          index: non_neg_integer() | nil,
+          index: transaction_index | nil,
           input: Data.t(),
           internal_transactions: %Ecto.Association.NotLoaded{} | [InternalTransaction.t()],
           internal_transactions_indexed_at: DateTime.t(),
diff --git a/apps/explorer/lib/explorer/paging_options.ex b/apps/explorer/lib/explorer/paging_options.ex
new file mode 100644
index 0000000000..1bac2dc71a
--- /dev/null
+++ b/apps/explorer/lib/explorer/paging_options.ex
@@ -0,0 +1,13 @@
+defmodule Explorer.PagingOptions do
+  @moduledoc """
+  Defines paging options for paging by a stable key such as a timestamp or block
+  number and index.
+  """
+
+  @type t :: %__MODULE__{key: key, page_size: page_size}
+
+  @typep key :: any()
+  @typep page_size :: non_neg_integer()
+
+  defstruct [:key, :page_size]
+end
diff --git a/apps/explorer/test/explorer/chain_test.exs b/apps/explorer/test/explorer/chain_test.exs
index 7b7a31b5dd..d2a5953928 100644
--- a/apps/explorer/test/explorer/chain_test.exs
+++ b/apps/explorer/test/explorer/chain_test.exs
@@ -861,4 +861,15 @@ defmodule Explorer.ChainTest do
       assert block_reward.reward == Chain.block_reward(block)
     end
   end
+
+  describe "recent_collated_transactions/1" do
+    test "with no collated transactions it returns an empty list" do
+      assert [] == Explorer.Chain.recent_collated_transactions()
+    end
+
+    test "it excludes pending transactions" do
+      insert(:transaction)
+      assert [] == Explorer.Chain.recent_collated_transactions()
+    end
+  end
 end
diff --git a/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex b/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex
index 27dd119498..684703e036 100644
--- a/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex
+++ b/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex
@@ -1,14 +1,15 @@
 defmodule ExplorerWeb.TransactionController do
   use ExplorerWeb, :controller
 
-  alias Explorer.Chain
+  alias Explorer.{Chain, PagingOptions}
 
   def index(conn, params) do
-    with %{"last_seen_collated_hash" => last_seen_collated_hash_string} <- params,
-         {:ok, last_seen_collated_hash} <- Chain.string_to_transaction_hash(last_seen_collated_hash_string) do
-      do_index(conn, after_hash: last_seen_collated_hash)
-    else
-      _ -> do_index(conn)
+    case params do
+      %{"block_number" => block_number, "index" => index} ->
+        do_index(conn, paging_options: %PagingOptions{key: {block_number, index}, page_size: 50})
+
+      _ ->
+        do_index(conn)
     end
   end
 
@@ -16,7 +17,7 @@ defmodule ExplorerWeb.TransactionController do
     redirect(conn, to: transaction_internal_transaction_path(conn, :index, locale, id))
   end
 
-  defp do_index(conn, options \\ []) when is_list(options) do
+  defp do_index(conn, options \\ [paging_options: %PagingOptions{page_size: 50}]) when is_list(options) do
     full_options =
       Keyword.merge(
         [
@@ -30,21 +31,21 @@ defmodule ExplorerWeb.TransactionController do
       )
 
     transactions = Chain.recent_collated_transactions(full_options)
-    last_seen_collated_hash = last_seen_collated_hash(transactions)
     transaction_count = Chain.transaction_count()
 
     render(
       conn,
       "index.html",
-      last_seen_collated_hash: last_seen_collated_hash,
+      earliest: earliest(transactions),
       transaction_count: transaction_count,
       transactions: transactions
     )
   end
 
-  defp last_seen_collated_hash([]), do: nil
+  defp earliest([]), do: nil
 
-  defp last_seen_collated_hash(transactions) do
-    List.last(transactions).hash
+  defp earliest(transactions) do
+    last = List.last(transactions)
+    %{block_number: last.block_number, index: last.index}
   end
 end
diff --git a/apps/explorer_web/lib/explorer_web/templates/transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/transaction/index.html.eex
index e512042e3d..fa4cebb868 100644
--- a/apps/explorer_web/lib/explorer_web/templates/transaction/index.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/transaction/index.html.eex
@@ -50,13 +50,13 @@
               </td>
               <td>
                 <%= link(
-                      transaction.block,
+                      transaction.block_number,
                       class: "transactions__link",
                       to: block_path(@conn, :show, @conn.assigns.locale, transaction.block)
                     ) %>
               </td>
               <td>
-                <%= transaction.block.timestamp |> Timex.from_now %>
+                <%= transaction.block.timestamp %>
               </td>
               <td>
                 <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.from_address %>
@@ -73,16 +73,16 @@
       </table>
     </div>
   </div>
-  <%= if @last_seen_collated_hash do %>
+  <%= if @earliest do %>
     <%= link(
-          gettext("Next Page"),
-          class: "button button--secondary button--sm u-float-right mt-3",
-          to: transaction_path(
-            @conn,
-            :index,
-            @conn.assigns.locale,
-            %{"last_seen_collated_hash" => to_string(@last_seen_collated_hash)}
-          )
-        ) %>
+      gettext("Older"),
+      class: "button button--secondary button--sm u-float-right mt-3",
+      to: transaction_path(
+        @conn,
+        :index,
+        @conn.assigns.locale,
+        %{"block_number" => @earliest.block_number, "index" => @earliest.index}
+      )
+    ) %>
   <% end %>
 </section>
diff --git a/apps/explorer_web/test/explorer_web/controllers/transaction_controller_test.exs b/apps/explorer_web/test/explorer_web/controllers/transaction_controller_test.exs
index 944105c9bc..fa94e086e8 100644
--- a/apps/explorer_web/test/explorer_web/controllers/transaction_controller_test.exs
+++ b/apps/explorer_web/test/explorer_web/controllers/transaction_controller_test.exs
@@ -1,10 +1,11 @@
 defmodule ExplorerWeb.TransactionControllerTest do
   use ExplorerWeb.ConnCase
+  alias Explorer.Chain.Transaction
 
   import ExplorerWeb.Router.Helpers, only: [transaction_path: 4, transaction_internal_transaction_path: 4]
 
   describe "GET index/2" do
-    test "returns a transaction with a receipt", %{conn: conn} do
+    test "returns a collated transactions", %{conn: conn} do
       transaction =
         :transaction
         |> insert()
@@ -22,43 +23,47 @@ defmodule ExplorerWeb.TransactionControllerTest do
 
       conn = get(conn, "/en/transactions")
 
-      assert length(conn.assigns.transactions) == 1
+      assert conn.assigns.transaction_count == 1
     end
 
-    test "returns no pending transactions", %{conn: conn} do
-      insert(:transaction)
-
-      conn = get(conn, "/en/transactions")
-
-      assert conn.assigns.transactions == []
-    end
+    test "excludes pending transactions", %{conn: conn} do
+      %Transaction{hash: hash} =
+        :transaction
+        |> insert()
+        |> with_block()
 
-    test "only returns transactions that have a receipt", %{conn: conn} do
       insert(:transaction)
 
       conn = get(conn, "/en/transactions")
 
-      assert length(conn.assigns.transactions) == 0
+      assert [%Transaction{hash: ^hash}] = conn.assigns.transactions
     end
 
-    test "paginates transactions using the last seen transaction", %{conn: conn} do
-      transaction =
+    test "returns next page of results based on last seen transaction", %{conn: conn} do
+      second_page_hashes =
+        50
+        |> insert_list(:transaction)
+        |> with_block()
+        |> Enum.map(& &1.hash)
+
+      %Transaction{block_number: block_number, index: index} =
         :transaction
         |> insert()
         |> with_block()
 
-      conn =
-        get(
-          conn,
-          "/en/transactions",
-          last_seen_collated_hash: to_string(transaction.hash)
-        )
+      conn = get(conn, "/en/transactions", %{"block_number" => block_number, "index" => index})
 
-      assert conn.assigns.transactions == []
+      actual_hashes =
+        conn.assigns.transactions
+        |> Enum.map(& &1.hash)
+        |> Enum.reverse()
+
+      assert second_page_hashes == actual_hashes
     end
 
     test "sends back the number of transactions", %{conn: conn} do
       insert(:transaction)
+      |> with_block()
 
       conn = get(conn, "/en/transactions")
 

From a66e2b6e8384a234ffc728e33de885c067a087b0 Mon Sep 17 00:00:00 2001
From: Tim Mecklem <timothy@mecklem.com>
Date: Tue, 5 Jun 2018 15:16:20 -0400
Subject: [PATCH 3/6] Remove joins to address table

Co-authored-by: Stamates <stamates@hotmail.com>
---
 .../explorer_web/controllers/transaction_controller.ex |  4 +---
 .../lib/explorer_web/templates/address/_link.html.eex  | 10 +++++-----
 .../address_internal_transaction/index.html.eex        |  4 ++--
 .../templates/address_transaction/index.html.eex       |  4 ++--
 .../templates/block_transaction/index.html.eex         |  4 ++--
 .../lib/explorer_web/templates/chain/_blocks.html.eex  |  2 +-
 .../templates/chain/_transactions.html.eex             |  4 ++--
 .../templates/pending_transaction/index.html.eex       |  4 ++--
 .../explorer_web/templates/transaction/index.html.eex  |  4 ++--
 .../transaction_internal_transaction/index.html.eex    |  4 ++--
 .../lib/explorer_web/views/address_view.ex             |  3 ++-
 11 files changed, 23 insertions(+), 24 deletions(-)

diff --git a/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex b/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex
index 684703e036..e262d55711 100644
--- a/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex
+++ b/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex
@@ -22,9 +22,7 @@ defmodule ExplorerWeb.TransactionController do
       Keyword.merge(
         [
           necessity_by_association: %{
-            block: :required,
-            from_address: :optional,
-            to_address: :optional
+            block: :required
           }
         ],
         options
diff --git a/apps/explorer_web/lib/explorer_web/templates/address/_link.html.eex b/apps/explorer_web/lib/explorer_web/templates/address/_link.html.eex
index d82944a646..96a579f41a 100644
--- a/apps/explorer_web/lib/explorer_web/templates/address/_link.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/address/_link.html.eex
@@ -1,14 +1,14 @@
 <div class="address-link">
-<%= if @address do %>
-  <%= link to: address_path(@conn, :show, @conn.assigns.locale, @address),
+<%= if @address_hash do %>
+  <%= link to: address_path(@conn, :show, @conn.assigns.locale, @address_hash),
       "data-toggle": "tooltip",
       "data-placement": "top",
       class: "address-link__font",
-      title: @address do %>
+      title: @address_hash do %>
         <i class="address-link__type fas fa-address-card"></i>
-    <%= @address |> hash |> String.slice(0..3) %><i class="fas fa-ellipsis-v address-link__seperator"></i><%= @address |> hash |> String.slice(-4..-1) %>
+    <%= @address_hash |> hash() |> String.slice(0..3) %><i class="fas fa-ellipsis-v address-link__seperator"></i><%= @address_hash |> hash() |> String.slice(-4..-1) %>
 <% end %>
-<button class="address-link__copy-button" data-clipboard-text="<%= @address %>" aria-label="copy address">
+<button class="address-link__copy-button" data-clipboard-text="<%= @address_hash %>" aria-label="copy address">
   <i class="fa fa-copy"></i>
 </button>
 <% end %>
diff --git a/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex
index af48cf81a1..41c16e7d0a 100644
--- a/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/address_internal_transaction/index.html.eex
@@ -96,10 +96,10 @@
                   </td>
                   <td><%= ExplorerWeb.BlockView.age(internal_transaction.transaction.block) %></td>
                   <td>
-                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: internal_transaction.from_address %>
+                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: internal_transaction.from_address_hash %>
                   </td>
                   <td>
-                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: internal_transaction.to_address %>
+                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: internal_transaction.to_address_hash %>
                   </td>
                   <td><%= ExplorerWeb.TransactionView.value(internal_transaction, include_label: false) %></td>
                 </tr>
diff --git a/apps/explorer_web/lib/explorer_web/templates/address_transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/address_transaction/index.html.eex
index 8169efebf8..a5e510bd5f 100644
--- a/apps/explorer_web/lib/explorer_web/templates/address_transaction/index.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/address_transaction/index.html.eex
@@ -103,11 +103,11 @@
                 </td>
                 <td><%= transaction.block.timestamp |> Timex.from_now %></td>
                 <td class="address-cell">
-                  <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.from_address %>
+                  <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.from_address_hash %>
                 </td>
                 <td class="u-text-center"><i class="fas fa-arrow-circle-right"></i></td>
                 <td>
-                  <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.to_address %>
+                  <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.to_address_hash %>
                 </td>
                 <td><%= ExplorerWeb.TransactionView.value(transaction, include_label: false) %></td>
                 <td><%= ExplorerWeb.TransactionView.formatted_fee(transaction, denomination: :ether) %></td>
diff --git a/apps/explorer_web/lib/explorer_web/templates/block_transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/block_transaction/index.html.eex
index b0cefd869e..5a8b6e1e54 100644
--- a/apps/explorer_web/lib/explorer_web/templates/block_transaction/index.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/block_transaction/index.html.eex
@@ -164,11 +164,11 @@
                     <%= transaction.block.timestamp |> Timex.from_now %>
                   </td>
                   <td class="address-cell">
-                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.from_address %>
+                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.from_address_hash %>
                   </td>
                   <td class="u-text-center"><i class="fas fa-arrow-circle-right"></i></td>
                   <td>
-                      <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.to_address %>
+                      <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.to_address_hash %>
                   </td>
                   <td>
                     <%= ExplorerWeb.TransactionView.value(transaction) %>
diff --git a/apps/explorer_web/lib/explorer_web/templates/chain/_blocks.html.eex b/apps/explorer_web/lib/explorer_web/templates/chain/_blocks.html.eex
index 4963d97113..4e132eef91 100644
--- a/apps/explorer_web/lib/explorer_web/templates/chain/_blocks.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/chain/_blocks.html.eex
@@ -21,7 +21,7 @@
           <td><%= block.transactions |> Enum.count %></td>
           <td><%= block.gas_used |> Cldr.Number.to_string! %></td>
           <td>
-            <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: block.miner %>
+            <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: block.miner_hash %>
           </td>
         </tr>
         <% end %>
diff --git a/apps/explorer_web/lib/explorer_web/templates/chain/_transactions.html.eex b/apps/explorer_web/lib/explorer_web/templates/chain/_transactions.html.eex
index ed4d1bff71..09423bf7d1 100644
--- a/apps/explorer_web/lib/explorer_web/templates/chain/_transactions.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/chain/_transactions.html.eex
@@ -17,10 +17,10 @@
             <%= render ExplorerWeb.TransactionView, "_link.html", conn: @conn, transaction: transaction %>
           </td>
           <td>
-            <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.from_address %>
+            <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.from_address_hash %>
           </td>
           <td>
-            <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.to_address %>
+            <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.to_address_hash %>
           </td>
           <td><%= ExplorerWeb.TransactionView.value(transaction, include_label: false) %> </td>
           <td><%= transaction.block.timestamp |> Timex.from_now() %></td>
diff --git a/apps/explorer_web/lib/explorer_web/templates/pending_transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/pending_transaction/index.html.eex
index e3ef865c36..650c41ace2 100644
--- a/apps/explorer_web/lib/explorer_web/templates/pending_transaction/index.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/pending_transaction/index.html.eex
@@ -50,10 +50,10 @@
               </td>
               <td><%= last_seen(transaction) %></td>
               <td>
-                <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.from_address %>
+                <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.from_address_hash %>
               </td>
               <td>
-                <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.to_address %>
+                <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.to_address_hash %>
               </td>
               <td>
               <%= ExplorerWeb.TransactionView.value(transaction, include_label: false) %>
diff --git a/apps/explorer_web/lib/explorer_web/templates/transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/transaction/index.html.eex
index fa4cebb868..44ea0a3436 100644
--- a/apps/explorer_web/lib/explorer_web/templates/transaction/index.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/transaction/index.html.eex
@@ -59,10 +59,10 @@
                 <%= transaction.block.timestamp %>
               </td>
               <td>
-                <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.from_address %>
+                <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.from_address_hash %>
               </td>
               <td>
-                <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: transaction.to_address %>
+                <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: transaction.to_address_hash %>
               </td>
               <td>
                 <%= ExplorerWeb.TransactionView.value(transaction, include_label: false) %>
diff --git a/apps/explorer_web/lib/explorer_web/templates/transaction_internal_transaction/index.html.eex b/apps/explorer_web/lib/explorer_web/templates/transaction_internal_transaction/index.html.eex
index a011aa9b84..ad71b65430 100644
--- a/apps/explorer_web/lib/explorer_web/templates/transaction_internal_transaction/index.html.eex
+++ b/apps/explorer_web/lib/explorer_web/templates/transaction_internal_transaction/index.html.eex
@@ -38,10 +38,10 @@
                 <tr>
                   <td><%= internal_transaction.call_type %></td>
                   <td>
-                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: internal_transaction.from_address %>
+                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: internal_transaction.from_address_hash %>
                   </td>
                   <td>
-                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address: internal_transaction.to_address %>
+                    <%= render ExplorerWeb.AddressView, "_link.html", conn: @conn, address_hash: internal_transaction.to_address_hash %>
                   </td>
                   <td><%= ExplorerWeb.TransactionView.value(internal_transaction, include_label: false) %></td>
                   <td><%= ExplorerWeb.TransactionView.gas(internal_transaction) %></td>
diff --git a/apps/explorer_web/lib/explorer_web/views/address_view.ex b/apps/explorer_web/lib/explorer_web/views/address_view.ex
index fe130f9c29..2c75f3a403 100644
--- a/apps/explorer_web/lib/explorer_web/views/address_view.ex
+++ b/apps/explorer_web/lib/explorer_web/views/address_view.ex
@@ -2,6 +2,7 @@ defmodule ExplorerWeb.AddressView do
   use ExplorerWeb, :view
 
   alias Explorer.Chain.{Address, Wei}
+  alias Explorer.Chain.Hash
   alias Explorer.ExchangeRates.Token
   alias ExplorerWeb.ExchangeRates.USD
 
@@ -41,7 +42,7 @@ defmodule ExplorerWeb.AddressView do
     end
   end
 
-  def hash(%Address{hash: hash}) do
+  def hash(%Hash{} = hash) do
     to_string(hash)
   end
 

From 801074420e44340d54b1ee8b312d370350dc9b49 Mon Sep 17 00:00:00 2001
From: Tim Mecklem <timothy@mecklem.com>
Date: Tue, 5 Jun 2018 15:19:54 -0400
Subject: [PATCH 4/6] gettext

Co-authored-by: Stamates <stamates@hotmail.com>
---
 apps/explorer_web/priv/gettext/default.pot               | 9 ++++++---
 apps/explorer_web/priv/gettext/en/LC_MESSAGES/default.po | 9 ++++++---
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/apps/explorer_web/priv/gettext/default.pot b/apps/explorer_web/priv/gettext/default.pot
index ed6aa5b175..a3cbcd24b0 100644
--- a/apps/explorer_web/priv/gettext/default.pot
+++ b/apps/explorer_web/priv/gettext/default.pot
@@ -155,7 +155,7 @@ msgstr ""
 
 #: lib/explorer_web/templates/address/overview.html.eex:11
 #: lib/explorer_web/templates/transaction_log/index.html.eex:29
-#: lib/explorer_web/views/address_view.ex:17
+#: lib/explorer_web/views/address_view.ex:18
 msgid "Address"
 msgstr ""
 
@@ -302,7 +302,6 @@ msgid "TPM"
 msgstr ""
 
 #: lib/explorer_web/templates/pending_transaction/index.html.eex:69
-#: lib/explorer_web/templates/transaction/index.html.eex:78
 msgid "Next Page"
 msgstr ""
 
@@ -497,7 +496,7 @@ msgstr ""
 msgid "Contract"
 msgstr ""
 
-#: lib/explorer_web/views/address_view.ex:15
+#: lib/explorer_web/views/address_view.ex:16
 msgid "Contract Address"
 msgstr ""
 
@@ -508,3 +507,7 @@ msgstr ""
 #: lib/explorer_web/templates/block_transaction/index.html.eex:181
 msgid "There are no Transactions"
 msgstr ""
+
+#: lib/explorer_web/templates/transaction/index.html.eex:78
+msgid "Older"
+msgstr ""
diff --git a/apps/explorer_web/priv/gettext/en/LC_MESSAGES/default.po b/apps/explorer_web/priv/gettext/en/LC_MESSAGES/default.po
index 5e7a1ea3b9..c664eec8e8 100644
--- a/apps/explorer_web/priv/gettext/en/LC_MESSAGES/default.po
+++ b/apps/explorer_web/priv/gettext/en/LC_MESSAGES/default.po
@@ -167,7 +167,7 @@ msgstr "%{count} transactions in this block"
 
 #: lib/explorer_web/templates/address/overview.html.eex:11
 #: lib/explorer_web/templates/transaction_log/index.html.eex:29
-#: lib/explorer_web/views/address_view.ex:17
+#: lib/explorer_web/views/address_view.ex:18
 msgid "Address"
 msgstr "Address"
 
@@ -314,7 +314,6 @@ msgid "TPM"
 msgstr ""
 
 #: lib/explorer_web/templates/pending_transaction/index.html.eex:69
-#: lib/explorer_web/templates/transaction/index.html.eex:78
 msgid "Next Page"
 msgstr ""
 
@@ -509,7 +508,7 @@ msgstr ""
 msgid "Contract"
 msgstr ""
 
-#: lib/explorer_web/views/address_view.ex:15
+#: lib/explorer_web/views/address_view.ex:16
 msgid "Contract Address"
 msgstr ""
 
@@ -520,3 +519,7 @@ msgstr ""
 #: lib/explorer_web/templates/block_transaction/index.html.eex:181
 msgid "There are no Transactions"
 msgstr ""
+
+#: lib/explorer_web/templates/transaction/index.html.eex:78
+msgid "Older"
+msgstr ""

From f96ea1093c710c3fb004daa695f3bba30fb15812 Mon Sep 17 00:00:00 2001
From: Tim Mecklem <timothy@mecklem.com>
Date: Tue, 5 Jun 2018 18:00:05 -0400
Subject: [PATCH 5/6] Fix typespecs, handle default keyword list options
 cleanly, check inputs

Co-authored-by: Stamates <stamates@hotmail.com>
---
 apps/explorer/lib/explorer/chain.ex           |  2 +-
 .../lib/explorer/chain/transaction.ex         |  2 +-
 .../lib/explorer_web/controller.ex            |  7 +++++++
 .../controllers/transaction_controller.ex     | 21 ++++++++++++-------
 .../lib/explorer_web/views/error_view.ex      |  4 ++++
 .../transaction_controller_test.exs           | 16 +++++++++++++-
 6 files changed, 42 insertions(+), 10 deletions(-)

diff --git a/apps/explorer/lib/explorer/chain.ex b/apps/explorer/lib/explorer/chain.ex
index 8cfc469f3d..5bf2708789 100644
--- a/apps/explorer/lib/explorer/chain.ex
+++ b/apps/explorer/lib/explorer/chain.ex
@@ -50,7 +50,7 @@ defmodule Explorer.Chain do
   @typep inserted_after_option :: {:inserted_after, DateTime.t()}
   @typep necessity_by_association_option :: {:necessity_by_association, necessity_by_association}
   @typep pagination_option :: {:pagination, pagination}
-  @typep paging_options :: PagingOptions.t()
+  @typep paging_options :: {:paging_options, PagingOptions.t()}
   @typep params_option :: {:params, map()}
   @typep timeout_option :: {:timeout, timeout}
   @typep timestamps :: %{inserted_at: DateTime.t(), updated_at: DateTime.t()}
diff --git a/apps/explorer/lib/explorer/chain/transaction.ex b/apps/explorer/lib/explorer/chain/transaction.ex
index 98185971ce..a751c827df 100644
--- a/apps/explorer/lib/explorer/chain/transaction.ex
+++ b/apps/explorer/lib/explorer/chain/transaction.ex
@@ -53,7 +53,7 @@ defmodule Explorer.Chain.Transaction do
   @type standard_v :: 0..3
 
   @typedoc """
-    The index of the transaction in its block.
+  The index of the transaction in its block.
   """
   @type transaction_index :: non_neg_integer()
 
diff --git a/apps/explorer_web/lib/explorer_web/controller.ex b/apps/explorer_web/lib/explorer_web/controller.ex
index d2839afa80..41290de3fa 100644
--- a/apps/explorer_web/lib/explorer_web/controller.ex
+++ b/apps/explorer_web/lib/explorer_web/controller.ex
@@ -15,4 +15,11 @@ defmodule ExplorerWeb.Controller do
     |> put_view(ExplorerWeb.ErrorView)
     |> render("404.html")
   end
+
+  def unprocessable_entity(conn) do
+    conn
+    |> put_status(:unprocessable_entity)
+    |> put_view(ExplorerWeb.ErrorView)
+    |> render("422.html")
+  end
 end
diff --git a/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex b/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex
index e262d55711..1a2e5ce4d6 100644
--- a/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex
+++ b/apps/explorer_web/lib/explorer_web/controllers/transaction_controller.ex
@@ -3,27 +3,34 @@ defmodule ExplorerWeb.TransactionController do
 
   alias Explorer.{Chain, PagingOptions}
 
-  def index(conn, params) do
-    case params do
-      %{"block_number" => block_number, "index" => index} ->
-        do_index(conn, paging_options: %PagingOptions{key: {block_number, index}, page_size: 50})
+  @default_paging_options %PagingOptions{page_size: 50}
 
+  def index(conn, %{"block_number" => block_number_string, "index" => index_string}) do
+    with {block_number, ""} <- Integer.parse(block_number_string),
+         {index, ""} <- Integer.parse(index_string) do
+      do_index(conn, paging_options: %{@default_paging_options | key: {block_number, index}})
+    else
       _ ->
-        do_index(conn)
+        unprocessable_entity(conn)
     end
   end
 
+  def index(conn, _params) do
+    do_index(conn)
+  end
+
   def show(conn, %{"id" => id, "locale" => locale}) do
     redirect(conn, to: transaction_internal_transaction_path(conn, :index, locale, id))
   end
 
-  defp do_index(conn, options \\ [paging_options: %PagingOptions{page_size: 50}]) when is_list(options) do
+  defp do_index(conn, options \\ []) when is_list(options) do
     full_options =
       Keyword.merge(
         [
           necessity_by_association: %{
             block: :required
-          }
+          },
+          paging_options: @default_paging_options
         ],
         options
       )
diff --git a/apps/explorer_web/lib/explorer_web/views/error_view.ex b/apps/explorer_web/lib/explorer_web/views/error_view.ex
index 1c9eb50a7d..afc04c06d6 100644
--- a/apps/explorer_web/lib/explorer_web/views/error_view.ex
+++ b/apps/explorer_web/lib/explorer_web/views/error_view.ex
@@ -5,6 +5,10 @@ defmodule ExplorerWeb.ErrorView do
     "Page not found"
   end
 
+  def render("422.html", _assigns) do
+    "Unprocessible entity"
+  end
+
   def render("500.html", _assigns) do
     "Internal server error"
   end
diff --git a/apps/explorer_web/test/explorer_web/controllers/transaction_controller_test.exs b/apps/explorer_web/test/explorer_web/controllers/transaction_controller_test.exs
index fa94e086e8..ae24ae3a28 100644
--- a/apps/explorer_web/test/explorer_web/controllers/transaction_controller_test.exs
+++ b/apps/explorer_web/test/explorer_web/controllers/transaction_controller_test.exs
@@ -51,7 +51,11 @@ defmodule ExplorerWeb.TransactionControllerTest do
         |> insert()
         |> with_block()
 
-      conn = get(conn, "/en/transactions", %{"block_number" => block_number, "index" => index})
+      conn =
+        get(conn, "/en/transactions", %{
+          "block_number" => Integer.to_string(block_number),
+          "index" => Integer.to_string(index)
+        })
 
       actual_hashes =
         conn.assigns.transactions
@@ -61,6 +65,16 @@ defmodule ExplorerWeb.TransactionControllerTest do
       assert second_page_hashes == actual_hashes
     end
 
+    test "guards against bad block_number input", %{conn: conn} do
+      conn = get(conn, "/en/transactions", %{"block_number" => "foo", "index" => "2"})
+      assert html_response(conn, 422)
+    end
+
+    test "guards against bad index input", %{conn: conn} do
+      conn = get(conn, "/en/transactions", %{"block_number" => "2", "index" => "bar"})
+      assert html_response(conn, 422)
+    end
+
     test "sends back the number of transactions", %{conn: conn} do
       insert(:transaction)
       |> with_block()

From cda5fb2afdd1e4fef3005abb4edfa69283e95141 Mon Sep 17 00:00:00 2001
From: Stamates <Stamates@users.noreply.github.com>
Date: Wed, 6 Jun 2018 09:46:15 -0400
Subject: [PATCH 6/6] Remove unused nil function head and spelling correction
 on 422 error

---
 apps/explorer/lib/explorer/chain.ex                           | 2 --
 apps/explorer_web/lib/explorer_web/views/error_view.ex        | 2 +-
 apps/explorer_web/test/explorer_web/views/error_view_test.exs | 4 ++++
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/apps/explorer/lib/explorer/chain.ex b/apps/explorer/lib/explorer/chain.ex
index 5bf2708789..e4dfd0e51a 100644
--- a/apps/explorer/lib/explorer/chain.ex
+++ b/apps/explorer/lib/explorer/chain.ex
@@ -1855,8 +1855,6 @@ defmodule Explorer.Chain do
     end)
   end
 
-  defp page_transaction(query, nil), do: query
-
   defp page_transaction(query, %PagingOptions{key: nil}), do: query
 
   defp page_transaction(query, %PagingOptions{key: {block_number, index}}) do
diff --git a/apps/explorer_web/lib/explorer_web/views/error_view.ex b/apps/explorer_web/lib/explorer_web/views/error_view.ex
index afc04c06d6..6c8b8c00af 100644
--- a/apps/explorer_web/lib/explorer_web/views/error_view.ex
+++ b/apps/explorer_web/lib/explorer_web/views/error_view.ex
@@ -6,7 +6,7 @@ defmodule ExplorerWeb.ErrorView do
   end
 
   def render("422.html", _assigns) do
-    "Unprocessible entity"
+    "Unprocessable entity"
   end
 
   def render("500.html", _assigns) do
diff --git a/apps/explorer_web/test/explorer_web/views/error_view_test.exs b/apps/explorer_web/test/explorer_web/views/error_view_test.exs
index 5cec490214..95a86e8007 100644
--- a/apps/explorer_web/test/explorer_web/views/error_view_test.exs
+++ b/apps/explorer_web/test/explorer_web/views/error_view_test.exs
@@ -8,6 +8,10 @@ defmodule ExplorerWeb.ErrorViewTest do
     assert render_to_string(ExplorerWeb.ErrorView, "404.html", []) == "Page not found"
   end
 
+  test "renders 422.html" do
+    assert render_to_string(ExplorerWeb.ErrorView, "422.html", []) == "Unprocessable entity"
+  end
+
   test "render 500.html" do
     assert render_to_string(ExplorerWeb.ErrorView, "500.html", []) == "Internal server error"
   end