246 Commits (4240af044d0a7d6462811e321ea4cf6ee81f90bf)

Author	SHA1	Message	Date
zachdaniel	45bf31c2dc	address view/test inconsistencies	6 years ago
zachdaniel	c68d59a011	feat: render addresses according to eip-55 ... For more information, see: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md#specification	6 years ago
Luke Imhoff	4556ee2c01	Fix tests of transactions on non-consensus blocks ... Tests for BlockTransactionController mistakenly simulated transactions on non-consensus blocks by making the `transaction.block` `consensus` `false`, but this is unrealistic - the importing only sets the consensus block to `transaction.block` and non-consensus blocks show up as `transaction.transaction_forks` `transaction_fork.uncle`. To prevent this from happening again, `Explorer.Factory.with_block` now checks the `block` has `consensus: true`. With this setup fixed, the tests needed to be updated to show that *no* _transactions_ would be shown for non-consensus blocks (because there are only transactions forks) and whether the non-consensus blocks showed as "above tip" only had to do with the number being above the consensus number and not to do with it being non-consensus. Floki selectors are used to improve error messages when messages are unexpected.	6 years ago
Luke Imhoff	57808d6b23	Separate usage of max consensus block number and block height ... The block height should be used when calculating confirmations while the max consensus block number when a block number is needed and you want to tell if the chain is empty or only the genesis block is available. The block height is 0 if there are no blocks or if there is only the genesis block.	6 years ago
Luke Imhoff	cb7bc384e8	Calculate indexed ratio in SQL ... By calculating the indexed ratio in SQL, we only have 1 round trip to the database instead of 1 to get the max and 1 to get the min.	6 years ago
Luke Imhoff	41d4aaabf5	Fix test to expose #1277	6 years ago
Luke Imhoff	a571a4edb3	Don't fetch or import internal transactions for value transfers ... Fixes #1287 For simple value transfers, the UI already doesn't show the redundant single internal transaction, but we can speed up the indexing by determine the internal transactions aren't needed when the transacion is a successful simple value transfer as determined by status being `:ok` and the input being empty (`0x`).	6 years ago
Amanda Sposito	5fb1347bf4	Fix 'DBConnection.OwnershipError' in feature tests. ... * Add sandbox config to shared mode when test is async false.	6 years ago
Luke Imhoff	8ffbe6418d	Use COUNT(*) of current_token_balances to eliminate TokenHoldersCounter ... `TokenHolderCounter` was created 20 days before the current_token_balances table and wasn't redesigned to make use of `current_token_balances`. With `current_token_balances` in place, the problematic query over `token_balances` that necessitated `TokenHoldersCounter` can use `current_token_balances`. Using `current_token_balances` with `COUNT(*)` is when tested on eth60-test, the new query for `Explorer.Chain.count_token_holders_from_token_hash/1` still took 11 seconds. ``` sql> SELECT COUNT(*) FROM address_current_token_balances WHERE token_contract_address_hash = decode('f230b790e05390fc8295f4d3f60332c93bed42e2', 'hex') AND address_hash != decode('0000000000000000000000000000000000000000', 'hex') AND value > 0 [2019-01-02 08:04:26] 1 row retrieved starting from 1 in 11 s 554 ms (execution: 11 s 463 ms, fetching: 91 ms) ``` Using `EXPLAIN`, it should this was using a full sequential scan of table, so like in the other `COUNT(*)` optimizations PRs, I added an index to enable an index scan. Running the migration to add the index took only 1 minute on eth60-test: ``` 2019-01-02T08:40:16.220 application=ecto_sql [info] == Running 20190102141900 Explorer.Repo.Migrations.IndexCurrentTokenHolders.change/0 forward 2019-01-02T08:40:16.220 application=ecto_sql [info] create index address_current_token_balances_token_contract_address_hash_index 2019-01-02T08:41:13.746 application=ecto_sql [info] == Migrated 20190102141900 in 57.5s ``` After the migration ran, Index Scan was enabled and the query took only 837ms. ``` sql> SELECT COUNT(*) FROM address_current_token_balances WHERE token_contract_address_hash = decode('f230b790e05390fc8295f4d3f60332c93bed42e2', 'hex') AND address_hash != decode('0000000000000000000000000000000000000000', 'hex') AND value > 0 [2019-01-02 08:42:44] 1 row retrieved starting from 1 in 866 ms (execution: 837 ms, fetching: 29 ms) ```	6 years ago
Gustavo Santos Ferreira	ae7bd4aefc	make the market history chart load async	6 years ago
Gustavo Santos Ferreira	bc48b8ea23	new endpoint for the market chart data	6 years ago
Amanda Sposito	9cf7e8397e	Add async loading to block list in the home page.	6 years ago
William Sanches	32f24664f2	Add async load to home page transactions	6 years ago
fvictorio	616658adbf	Show token price in USD	6 years ago
William Sanches	dfc600b1c9	Add tests	6 years ago
William Sanches	33b06b228b	Refactor transaction tile identifier ... Now both transactions and emission rewards must be in the same list, so I changed the identifier to a more generic name to contemplate both of cases.	6 years ago
Amanda Sposito	bd58afff74	Add blocks indexed counter at BlockScoutWeb	6 years ago
Luke Imhoff	903d322553	Use index and COUNT(*) for address_to_validation_count ... BlockValidationCounter is not needed once the query is switched to `COUNT(*)` and an index is added for `blocks.miner_hash`. Creating the index on eth60-test took only 12 seconds. ``` 2018-12-21T08:32:46.375 application=ecto_sql [info] == Running 20181221143000 Explorer.Repo.Migrations.CreateBlocksMinerHashIndex.change/0 forward 2018-12-21T08:32:46.375 application=ecto_sql [info] create index blocks_miner_hash_index 2018-12-21T08:32:59.211 application=ecto_sql [info] == Migrated 20181221143000 in 12.8s ``` Before the index both `COUNT(*)` and `COUNT(hash)` (the old usage before 76fc8e0377 in 92f99cac22) take > 800ms, which would have a noticable impact on the UI. ``` sql> SELECT COUNT(*) FROM blocks WHERE blocks.miner_hash = ( SELECT blocks.miner_hash FROM blocks LIMIT 1 ) [2018-12-21 08:27:43] 1 row retrieved starting from 1 in 906 ms (execution: 889 ms, fetching: 17 ms) sql> SELECT COUNT(hash) FROM blocks WHERE blocks.miner_hash = ( SELECT blocks.miner_hash FROM blocks LIMIT 1 ) [2018-12-21 08:28:04] 1 row retrieved starting from 1 in 819 ms (execution: 811 ms, fetching: 8 ms) ``` After the index both queries benefited because `COUNT(hash)` was able to use Bitmap Index Scan, but `COUNT(*)` was much better using a normal Index Scan: ``` sql> SELECT COUNT(hash) FROM blocks WHERE blocks.miner_hash = ( SELECT blocks.miner_hash FROM blocks LIMIT 1 ) [2018-12-21 08:33:43] 1 row retrieved starting from 1 in 776 ms (execution: 768 ms, fetching: 8 ms) sql> SELECT COUNT(*) FROM blocks WHERE blocks.miner_hash = ( SELECT blocks.miner_hash FROM blocks LIMIT 1 ) [2018-12-21 08:33:55] 1 row retrieved starting from 1 in 130 ms (execution: 120 ms, fetching: 10 ms) ``` The `SELECT` to get a miner_hash takes 54ms alone, so the `COUNT(*)` takes ~70ms, but EXPLAINs take just as long so ~50ms is my latency to eth60-test, meaning the `SELECT COUNT(*)` takes about 20ms plus latency.	6 years ago
Luke Imhoff	f67241cfc0	Use COUNT(*) for count_token_transfers_from_token_hash ... By using `COUNT(*)` instead of `COUNT(column)`, Postgres optimizes the count to use the row count recorded in the index. The ETS counter appeared necessary because in 95de1ebcb0, `COUNT(id)` was being used (95de1ebcb0/apps/explorer/lib/explorer/chain/token_transfer.ex (L138)), which seems reasonable in Ecto as you need some column to count, but in Postgres, it is more efficient to count everything with `*` as it implies "count rows". `COUNT(column)` requires Postgres check if any of the values are `NULL` and it does not optimize the query even if the column is `NOT NULL` in most cases like when the `id` was used. Testing on eth60-test database, `COUNT(*)` took 62ms while `COUNT(column)` (in this case `amount` since the table no longer has `id) took 16s demonstrating the vast speed improvement of `*` counting. ``` sql> SELECT COUNT(*) FROM token_transfers WHERE token_contract_address_hash = ( SELECT token_contract_address_hash FROM token_transfers LIMIT 1) [2018-12-21 07:51:02] 1 row retrieved starting from 1 in 70 ms (execution: 62 ms, fetching: 8 ms) sql> SELECT COUNT(amount) FROM token_transfers WHERE token_contract_address_hash = ( SELECT token_contract_address_hash FROM token_transfers LIMIT 1) [2018-12-21 07:51:43] 1 row retrieved starting from 1 in 16 s 862 ms (execution: 16 s 855 ms, fetching: 7 ms) ```	6 years ago
Luke Imhoff	81179f9459	Use :timer functions to make timeout values clearer	6 years ago
Amanda Sposito	de3520667f	Add reward value of a block in the tile and overview section	6 years ago
William Sanches	c1e582e85c	Add better error messages	6 years ago
fvictorio	cd51e7cb29	Use address_current_token_balances in address tokens tab	6 years ago
Luke Imhoff	ea58dad12b	Update to Ecto 3.0	6 years ago
William Sanches	23bd2b0049	Rename block_rewards to emission_rewards	6 years ago
fvictorio	be36adbc8e	Improve token balances fetching for specific addresses	6 years ago
Felipe Renan	b18b491839	Fix blocks validated page to show all tabs ... * Add to blocks validated use the "address/_tabs.html" partial * Add to "address/_tabs.html" considers if block validated page is the current page * Add tests to ensure all behavior above.	6 years ago
fvictorio	6966f01097	Add coin balance history tab to address page	6 years ago
fvictorio	c9130df866	Use async load and simple pagination in blocks page	6 years ago
Gustavo Santos Ferreira	0a8a6d9ce9	fix the tests	6 years ago
Felipe Renan	f9ea258ad0	Refactor transactions page ... As we did in other pages, we removed the infinite scroll and make the first load async.	6 years ago
natlg	01e19cb13d	Fix test	6 years ago
natlg	b717371a4d	Add primary names to the top accounts page	6 years ago
Gustavo Santos Ferreira	501734797d	change the test file to exs	6 years ago
Sebastian Abondano	fa09f399d8	GraphQL API token_transfers query ... Why: * For GraphQL API users to be able to fetch token transfer events. RPC API users could use this instead of the `tokentx` RPC API action. Example usage: 1. ``` query ($token_contract_address_hash: AddressHash!, $first: Int!) { token_transfers(token_contract_address_hash: $token_contract_address_hash, first: $first) { edges { node { amount block_number log_index token_id from_address_hash to_address_hash token_contract_address_hash transaction_hash } } } } ``` 2. with pagination support via [Relay Cursor Connections](https://facebook.github.io/relay/graphql/connections.htm) ``` query ($token_contract_address_hash: AddressHash!, $first: Int!, $after: ID!) { token_transfers(token_contract_address_hash: $token_contract_address_hash, first: $first, after: $after) { page_info { has_next_page has_previous_page } edges { node { amount from_address_hash to_address_hash } cursor } } } ``` * Issue link: n/a This change addresses the need by: * Editing the node interface and node field in `BlockScoutWeb.Schema` to support token transfers. * Adding `token_transfers` connection field to root query object in `BlockScoutWeb.Schema` * Making `token_transfer` object types a node type and adding a few new fields to it, in `BlockScoutWeb.Schema.Types`. * Creating `BlockScoutWeb.Resolvers.TokenTransfer` with resolver functions for getting token transfers. * Adding `get_token_transfer/1` and `list_token_transfers_query/1` to `Explorer.GraphQL`. These two functions are used by the new resolver functions mentioned above. * Editing RPC API docs to reference the new GraphQL query field added in this commit.	6 years ago
Gustavo Santos Ferreira	bbe5f0ac72	remove skips ... these tests were being skiped because of problems with asyncload those problems were fixed with the update to use redux with the async	6 years ago
Lokraan	582345cfb7	Create tests for new dependency injection model.	6 years ago
Felipe Renan	87579dfd63	Fix controller tests	6 years ago
fvictorio	d147e94fee	Remove infinite scroll in address transactions page	6 years ago
Sebastian Abondano	24079bb741	GraphQL support to get internal transactions ... Why: * For GraphQL API users to be able to get internal transactions. RPC API users could use this instead of the `txlistinternal` RPC API action. Example usage: 1. ``` query ($hash: FullHash!, $first: Int!) { transaction(hash: $hash) { internal_transactions(first: $first) { edges { node { index value block_number transaction_index from_address_hash to_address_hash } } } } } ``` 2. with pagiantion support via [Relay Cursor Connections](https://facebook.github.io/relay/graphql/connections.htm) ``` query ($hash: AddressHash!, $first: Int!, $after: ID!) { transaction(hash: $hash) { internal_transactions(first: $first, after: $after) { page_info { has_next_page has_previous_page } edges { node { index transaction_hash } cursor } } } } ``` * Issue link: n/a This change addresses the need by: * Editing the node interface and node field in `BlockScoutWeb.Schema` to support internal transactions. * Adding `internal_transaction` object type to `BlockScoutWeb.Schema.Types`. * Adding an `internal_transaction` connection field to the `transaction` object type in `BlockScoutWeb.Schema.Types`. * Adding `:call_type` and `:type` enums to `BlockScoutWEb.Schema.Scalars`. Needed by `internal_transaction` GraphQL object type. * Creating `BlockScoutWeb.Resolvers.InternalTransaction` with resolver functions for getting internal transactions. * Adding `get_internal_transactions/1` and `transaction_to_internal_transactions_query/1` to `Explorer.GraphQL`. These are used by the new resolver functions mentioned above.	6 years ago
Felipe Renan	d4feeff7b1	Fix pagination on inventory tab at Token's page ... This code was removed and it shouldn't :(. Besides bringing this code back, I'm adding tests in the controller layer to make sure that it will not happen anymore.	6 years ago
Gustavo Santos Ferreira	0eb912a28f	new function to help print line numbers on the page	6 years ago
Gustavo Santos Ferreira	7ef0c400a7	adapt the tests for the async loading	6 years ago
William Sanches	d122f820b2	Add better tests	6 years ago
William Sanches	52da3f0f2b	Skip feature test for address token transfers page ... This test wasn't working realiably either in CI or locally. It would fail on cases it was supposed to work in CI and passing when it should fail on local environment.	6 years ago
William Sanches	e5d7fae2e3	Add JSON handle to address token transfer controller	6 years ago
Felipe Renan	da72f83b35	Refactor token transfers' pagination ... We changed the token transfer's pagination uses the block_number instead of the inserted_at. It will make the pagination consistent since the list is sorted by the block_number.	6 years ago
Gustavo Santos Ferreira	2fbfaa1994	testing the filters in controller tests instead of feature tests	6 years ago
Gustavo Santos Ferreira	51a8654fde	Skip tests that are unreliable and unstable ... those tests are giving off unstable results in the CI they don't pass at all but the error messages change every time while locally it passes and fails almost equally	6 years ago
Gustavo Santos Ferreira	833cc8aae8	make internal transactions load async	6 years ago