3019 Commits (df427d5c5183447137431ba99f6c3c063141ac42)

 

All Branches   

Search

Author	SHA1	Message	Date
Luke Imhoff	e5e32d693a	Merge pull request #1275 from poanetwork/counters-queries ... Counter the need for counter queries by using COUNT(*) and adding indexes	6 years ago
Luke Imhoff	903d322553	Use index and COUNT(*) for address_to_validation_count ... BlockValidationCounter is not needed once the query is switched to `COUNT(*)` and an index is added for `blocks.miner_hash`. Creating the index on eth60-test took only 12 seconds. ``` 2018-12-21T08:32:46.375 application=ecto_sql [info] == Running 20181221143000 Explorer.Repo.Migrations.CreateBlocksMinerHashIndex.change/0 forward 2018-12-21T08:32:46.375 application=ecto_sql [info] create index blocks_miner_hash_index 2018-12-21T08:32:59.211 application=ecto_sql [info] == Migrated 20181221143000 in 12.8s ``` Before the index both `COUNT(*)` and `COUNT(hash)` (the old usage before 76fc8e0377 in 92f99cac22) take > 800ms, which would have a noticable impact on the UI. ``` sql> SELECT COUNT(*) FROM blocks WHERE blocks.miner_hash = ( SELECT blocks.miner_hash FROM blocks LIMIT 1 ) [2018-12-21 08:27:43] 1 row retrieved starting from 1 in 906 ms (execution: 889 ms, fetching: 17 ms) sql> SELECT COUNT(hash) FROM blocks WHERE blocks.miner_hash = ( SELECT blocks.miner_hash FROM blocks LIMIT 1 ) [2018-12-21 08:28:04] 1 row retrieved starting from 1 in 819 ms (execution: 811 ms, fetching: 8 ms) ``` After the index both queries benefited because `COUNT(hash)` was able to use Bitmap Index Scan, but `COUNT(*)` was much better using a normal Index Scan: ``` sql> SELECT COUNT(hash) FROM blocks WHERE blocks.miner_hash = ( SELECT blocks.miner_hash FROM blocks LIMIT 1 ) [2018-12-21 08:33:43] 1 row retrieved starting from 1 in 776 ms (execution: 768 ms, fetching: 8 ms) sql> SELECT COUNT(*) FROM blocks WHERE blocks.miner_hash = ( SELECT blocks.miner_hash FROM blocks LIMIT 1 ) [2018-12-21 08:33:55] 1 row retrieved starting from 1 in 130 ms (execution: 120 ms, fetching: 10 ms) ``` The `SELECT` to get a miner_hash takes 54ms alone, so the `COUNT(*)` takes ~70ms, but EXPLAINs take just as long so ~50ms is my latency to eth60-test, meaning the `SELECT COUNT(*)` takes about 20ms plus latency.	6 years ago
Luke Imhoff	f67241cfc0	Use COUNT(*) for count_token_transfers_from_token_hash ... By using `COUNT(*)` instead of `COUNT(column)`, Postgres optimizes the count to use the row count recorded in the index. The ETS counter appeared necessary because in 95de1ebcb0, `COUNT(id)` was being used (95de1ebcb0/apps/explorer/lib/explorer/chain/token_transfer.ex (L138)), which seems reasonable in Ecto as you need some column to count, but in Postgres, it is more efficient to count everything with `*` as it implies "count rows". `COUNT(column)` requires Postgres check if any of the values are `NULL` and it does not optimize the query even if the column is `NOT NULL` in most cases like when the `id` was used. Testing on eth60-test database, `COUNT(*)` took 62ms while `COUNT(column)` (in this case `amount` since the table no longer has `id) took 16s demonstrating the vast speed improvement of `*` counting. ``` sql> SELECT COUNT(*) FROM token_transfers WHERE token_contract_address_hash = ( SELECT token_contract_address_hash FROM token_transfers LIMIT 1) [2018-12-21 07:51:02] 1 row retrieved starting from 1 in 70 ms (execution: 62 ms, fetching: 8 ms) sql> SELECT COUNT(amount) FROM token_transfers WHERE token_contract_address_hash = ( SELECT token_contract_address_hash FROM token_transfers LIMIT 1) [2018-12-21 07:51:43] 1 row retrieved starting from 1 in 16 s 862 ms (execution: 16 s 855 ms, fetching: 7 ms) ```	6 years ago
Andrew Cravenho	5999db7fab	Merge pull request #1272 from poanetwork/fix-compile-time-spandex-config ... fix: update spandex for run time config	6 years ago
Luke Imhoff	a5ca11930a	Merge branch 'master' into fix-compile-time-spandex-config	6 years ago
Luke Imhoff	4e7a04ae9b	Merge pull request #1270 from poanetwork/add-heart-for-restarts ... feat: restart on heartbeat timeout	6 years ago
Zach Daniel	6c8b8a3995	Merge branch 'master' into fix-compile-time-spandex-config	6 years ago
Zach Daniel	56e374eb10	Merge branch 'master' into add-heart-for-restarts	6 years ago
Luke Imhoff	746305c4ec	Merge pull request #1273 from poanetwork/1266 ... Allow block numbers to exceed missing block search range by > 1	6 years ago
Zach Daniel	0bda44d0aa	Merge branch 'master' into add-heart-for-restarts	6 years ago
Luke Imhoff	2a4223c2c6	Allow block numbers to exceed missing block search range by > 1 ... Fixes #1266 Issue #1266 was triggered when the recorded block number exceeded the reported max block number as can happen temporary when the node that gives the latest block number is farther behind than the node that gave the block data. The previous `Explorer.Chain.missing_block_number_ranges` query added in #1230 did not account for the max block number in the database exceeding the range max. When this occurs, an errant range was produced by the #1230 query because it chose the greatest of the range and the max block when trying to find the end point for the gap search. The testing did not catch #1266 because the doctests only used block numbers that exceeded the search range, by 1 and the bug did not show up until it was 2 or more. The new query is split into 4 subqueries: 1. missing prefix when range min < min(block.number) 2. missing infix when the blocks aren't in the range at all 3. missing suffix when max(block.number) < range max 4. gaps between existent block numbers This version is also more efficient as there is only a single sort of the outer `UNION ALL` result instead of a sort of real blocks and fake end points for the range. It is able to move the `UNION ALL` up because it doesn't need to produce fake end cap blocks. This positioning of the `UNION ALL` and `ORDER BY` on the outer most query allows for all 4 queries to use `one_consensus_block_at_height` index and either a limit (for `min`/`max`) or a window aggregate (for `lag`), which has minimal, single row cost.	6 years ago
Luke Imhoff	07cb543948	Failing regression test for #1266 ... When the max block number exceeds the search range by more than 1 it causes extra ranges to be calculated and they depend on the max block number instead of the search range.	6 years ago
Luke Imhoff	331b4ed26a	Merge pull request #1271 from poanetwork/1262 ... Add ON CONFLICT to derive_transaction_forks	6 years ago
Luke Imhoff	1579db1aec	Add ON CONFLICT to derive_transaction_forks ... Fixes #1262	6 years ago
Luke Imhoff	786f89164b	Failing regression test for #1262	6 years ago
Luke Imhoff	ce9a5bdc98	Merge pull request #1265 from poanetwork/eth-mainnet-timeout ... Increase DB transaction timeout to account for Eth Mainnet performance	6 years ago
zachdaniel	5a19a04813	fix: update spandex for run time config	6 years ago
zachdaniel	ea961f20ee	feat: restart on heartbeat timeout	6 years ago
Luke Imhoff	81179f9459	Use :timer functions to make timeout values clearer	6 years ago
Luke Imhoff	1a17658866	Increase DB transaction timeout to 4 minutes ... This prevents DB timeouts against Eth Mainnet for stretches of 20 minutes when testing with block concurrency of 5 and block batch size of 5 while production is simultaneously running at 12x12.	6 years ago
Luke Imhoff	4551d7f70c	Merge pull request #1260 from poanetwork/on-conflict-where ... Use where clause for on_conflict to only write tuples that are different	6 years ago
Luke Imhoff	bf50a03070	Change RollingWindowTest to async: false ... The same named process is used for all tests and they use the same key, so they interfere with each other.	6 years ago
Luke Imhoff	2b60cba8a1	Remove unused import	6 years ago
Luke Imhoff	ef02ae0504	Fix missed pinning ... Showed up as unused variables	6 years ago
Luke Imhoff	254d6b46a1	Increase assert_receive timeout	6 years ago
Luke Imhoff	04d3644839	Use where clause for on_conflict to only write tuples that are different ... When the `ON CONFLICT` clause is triggered, it still causes a new tuple in Postgres to be written even if the value of all the columns is the same. Making a new tuple means that the table needs to be vacuumed sooner and leads to more work and churn for the database and its storage. But, there is a way to prevent this unnecessary churn: Postgres supports a `WHERE` clause on the `ON CONFLICT DO UPDATE` that allows us to not write a new row if the data would be the same. While testing this, it already showed it can prevent unnecessary updates to the `tokens` table when the MetadataUpdater is running.	6 years ago
Luke Imhoff	85883011eb	Merge pull request #1261 from poanetwork/import_id-transaction_id-logger-metadata ... Include import_id and transaction_id in logger metadata	6 years ago
Luke Imhoff	3c0adace16	Include import_id and transaction_id in logger metadata ... When `import_id` and `transaction_id` was added in Logger calls, they were not added to the metadata allowed to be shown and so weren't appearing in the logs.	6 years ago
Amanda	f0bde6abd8	Merge pull request #1249 from poanetwork/ams-reward-value-in-tile ... Add reward value of a block in the tile and overview section.	6 years ago
Amanda Sposito	c939b1d8a7	Add gettext	6 years ago
Amanda Sposito	6cb8f3f2ba	Add :dev to plug_cowboy dependency in explorer ... * The iex was not initiating due to this dependency	6 years ago
Amanda Sposito	de3520667f	Add reward value of a block in the tile and overview section	6 years ago
Luke Imhoff	d8a894c66a	Merge pull request #1255 from poanetwork/only-query-when-channel-connected ... Only query for coin balance when channel connected	6 years ago
Luke Imhoff	2ec9600a61	Only query for coin balance when channel connected ... Normally, it is good idea to only query the database once no matter the number of sockets for a channel, but most addresses don't have listeners, so it is cheaper to not query unless the channel is in use. If we start to see popular addresses, con_cache can be used to only do the query once across all connected sockets for the same address. Co-authored-by: Chris McCord <chris@chrismccord.com>	6 years ago
Luke Imhoff	131e972526	Merge pull request #1256 from poanetwork/step-step ... Don't use step variable twice	6 years ago
Luke Imhoff	e22fca4ada	Don't use step variable twice ... Accidentally used `step` variable twice when the actual error is like `{:import, {:error, import_step, ..., ...}` which would only allow `{:import, {:error, :import, ..., ...}`.	6 years ago
Andrew Cravenho	3e3c9198ce	Merge pull request #1241 from poanetwork/1204-realtime-blocks-issue ... Handle new blocks older than last block	6 years ago
fvictorio	1765435922	Handle new blocks older than last block	6 years ago
Luke Imhoff	89c2367fb5	Merge pull request #1254 from poanetwork/1253 ... Chunk pending transactions	6 years ago
Luke Imhoff	3592b66340	Chunk pending transactions ... Fixes #1253 Ensure pending transaction import without timeout by chunking in case the node has a lot of pending transactions.	6 years ago
Luke Imhoff	575d3dda9a	Merge pull request #1252 from poanetwork/1251 ... Convert DBConnection.ConnectionError tcp recv: closed to {:error, :timeout}	6 years ago
Luke Imhoff	8e1bfc0589	Convert DBConnection.ConnectionError tcp recv: closed to {:error, :timeout} ... Resolves #1251	6 years ago
William Sanches	5a3787da8b	Merge pull request #1245 from poanetwork/wsa-jason-decode-error ... Fix Jason decode error validating contracts	6 years ago
William Sanches	2b48235898	Remove opcodes from CodeCompiler ... Really old versions of solidity compiler, e.g. v0.1.3, have different output schemas. This data was never used by our application, so instead of having to deal with different outputs, we just don't try to get this item anymore.	6 years ago
William Sanches	c1e582e85c	Add better error messages	6 years ago
William Sanches	3ff530c22e	Update JS solidity compiler ... The old lib would produce errors with solidity versions newer than v0.5.0. This will allow more recent codes to be verified.	6 years ago
Gustavo	cabee38387	Merge pull request #1240 from poanetwork/gsf-validator-metadata ... validator metadata retrieval and display	6 years ago
Gustavo Santos Ferreira	07cb1d918b	gettext	6 years ago
Gustavo Santos Ferreira	f2cbf37200	genserver that executes validator data imports every 24 hours	6 years ago
Gustavo Santos Ferreira	add2b2c213	add a modal fo the validator info	6 years ago