From 1921c45885a6b630ab4ee2b68b8bedf1729e5f5f Mon Sep 17 00:00:00 2001
From: Daniel Savu <23065004+daniel-savu@users.noreply.github.com>
Date: Fri, 16 Jun 2023 13:01:38 +0100
Subject: [PATCH] chore(relayer): improve ISM address error message (#2345)

Closes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2090

Recent improvements from
https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2195 already
catch the error in that user report. This PR just adds a hint as to why
fetching may have failed; in that report, the user's `fallback` function
was returning an empty value which caused casting to an `address` to
fail and revert, so the error occurs because the returned value is
malformed.

Thanks to @tkporter for walking me through the contracts to better
understand the scope of
https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2090.
---
 rust/agents/relayer/src/msg/pending_message.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/agents/relayer/src/msg/pending_message.rs b/rust/agents/relayer/src/msg/pending_message.rs
index 92a50621c..02b566fa8 100644
--- a/rust/agents/relayer/src/msg/pending_message.rs
+++ b/rust/agents/relayer/src/msg/pending_message.rs
@@ -150,7 +150,7 @@ impl PendingOperation for PendingMessage {
                 .destination_mailbox
                 .recipient_ism(self.message.recipient)
                 .await,
-            "fetching ISM address"
+            "fetching ISM address. Potentially malformed recipient ISM address."
         );
 
         let Some(metadata) = op_try!(