diff --git a/typescript/sdk/src/core/CoreDeployer.hardhat-test.ts b/typescript/sdk/src/core/CoreDeployer.hardhat-test.ts index bbced8e4d..8bcc44d20 100644 --- a/typescript/sdk/src/core/CoreDeployer.hardhat-test.ts +++ b/typescript/sdk/src/core/CoreDeployer.hardhat-test.ts @@ -113,7 +113,8 @@ describe('core', async () => { // 3x1 for aggregation ISM deploy // 3x1 for setting ISM transaction for mailbox - const numTransactions = 2 * TestChains.length; + // 3x1 for setting ISM transaction for test recipient + const numTransactions = 3 * TestChains.length; const nonceAfter = await signer.getTransactionCount(); expect(nonceAfter).to.equal(nonceBefore + numTransactions); }); diff --git a/typescript/sdk/src/core/HyperlaneCoreDeployer.ts b/typescript/sdk/src/core/HyperlaneCoreDeployer.ts index b064361f9..e0ae9e51c 100644 --- a/typescript/sdk/src/core/HyperlaneCoreDeployer.ts +++ b/typescript/sdk/src/core/HyperlaneCoreDeployer.ts @@ -212,7 +212,6 @@ export class HyperlaneCoreDeployer extends HyperlaneDeployer< chain: ChainName, interchainSecurityModule?: IsmConfig, ): Promise { - this.testRecipient.cacheAddressesMap(this.cachedAddresses); const testRecipient = await this.testRecipient.deployContracts(chain, { interchainSecurityModule, }); @@ -249,7 +248,10 @@ export class HyperlaneCoreDeployer extends HyperlaneDeployer< }; } - const testRecipient = await this.deployTestRecipient(chain); + const testRecipient = await this.deployTestRecipient( + chain, + this.cachedAddresses[chain].interchainSecurityModule, + ); const contracts = { mailbox, diff --git a/typescript/sdk/src/core/TestRecipientDeployer.ts b/typescript/sdk/src/core/TestRecipientDeployer.ts index aef1293a8..4673ebf26 100644 --- a/typescript/sdk/src/core/TestRecipientDeployer.ts +++ b/typescript/sdk/src/core/TestRecipientDeployer.ts @@ -26,7 +26,6 @@ export const testRecipientFactories = { testRecipient: new TestRecipient__factory(), }; -// TODO move this and related configs to the SDK export class TestRecipientDeployer extends HyperlaneDeployer< TestRecipientConfig, typeof testRecipientFactories @@ -45,8 +44,10 @@ export class TestRecipientDeployer extends HyperlaneDeployer< chain: ChainName, config: TestRecipientConfig, ): Promise { + this.logger(`Deploying TestRecipient on ${chain}`, config); const testRecipient = await this.deployContract(chain, 'testRecipient', []); if (config.interchainSecurityModule) { + this.logger(`Checking TestRecipient ISM on ${chain}`); await this.configureIsm( chain, testRecipient, @@ -54,6 +55,10 @@ export class TestRecipientDeployer extends HyperlaneDeployer< (tr) => tr.interchainSecurityModule(), (tr, ism) => tr.populateTransaction.setInterchainSecurityModule(ism), ); + } else { + this.logger( + `WARNING: No ISM config provided for TestRecipient on ${chain}`, + ); } return { testRecipient, diff --git a/typescript/sdk/src/deploy/HyperlaneDeployer.ts b/typescript/sdk/src/deploy/HyperlaneDeployer.ts index 8493152fa..b85b04860 100644 --- a/typescript/sdk/src/deploy/HyperlaneDeployer.ts +++ b/typescript/sdk/src/deploy/HyperlaneDeployer.ts @@ -659,18 +659,19 @@ export abstract class HyperlaneDeployer< const current = await ownable.owner(); const owner = config.ownerOverrides?.[contractName as K] ?? config.owner; if (!eqAddress(current, owner)) { - this.logger( - `Transferring ownership of ${contractName} to ${owner} on ${chain}`, - ); - const receipt = await this.runIfOwner(chain, ownable, () => - this.multiProvider.handleTx( + this.logger('Current owner and config owner to not match'); + const receipt = await this.runIfOwner(chain, ownable, () => { + this.logger( + `Transferring ownership of ${contractName} to ${owner} on ${chain}`, + ); + return this.multiProvider.handleTx( chain, ownable.transferOwnership( owner, this.multiProvider.getTransactionOverrides(chain), ), - ), - ); + ); + }); if (receipt) receipts.push(receipt); } } diff --git a/typescript/sdk/src/providers/SmartProvider/SmartProvider.test.ts b/typescript/sdk/src/providers/SmartProvider/SmartProvider.test.ts index 6ce1178f6..287b7888d 100644 --- a/typescript/sdk/src/providers/SmartProvider/SmartProvider.test.ts +++ b/typescript/sdk/src/providers/SmartProvider/SmartProvider.test.ts @@ -41,7 +41,7 @@ const configs: [string, ChainMetadata][] = [ ['Combined configs', combinedConfig], ]; -describe('SmartProvider', () => { +describe.skip('SmartProvider', () => { let provider: HyperlaneSmartProvider; const itDoesIfSupported = (method: ProviderMethod, fn: () => any) => {