2795 Commits (085aaee2a40c8b0ea658ec9eb06cd67be95f6755)

 

All Branches   

Search

Author	SHA1	Message	Date
Lee	d0f7f21fd4	fix(cli): hyperlane core apply logging fix (#4251) ... ### Description Fixes `hyperlane core apply` to say "Hyperlane Core Apply" ### Backward compatibility Yes ### Testing Manual	4 months ago
Trevor Porter	cffbfcac13	feat: fully testing ICA ownership with tooling (#4245) ... ### Description Some tweaks to get checker tooling working with ICA ownership: - changed the `inferCallSubmissionTypes` logic to no longer mutate `this.calls`. Some weird side effects were occurring, especially where the ICA logic would try to pop and push from `this.calls` while also looping over it. This is also why I made it serial again. I ended up moving away from mutating this.calls entirely during the iteration, so I guess moving back to doing it concurrently can be done again. Happy to do this if it feels good to - the only reason I haven't is this wasn't a place where we had huge inefficiencies and it'd complicate the code a little - Got it working where a Safe on chain A owns an ICA on chain B These are the flows I tested: - sepolia is the "owner chain" - deployed a warp route between sepolia and alfajores. Changed the alfajores owner to an ICA owned by the sepolia deployer key. Tested transferring ownership back from this to the deployer. - Did the exact same as above, but now with the ICA being owned by a Safe on sepolia - Transferred ownership of Alfajores core contracts to and from the sepolia-deployer-owned ICA These are some raw notes that may be of interest of what I did https://www.notion.so/hyperlanexyz/ICA-playground-996cf28aea1649a18051afb8bb82acb2 This doesn't auto-deploy ICAs. An ICA is expected to have been deployed already, and then just configured in `owners.ts`. Check-deploy figures out that it's an ICA and does all the rest. This is fine imo in the short term as I only imagine us using ICAs on two chains (inevm and viction) for the time being. ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	4 months ago
J M Rossy	69a39da1cf	fix(sdk): Access correct consensus client when estimating cosmwasm txs (#4249) ... ### Description `tmClient` (i.e. TendermintClient) is now `cometClient` ### Related issues Related to #4209 but not surfaced because of ts-ignore, which is necessary because the required data isn't surfaced properly by CosmJS ### Backward compatibility Yes ### Testing Tested in Warp UI	4 months ago
Paul Balaji	c6bf71d1b3	chore: update registry to v2.4.0 (#4247) ... chore: update registry to v2.4.0 - pinned CI version updated to `d9fea91f16949a51b2c8e776bac26712ba1fef3d`, which includes some testnet updates after 2.4.0 (https://github.com/hyperlane-xyz/hyperlane-registry/pull/126) --------- Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>	4 months ago
Yorke Rhodes	929760cf30	fix: revert "fix: enable metadata builder unit tests" (#4246) ... Reverts hyperlane-xyz/hyperlane-monorepo#4176 Fixes flakey metadata builder test	4 months ago
Mohammed Hussan	c21a99abf8	feat(infra): ensure check-deploy covers ownable ISMs (#4236) ... ### Description - check-deploy will surface violations when the on-chain ISM state differs from the config for core and warp modules Example of running check-deploy when the warp config includes a new validator Vs on-chain ISM state ``` ┌─────────┬────────────┬────────┬──────────────┬─────────────┬─────────┬──────────────────────────────────────────────┬──────────────────────────────────────────────┐ │ (index) │ chain │ remote │ name │ type │ subType │ actual │ expected │ ├─────────┼────────────┼────────┼──────────────┼─────────────┼─────────┼──────────────────────────────────────────────┼──────────────────────────────────────────────┤ │ 0 │ 'ethereum' │ │ │ 'ClientIsm' │ │ [Object] │ [Object] │ │ 1 │ 'ethereum' │ │ 'collateral' │ 'Owner' │ │ '0x3965AC3D295641E452E0ea896a086A9cD7C6C5b6' │ '0xa7ECcdb9Be08178f896c26b7BbD8C3D4E844d9Ba' │ └─────────┴────────────┴────────┴──────────────┴─────────────┴─────────┴──────────────────────────────────────────────┴──────────────────────────────────────────────┘ Connection client violation ClientIsm details: + Added to config staticAggregationIsm.modules.0.merkleRootMultisigIsm.validators.3: "0xbb5842ae0e05215b53df4787a29144efb7e67551" + Added to config staticAggregationIsm.modules.1.messageIdMultisigIsm.validators.3: "0xbb5842ae0e05215b53df4787a29144efb7e67551" ~ Updated config staticAggregationIsm.modules.0.merkleRootMultisigIsm.validators.0: "0x95c7bf235837cb5a609fe6c95870410b9f68bcff" -> "0x4d966438fe9e2b1e7124c87bbb90cb4f0f6c59a1" ~ Updated config staticAggregationIsm.modules.0.merkleRootMultisigIsm.validators.1: "0xa5a56e97fb46f0ac3a3d261e404acb998d9a6969" -> "0x95c7bf235837cb5a609fe6c95870410b9f68bcff" ~ Updated config staticAggregationIsm.modules.0.merkleRootMultisigIsm.validators.2: "0xbb5842ae0e05215b53df4787a29144efb7e67551" -> "0xa5a56e97fb46f0ac3a3d261e404acb998d9a6969" ~ Updated config staticAggregationIsm.modules.1.messageIdMultisigIsm.validators.0: "0x95c7bf235837cb5a609fe6c95870410b9f68bcff" -> "0x4d966438fe9e2b1e7124c87bbb90cb4f0f6c59a1" ~ Updated config staticAggregationIsm.modules.1.messageIdMultisigIsm.validators.1: "0xa5a56e97fb46f0ac3a3d261e404acb998d9a6969" -> "0x95c7bf235837cb5a609fe6c95870410b9f68bcff" ~ Updated config staticAggregationIsm.modules.1.messageIdMultisigIsm.validators.2: "0xbb5842ae0e05215b53df4787a29144efb7e67551" -> "0xa5a56e97fb46f0ac3a3d261e404acb998d9a6969" ``` ### Backward compatibility Yes ### Testing Manual	4 months ago
Trevor Porter	fe9365fdb3	chore: agent metric log tweaks (#4244) ... ### Description - some small tweaks as I looked into a recent issue with metrics ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	4 months ago
J M Rossy	5125b798df	feat(cli): Prompt for isTestnet when defining chain (#4240) ... ### Description Prompt for chain testnet/mainnet during chain definition flow <img width="893" alt="Screenshot 2024-08-01 at 2 13 48 PM" src="https://github.com/user-attachments/assets/b4e73e19-b1ab-4a01-a769-f9b1495457a9"> ### Testing Locally	4 months ago
Lee	c7f5a35e82	feat(sdk,cli): Add hyperlane core apply with update defaultIsm (#4224) ... ### Description - Adds update defaultIsm to CoreModule - - Create `hyperlane core apply --chain beta --config ./configs/core-config.yaml` - `--chain` is the only required arg - `--config` is the filepath to `core-config.yaml`, which defaults to `./configs/core-config.yaml` - This command relies on the registry artifacts (CHAIN/addresses.yaml), which is fetched by chainname ### Related issues https://github.com/hyperlane-xyz/issues/issues/1331 ### Backward compatibility Yes ### Testing Manual	4 months ago
Yorke Rhodes	6341edf2a2	fix: use merkle tree hook address from registry for self relay hook derivations (#4223) ... ### Description Circumvents bad hook derivation during self relay ### Related issues - Fixes https://github.com/hyperlane-xyz/issues/issues/1320 ### Backward compatibility Yes ### Testing manual warp send from sepolia origin --------- Co-authored-by: Noah Bayindirli 🥂 <15343884+nbayindirli@users.noreply.github.com>	4 months ago
Yorke Rhodes	c539775d76	feat: default to mailbox address in registry (#4219) ... ### Description ```sh yarn hyperlane core read --chain etherereum ``` will fetch mailbox address from registry ### Drive-by changes None ### Backward compatibility Yes ### Testing Manual	4 months ago
Tien Dao	f1d70a5e82	feat: refactor select chain CLI (#4118) ... ### Description This PR refactors the chain selection process in the CLI to split it into two steps: - Select between **mainnet** and **testnet**. - Select the specific chain within the chosen network type. This change helps to manage long lists of chains more efficiently.  <!-- What's included in this PR? --> ### Affected File ```hyperlane-monorepo/typescript/cli/src/utils/chains.ts``` ### Drive-by changes Move select chain into 2 functions <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	4 months ago
Mohammed Hussan	8e942d3c6b	feat: deploy cheesechain, worldchain, xlayer (#4207) ... ### Description - Support deployment to cheesechain, worldchain and zlayer ### Drive-by changes - update `CosmosChainSchema` to add `chain_type` to fix breaking change introduced by 6854133f98	4 months ago
Lee	5529d98d03	feat(sdk,cli): Add hyperlane core apply with mailbox transfer ownership (#4215) ... ### Description - Adds `hyperlane core apply` to the CLI - Adds mailbox transfer ownership to SDK ### Related issues - https://github.com/hyperlane-xyz/issues/issues/1328 - https://github.com/hyperlane-xyz/issues/issues/1330 ### Backward compatibility Yes ### Testing Manual/Unit Tests --------- Co-authored-by: J M Rossy <jm.rossy@gmail.com>	4 months ago
J M Rossy	9edbc175cf	fix: Add widgets ref to dockerfile (#4216) ... Fixes missing docker entry from PR #4139	4 months ago
Kunal Arora	968160f4e2	feat: AVS upgrade for correct reporting on Eigenlayer UI (#4152) ... ### Description - upgraded the AVS on holesky - now working splendidly! - included the function call for upgrading the AVS on mainnet `upgradeHsm4090` - encoded calldata to `0x9e3045a8Feb10F05f4d1268Ef8E303b655e8F562` is `0x99a88ec4000000000000000000000000e8e59c6c8b56f2c178f63bcfc4ce5e5e2359c8fc0000000000000000000000009e3045a8feb10f05f4d1268ef8e303b655e8f562 ` - make the call `forge script script/avs/DeployAVS.s.sol:DeployAVS --sig "upgradeHsm4090(string memory,address,address)" "ethereum" 0xe8E59c6C8B56F2c178f63BCFC4ce5e5e2359c8fc 0x272CF0BB70D3B4f79414E0823B426d2EaFd48910 --rpc-url https://rpc.ankr.com/eth -vvvv --sender 0x3965AC3D295641E452E0ea896a086A9cD7C6C5b6` to repro ### Drive-by changes Found two issues with forge scripting - upgrade call wasn't working with a pranked sender but the equivalent low-level call worked - once you call `vm.expectRevert()` the script terminates. ### Related issues - fixes https://github.com/hyperlane-xyz/issues/issues/1297 ### Backward compatibility Yes ### Testing Fork run of upgrade --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	4 months ago
Daniel Savu	b643fba90a	feat: use multiple `mpsc` channels instead of `broadcast` for async interface (#4190) ... ### Description Follow up to https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/4180 Lowers txid broadcast channel capacity from 1M to 30k and refactors it to use a vec of `mpsc` under the hood. ### Context The heap profiler showed that each new chain takes up 100MB of memory because of the txid broadcast channel. In addition to this, the tokio broadcast channel is a ring buffer where new items simply overwrite old items, making it hard to safely lower the capacity. As such, to be able to safely lower the capacity of this channel, usage of `tokio`'s `broadcast` channel is replaced with a `Vec` of `mpsc`s, which offer an async `send` interface for backpressure. So instead of overwriting old items, senders will block on sends, which makes sense in our case as we absolutely don't want to miss items. The submitter is slower than the indexer based on empirical observation, so blocking on channel size doesn't bottleneck throughput. I noticed the max number of channel items we can reach is 29k, by running the RC relayer after an 8 day break, during which around 160k messages were submitted. Lowering the capacity to 30k should cause us to only encounter backpressure in very rare cases, and the footprint of this channel would lower from 100MB to 3MB. ### Drive-by changes The delivery indexer in the scraper is no longer passed a txid receiver, since message deliveries are not expected to occur in the same tx as message dispatches. ### Related issues - Fixes https://github.com/hyperlane-xyz/issues/issues/1293 ### Testing E2E, by adding invariants to make sure txid indexing works --------- Co-authored-by: Trevor Porter <tkporter4@gmail.com>	4 months ago
J M Rossy	98eb680adf	chore: Migrate widgets from separate repo to monorepo (#4139) ... ### Description Copies the [widget lib](https://github.com/hyperlane-xyz/hyperlane-widgets) over so that it can use the same review and release process as other packages. No code changes, only some minor tooling config changes to work in monorepo. ### Related issues Fixes https://github.com/hyperlane-xyz/issues/issues/1111 ### Backward compatibility Yes ### Testing Tested in storybook	4 months ago
Lee	9046cbbad9	chore(sdk): Add server error unit tests to SmartProvider (#4206) ... ### Description This Re-adds the unit tests commented out in https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/4201	4 months ago
J M Rossy	488f949efa	chore: Upgrade CosmJS libs to 0.32.4 (#4209) ... ### Description - Upgrade CosmJS libs to 0.32.4 - Remove explorer dep from ccip-server ### Related issues https://github.com/hyperlane-xyz/hyperlane-warp-ui-template/issues/202 ### Backward compatibility No, major version bump required because CosmJS 0.32 is not backwards compatible with 0.31 ### Testing Tested in Warp UI	4 months ago
Lee	ded5718a09	fix(cli): hide large configs in core read command (#4192) ... ### Description This PR adds a helper function that logs the config terminal "preview", _only_ if the number of lines is < 250 for `hyperlane core read`. ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4191 Yes ### Testing Manual - `yarn build && yarn hyperlane core read --mailbox 0x2f9DB5616fa3fAd1aB06cB2C906830BA63d135e3 --chain fraxtal ` - And tried with a deployed one to test out lines < 250 --------- Co-authored-by: Noah Bayindirli 🥂 <15343884+nbayindirli@users.noreply.github.com>	4 months ago
Noah Bayindirli 🥂	c2a2897d7f	fix(cli): fix collateralVault 'token' input request for yield routes (#4202) ... ### Description - fixes collateralVault 'token' input request for yield routes, where we were asking for a token instead of a vault address ### Drive-by changes - none ### Related issues - none ### Backward compatibility - yes ### Testing - ci	4 months ago
Daniel Savu	d864c6a939	fix(evm): only create signer provider when needed (#4208) ... ### Description Adds an associated const to all ethereum provider builders to specify whether a signer is needed. For an e2e run with 20 messages, we now have 12 providers built with signers at the beginning (3 of which are validator announce), and 708 providers built without a signer. This should hopefully fix the gas escalator memory leak. ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	4 months ago
J M Rossy	cfb890dc6b	chore(sdk): Remove dead SDK logos (#4205) ... ### Description Logos were moved to the registry. Existing logos in monorepo are stale and no longer needed. ### Backward compatibility No but very unlikely anyone but us was using them	4 months ago
Lee	4907b510cc	feat(sdk): Add unified error parsing to handle server and timeout errors (#4201) ... ### Description Adds logic to parse the Ethers and SmartProvider error code to direct users to change their RPC. `RPC request failed with ${errorMsg}. Check RPC validity. To override RPC URLs, see: https://docs.hyperlane.xyz/docs/deploy-hyperlane-troubleshooting#override-rpc-urls` ### Related issues https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4200 ### Backward compatibility Yes ### Testing Manual/Unit Tests --------- Co-authored-by: Noah Bayindirli 🥂 <15343884+nbayindirli@users.noreply.github.com>	4 months ago
Daniel Savu	6140e6f397	feat: Relayer heap profiling (#4180) ... ### Description During the scalability audit we've identified relayer memory usage as a cause of concern. This PR runs the profiler each time e2e is run and outputs a report called `dhat-heap.json` in the current dir. That file can be visualised with a dhat viewer, such as the one hosted by the author [here](https://nnethercote.github.io/dh_view/dh_view.html). It adds a conditionally compiled heap memory profiler ([dhat-rs](https://docs.rs/dhat/latest/dhat/)), which is only included when both the `memory-profiling` feature is enabled and the `memory-profiling` cargo profile is used. The report can order the profiling results by total lifetime allocated bytes, peak allocated bytes, total allocation count, etc. Below is the result of sorting by total lifetime allocated bytes, which reveals that the biggest memory hogs are the hook indexing channel [senders](https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/rust/hyperlane-base/src/contract_sync/mod.rs#L52) (one per origin chain), taking up 100+ MB. Its size can most likely be reduced from 1M to 1k.  ### Drive-by changes Adds the remaining IDs in the channel as a field to the hook indexing log, to know if it's safe to lower the channel size. ### Related issues - Fixes https://github.com/hyperlane-xyz/issues/issues/1293 ### Backward compatibility Yes, since everything is conditionally compiled / isolated in a new cargo profile. ### Testing Manual	4 months ago
Noah Bayindirli 🥂	ed63e04c4a	fix(sdk): silence provider logs in deriveIsmConfig (#4194) ... ### Description - silences provider logs in deriveIsmConfig, like deriveHookConfig - created HyperlaneReader class for readers to extend in order to reuse `setSmartProviderLogLevel` ### Drive-by changes - none ### Related issues - fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4061 ### Backward compatibility - yes ### Testing - manual - ci	4 months ago
Mohammed Hussan	5c93f69238	feat(infra): support retrying safe proposal transactions (#4197) ... ### Description - This is required as some (Zetachain) safe transaction services are flaky <!-- What's included in this PR? -- ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	4 months ago
Kunal Arora	a3aecf9e41	feat: migrate metadata builder test from `HyperlaneHookDeployer` to `EvmHookModule` (#4195) ... ### Description - updates the deployment of hooks to use EvmHookModule.create() ### Drive-by changes None ### Related issues - fixes https://github.com/hyperlane-xyz/issues/issues/1322 ### Backward compatibility Yes ### Testing Unit tests	4 months ago
Lee	8533f9e66c	feat(sdk): Add ownership transfer to update (#4175) ... ### Description Add transfer ownership to warp update ### Related issues https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4174 ### Backward compatibility Yes ### Testing Manual/Unit test	4 months ago
Mohammed Hussan	957a262d54	feat: new validators (#4179) ... ### Description <!-- What's included in this PR? --> - Add new validators - Add new safes - make mapViolationsToCalls run in parallel ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> - improve `create-safe.ts` script to fetch and print the transaction service url with instruction to add it to registry ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> --------- Co-authored-by: Trevor Porter <tkporter4@gmail.com>	4 months ago
Yorke Rhodes	b69bc23239	fix: enable metadata builder unit tests (#4176) ... ### Description Reenables metadata builder tests with decreased random limits to prevent flakes ### Testing Unit Tests	4 months ago
Kunal Arora	90598ad449	feat: remove outbox param from `ArbL2ToL1Ism` (#4178) ... ### Description - outbox contract can be derived from arbitrum's bridge contract so it's not useful to pass in ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Unit	4 months ago
Paul Balaji	1474865ae1	fix(utils): use browser compatible `deepEquals` (#4141) ... - fix: use browser compatible `deepEquals` - removes use of node-specific deepEquality check - add a few unit tests for `deepEqual` and `deepCopy` --------- Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com> Co-authored-by: J M Rossy <jm.rossy@gmail.com>	4 months ago
J M Rossy	ed65556aa4	feat: Improve WarpCore validation errors (#4116) ... ### Description Improve WarpCore validation error message for gas fee checks ### Drive-by changes Enable ES2022 lib types in TS config ### Related issues Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/3768 ### Backward compatibility Yes ### Testing Tested in Warp UI	4 months ago
Trevor Porter	00333a50d6	fix: use known registry commit in .registryrc (#4172) ... ### Description Seems like the commit previously used is no longer part of a branch on the repo and this is causing issues in the image CI, e.g. https://github.com/hyperlane-xyz/hyperlane-monorepo/actions/runs/10040156538/job/27745616823#step:8:501 ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	4 months ago
Mohammed Hussan	944b2f65e1	feat(infra): Add script to create safes and add safe addresses for new chains (#4127) ... ### Description <!-- What's included in this PR? --> - Add an infra script to create a safe on specific chain using the `safeSigners.json` config where the safe signers are defined ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> Manual	4 months ago
Daniel Savu	97588b6fc1	fix(relayer): don't submit reverting messages in batches (#4169) ... ### Description Depends on https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/4159 Some messages in a Multicall would revert because previous messages would invalidate them temporarily. The IGP allowance of those messages would be deducted, and if this happened more than once, those messages would become stuck. This PR fixes those unnecesary spends on reverting `process` txs by using `.call()` to simulate the outcome of a Multicall tx. Reverting messages are removed from the batch and submitted serially, and if the batch is only left with one non-reverting message, even that one is submitted serially (rather than through a batch of one message). Messages that did get submitted have their igp allowance deducted and status updated in `update_sent_ops_state`. ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues - Fixes https://github.com/hyperlane-xyz/issues/issues/1294 ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing Tested by manually setting the result of `call` to failed for all messages, to see if they are submitted serially. In prod, we can track the `Submitted transaction batch` log, which now includes any excluded messages from the batch.	4 months ago
Daniel Savu	bb16dfa728	fix: more conservative batching gas estimates (#4159) ... ### Description Estimating gas isn't very accurate for Multicall txs that allow failures. This PR now estimates gas as: `max(batch_tx_estimate, individual_tx_estimates_sum)`, where `individual_tx_estimates_sum` estimates each individual tx and adds a conservative overhead that `Multicall.aggregate3` adds per subtx. The aggregate3 overhead is calcualted based on some observed tenderly gas profiling results as follows. - For [4 txs](https://dashboard.tenderly.co/shared/simulation/63e85ac7-3ea9-475c-8218-a7c1dd508366/gas-usage): - aggregate3 gas: 805,160 - process costs: 290,091 + 168,711 + 168,711 + 168,711 = 796,224 - overhead: 805,160 - 796,224 = 8,936 => 2,234 per subtx - For [2 txs](https://dashboard.tenderly.co/tx/arbitrum/0xad644e431dc53c3fc0a074a749d118ff5517346c3f28d8e2513610cc9ab5c91a/gas-usage): - aggregate3 gas: 201,710 - process costs: 103,011 + 92,512 = 195,523 - overhead: 201,710 - 195,523 = 6,187 => 3,093 per subtx - So will assume an overhead of 3500 `aggregate3` gas per message in batch ### Drive-by changes This slightly changes the semantics of gas overrides. If a gas limit is configured, it will only guarantee that that's the minimum limit a tx can have. Now we use the `max(estimated_gas, gas_limit_override)` as the actual gas limit. ### Related issues - Fixes https://github.com/hyperlane-xyz/issues/issues/1295 ### Backward compatibility Yes ### Testing I think it's ok to release to release and check the new log, to see the individual estimate vs the batch estimate and double-check which one is picked in the tx explorer	4 months ago
Noah Bayindirli 🥂	7fdd3958d6	fix(sdk): sourceCode entity too large for contract verification (#4166) ... ### Description - used BFS to traverse and prune the dependency graph of any named contract in the buildArtifact input to address 'entity size too large' error thrown from bsc mainnet etherscan explorer ### Drive-by changes - none ### Related issues - fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4164 ### Backward compatibility - yes ### Testing - manual (bsc now verifying)	4 months ago
Noah Bayindirli 🥂	fef6296737	fix(sdk): adjust timeouts based on explorer family & collate verif process (#4168) ... ### Description - adjusts timeouts based on explorer family - collates verif process for maintainability/readability (this also makes timeouts more consistent) ### Drive-by changes - none ### Related issues - partially fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4130 ### Backward compatibility - yes ### Testing - manual	4 months ago
Noah Bayindirli 🥂	ab827a3fa6	fix(sdk): remove contract verification check; add expectedimplementation; enhance logging (#4165) ... ### Description - removes contract verification check - adds `expectedimplementation` method params for `verifyproxycontract` - enhances logging and renames variables for clarity ### Drive-by changes - none ### Related issues - fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4123 ### Backward compatibility - yes ### Testing - manual	5 months ago
Lee	62d71fad35	feat(cli): Add hyperlane warp extend (#4107) ... ### Description - Adds "extend warp route" logic to `hyperlane warp update` - To extend, provide the existing `warp-route-deployment.yaml` with the additional `TokenRouterConfig` For example, considering `hyperlane warp deploy` is called with this config: ```yaml alpha: interchainSecurityModule: modules: - relayer: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266' type: trustedRelayerIsm - domains: {} owner: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266' type: defaultFallbackRoutingIsm threshold: 1 type: staticAggregationIsm isNft: false mailbox: '0xe04e5D673F3f253BF43A82ce66Bba0Ae771CF09B' owner: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266' type: native ``` To extend, add a new TokenRouter config: ```yaml alpha: interchainSecurityModule: modules: - relayer: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266' type: trustedRelayerIsm - domains: {} owner: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266' type: defaultFallbackRoutingIsm threshold: 1 type: staticAggregationIsm isNft: false mailbox: '0xe04e5D673F3f253BF43A82ce66Bba0Ae771CF09B' owner: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266' type: native arbitrum: interchainSecurityModule: modules: - relayer: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266' type: trustedRelayerIsm - domains: {} owner: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266' type: defaultFallbackRoutingIsm threshold: 1 type: staticAggregationIsm isNft: false mailbox: '0x979Ca5202784112f4738403dBec5D0F3B9daabB9' owner: '0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266' type: native ``` The newly deployed `arbitrum` `TokenRouterConfig` will deploy the Router, and then enroll the existing `alpha` Router with each other. ### Drive by - Fix native deriving to send 0 wei instead of 1 ### Related issues https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4078 ### Testing Manual - Tested with deploying - native and extending with native - native and extending with native, and native - native and extending with synthetic - use `cast abi-decode "domain()(uint32[])" $(cast call $TOKEN_ROUTER "domains()")` to test enrollment E2e test --------- Co-authored-by: Noah Bayindirli 🥂 <noah@primeprotocol.xyz>	5 months ago
Daniel Savu	bf1dad7f77	feat(relayer): new status label for IGP not found (#4106) ... ### Description Adds new status label to relayer opqueue for operations whose gas payments were not found. This now creates a distinction between operations without a payment and those with insufficient payment. Helps better uncover cases where hook indexing misses events because there is no receipt yet	5 months ago
Noah Bayindirli 🥂	f800297259	fix(sdk): account for unparsable scanner responses during contract verification (#4163) ... ### Description - for certain failures, etherscan may return an html response we cannot parse with JSON.parse(). One such example is when our `sourceCode` is too large, due to including all build artifacts during contract verification. - while the underlying issue is `Request Entity Too Large` for this failure, our verifier was crashing with: ``` `Error verifying contract: SyntaxError: Unexpected token '<', "<html> <h"... is not valid JSON` ``` - this change accounts for unparsable scanner responses during contract verification, and gives our users insight into the underlying failure ### Drive-by changes - minor log update - also accounts for bug where we printed "Verification failed" every time we'd check if a contract had been verified or not before verifying ### Related issues - https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4130 ### Backward compatibility - yes ### Testing - manual example output: ``` Pending https://bscscan.com/tx/0x47d9c0fd641b8689deb6cee2cb5f5d3651eb246be0a1de59d523b655c621140b (waiting 1 blocks for confirmation) 📝 Verifying implementation at 0xfFd1c0E31d1B18b51D1cfdBafbC679A97ACfb3Fa... { failure: 'Request Entity Too Large', status: 413, chain: 'bsc', apiUrl: 'https://api.bscscan.com/api', family: 'etherscan' } Failed to parse response from explorer. Error verifying contract: Error: Failed to parse response from explorer (https://api.bscscan.com/api, bsc): Request Entity Too Large (413) ```	5 months ago
Lee	79740755bf	feat(sdk): Implement enroll router logic into WarpModule (#4145) ... ### Description - Adds (optional) `remoteRouters` into WarpDeployConfig so update() can use it to compare with onchain config - Adds enroll router logic into WarpModule ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4144 ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing Unit Tests	5 months ago
Trevor Porter	7489a5e143	feat: start sending resource request metrics to grafana; bump scraper CPU requests (#4158) ... ### Description - Starts sending `kube_pod_container_resource_requests` to grafana - Useful for alerts that depend on the requests for a pod - Deployed prom servers on testnet4 and mainnet3 with this config change - Found that the scraper CPU requests are too low - bumped to 2 CPU - seemingly upon startup there's a pretty big CPU spike, so adjusted the requests to be within this spike. -  ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	5 months ago
Noah Bayindirli 🥂	7265a40875	chore(sdk): add rpcUrl, chainId, and method(params) to smart provider logging (#4146) ... ### Description - adds rpcUrl, chainId, and method(params) to smart provider logging ### Drive-by changes - none ### Related issues - none ### Backward compatibility - yes ### Testing - manual	5 months ago
Daniel Savu	4fa75a4bd8	chore: better agent e2e test naming (#4157) ... ### Description For partners / OSS contributors to have an easier time building and testing the env most relevant to them	5 months ago
Trevor Porter	37b460193f	chore: deploy kathy (#4156) ... ### Description I didn't deploy kathy following https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/3875 and we've hit some RPC issues ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	5 months ago