hyperlane-monorepo

Commit Graph

Author	SHA1	Message	Date
Alex	0ddaf1c5cc	Fix incorrect getRemoteInterchainAccount derivation (#2446 ) ### Description A minor change to how we deploy InterchainAccountRouter's and a fix for remote ICA address derivation. The fix is outlined clearly in #2383 by Nam but essentially by assigning the `implementation` & `bytecode` variables in the constructor of `InterchainAccountRouter`, we are unable to correctly access them in `getRemoteInterchainAccount` if using a proxy. By moving initialisation of these variables to `initialize` we correctly store the values in the proxy storage, not the implementation storage. ### Drive-by changes The `InterchainAccountRouter` should no longer be used unproxied. ### Related issues - Fixes #2383 ### Backward compatibility No, new ICA deploy ### Testing - [x] Unit Tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	7c872bc449	5164 hook support (#2471 ) ### Description - Adding support for any ERC-5164 compatible bridge adapter to be added as a hook. See https://eips.ethereum.org/EIPS/eip-5164 for more details on the EIP and https://github.com/MultiMessageAggregation/multibridge for adapter implementations for different vendors. ### Drive-by changes - Switched mapping(bytes32 => mapping(address => true) to mapping(bytes32 => bytes) for verifedMessageIds because the last boolean is redundant in the AbtrsactNativeISM contract. ### Related issues - Fixes #2417 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	1 year ago
Kunal Arora	445da4fb0d	Adding Optimism native bridge support (#2316 ) ### Description - Adds support for the native Optimism bridge (L1->L2) to send messageID to be verified by the custom ISM on the rollup. - Only the smart contract component. - Outside Mailbox and needs to be called separately. - Uses Openzeppelin's CrossChainEnabled pattern for ensuring the right cross chain sender address. ### Drive-by changes - None ### Related issues - Fixes https://github.com/hyperlane-xyz/issues/issues/379 - Opens https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2409 - Related to https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2381 ### Backward compatibility - Needs modifying the relayer to read OptimismISM's storage to wait for `receivedEmitters` mapping to get updated before retrying `process` on the mailbox. ### Testing - Unit Tests with Foundry forks and Optimism's L1-L2 messenger contracts. --------- Co-authored-by: Asa Oines <asaoines@gmail.com>	1 year ago
Yorke Rhodes	50f04db1fa	Make merkle proofs optional on multisig ISM (#2173 ) ### Description Validators currently sign `(root, index)` checkpoints and during verification, a `message` is passed as calldata, an `id()` is derived, and a `proof` of `id()` at `index` in `root` is verified This provides “all or nothing” censorship resistance guarantees because a validator can only sign roots to allow any contained messages to be processed. We have considered alternatives where validators sign `message` directly and we lose censorship resistance in exchange for eliminating merkle proof verification gas costs. However, if validators sign `(root, index, message)` tuples, we can skip merkle proof verification on the destination chain while still maintaining censorship resistance by providing two valid metadata formats: 1. existing validator signatures and merkle proof verification of inclusion 2. including merkle proof verification for pathway where validators are censoring `message` It’s worth noting the validator is required to index event data to produce this new signature format. However, this does not require historical indexing and new validators being spun up can simply begin indexing from tip. See https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2187 for validator changes See https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2248 for relayer and e2e test changes ### Drive-by changes Merkle index also optional ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2192 ### Backward compatibility - new ISM deployment is necessary (we could upgrade implementation in theory) - Validator and relayer upgrades ### Testing Unit (fuzz) Tests, E2E tests	2 years ago
Asa Oines	ec63ed19c5	Fix CI flakiness (#2269 ) ### Description - Don't panic if E2E test fails to fetch a metric - Run coverage commands sequentially ### Drive-by changes - Cleans up some lint errors in forge tests	2 years ago
Asa Oines	1e9d0be9b3	Fix DomainRoutingIsm tests (#2255 ) ### Description Fixes a bug in the DomainRoutingIsm tests that curiously only started showing in CI a few days ago. ### Drive-by changes None	2 years ago
Asa Oines	6b058e7014	Add checkConfig to HyperlaneRouterDeployer (#2156 ) ### Description Adds a pre-deploy check to HyperlaneDeployer, with an implementation for HyperlaneRouterDeployer that does a best-effort check that the ISM and IGP are properly configured for each chain. ### Drive-by changes - Move TestIsm to TestMultisigIsm for compatibility with pre-deploy checks ### Related issues - Fixes #2038 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Manual	2 years ago
Asa Oines	f8d645e580	Add RoutingIsm (#1985 ) ### Description This PR adds `IRoutingIsm` and three implementations: - AbstractRoutingIsm, which folks building RoutingIsms can inherit from - DomainRoutingIsm, which routes based on message origin - InterchainAccountIsm, which routes based on the ISM in the InterchainAccountMessage ### Drive-by changes - Some related testing changes ### Related issues - Fixes #1521 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Yorke Rhodes	55f40ad760	Merge audit v2 remediation to main (#1727 ) ### Description Merge [`audit-v2`](https://github.com/hyperlane-xyz/hyperlane-monorepo/releases/tag/audit-v2) into `main` See [changelog](`034e75b632`...audit-v2)	2 years ago
Asa Oines	96e03b1681	Remove Create2Factory and associated deployer code (#2064 ) ### Description As discussed offline, the complexity of maintaining consistent addresses across chains is no longer worth it, especially as consistent addresses cannot be maintained across PI chains. ### Drive-by changes - Move governors into infra/src/govern - Take initialization args list as opposed to abi encoded args in deployer - Do not initialize IGP in the constructor since we need to initialize the proxy ### Related issues - Fixes #2040 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ None	2 years ago
Asa Oines	63558af85d	Use interfaces in agents (#2022 ) ### Description Move agents to use contract interfaces artifacts rather than the artifacts themselves. This ensures we don't anything that we can't guarantee is in every implementation of that interface. Particularly relevant for IGPs and ISMs. ### Drive-by changes - Moves `solidity/interfaces` to `solidity/contracts/interfaces` so that their artifacts can be used in `update_abis.sh` ### Related issues - #1757 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ None	2 years ago
Yorke Rhodes	6f7495320b	Regenerate test fixtures and unskip hardhat tests (#2035 )	2 years ago
Asa Oines	f8b04029ac	Fix flaky solidity test (#2013 ) ### Description It's failing during certain fuzzer conditions b/c the assertion is made before the assumption.	2 years ago
Asa Oines	e8d90775f7	Add Aggregation ISM (#1737 ) ### Description This PR introduces the Aggregation ISM, which requires interchain messages to be verified by an m-of-n ISM set. This PR also introduces a new MultisigISM, which does not make use of the "commitment" optimization in its metadata. The previous MultisigISM has been moved to LegacyMultisigISM. Both AggregationISM and MultisigISM have abstract contracts that require `valuesAndThreshold` implementations. This PR implements versions with static m-of-n sets, using the EIP-3448 MetaProxy standard. These implementations are intended to be combined with a future RoutingISM implementation to replace LegacyMultisigISM. ### Drive-by changes - genhtml in solidity code coverage ### Related issues - Fixes #1522 ### Backward compatibility _Are these changes backward compatible?_ Yes ### Testing _What kind of testing have these changes undergone? Unit Tests	2 years ago
Asa Oines	f5a74006ec	Add non-struct API for IQS and ICA middlewares (#1989 ) ### Description This PR adds functions to the ICA and IQS middlewares that do not take complex types. These simpler interfaces lower the barrier to entry for users, especially for those using tooling that does not support structs well (e.g. etherscan, tally) ### Drive-by changes - Rename destinationDomain -> destination - Remove messageId from InterchainCallDispatched, rename to RemoteCallDispatched ### Related issues None ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Asa Oines	7f5d50ee9c	Interoperable Interchain Accounts (#1832 ) ### Description This PR introduces a version of Interchain Accounts that is fully interoperable with any compatible contract deployed on a remote chain. Rather than follow the previous `Router` pattern in which destination contracts were hard coded by the deployer, this version allows the user to optionally specify which destination contract should receive the interchain account message. In order to make this secure, interchain accounts are additionally name spaced by ISM and origin router. Note that this is not feature-complete until paired with a RoutingISM that switches based on the ISM included in the message ### Drive-by changes - Creates the `IRouter` and `IHyperlaneConnectionClient` interfaces - Moves middleware interfaces into their own directory - Moves middleware libs into their own directory - Changes `InterchainCallMessage` -> `InterchainQueryMessage` now that it's unused by anything else ### Related issues - Fixes #1747 - Fixes #1969 ### Backward compatibility _Are these changes backward compatible?_ No _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Yorke Rhodes	4ac6290886	Use bytecode deployer for ICA auth (#1914 ) ### Description - Replaces `OwnableMulticall` (`owner` in storage) with `DeployerMulticall` (`deployer` in bytecode) for optimizing ICA deployment costs ### Backward compatibility No, bytecode changes implies new ICA addresses ### Testing Unit Tests	2 years ago
Trevor Porter	cd75c25f40	Check IGP ownership, transfer IGP ownership in the initializer (#1895 ) ### Description * Adds the IGP & DefaultIsmIgp to the HyperlaneCoreChecker's list of ownables * Transfers ownership in the `initialize` function of the IGP - this way we won't ever get in a scenario where the proxy admin is the owner for fresh deploys ### Drive-by changes * The provided default mumbai rpc `https://rpc-mumbai.maticvigil.com` was giving problems for eth_getStorageAt, so changed it * Removed the DefaultIsmInterchainGasPaymaster from the list of proxies because it's not proxied (this is in #1765, but made this change in here too) ### Related issues n/a ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Trevor Porter	07f91490fc	Fix flaky fuzz test (#1903 ) ### Description I believe this is the fix for the flaky fuzz tests we've been experiencing. My theory is that the IGP's balance was overflowing by there being 2 subsequent `payForGas` calls with each payment being > `type(uint256).max / 2`. I found that this test was the culprit by running specific fuzz tests we have. Then made the fix and ran it multiple times and never saw an overflow again ### Drive-by changes n/a ### Related issues n/a ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Trevor Porter	f5d1fbbd03	On chain gas oracles in the IGP (#1765 ) * Rough implementations of all gas oracles, done with StaticGasOracle & tests * more tests, beef up StorageGasOracle * Tests cleaned up, moved to Foundry test for IGP * rm StaticGasOracle, fix all tests * cleaning up * comment * yarn gas, better comments * Fix sdk test * Fix e2e * Rm LZ stuff * fix router test * Rm MockInterchainGasPaymaster * pr comments * Move to setGasConfigs instead of setGasConfig * fix test * nit * yarn gas * IGP deploy & checker tooling, script to update on-chain StorageGasOracle data (#1794) * Add IGP gas oracle to checker * Checker works * Support different gas oracle contracts in IGP deploy tooling too * Export some types * Build out set-storage-gas-oracle-values * nit * nit * rm comment * Add pricing data * nits * nearly there * haven't tested e2e yet, but added new proxy upgrade logic to set gas oracles in IGP in upgradeAndCall * pr comments * lots * Move away from upgradeAndCall for IGP upgrade, trying to debug annoying dependency issue * Got working, cleaned a little * Add test to ensure a new implementation is deployed * yarn hyperlane * nits * cleaning * Map in description * Dedupe submission type logic * yarn gas * Separate beneficiary in IGP (#1801) * Add IGP gas oracle to checker * Checker works * Support different gas oracle contracts in IGP deploy tooling too * Export some types * Build out set-storage-gas-oracle-values * nit * nit * Add separate beneficiary to IGP * Checker / govern / deploy tooling * nits * Add compare-storage-gas-oracle * successful test upgrade, minor changes * Nits * Fix tests * Performed testne3 upgrade. Need to clean up code, but should probably use this for the mainnet upgrade * nit * update prices * Update gas prices and token exchange rates for mainnet * mainnet upgrade. needs lots of cleaning, but here it is in all its glory * Starting to clean up * more cleanup * Use updated submodules * yarn gas * nit * PR comments * yarn hyperlane * yarn gas	2 years ago
Yorke Rhodes	655bee2da7	Allow value in ICAs (#1640 ) * ICA router changes * Add ICA tests with value * Use InterchainCallMessage lib * Simplify interfaces of middlewares * Avoid using for to improve library coverage * Tolerate 2% gas snapshot deviations * Address pr comments	2 years ago
Yorke Rhodes	aeb056336c	Implement GasRouter (#1621 ) * Implement GasRouter * Add gas router deployer * Add quote gas helper to gas router * Add coverage to GasRouter * Update gas snapshot	2 years ago
Asa Oines	0477ee11ef	Speed up CI (#1683 )	2 years ago
Trevor Porter	7bafc83da6	Fix HyperlaneRouterChecker (#1660 )	2 years ago
Trevor Porter	aaafdee480	Update InterchainGasCalculator with on chain fee quoting (#1645 ) * IGP charges 1 wei * Don't pay for gas in LiquidityLayerRouter * Add GasOverheadIgp * Remove compiler silencing * Shift around some fns * nit var name * nit * Configure gas overhead IGP (#1588) * Instrument multisigIsm.verify gas costs * Add deployment tooling for IGP gas overhead * Include mailbox.process and max body in overhead * Restore multisig tests * GasOverheadIgp -> OverheadIgp, fix infra build * Prettier, change some infra / deploy tooling * run yarn hyperlane * yarn gas, update test contracts * rm OwnableUpgradeable for Overhead ISM * Move gas instrumentation into its own describe * back to TestRecipient__factory for normal verify tests * deploy test * BaseInterchainGasPaymaster -> InterchainGasPaymaster * trying to deploy * Deploying with deployerOwnedProxyAdmin * Deployed to testnet3 * Cleaning up * cleaning up * clean * everything * Clean up, remove more coingecko stuff * Use actual quoted value in kathy * Fix yarn lint-ts * Fix flaky test * yarn gas * Add back gas payment estimates * fix test * reset src/index.ts * revert infra/package.json * clean up verification.json * Update yarn.lock * Fix build * update kathy, some nits * Rebase had some incorrect code; fixed that * ran yarn hyperlane * update test * reset test_config.json Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	2 years ago
Trevor Porter	bf9d0ae792	OverheadIGP.sol, deploy new IGPs, deploy ValidatorAnnounce (#1572 ) * IGP charges 1 wei * Don't pay for gas in LiquidityLayerRouter * yarn gas * Add GasOverheadIgp * Remove compiler silencing * yarn gas * Shift around some fns * nit var name * nit * Configure gas overhead IGP (#1588) * Instrument multisigIsm.verify gas costs * Add deployment tooling for IGP gas overhead * Include mailbox.process and max body in overhead * Restore multisig tests * GasOverheadIgp -> OverheadIgp, fix infra build * Prettier, change some infra / deploy tooling * run yarn hyperlane * yarn gas * yarn gas, update test contracts * rm OwnableUpgradeable for Overhead ISM * Move gas instrumentation into its own describe * back to TestRecipient__factory for normal verify tests * New submodule commits * deploy test * BaseInterchainGasPaymaster -> InterchainGasPaymaster * trying to deploy * Deploying with deployerOwnedProxyAdmin * Deployed to testnet3 * Cleaning up * cleaning up * clean * Fix tests * revert infra/package.json * clean up verification.json * Update yarn.lock * Fix lint * Changing logic around deployerOwnedProxyAdmin * Deploy mainnet * Redeploy testnet with new salt versions * nit Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	2 years ago
Trevor Porter	49969940b4	Pay for gas in TestQuerySender (#1615 ) * Pay for gas in TestQuerySender * Make TestQuerySender pay for gas * yarn gas	2 years ago
Yorke Rhodes	f21da232de	Fix bubbling up revert reason (#1597 ) * Fix bubbling up revert reason * Add Call lib * Add coverage for revert reasons to middlewares * Address pr comments * Update gas snapshot	2 years ago
Asa Oines	55a6a7ce96	ValidatorAnnounce contract (#1531 )	2 years ago
Trevor Porter	370e3e768a	Charge 1 wei in the InterchainGasPaymaster (#1559 ) * IGP charges 1 wei * Don't pay for gas in LiquidityLayerRouter * yarn gas * Remove compiler silencing * yarn gas	2 years ago
Nam Chu Hoai	656880871a	Minor changes for Liquidity Layer deployment on v2 (#1554 ) * Minor changes for Liquidity Layer deployment on v2 * Fix Build	2 years ago
Nam Chu Hoai	891ca4ccdb	Port LiquidiyLayer PRs to v2 (#1497 ) * Add PortalAdapter to LiquidityLayer (#1290) * Add PortalAdapter to LiquidityLayer * newlines * Fix up circle relayer * Dont require context when getting args * Fix up context argument parsing * Liquidity Layer Relayer Infras (#1292) * PR review * PR review * Use redeployed CCTP contracts (#1482) * Use redeployed CCTP contracts * Fix build * Rename more things to TokenMessenger and fix nonceHash calculation * New artifacts * Fix build * Deploy relaers * Gas snapshot * PR review * Add new line	2 years ago
Yorke Rhodes	1651c78ead	Deploy v2 middlewares (#1540 ) * Update contracts with initialize owner changes * Sdk updates * Deploy ICAs and IQS to testnet3 * Deploy ICAs and IQS to mainnet2 * Update artifacts with names * Fix celo IGP * Redeploy middlewares to testnet3 * Fix alfajores verification * Redeploy middlewares to mainnet2 * Use helloworld main * Address pr comments * Simplify expect violations * Update gas snapshot	2 years ago
Yorke Rhodes	68dc546ee0	Middleware cleanup (#1501 ) * Improve docs and comments * Cleanup interchain queries tests * Update gas snapshot * Improve middleware test coverage * Add forge coverage report * Update gas snapshot * Add coverage report to PR comments * Use latest version of coverage report action	2 years ago
Asa Oines	b450181c7f	Expose Mailbox.recipientIsm() as a public function (#1480 )	2 years ago
Asa Oines	05b2bdc8d8	Make MultisigIsm HIP compliant (#1478 )	2 years ago
Asa Oines	fdc6de49da	Transfer ownership in Mailbox initializer (#1477 )	2 years ago
Yorke Rhodes	d0f14c1b88	Make router domains enumerable (#1460 ) * Make router domains enumerable * Fix tests * Make routers fn backwards compatible * Add external domains fn	2 years ago
Yorke Rhodes	ffe107387b	Use minimal proxies in ICA router (#1440 ) * Use minimal proxies in ICA router * Update optimized gas snapshots * Add instructions for gas snapshot update * Match solc config of hardhat and foundry * Pull out constants and add useful comments * Optimize with immutables	2 years ago
Asa Oines	8f77723001	Consistent addresses for upgradable contracts (#1389 )	2 years ago
Asa Oines	4fc474ed55	Smaller MultisigMetadata (#1394 )	2 years ago
Yorke Rhodes	848f96780f	Add pause (#1373 ) * Add pause * Optimize away cold SLOADs * Add natspec * Add forge tests for pausable reentrancy guard Co-authored-by: Asa Oines <asaoines@gmail.com>	2 years ago
Yorke Rhodes	c25cd842b2	Run forge tests in CI (#1355 ) * Move foundry workflow so it is picked up by github * Require ISM in router config Co-authored-by: Asa Oines <asaoines@gmail.com>	2 years ago
Yorke Rhodes	5b5ce88b72	Modify `Dispatch`, `Process` and add `DispatchId`, `ProcessId` (#1360 ) * Modify Dispatch, Process and add DispatchId, ProcessId * Update rust mailbox * Update sdk * Improve unit tests	2 years ago
Trevor Porter	6046ce68ef	v2 IGP interface change (#1308 ) * Solidity / ts changes * Update ABIs * Agent changes * cargo fmt * TestSendReceiver changes * Change param order * Rm gas payment > 0 check, add handleGasAmounts mapping to HelloWorld * Some renames * Update abi * Fix router test * Note on why we call the IGP always in _dispatchWithGas	2 years ago
Yorke Rhodes	3dc8545b76	ConnectionClient v2 (#1288 ) * Add ISM to ConnectionClient * Add Router#enrollRemoteRouters (#1310) * Use batch enroll remote routers in deployer * Fix zero address tests Co-authored-by: Nam Chu Hoai <nambrot@googlemail.com>	2 years ago
Asa Oines	a23c1a8d2a	V2 agents (#1227 )	2 years ago
Nam Chu Hoai	58492691c3	Rename to LiquidityLayer (#1277 )	2 years ago
Asa Oines	f4a2462364	Rename files to remove V2 suffix (#1198 )	2 years ago
Asa Oines	4a82f13dac	Adopt V2 throughout the solidity/typescript repo (#1196 )	2 years ago

1 2

72 Commits (0ddaf1c5cc374bcbab7fa1ea0a8532405a956404)