hyperlane-monorepo

Commit Graph

Author	SHA1	Message	Date
Kunal Arora	f26453ee55	fix(contracts): add `msg.Value` to `verifyMessageId` (#4541 ) ### Description - Added to the msg.value to verifyMessageId to test if the msgValue passed in is the same as the msgValue used postDispatch ### Drive-by changes - None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/3 ### Backward compatibility Yes ### Testing Unit tests	4 weeks ago
Kunal Arora	c9085afd96	fix: add fix for checking for correct messageId in `OPL2ToL1Ism` and `ArbL2ToL1Ism` via external call (#4437 ) ### Description - In agreement with Chainlight team's recommendation, added a second isVerified() check after portal call to make sure an arbitrary call which passes the check for metadata length and messageId cannot be verified without calling is verifyMessageId(messageId) in `OPL2ToL1Ism` and `ArbL2ToL1` ### Drive-by changes None ### Related issues - fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/2 ### Backward compatibility No, but the contracts aren't deployed anywhere ### Testing Unit testing	1 month ago
Kunal Arora	c032b8ba27	chore: refactor MessagIdHook/ISM tests into a common `ExternalBridgeTest` contract (#4490 ) ### Description We currently have 6 different versions of ISMs derived from AbstractMessageIdAuthorizedIsm: - OPL2ToL1 - ArbL2ToL1 - OPStack (L1->L2) - ERC5164 - LayerZero - PolygonPOS But all of them have their own custom test suite right now, with widely overlapping testing areas. For standardizing the tests, I've created a base test contract `ExternalBridgeTest` that handles the common tests. This has a few benefits: - harder to miss tests for known pitfalls like msg.value or asynchronicity assumption for verifyMessageId - less code duplication with each additional Ism I have moved OPL2ToL1, ArbL2ToL1, OPStack, and ERC5164 to the new base test, and I'll forgo the rest for now because of the time sensitivity of audit remediations. I've created an issue tracking the remaining work here: https://github.com/hyperlane-xyz/issues/issues/1384 ### Drive-by changes None ### Related issues Related to https://github.com/chainlight-io/2024-08-hyperlane/issues/3 ### Backward compatibility Yes ### Testing Unit	2 months ago
J M Rossy	adab1bec0c	Add code spellcheck CI job (#3467 ) ### Description Fix spelling mistakes and create codespell CI job. An extension of #3422 with the remaining mistakes fixed ### Backward compatibility Yes --------- Co-authored-by: miles <66052478+miles-six@users.noreply.github.com> Co-authored-by: Paul Balaji <paul@hyperlane.xyz>	8 months ago
Lee	b379336b91	Yield-earning Warp Routes with ERC4626 (#3076 ) ### Description Integrates ERC4626 compatible vaults. This PR assumes that the vault `asset` is the same as `wrappedToken` - `_transferFromSender()` deposits into the vault - `_transferTo()` withdraws from the vault - `sweep()` redeems excess shares for the vault asset - Uses internal `assetDeposited` store to keep track of assets deposited. Used to calculate excess shares to be withdrawn by owner - Makes minor changes to existing test files to allow new tests to inherit ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues - Implements #2450 ### Backward compatibility Yes ### Testing Manual/Unit Tests --------- Co-authored-by: Yorke Rhodes <email@yorke.dev>	9 months ago
Kunal Arora	9561931571	fix: failing ci tests for `SmartProvider` and `OpStackIsm.t.sol` (#3148 ) ### Description - Problem: OpStackIsm.t.sol was failing because of very stale block number for fork Fix: Excluding foundry fork testing from CI and updating block number - Problem: SmartProvider getLogs tests failing because the the results end up being an empty list and getConfirmations results a smaller number of confirmations than expected (712 vs 1705184) fix: excluded from ci ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Manual	11 months ago
Yorke Rhodes	1a584ad8a4	Improve standard hook metadata API	1 year ago
Yorke Rhodes	b14f997810	Graduate to yarn 4 🧶 (#2899 ) Co-authored-by: J M Rossy <jm.rossy@gmail.com> Fixes https://github.com/hyperlane-xyz/issues/issues/687 Fixes #2228 Fixes https://github.com/hyperlane-xyz/issues/issues/704	1 year ago
Kunal Arora	e90ae5a0d3	Remediate Trevor's comments (#2835 ) Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Yorke Rhodes	49fc06e65e	Support hook rotation in core deployer (#2834 )	1 year ago
Yorke Rhodes	1ecfc46ce2	v3 Router SDK changes (#2752 ) ### Description - Reorganize solidity directory structure for clarity - Updates router apps (token and helloworld) with changes from https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2749 ### Drive-by changes - Merges the hyperlane-token package to solidity and sdk ### Backward compatibility No (removed token package) ### Testing - Unit Tests - Instrumented coverage	1 year ago
Yorke Rhodes	fcfecdf250	Update router implementations for v3 (#2749 )	1 year ago
Kunal Arora	03c92e1e34	Minor internal review remediation 1 (#2748 )	1 year ago
Kunal Arora	f783c4e96f	add globalHookMetadata (#2743 ) ### Description - Consolidating IGPMetadata and OPStackMetadata to versioned GlobalHookMetadata - Add `supportMetadata` to `IPostDispatchHook` - Metadata Schema [0:1] variant [2:33] msg.value [34:65] Gas limit for message (IGP) [66:85] Refund address for message (IGP) [86:] Custom metadata ### Drive-by changes None ### Related issues - fixes https://github.com/hyperlane-xyz/issues/issues/610 ### Backward compatibility No ### Testing Unit tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	43ba1b46f1	Running forge with latest solc (#2729 ) ### Description - Removed contracts-bedrock contracts dependency from eth-optimism (which was forcing us to use 0.8.15) - Added local minimal interfaces for the CrossDomainMessenger contract ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Unit tests --------- Signed-off-by: -f <kunalarora1729@gmail.com> Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Yorke Rhodes	7309f770ef	Add forge test for Mailbox (#2713 )	1 year ago
Kunal Arora	2b7ecfc312	Add `quoteDispatch` to `IPostDispatchHook` (#2660 ) - `quoteDispatch` added to `IPostDispatchHook` interface and the relevant hooks: - StaticProtocolFee - OPStackHook - InterchainGasPaymaster - MerkleTreeHook - PausableHook (no tests) - DomainRoutingHook (no tests) - ConfigFallbackDomainRoutingHook - ConfigurableDomainRoutingHook (no tests) - `expectEmit` -> `expectCall` - Quote in V3 Yes Uint tests	1 year ago
Kunal Arora	6a32287f00	Fix forge tests post V3 (#2661 ) - fixes GasRouter expectRevert message - added TestMerkleRootHook for proof() and fixes MerkleRootMultisig test - fixes ERC5164 tests post v3 changes - added contract name to mailbox and abstractHook error messages - removed unnecessary tests for "message too large" - downgrade slither in actions to 0.3.0 because of their recent "missing inheritance" bug on main - V3 Yes Unit tests	1 year ago
Kunal Arora	760dce657b	Converting the OP stack hooks to transient storage version (#2632 ) - Updated the OP Stack tests for the Mailbox V3 transient storage version - Allowing OPStackHook to send msg.value at the time of message delivery (uses bit masking) - Added LibBit library, will be useful for all the auth hooks which can send `msg.value` - None - Fixes breaking OP Stack tests for https://github.com/hyperlane-xyz/issues/issues/513 - Also fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2410 No Unit tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz> Remove e2e and add yarn build to CI Adding protocol fees (#2640) - Adding protocol fee as a hook - None V3 Yes Fuzz tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	0e10306d4b	Adding Optimism Hook and dispatch with metadata (#2580 ) Use mailbox callback to authenticate messages in hooks where necessary (#2609) Co-authored-by: Kunal Arora <55632507+aroralanuk@users.noreply.github.com>	1 year ago
Yorke Rhodes	aa92fe37db	Fix crosschaincall duplicate warning (#2532 ) ### Description Fixes ``` duplicate definition - NotCrossChainCall() ```	1 year ago
Kunal Arora	7918a320c9	reset to mapping of mapping of messageiD and adding crosschain (#2506 ) ### Description - Reverting to using `mapping(bytes32 => mapping(bytes32 => bool)) public verifiedMessageIds` to prevent a malicious party from changing sender addresses in the ISM and causing liveness failiure for the honest party. - Adding `CrossChainEnabledOptimism` libraries and contracts locally instead of importing from OpenZeppelin's library (removed) - Renaming `AbstractNativeISM` to `AbstractHookISM` for flexibility and clarity. ### Drive-by changes Nope ### Related issues Fixes #2497 ### Backward compatibility Backward compatible? Yes Any infrastructure implications? No ### Testing Unit Tests	1 year ago
Kunal Arora	7c872bc449	5164 hook support (#2471 ) ### Description - Adding support for any ERC-5164 compatible bridge adapter to be added as a hook. See https://eips.ethereum.org/EIPS/eip-5164 for more details on the EIP and https://github.com/MultiMessageAggregation/multibridge for adapter implementations for different vendors. ### Drive-by changes - Switched mapping(bytes32 => mapping(address => true) to mapping(bytes32 => bytes) for verifedMessageIds because the last boolean is redundant in the AbtrsactNativeISM contract. ### Related issues - Fixes #2417 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	1 year ago
Kunal Arora	445da4fb0d	Adding Optimism native bridge support (#2316 ) ### Description - Adds support for the native Optimism bridge (L1->L2) to send messageID to be verified by the custom ISM on the rollup. - Only the smart contract component. - Outside Mailbox and needs to be called separately. - Uses Openzeppelin's CrossChainEnabled pattern for ensuring the right cross chain sender address. ### Drive-by changes - None ### Related issues - Fixes https://github.com/hyperlane-xyz/issues/issues/379 - Opens https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2409 - Related to https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2381 ### Backward compatibility - Needs modifying the relayer to read OptimismISM's storage to wait for `receivedEmitters` mapping to get updated before retrying `process` on the mailbox. ### Testing - Unit Tests with Foundry forks and Optimism's L1-L2 messenger contracts. --------- Co-authored-by: Asa Oines <asaoines@gmail.com>	1 year ago

20 Commits (34c6820cfdb87db9a3f08d627b999139cc911de5)