hyperlane-monorepo

Commit Graph

Author	SHA1	Message	Date
Kunal Arora	cbea29091d	fix:add forge tests for `TestSendReceiver` (#3055 ) ### Description - Added `TestSendReceiverTest` after having removed `testSendReceiver.hardhat-test.ts` (latter uses blockhash randomness and can fail in CI infrequently but very frustratingly whereas the former is fuzzed and conditionally checked) ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Fuzz tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	12 months ago
Kunal Arora	7919417ecd	feat: add routing delta for more granular routingIsm config updates (#3017 ) ### Description - add support for `routingIsmDelta` which filters out the incompatibility between the onchain deployed config and the desired config. - based on the above, you either update the deployed Ism with new routes, delete old routes, change owners, etc. - moduleMatchesConfig uses the same ### Drive-by changes - checking exclusion of domains in the onchain deployed config ### Related issues - fixes https://github.com/hyperlane-xyz/issues/issues/818 ### Backward compatibility Yes ### Testing Unit tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	12 months ago
Trevor Porter	1a64cef37e	Refactor key management in infra and key funder (#3023 ) ### Description * Remove the `bank` role, which we haven't used since the inception of abacus / hyperlane * Big changes to `key-utils.ts` so that there's a single source of truth on what kind of keys are used depending on the role & chain. Before this was sprinkled in a few different places * You can now get an object of `{ [chain]: { [role]: keys[] } }`, so it's super clear what kind of key relates to which chain. For example, before we would use the AWS-based relayer key for EVM chains, and then a GCP-based relayer key for non-EVM chains. But this wasn't really honored by key funder - it had no way of knowing to only fund the AWS relayer on EVM chains, and only fund the GCP relayer on non-EVM chains. Same situation for Kathy, where we want to use AWS keys for EVM chains but the GCP key for non-EVM chains * On v2 and prior to that we were using the AWS-based key for Kathy. Originally, we also launched v3 this way. However it was changed on v3 to use the GCP key for Kathy, causing us to fund both types of addresses on v3. This makes it more clear that we should be using the AWS-based key for Kathy on EVM chains ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	12 months ago
Kunal Arora	e06fe0b327	fix:enable `DefaultFallbackRoutingIsm` through non-factory deployment (#3009 ) ### Description - `DefaultFallbackRoutingIsm` needs the mailbox address which meant `DefaultFallbackRoutingIsmFactory` needed the mailbox address which is not ideal. So, I switched to non-factory deployments for this specific ISM type. - CLI does the ISM deployment inside core deployment instead of ISM first and core then. - Using the coreDeployer's `cachedAddresses` to store the latest ie toplevel ISM. ### Drive-by changes - fixed bug in `ismFactory.fromAddressMap` to not use the multiprovider filtered by contract map. This is undesirable as CLI user can provide chain selection and artifacts which doesn't include all the chains in the configs (and when we call `multiprovider.getDomainId` for the origin which may now be missing from the filtered MP, we get an error). ### Related issues - fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2895 ### Backward compatibility Yes ### Testing Manual through CLI	1 year ago
Yorke Rhodes	3501755816	Add storage layout diff checks (#2991 )	1 year ago
Yorke Rhodes	1a584ad8a4	Improve standard hook metadata API	1 year ago
Yorke Rhodes	b14f997810	Graduate to yarn 4 🧶 (#2899 ) Co-authored-by: J M Rossy <jm.rossy@gmail.com> Fixes https://github.com/hyperlane-xyz/issues/issues/687 Fixes #2228 Fixes https://github.com/hyperlane-xyz/issues/issues/704	1 year ago
OttBunn	5c3e2aa9c0	Migrate router test v3 (#2796 ) Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz> Fixes #2757	1 year ago
Kunal Arora	e90ae5a0d3	Remediate Trevor's comments (#2835 ) Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Yorke Rhodes	49fc06e65e	Support hook rotation in core deployer (#2834 )	1 year ago
Kunal Arora	a60ec18237	Unify overheardIgp and igp (#2766 ) ### Description - v3 uses the OverheadIgp as the default igp and removing an "inner" igp makes it simpler to deploy and interact with - `InterchainGasPaymaster` has a `setDestinationGasConfigs` which sets it the overhead and the oracle. - the gas overhead gets added it directly to the specified gasAmount. - Downstream changes to the `typescript/*` module in the igpConfig, checke, deployer, etc ### Drive-by changes None ### Related issues - precursor to https://github.com/hyperlane-xyz/issues/issues/623 - related to https://github.com/hyperlane-xyz/issues/issues/637 - missing changes to governor https://github.com/hyperlane-xyz/issues/issues/641 ### Backward compatibility Yes ### Testing Fuzz	1 year ago
Yorke Rhodes	8e4f2bbe18	Make immutable implementation of factories public (#2761 ) Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2759	1 year ago
Yorke Rhodes	bf3d3c4639	Make recipientIsm more robust (#2767 ) Fixes https://github.com/hyperlane-xyz/issues/issues/629	1 year ago
Yorke Rhodes	c91f589e4e	Add unenroll to Router (#2760 ) Fixes https://github.com/hyperlane-xyz/issues/issues/630	1 year ago
Yorke Rhodes	1ecfc46ce2	v3 Router SDK changes (#2752 ) ### Description - Reorganize solidity directory structure for clarity - Updates router apps (token and helloworld) with changes from https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2749 ### Drive-by changes - Merges the hyperlane-token package to solidity and sdk ### Backward compatibility No (removed token package) ### Testing - Unit Tests - Instrumented coverage	1 year ago
Yorke Rhodes	fcfecdf250	Update router implementations for v3 (#2749 )	1 year ago
Kunal Arora	03c92e1e34	Minor internal review remediation 1 (#2748 )	1 year ago
Kunal Arora	f783c4e96f	add globalHookMetadata (#2743 ) ### Description - Consolidating IGPMetadata and OPStackMetadata to versioned GlobalHookMetadata - Add `supportMetadata` to `IPostDispatchHook` - Metadata Schema [0:1] variant [2:33] msg.value [34:65] Gas limit for message (IGP) [66:85] Refund address for message (IGP) [86:] Custom metadata ### Drive-by changes None ### Related issues - fixes https://github.com/hyperlane-xyz/issues/issues/610 ### Backward compatibility No ### Testing Unit tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	f0e4f2b89b	Prevent invalid destination griefing for the relayer (#2703 ) ### Description - Adds destinationDomain to the `GasPayment` event - recording destination domain as `destination` while reading events for the relayer ### Drive-by changes - none ### Related issues - fixes https://github.com/hyperlane-xyz/issues/issues/475 ### Backward compatibility No, change in event emitted and relayer indexing ### Testing - Unit --------- Signed-off-by: -f <kunalarora1729@gmail.com> Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	7312a6f6db	add InsertedIntoTree event (#2736 ) ### Description - Adding "InsertedIntoEvent" for standalone indexing of events by the agents ### Drive-by changes None ### Related issues #2313 ### Backward compatibility Yes ### Testing Unit tests	1 year ago
Kunal Arora	43ba1b46f1	Running forge with latest solc (#2729 ) ### Description - Removed contracts-bedrock contracts dependency from eth-optimism (which was forcing us to use 0.8.15) - Added local minimal interfaces for the CrossDomainMessenger contract ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Unit tests --------- Signed-off-by: -f <kunalarora1729@gmail.com> Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Yorke Rhodes	af88ae66c3	Fix rebase	1 year ago
Yorke Rhodes	f7dbc71335	Update multisig ISMs for merkle hooks (#2722 ) Fixes https://github.com/hyperlane-xyz/issues/issues/591	1 year ago
Yorke Rhodes	7309f770ef	Add forge test for Mailbox (#2713 )	1 year ago
Kunal Arora	a07a993089	Add aggregation hook for V3 (#2667 ) ### Description - AggregationHook for v3 ### Drive-by changes None ### Related issues v3 https://github.com/hyperlane-xyz/issues/issues/514 ### Backward compatibility Yes ### Testing Always be fuzzing	1 year ago
Yorke Rhodes	467e01a6c7	Add deployed block numbers to indexable contracts (#2672 ) Fixes #2004	1 year ago
Kunal Arora	2b7ecfc312	Add `quoteDispatch` to `IPostDispatchHook` (#2660 ) - `quoteDispatch` added to `IPostDispatchHook` interface and the relevant hooks: - StaticProtocolFee - OPStackHook - InterchainGasPaymaster - MerkleTreeHook - PausableHook (no tests) - DomainRoutingHook (no tests) - ConfigFallbackDomainRoutingHook - ConfigurableDomainRoutingHook (no tests) - `expectEmit` -> `expectCall` - Quote in V3 Yes Uint tests	1 year ago
Kunal Arora	6a32287f00	Fix forge tests post V3 (#2661 ) - fixes GasRouter expectRevert message - added TestMerkleRootHook for proof() and fixes MerkleRootMultisig test - fixes ERC5164 tests post v3 changes - added contract name to mailbox and abstractHook error messages - removed unnecessary tests for "message too large" - downgrade slither in actions to 0.3.0 because of their recent "missing inheritance" bug on main - V3 Yes Unit tests	1 year ago
Kunal Arora	760dce657b	Converting the OP stack hooks to transient storage version (#2632 ) - Updated the OP Stack tests for the Mailbox V3 transient storage version - Allowing OPStackHook to send msg.value at the time of message delivery (uses bit masking) - Added LibBit library, will be useful for all the auth hooks which can send `msg.value` - None - Fixes breaking OP Stack tests for https://github.com/hyperlane-xyz/issues/issues/513 - Also fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2410 No Unit tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz> Remove e2e and add yarn build to CI Adding protocol fees (#2640) - Adding protocol fee as a hook - None V3 Yes Fuzz tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	f38660e70a	Modifying IGP to be a hook (#2638 ) - IGP as a standalone hook, implementing postDispatch to call payForGas directly - Setting a DEFAULT_GAS_USAGE if metadata not specified and message.senderAddress() as refund address if not specified. - None Fixes https://github.com/hyperlane-xyz/issues/issues/511 Yes, same interface as the previous IGP but for Mailbox V3 Unit Tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	0e10306d4b	Adding Optimism Hook and dispatch with metadata (#2580 ) Use mailbox callback to authenticate messages in hooks where necessary (#2609) Co-authored-by: Kunal Arora <55632507+aroralanuk@users.noreply.github.com>	1 year ago
Yorke Rhodes	ff2a495389	Add pausable ism (#2675 )	1 year ago
Yorke Rhodes	e582357de8	Make Domain Routing ISM enumerable (#2644 )	1 year ago
Kunal Arora	f01dfd005f	Add custom error message for when gasOracle not configured for domain in IGP (#2656 ) ### Description - Better error message for when gas oracle for a specific domain isn't configured ### Drive-by changes - None ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2438 ### Backward compatibility Yes ### Testing - Unit tests	1 year ago
J M Rossy	465112db6f	Refactor utils package (#2550 ) ### Description - Reorganize code into separate files - Move in utils from other packages - Fix export structure - Add multi-protocol address utils ### Drive-by changes Lint fix in token package ### Related issues Pre-req for #2503 ### Backward compatibility No, some exports have been removed from the SDK and moved to utils	1 year ago
Yorke Rhodes	aa92fe37db	Fix crosschaincall duplicate warning (#2532 ) ### Description Fixes ``` duplicate definition - NotCrossChainCall() ```	1 year ago
Kunal Arora	7918a320c9	reset to mapping of mapping of messageiD and adding crosschain (#2506 ) ### Description - Reverting to using `mapping(bytes32 => mapping(bytes32 => bool)) public verifiedMessageIds` to prevent a malicious party from changing sender addresses in the ISM and causing liveness failiure for the honest party. - Adding `CrossChainEnabledOptimism` libraries and contracts locally instead of importing from OpenZeppelin's library (removed) - Renaming `AbstractNativeISM` to `AbstractHookISM` for flexibility and clarity. ### Drive-by changes Nope ### Related issues Fixes #2497 ### Backward compatibility Backward compatible? Yes Any infrastructure implications? No ### Testing Unit Tests	1 year ago
Alex	0ddaf1c5cc	Fix incorrect getRemoteInterchainAccount derivation (#2446 ) ### Description A minor change to how we deploy InterchainAccountRouter's and a fix for remote ICA address derivation. The fix is outlined clearly in #2383 by Nam but essentially by assigning the `implementation` & `bytecode` variables in the constructor of `InterchainAccountRouter`, we are unable to correctly access them in `getRemoteInterchainAccount` if using a proxy. By moving initialisation of these variables to `initialize` we correctly store the values in the proxy storage, not the implementation storage. ### Drive-by changes The `InterchainAccountRouter` should no longer be used unproxied. ### Related issues - Fixes #2383 ### Backward compatibility No, new ICA deploy ### Testing - [x] Unit Tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	7c872bc449	5164 hook support (#2471 ) ### Description - Adding support for any ERC-5164 compatible bridge adapter to be added as a hook. See https://eips.ethereum.org/EIPS/eip-5164 for more details on the EIP and https://github.com/MultiMessageAggregation/multibridge for adapter implementations for different vendors. ### Drive-by changes - Switched mapping(bytes32 => mapping(address => true) to mapping(bytes32 => bytes) for verifedMessageIds because the last boolean is redundant in the AbtrsactNativeISM contract. ### Related issues - Fixes #2417 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	1 year ago
Kunal Arora	445da4fb0d	Adding Optimism native bridge support (#2316 ) ### Description - Adds support for the native Optimism bridge (L1->L2) to send messageID to be verified by the custom ISM on the rollup. - Only the smart contract component. - Outside Mailbox and needs to be called separately. - Uses Openzeppelin's CrossChainEnabled pattern for ensuring the right cross chain sender address. ### Drive-by changes - None ### Related issues - Fixes https://github.com/hyperlane-xyz/issues/issues/379 - Opens https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2409 - Related to https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2381 ### Backward compatibility - Needs modifying the relayer to read OptimismISM's storage to wait for `receivedEmitters` mapping to get updated before retrying `process` on the mailbox. ### Testing - Unit Tests with Foundry forks and Optimism's L1-L2 messenger contracts. --------- Co-authored-by: Asa Oines <asaoines@gmail.com>	1 year ago
Yorke Rhodes	50f04db1fa	Make merkle proofs optional on multisig ISM (#2173 ) ### Description Validators currently sign `(root, index)` checkpoints and during verification, a `message` is passed as calldata, an `id()` is derived, and a `proof` of `id()` at `index` in `root` is verified This provides “all or nothing” censorship resistance guarantees because a validator can only sign roots to allow any contained messages to be processed. We have considered alternatives where validators sign `message` directly and we lose censorship resistance in exchange for eliminating merkle proof verification gas costs. However, if validators sign `(root, index, message)` tuples, we can skip merkle proof verification on the destination chain while still maintaining censorship resistance by providing two valid metadata formats: 1. existing validator signatures and merkle proof verification of inclusion 2. including merkle proof verification for pathway where validators are censoring `message` It’s worth noting the validator is required to index event data to produce this new signature format. However, this does not require historical indexing and new validators being spun up can simply begin indexing from tip. See https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2187 for validator changes See https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2248 for relayer and e2e test changes ### Drive-by changes Merkle index also optional ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2192 ### Backward compatibility - new ISM deployment is necessary (we could upgrade implementation in theory) - Validator and relayer upgrades ### Testing Unit (fuzz) Tests, E2E tests	2 years ago
Asa Oines	ec63ed19c5	Fix CI flakiness (#2269 ) ### Description - Don't panic if E2E test fails to fetch a metric - Run coverage commands sequentially ### Drive-by changes - Cleans up some lint errors in forge tests	2 years ago
Asa Oines	1e9d0be9b3	Fix DomainRoutingIsm tests (#2255 ) ### Description Fixes a bug in the DomainRoutingIsm tests that curiously only started showing in CI a few days ago. ### Drive-by changes None	2 years ago
Asa Oines	6b058e7014	Add checkConfig to HyperlaneRouterDeployer (#2156 ) ### Description Adds a pre-deploy check to HyperlaneDeployer, with an implementation for HyperlaneRouterDeployer that does a best-effort check that the ISM and IGP are properly configured for each chain. ### Drive-by changes - Move TestIsm to TestMultisigIsm for compatibility with pre-deploy checks ### Related issues - Fixes #2038 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Manual	2 years ago
Asa Oines	f8d645e580	Add RoutingIsm (#1985 ) ### Description This PR adds `IRoutingIsm` and three implementations: - AbstractRoutingIsm, which folks building RoutingIsms can inherit from - DomainRoutingIsm, which routes based on message origin - InterchainAccountIsm, which routes based on the ISM in the InterchainAccountMessage ### Drive-by changes - Some related testing changes ### Related issues - Fixes #1521 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Yorke Rhodes	55f40ad760	Merge audit v2 remediation to main (#1727 ) ### Description Merge [`audit-v2`](https://github.com/hyperlane-xyz/hyperlane-monorepo/releases/tag/audit-v2) into `main` See [changelog](`034e75b632`...audit-v2)	2 years ago
Asa Oines	96e03b1681	Remove Create2Factory and associated deployer code (#2064 ) ### Description As discussed offline, the complexity of maintaining consistent addresses across chains is no longer worth it, especially as consistent addresses cannot be maintained across PI chains. ### Drive-by changes - Move governors into infra/src/govern - Take initialization args list as opposed to abi encoded args in deployer - Do not initialize IGP in the constructor since we need to initialize the proxy ### Related issues - Fixes #2040 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ None	2 years ago
Asa Oines	63558af85d	Use interfaces in agents (#2022 ) ### Description Move agents to use contract interfaces artifacts rather than the artifacts themselves. This ensures we don't anything that we can't guarantee is in every implementation of that interface. Particularly relevant for IGPs and ISMs. ### Drive-by changes - Moves `solidity/interfaces` to `solidity/contracts/interfaces` so that their artifacts can be used in `update_abis.sh` ### Related issues - #1757 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ None	2 years ago
Yorke Rhodes	6f7495320b	Regenerate test fixtures and unskip hardhat tests (#2035 )	2 years ago
Asa Oines	f8b04029ac	Fix flaky solidity test (#2013 ) ### Description It's failing during certain fuzzer conditions b/c the assertion is made before the assumption.	2 years ago

1 2 3

109 Commits (5c8d483b371714875b94eb8945d5a919cfcdaf4c)