hyperlane-monorepo

Commit Graph

Author	SHA1	Message	Date
Kunal Arora	2760da1ded	fix: ensure no duplicate signatures verified for `AbstractWeightedMultisigIsm.verify()` (#4468 ) ### Description - There's a bug in the verify function of `AbstractWeightedMultisigIsm` that an attacker might use to bypass the verification of multiple signatures. The code tried to check the duplication of the signers if not found, but the code does not increment validatorIndex when the recovered signer matches to the stored signer. For instance: - validatorsAndThresholdWeight returns [A, B, C, D] - an attacker uses signatures as [sig from A, sig from A, sig from A, sig from A, ...] or [sig from B, sig from B, …] Fix is to add a ++validatorIndex at the end of the for loop implies we don't allow the next signer to be the same as the signer we just verified. ### Drive-by changes None ### Related issues From Chainlight's audit findings ### Backward compatibility We haven't deployed these contracts yet on testnet/mainnet ### Testing Fuzz testing	1 month ago
Kunal Arora	d396e2c553	feat: add `IStaticWeightedIsm` implementation (#4170 ) ### Description - Adding the static variation of the IWeightedIsm config where you configure validators with their corresponding weights and store it as bytecode. ### Drive-by changes None ### Related issues - fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4160 ### Backward compatibility Yes ### Testing Fuzz tests	4 months ago
Yorke Rhodes	69de68a66e	Multisig and Aggregation ISM Metadata Encoding (#3701 ) ### Description - Implement multisig metadata encoding/decoding - Implement aggregation metadata encoding/decoding - Generates test metadata fixtures from solidity unit tests - Test encoders using fixtures ### Drive By - Make CI tests run topologically ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/3449 - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/3451 ### Backward compatibility Yes ### Testing Unit Tests	7 months ago
Yorke Rhodes	b14f997810	Graduate to yarn 4 🧶 (#2899 ) Co-authored-by: J M Rossy <jm.rossy@gmail.com> Fixes https://github.com/hyperlane-xyz/issues/issues/687 Fixes #2228 Fixes https://github.com/hyperlane-xyz/issues/issues/704	1 year ago
Yorke Rhodes	8e4f2bbe18	Make immutable implementation of factories public (#2761 ) Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2759	1 year ago
Yorke Rhodes	1ecfc46ce2	v3 Router SDK changes (#2752 ) ### Description - Reorganize solidity directory structure for clarity - Updates router apps (token and helloworld) with changes from https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2749 ### Drive-by changes - Merges the hyperlane-token package to solidity and sdk ### Backward compatibility No (removed token package) ### Testing - Unit Tests - Instrumented coverage	1 year ago
Yorke Rhodes	fcfecdf250	Update router implementations for v3 (#2749 )	1 year ago
Yorke Rhodes	f7dbc71335	Update multisig ISMs for merkle hooks (#2722 ) Fixes https://github.com/hyperlane-xyz/issues/issues/591	1 year ago
Yorke Rhodes	7309f770ef	Add forge test for Mailbox (#2713 )	1 year ago
Kunal Arora	6a32287f00	Fix forge tests post V3 (#2661 ) - fixes GasRouter expectRevert message - added TestMerkleRootHook for proof() and fixes MerkleRootMultisig test - fixes ERC5164 tests post v3 changes - added contract name to mailbox and abstractHook error messages - removed unnecessary tests for "message too large" - downgrade slither in actions to 0.3.0 because of their recent "missing inheritance" bug on main - V3 Yes Unit tests	1 year ago
Kunal Arora	0e10306d4b	Adding Optimism Hook and dispatch with metadata (#2580 ) Use mailbox callback to authenticate messages in hooks where necessary (#2609) Co-authored-by: Kunal Arora <55632507+aroralanuk@users.noreply.github.com>	1 year ago
Yorke Rhodes	50f04db1fa	Make merkle proofs optional on multisig ISM (#2173 ) ### Description Validators currently sign `(root, index)` checkpoints and during verification, a `message` is passed as calldata, an `id()` is derived, and a `proof` of `id()` at `index` in `root` is verified This provides “all or nothing” censorship resistance guarantees because a validator can only sign roots to allow any contained messages to be processed. We have considered alternatives where validators sign `message` directly and we lose censorship resistance in exchange for eliminating merkle proof verification gas costs. However, if validators sign `(root, index, message)` tuples, we can skip merkle proof verification on the destination chain while still maintaining censorship resistance by providing two valid metadata formats: 1. existing validator signatures and merkle proof verification of inclusion 2. including merkle proof verification for pathway where validators are censoring `message` It’s worth noting the validator is required to index event data to produce this new signature format. However, this does not require historical indexing and new validators being spun up can simply begin indexing from tip. See https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2187 for validator changes See https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2248 for relayer and e2e test changes ### Drive-by changes Merkle index also optional ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2192 ### Backward compatibility - new ISM deployment is necessary (we could upgrade implementation in theory) - Validator and relayer upgrades ### Testing Unit (fuzz) Tests, E2E tests	2 years ago
Asa Oines	f8d645e580	Add RoutingIsm (#1985 ) ### Description This PR adds `IRoutingIsm` and three implementations: - AbstractRoutingIsm, which folks building RoutingIsms can inherit from - DomainRoutingIsm, which routes based on message origin - InterchainAccountIsm, which routes based on the ISM in the InterchainAccountMessage ### Drive-by changes - Some related testing changes ### Related issues - Fixes #1521 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Asa Oines	63558af85d	Use interfaces in agents (#2022 ) ### Description Move agents to use contract interfaces artifacts rather than the artifacts themselves. This ensures we don't anything that we can't guarantee is in every implementation of that interface. Particularly relevant for IGPs and ISMs. ### Drive-by changes - Moves `solidity/interfaces` to `solidity/contracts/interfaces` so that their artifacts can be used in `update_abis.sh` ### Related issues - #1757 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ None	2 years ago
Asa Oines	e8d90775f7	Add Aggregation ISM (#1737 ) ### Description This PR introduces the Aggregation ISM, which requires interchain messages to be verified by an m-of-n ISM set. This PR also introduces a new MultisigISM, which does not make use of the "commitment" optimization in its metadata. The previous MultisigISM has been moved to LegacyMultisigISM. Both AggregationISM and MultisigISM have abstract contracts that require `valuesAndThreshold` implementations. This PR implements versions with static m-of-n sets, using the EIP-3448 MetaProxy standard. These implementations are intended to be combined with a future RoutingISM implementation to replace LegacyMultisigISM. ### Drive-by changes - genhtml in solidity code coverage ### Related issues - Fixes #1522 ### Backward compatibility _Are these changes backward compatible?_ Yes ### Testing _What kind of testing have these changes undergone? Unit Tests	2 years ago

15 Commits (5fd4267e7949f4499c28bf9ef31552a965f30fcd)