hyperlane-monorepo

Commit Graph

Author	SHA1	Message	Date
Daniel Savu	c402185fd3	Solana and Nautilus RC validators (#2685 ) ### Description Adds addresses of the rc validator keys for solana, nautilus and their testnet counterparts ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	1 year ago
josedev-union	76467daf3a	feat(helm): Support chain signer key as external secret (#2543 ) ### Description This PR sets chain signer keys in the external secret. related to https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2458 ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> Co-authored-by: josedev-union <josedev-union@users.noreply.github.com> Co-authored-by: Nam Chu Hoai <nambrot@googlemail.com>	1 year ago
Trevor Porter	8127fa5aac	Deploy proteustestnet, nautilus, solanadevnet (again), and solana (#2646 ) ### Description just opening for image for now ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> --------- Co-authored-by: Daniel Savu <23065004+daniel-savu@users.noreply.github.com>	1 year ago
Mattie Conover	e4220f8412	Better node env testing (#2677 ) Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
josedev-union	70c1ceebbd	chore: Use templating for datasource in grafana dashboard file (#2542 ) ### Description This PR uses templating for datasource. i.e. no need to keep <prometheus> inside the dashboard json file which should be manually replaced by users. ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> Co-authored-by: josedev-union <josedev-union@users.noreply.github.com> Co-authored-by: Mattie Conover <git@mconover.dev>	1 year ago
Yorke Rhodes	ff2a495389	Add pausable ism (#2675 )	1 year ago
Mattie Conover	389029dafb	Agent Config Base Parsing (#2665 ) ### Description This is a big one for #2215... 1. Splits the parsing of configs from the config definitions to support both the old, new, and future parsers simultaneously. (We might want to rename it from parser to config format or something; not set on this name). 2. Implements the new config format without switching to it or enabling it. This means this PR does introduce dead code that is going to be used in the next PR. ### Drive-by changes - Deleted some unused (or single use) macros defined in hyperlane base - Updated the definition of the config parsing trait to simplify implementation - Added some more ergonomic methods of handling errors in config parsing - Removed any raw `unwrap()` I noticed since these cause difficult to debug errors in prod. - Added some additional validation to catch code mistakes in config path definitions ### Related issues - Progress on #2215 - Comes after #2658 ### Backward compatibility Yes ### Testing Manual (E2E only for now to make sure I did not break the old config format)	1 year ago
Mattie Conover	7c989e7eaa	Agent Config Parsing Casing Fixes (#2666 ) ### Description This is a fix for an issue in the arguments and environment where we are unable to correctly support attribute names due to the casing. The main issue cannot be fully fixed practically by this PR because it would cause some configuration cases to break. For now it adds manual exceptions for the command line argument case and leaves envs as they were. There are then two new parsers that can be used with the new config format. ### Drive-by changes Also adds this to argument parser since it was trivial to copy/paste it and it will allow us to harden parsing when we switch over. ### Related issues - Fixes #2662 - Fixes #2663 - Progress on #2215 ### Backward compatibility Yes ### Testing Unit Tests	1 year ago
josedev-union	0d3dd6076d	helm: Support different signer key per a chain in relayer (#2555 ) ### Description This PR supports a different signer key per a chain in relayer. ### Drive-by changes Add env var `HYP_BASE_RELAYCHAINS` ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> --------- Co-authored-by: josedev-union <josedev-union@users.noreply.github.com>	1 year ago
Yorke Rhodes	e582357de8	Make Domain Routing ISM enumerable (#2644 )	1 year ago
Yorke Rhodes	f1dabb6498	Default to multiprovider signer owner of routers (#2577 )	1 year ago
Yorke Rhodes	1baa12ebe7	Migrate from default ISM config object to cached addresses map (#2576 ) Caches the aggregation ISM addresses in the default ISM config for verification of governance proposal	1 year ago
Mattie Conover	d88fd4cd16	Agent Config Typescript Definitions (#2658 ) ### Description Updates the typescript definitions based on the rust code. This is the first in a series of PRs for handling Rust config streamlining. ### Drive-by changes - A couple of the core types I refined, please validate the definitions. ### Related issues Progress on #2215 Relates to #2491 ### Backward compatibility Yes ### Testing Unit Tests	1 year ago
Daniel Savu	51b81b84fa	fix(sealevel): data encoding in `set_return_data` (#2635 ) ### Description Suffixes `set_return_data` bytes with a non-zero byte to prevent a truncation bug ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2589 ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> --------- Co-authored-by: Trevor Porter <trkporter@ucdavis.edu>	1 year ago
Trevor Porter	510588825a	Add SetInterchainGasPaymaster instruction to warp route programs (#2657 ) ### Description Sadly I missed adding an instruction to allow a warp route owner to set the IGP. This adds that. We're deploying a warp route without an IGP for now because the UI hasn't been updated to work with IGP payments yet (which is required as the UI needs to handcraft specific accounts that are passed in). We'll probably wanna flip the switch to charging gas at some point, so want to make sure we're able to do that The way the tests are set up involves a lot of code duplications - sorry 🙈 - we should revisit at some point as now isn't the time ### Drive-by changes n/a ### Related issues Related #2613 ### Backward compatibility Fully backward compatible ### Testing Unit / functional tests	1 year ago
Daniel Savu	0178eeca08	fix(sealevel): use `overflow-checks` in the release profile (#2636 ) ### Description Uses `overflow-checks` in the release profiles of all sealevel programs and libraries, to revert txs when this happens. ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2590 ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	1 year ago
Kunal Arora	f01dfd005f	Add custom error message for when gasOracle not configured for domain in IGP (#2656 ) ### Description - Better error message for when gas oracle for a specific domain isn't configured ### Drive-by changes - None ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2438 ### Backward compatibility Yes ### Testing - Unit tests	1 year ago
Daniel Savu	326eced987	Revert "refactor(IndexMode): remove `IndexRange`… (#2562 )" (#2655 ) This reverts commit `127294decc`, to include a cursor bugfix in main and remove an IGP indexing bug added by that PR. ### Description <!-- What's included in this PR? --> ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	1 year ago
Mattie Conover	644db5eee1	Remove unused tracing logic (#2639 ) ### Description When I was working on #2215 I noticed that we are not using either zipkin or jaeger at all and possibly never have. Ripping these out to reduce dead code and also simplify our package dependencies. ### Drive-by changes None ### Related issues Discovered through #2215 ### Backward compatibility Yes - we were not using these features and did not document their existence ### Testing Manual - Verified that when running deploy-agents, the generated configs do not have jaeger or zipkin enabled on `main` and then tested to make sure they still work in this branch	1 year ago
Mattie Conover	041cf92d57	Fix insertion errors for txn and block (#2629 ) ### Description This resolves the insertion conflict that is being caused by #2246 that introduced multiple concurrent tasks to scrape. This does not address the underlying concurrency issue I discovered, however. Please review the issue comments for more details. ### Drive-by changes - Cleans up logs a bit (This was useful during testing and I think is useful globally) - Removed an unused file ### Related issues Fixes hyperlane-xyz/issues#493 ### Backward compatibility Yes ### Testing Manual	1 year ago
Trevor Porter	f5b59c9a30	Remove zbctestnet (#2633 ) ### Description No longer needed because of the updated Eclipse plan - the RPC URL was shut down as well ### Drive-by changes no ### Related issues n/a ### Backward compatibility removes zbctestnet chain ### Testing deployed, builds	1 year ago
Trevor Porter	c53c1f7059	Sealevel IGP connection client support, warp routes support gas payments (#2613 ) ### Description * Adds IGP configuration to the connection client * Adds gas router, which are used by warp routes to have configured gas amounts * Adds resizing of the HyperlaneToken account to warp routes (useful for remote routers & gas routers which can change size) * Adds IGP configuration to warp routes * Pays for gas in warp routes is an IGP is configured * Updates deploy tooling for warp routes to allow the IGP to be set, defaulting to the overhead IGP if one isn't configured ### Drive-by changes * Removed the CLI command `token init`, which we never really expect to be used directly anymore and is just dead weight. This instead happens in `warp-route deploy` behind the scenes * Moved IGP tests into their own crate to avoid a cyclical dependency situation between the IGP crate and test-utils. This is why `mailbox-test` exists too ### Related issues * Fixes #2494 ### Backward compatibility The storage layout of the warp route programs changes with this. So this is incompatible with existing sealevel testnet warp route deployments ### Testing e2e test, unit tests	1 year ago
Mattie Conover	8cbfd3cbc0	Support 64-byte txn ids (attempt 2) (#2612 ) ### Description Adds support to TxOutcome for 512-bit ids and to log meta to support Solana. Now that we have primitive types in our crate we were able to create a better solution than before which just stores the EVM 256bit hashes inside of the 512bit one with leading zeros rather than needing to over engineer an enum container for it. ### Drive-by changes - Removed some dead code - Improved primitive type support for 512bit types - Improved serialization support for 512bit types ### Related issues - Fixes #2252 - Replaces #2256 ### Backward compatibility _Are these changes backward compatible?_ Yes-ish, changes one of the internal database key strings. At standup we discussed the possibility of migrating the data and concluded that was a can of worms we did not want to open. _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit tests	1 year ago
Mattie Conover	5d8a2e568c	Validator announce signers (#2617 ) ### Description This handles a bug where we did not default the chain signer to the validator signature for EVM chains and also handles the case where we might try to announce without setting a chain signer for other chains. ### Drive-by changes Not really a change but I looked into #2457 and I noticed the validators already check that signers are set for all destination chains so I think the error was just for validators which this PR fixes. ### Related issues - Fixes #2458 - Fixes #2457 ### Backward compatibility Yes ### Testing Unit Tests	1 year ago
Mattie Conover	a5e1815746	Rust updates (#2619 ) ### Description Let this one slip a while. Updates our version of rust and as many packages as did not conflict with solana. I think we are going to need to figure something better out going forward with solana since if we have a couple more envs like this, it is going to make updates very hard. ### Drive-by changes None ### Related issues General Maintenance ### Backward compatibility Yes ### Testing Manual & Unit Tests	1 year ago
Daniel Savu	032e2492c4	fix: only run cargo fmt hook when rs files changed (#2620 ) ### Description The `cargo fmt` pre-commit hook runs regardless of whether any `.rs` files have changed and this is interfering with unrelated workflows. This reduces the scope of the hook to commits with nonempty rust diffs. ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->	1 year ago
Mattie Conover	dce883d3a1	Run rust fmt on pre-commit (#2608 ) ### Description Tired of the workflow telling you to run `cargo fmt`? Worry no more, now on commit all your rust code will get checked so you don't have to wait for the pipeline to fail. ### Drive-by changes None ### Related issues ### Backward compatibility Yes ### Testing manual	1 year ago
Mattie Conover	19838b11c6	E2E test `pkill` anvil (#2607 ) ### Description Fixes a minor bug when testing locally where sometimes a failure in the e2e test will not correctly clean up anvil. This just runs `pkill -SIGKILL anvil` to clean it up if it was running. ### Drive-by changes None ### Related issues ### Backward compatibility Yes ### Testing Manual	1 year ago
Mattie Conover	9045f8362e	IGP Tooling (#2602 ) ### Description Adds support for deploying IGPs and initial setup. Also extends the E2E tests to support these changes. - Deploy an IGP - Configure gas oracle data on IGPs - Configure gas overhead amounts for overhead IGP - Adds new config files to support the above - Adds support for u128 in `serde_json` ### Drive-by changes - Minor code cleanup around unused build cmd args - Refactored transaction submission to prevent common errors. - Cleaned up arg passing in the core commands ### Related issues Fixes #2500 ### Backward compatibility Yes-ish, slightly changes some sealevel commands but mostly the same. See the e2e test if in doubt. ### Testing Manual Unit Tests --------- Co-authored-by: Trevor Porter <trkporter@ucdavis.edu>	1 year ago
J M Rossy	d901ca2c6f	Minimal multi-protocol SDK support (#2529 ) ### Description - Create MultiProtocolProvider - Create ProviderType enum and TypedProvider - Add viem, solana, and ethers6 dev deps to SDK - Upgrade Typescript and Eslint across monorepo (required for Viem) - Break out metadata mgmt code into new ChainMetadataManager class - Implement basic MultiProtocolApp and MultiProtocolRouterApp - Create Evm and Sealevel router adapters - Refactor contract types into separate file to avoid circular dep ### Related issues https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2503 ### Backward compatibility Yes	1 year ago
J M Rossy	465112db6f	Refactor utils package (#2550 ) ### Description - Reorganize code into separate files - Move in utils from other packages - Fix export structure - Add multi-protocol address utils ### Drive-by changes Lint fix in token package ### Related issues Pre-req for #2503 ### Backward compatibility No, some exports have been removed from the SDK and moved to utils	1 year ago
Trevor Porter	2fc4903a90	Add `unique_gas_payment_pubkey` to GasPaymentData (#2583 ) ### Description Followup to #2574, we need this to verify gas payment PDAs Also fixes DiscriminatorPrefixed ### Drive-by changes n/a ### Related issues n/a ### Backward compatibility Different gas payment data account format, but hasn't been deployed so all is good ### Testing unit / functional tests	1 year ago
Mattie Conover	9ed3a24902	Solana e2e tests (#2578 ) ### Description Adds support for testing solana with the e2e tests. This involves 1) Downloading the pre-built solana cli tools 2) Setting up the solana configuration 3) Downloading the pre-built solana programs we need (see https://github.com/hyperlane-xyz/solana-program-library/releases/) 4) The solana programs in the repo 5) Start the solana validator 6) Deploy the solana programs 7) Deploy a warp route 8) Initialize the multisig ism and validator announce 9) Initialize a transfer 10) Wait for the message to be delivered In addition these were "woven" in with the existing E2E test logic, so for instance we only run one new validator and the existing relayer was extended to support these additional chains. This will make it much easier later on to support testes between environments. ### Drive-by changes - Fix a bug in the relayer when trying to index the mailbox - Add support in the hyperlane sealevel CLI for custom solana config paths - Fix a linker error on linux causes by not specifying `no-entrypoint` - Cleaned up unnecessary `no-entrypoint` features in libraries - Minor refactor to how we run commands to avoid arg passing - Created an easy way to define tasks that run asyncly `as_task` - Split up main logic flow into a couple files for easier reading - Use mold linker to speed up builds (well, the linking part) - Removed support for `log_all` to simplify code pathways - Added context when a child process ends unexpectedly for easier debugging - Fixed a bug in the validator where it would infinitely retry to send an announcement on failure without waiting - Cleaned up solana configs - Fixed processes hanging on exit (very annoying when testing locally since you have to manually go kill them) - Added stderr logging to the hyperlane sealevel CLI subprocess calls ### Related issues Fixes #2415 ### Backward compatibility Yes ### Testing Manual	1 year ago
Daniel Savu	127294decc	refactor(IndexMode): remove `IndexRange`, use default index mode per env (#2562 ) ### Description Removes the `index_mode` config field, default to whichever mode is currently supported by our existing envs. Doing this allows for safely removing runtime checks to see if the correct index mode was configured. Additional work is required to support multiple indexing modes per env. Check this discord thread for the full discussion: https://discord.com/channels/935678348330434570/961711527092682783/1133347733411987568 ### Drive-by changes - `IndexRange` is removed entirely and replaced by `RangeInclusive<u32>` - Moves `is_arbitrum_nitro` into a bigger existing `impl HyperlaneDomain` block for clarity ### Related issues This is part 1 of https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2511 ### Backward compatibility Yes ### Testing Relies on existing e2e tests	1 year ago
jaehunkim	018f0182a6	Fix hardhat test script in typescript/sdk/package.json (#2483 ) ### Description The previous `test:hardhat` script was not correctly finding and testing the `.hardhat-test.ts` files in the `src` directory. This commit updates the script to correctly find these files and pass them to the `hardhat test` command. Now, all Hardhat tests in the `src` directory and its subdirectories will be correctly run when the `test:hardhat` script is used. ### Testing Unit Tests Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Trevor Porter	21acccac3d	Sealevel IGP program (#2574 ) ### Description * Sealevel IGP program * Includes tests * Minor changes to some other Sealevel program tests to use some common test utils ### Drive-by changes n/a ### Related issues #2217 ### Backward compatibility Yes ### Testing Unit / functional	1 year ago
Nam Chu Hoai	07d3acc5e9	Update testnet3 test recipients (#2582 )	1 year ago
Trevor Porter	c7ad0f4433	Fix deploying validators when there's an empty validator set (#2565 ) ### Description Turns out when there aren't any validators in the set, which is the case for solanadevnet & zbctestnet on the RC context (https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/infra/config/environments/testnet3/validators.ts#L195), the helm value `hyperlane.validator.configs` wasn't being overridden with CLI value args. So the `configs` in values.yaml, which has a length of 1 with some keys and empty values to illustrate (part of) the expected format of the config, was being used. So then in the Helm template we'd end up iterate through the configs of len 1 :( The fix is to just set the default `configs` to `[]` I also considered adding a check to just skip the chain if the validator set is 0, because there's usually no use in deploying them anyways. But we may be deploying to a chain that used to have a non-zero validator set that we now want to be 0, so we may as well just deploy it and deal with the fact that there will be some helm releases relating to a validator set of 0 🤷 ### Drive-by changes n/a ### Related issues n/a ### Backward compatibility backward compatible ### Testing deployed	1 year ago
Kunal Arora	3a09f54b20	Updating the relayer and validator images to 2023-07-25 version (#2569 ) ### Description - Updating both rc and hyperlane testnet3 and mainnet2 versions for relayers and validators to `ed7569d-20230725-171222` image which has the necessary changes for `AggregationISM` and `NullMetadataISM` ### Drive-by changes None ### Related issues - Release: https://github.com/hyperlane-xyz/hyperlane-monorepo/releases/tag/agents-2023-07-25 ### Backward compatibility Yes ### Testing Manual	1 year ago
Kunal Arora	c278ee75b9	Deploy AggregationISM to mainnet2 (#2563 )	1 year ago
Kunal Arora	ed7569d1ac	Deploy AggregationISM for rc kathy mainnet (#2541 ) ### Description - Deployed AggregationISM to rc mainnet2 - AggregationISM can take in env as a param (moved out of `testnet3/`) - Set as defaultISM for rc mainnet2 context ### Drive-by changes - Deployed `MerkleRootMultisigFactory` and `MessageIdMultisigFactory` for mainnet2 - RoutingISM deployment can run in parallel for each origin. ### Related issues Fixes #2478 ### Backward compatibility Backward compatible? Yes ### Testing Manual, see issue #2560	1 year ago
Yorke Rhodes	16eff8d4d6	Fix fork tests to handle timelock proxy owners (#2558 )	1 year ago
Trevor Porter	8c5983933b	Sealevel (#2404 ) ### Description Opening for that sweet sweet agent image ### Drive-by changes _Are there any minor or drive-by changes also included?_ ### Related issues - Fixes #[issue number here] ### Backward compatibility _Are these changes backward compatible?_ Yes No _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None Yes ### Testing _What kind of testing have these changes undergone?_ None Manual Unit Tests --------- Co-authored-by: Steven Sloboda <steven@eclipse.builders> Co-authored-by: Nam Chu Hoai <nambrot@googlemail.com> Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz> Co-authored-by: J M Rossy <jm.rossy@gmail.com> Co-authored-by: Mattie Conover <git@mconover.dev> Co-authored-by: Asa Oines <asaoines@gmail.com> Co-authored-by: Sergei Patrikeev <serejke.best@gmail.com> Co-authored-by: Daniel Savu <23065004+daniel-savu@users.noreply.github.com> Co-authored-by: Kunal Arora <55632507+aroralanuk@users.noreply.github.com> Co-authored-by: yorhodes <yorkerhodesiv@gmail.com> Co-authored-by: Yorke Rhodes <yorke@useabacus.network> Co-authored-by: Yorke Rhodes <email@yorke.dev> Co-authored-by: Asa Oines <asaoines@Asas-MacBook-Pro.local> Co-authored-by: Kunal Arora <kuarora@ucsd.edu> Co-authored-by: Anett <44020788+anettrolikova@users.noreply.github.com> Co-authored-by: Yaqub Mahmoud <yaqub320@gmail.com> Co-authored-by: Alex <alex@alexbh.dev>	1 year ago
Yorke Rhodes	04bdce0877	Upgrade testnet relayer to include CCIP Read support (#2531 )	1 year ago
Mattie Conover	c1c86c7953	E2E Sealevel Prep (#2551 ) ### Description This PR hardens the e2e test pipeline to failure cases we have seen frequently and also makes the code more generic to better support future environments such as sealevel. The original ticket describes making one or more traits to help with this but after much experimentation and consideration, I feel that doing so would make the code unnecessarily complex and less flexible to future changes. My solution instead after talking with @tkporter regarding the sealvel e2e test pathway is to: 1) get utility code out of the way to make it more clear what the execution path is 2) simplify the process of running build tasks in the background so that as we add more envs we can have multiple things running concurrently without difficulty 3) standardize our program execution pattern to reduce the understanding overhead of the main execution path The main thing I kept running into every time I tried to create traits is that we ultimately need a lot of env and context which means either arg passing or even more structures to hold them or we statically code it into that module. The last option was the cleanest but at that point there isn't much difference between creating a trait and just defining a function to call. And even then there is still some live data we define as we go in main that is bulky to pass around but it might become worth it depending. Also the amount of support code for traits kept trying to ballon because we would need something that constructs the "components", and then runs each of the stages, but it also would need to still know what order to run things in, possibly even within each of those steps. ### Drive-by changes - Now watches agents to detect early termination - Standardizes log prefixes to distinguish between e2e logs and sub process logs - Now logs what commands are run - Standardized the program args concept to reduce param passing and better support reusable configurations - Has all build commands run asynchronously by default to prevent `spawn` commands in main - Fixed an issue where some rust components were being built twice, once as debug and again as release ### Related issues - Fixes hyperlane-xyz/issues#501 - Should help debug recent flakiness if not resolve it ### Backward compatibility Yes ### Testing Manual	1 year ago
Kunal Arora	e1baef1d56	Deploy AggregationISM to testnet3 core (#2539 ) ### Description - Deployed the AggregationISM configured with default multisig validators on Testnet ### Drive-by changes - Fixed edge case of handling zero address for `connectionClient.interchainSecurityModule` - Dedupe setting ism in `HyperlaneDeployer.ts` ### Related issues - Fixes #2477 ### Backward compatibility Yes ### Testing Manual	1 year ago
Kunal Arora	a1ca86b350	Better config.interchainSecurityModule type handling for **deployer classes (#2537 ) ### Description I merge #2517 prematurely so here's an update with better string handling for config.interchainSecurityModule ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Manual --------- Co-authored-by: Yorke Rhodes <email@yorke.dev> Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	e91be529db	AggregationISM set for rc kathy (#2517 ) ### Description - Using a separate set of validators for RC deployments and tests - Defining a recursive AggregationISM config which aggregates over two RoutingISMs, one for a set of MerkleRootMultisigISMs and one for a set of MessageIdMultisigISMs for each origin domain. ### Drive-by changes - Dployed MerkleRootMultisigISMFactory and MessageIdMultisigISMFactory for testnet3 in hyperlane context ### Related issues - Fixes #2224 ### Backward compatibility Backward compatible? Yes Any infrastructure implications? HyperlaneRouterChecker will fail silently if you provide an IsmConfig - #2534 ### Testing Manual Testnet --------- Co-authored-by: Yorke Rhodes <email@yorke.dev> Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Yorke Rhodes	aa92fe37db	Fix crosschaincall duplicate warning (#2532 ) ### Description Fixes ``` duplicate definition - NotCrossChainCall() ```	1 year ago
Yorke Rhodes	e0d8eb375f	Add badges to README (#2519 ) ### Description `main` is ✅ so let's 💪	1 year ago

... 10 11 12 13 14 ...

2237 Commits (6171d82c82e60f911f2b52c98144b98caf2c8789) All Branches Search

2237 Commits (6171d82c82e60f911f2b52c98144b98caf2c8789)

All Branches