2 Commits (97571fc3e1a0bed10616f491bcaf5b300ee1f85b)

Author	SHA1	Message	Date
Tien Dao	683a96257e	fix: reduce loop test igpconfig (#4005) ... ### Description Refactor `testIgpConfig` in `testUtils.ts` for Enhanced Readability and Maintainability by reduce loop <!-- What's included in this PR? --> ### Drive-by changes 1. **Constant Usage:** Introduced `OVERHEAD_COST` as a constant to replace the magic number `60000`, making the purpose of this value clearer and the code easier to update. 2. **Improved Readability:** By using descriptive names and constants, the function is now easier to understand at a glance, which is particularly beneficial for new contributors or during code reviews. 3. **Dynamic Configuration Logic:** Ensured that the configuration for `overhead` and `oracleConfig` is dynamically generated for each chain, excluding the current chain to simulate realistic test scenarios. <!-- Are there any minor or drive-by changes also included? --> These changes do not alter the logic but make the codebase cleaner and more maintainable. ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> --------- Co-authored-by: tiendn <tiendn.works@gmail.com>	6 months ago
Tien Dao	6cff4a2a9e	fix: prevent duplication in verification artifacts array (#4001) ... ## Enhance Artifact Deduplication in HyperlaneDeployer ### Description **Overview**: The `addVerificationArtifacts` method in the `HyperlaneDeployer` class previously added verification artifacts without checking for duplicates, potentially leading to redundant data that could affect performance and reliability. This PR introduces a mechanism to prevent such duplication by implementing a shallow comparison check before adding new artifacts. **Changes**: - Modified the `addVerificationArtifacts` method to include a shallow comparison against existing artifacts. - Used direct property comparisons to efficiently prevent the addition of duplicate entries. - Ensured that the comparison handles large ABI-encoded strings efficiently by comparing string references. **Benefits:** - Efficiency: Reduces unnecessary processing and storage by avoiding duplicate entries. - Accuracy: Ensures that the verification process uses a unique set of artifacts, improving the reliability of deployment verifications. - Performance: Minimizes the overhead associated with handling large sets of data, particularly with large ABI-encoded strings. **Testing:** - Added unit tests to verify that duplicates are not added to the artifacts array. - Ensured existing integration tests pass with the new changes, confirming backward compatibility and functional integrity. This update streamlines the deployment process by ensuring that only necessary and unique verification artifacts are considered, thereby optimizing both memory usage and processing time during contract deployments. --------- Co-authored-by: tiendn <tiendn.works@gmail.com>	6 months ago