hyperlane-monorepo

Commit Graph

Author	SHA1	Message	Date
Kunal Arora	a60ec18237	Unify overheardIgp and igp (#2766 ) ### Description - v3 uses the OverheadIgp as the default igp and removing an "inner" igp makes it simpler to deploy and interact with - `InterchainGasPaymaster` has a `setDestinationGasConfigs` which sets it the overhead and the oracle. - the gas overhead gets added it directly to the specified gasAmount. - Downstream changes to the `typescript/*` module in the igpConfig, checke, deployer, etc ### Drive-by changes None ### Related issues - precursor to https://github.com/hyperlane-xyz/issues/issues/623 - related to https://github.com/hyperlane-xyz/issues/issues/637 - missing changes to governor https://github.com/hyperlane-xyz/issues/issues/641 ### Backward compatibility Yes ### Testing Fuzz	1 year ago
Yorke Rhodes	8e4f2bbe18	Make immutable implementation of factories public (#2761 ) Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2759	1 year ago
Yorke Rhodes	bf3d3c4639	Make recipientIsm more robust (#2767 ) Fixes https://github.com/hyperlane-xyz/issues/issues/629	1 year ago
Yorke Rhodes	c91f589e4e	Add unenroll to Router (#2760 ) Fixes https://github.com/hyperlane-xyz/issues/issues/630	1 year ago
Yorke Rhodes	1ecfc46ce2	v3 Router SDK changes (#2752 ) ### Description - Reorganize solidity directory structure for clarity - Updates router apps (token and helloworld) with changes from https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2749 ### Drive-by changes - Merges the hyperlane-token package to solidity and sdk ### Backward compatibility No (removed token package) ### Testing - Unit Tests - Instrumented coverage	1 year ago
Yorke Rhodes	fcfecdf250	Update router implementations for v3 (#2749 )	1 year ago
Kunal Arora	03c92e1e34	Minor internal review remediation 1 (#2748 )	1 year ago
Kunal Arora	f783c4e96f	add globalHookMetadata (#2743 ) ### Description - Consolidating IGPMetadata and OPStackMetadata to versioned GlobalHookMetadata - Add `supportMetadata` to `IPostDispatchHook` - Metadata Schema [0:1] variant [2:33] msg.value [34:65] Gas limit for message (IGP) [66:85] Refund address for message (IGP) [86:] Custom metadata ### Drive-by changes None ### Related issues - fixes https://github.com/hyperlane-xyz/issues/issues/610 ### Backward compatibility No ### Testing Unit tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	f0e4f2b89b	Prevent invalid destination griefing for the relayer (#2703 ) ### Description - Adds destinationDomain to the `GasPayment` event - recording destination domain as `destination` while reading events for the relayer ### Drive-by changes - none ### Related issues - fixes https://github.com/hyperlane-xyz/issues/issues/475 ### Backward compatibility No, change in event emitted and relayer indexing ### Testing - Unit --------- Signed-off-by: -f <kunalarora1729@gmail.com> Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	7312a6f6db	add InsertedIntoTree event (#2736 ) ### Description - Adding "InsertedIntoEvent" for standalone indexing of events by the agents ### Drive-by changes None ### Related issues #2313 ### Backward compatibility Yes ### Testing Unit tests	1 year ago
Kunal Arora	43ba1b46f1	Running forge with latest solc (#2729 ) ### Description - Removed contracts-bedrock contracts dependency from eth-optimism (which was forcing us to use 0.8.15) - Added local minimal interfaces for the CrossDomainMessenger contract ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Unit tests --------- Signed-off-by: -f <kunalarora1729@gmail.com> Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Yorke Rhodes	af88ae66c3	Fix rebase	1 year ago
Yorke Rhodes	f7dbc71335	Update multisig ISMs for merkle hooks (#2722 ) Fixes https://github.com/hyperlane-xyz/issues/issues/591	1 year ago
Yorke Rhodes	7309f770ef	Add forge test for Mailbox (#2713 )	1 year ago
Kunal Arora	a07a993089	Add aggregation hook for V3 (#2667 ) ### Description - AggregationHook for v3 ### Drive-by changes None ### Related issues v3 https://github.com/hyperlane-xyz/issues/issues/514 ### Backward compatibility Yes ### Testing Always be fuzzing	1 year ago
Yorke Rhodes	467e01a6c7	Add deployed block numbers to indexable contracts (#2672 ) Fixes #2004	1 year ago
Kunal Arora	2b7ecfc312	Add `quoteDispatch` to `IPostDispatchHook` (#2660 ) - `quoteDispatch` added to `IPostDispatchHook` interface and the relevant hooks: - StaticProtocolFee - OPStackHook - InterchainGasPaymaster - MerkleTreeHook - PausableHook (no tests) - DomainRoutingHook (no tests) - ConfigFallbackDomainRoutingHook - ConfigurableDomainRoutingHook (no tests) - `expectEmit` -> `expectCall` - Quote in V3 Yes Uint tests	1 year ago
Kunal Arora	6a32287f00	Fix forge tests post V3 (#2661 ) - fixes GasRouter expectRevert message - added TestMerkleRootHook for proof() and fixes MerkleRootMultisig test - fixes ERC5164 tests post v3 changes - added contract name to mailbox and abstractHook error messages - removed unnecessary tests for "message too large" - downgrade slither in actions to 0.3.0 because of their recent "missing inheritance" bug on main - V3 Yes Unit tests	1 year ago
Kunal Arora	760dce657b	Converting the OP stack hooks to transient storage version (#2632 ) - Updated the OP Stack tests for the Mailbox V3 transient storage version - Allowing OPStackHook to send msg.value at the time of message delivery (uses bit masking) - Added LibBit library, will be useful for all the auth hooks which can send `msg.value` - None - Fixes breaking OP Stack tests for https://github.com/hyperlane-xyz/issues/issues/513 - Also fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2410 No Unit tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz> Remove e2e and add yarn build to CI Adding protocol fees (#2640) - Adding protocol fee as a hook - None V3 Yes Fuzz tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	f38660e70a	Modifying IGP to be a hook (#2638 ) - IGP as a standalone hook, implementing postDispatch to call payForGas directly - Setting a DEFAULT_GAS_USAGE if metadata not specified and message.senderAddress() as refund address if not specified. - None Fixes https://github.com/hyperlane-xyz/issues/issues/511 Yes, same interface as the previous IGP but for Mailbox V3 Unit Tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	0e10306d4b	Adding Optimism Hook and dispatch with metadata (#2580 ) Use mailbox callback to authenticate messages in hooks where necessary (#2609) Co-authored-by: Kunal Arora <55632507+aroralanuk@users.noreply.github.com>	1 year ago
Yorke Rhodes	ff2a495389	Add pausable ism (#2675 )	1 year ago
Yorke Rhodes	e582357de8	Make Domain Routing ISM enumerable (#2644 )	1 year ago
Kunal Arora	f01dfd005f	Add custom error message for when gasOracle not configured for domain in IGP (#2656 ) ### Description - Better error message for when gas oracle for a specific domain isn't configured ### Drive-by changes - None ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2438 ### Backward compatibility Yes ### Testing - Unit tests	1 year ago
J M Rossy	465112db6f	Refactor utils package (#2550 ) ### Description - Reorganize code into separate files - Move in utils from other packages - Fix export structure - Add multi-protocol address utils ### Drive-by changes Lint fix in token package ### Related issues Pre-req for #2503 ### Backward compatibility No, some exports have been removed from the SDK and moved to utils	1 year ago
Yorke Rhodes	aa92fe37db	Fix crosschaincall duplicate warning (#2532 ) ### Description Fixes ``` duplicate definition - NotCrossChainCall() ```	1 year ago
Kunal Arora	7918a320c9	reset to mapping of mapping of messageiD and adding crosschain (#2506 ) ### Description - Reverting to using `mapping(bytes32 => mapping(bytes32 => bool)) public verifiedMessageIds` to prevent a malicious party from changing sender addresses in the ISM and causing liveness failiure for the honest party. - Adding `CrossChainEnabledOptimism` libraries and contracts locally instead of importing from OpenZeppelin's library (removed) - Renaming `AbstractNativeISM` to `AbstractHookISM` for flexibility and clarity. ### Drive-by changes Nope ### Related issues Fixes #2497 ### Backward compatibility Backward compatible? Yes Any infrastructure implications? No ### Testing Unit Tests	1 year ago
Alex	0ddaf1c5cc	Fix incorrect getRemoteInterchainAccount derivation (#2446 ) ### Description A minor change to how we deploy InterchainAccountRouter's and a fix for remote ICA address derivation. The fix is outlined clearly in #2383 by Nam but essentially by assigning the `implementation` & `bytecode` variables in the constructor of `InterchainAccountRouter`, we are unable to correctly access them in `getRemoteInterchainAccount` if using a proxy. By moving initialisation of these variables to `initialize` we correctly store the values in the proxy storage, not the implementation storage. ### Drive-by changes The `InterchainAccountRouter` should no longer be used unproxied. ### Related issues - Fixes #2383 ### Backward compatibility No, new ICA deploy ### Testing - [x] Unit Tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>	1 year ago
Kunal Arora	7c872bc449	5164 hook support (#2471 ) ### Description - Adding support for any ERC-5164 compatible bridge adapter to be added as a hook. See https://eips.ethereum.org/EIPS/eip-5164 for more details on the EIP and https://github.com/MultiMessageAggregation/multibridge for adapter implementations for different vendors. ### Drive-by changes - Switched mapping(bytes32 => mapping(address => true) to mapping(bytes32 => bytes) for verifedMessageIds because the last boolean is redundant in the AbtrsactNativeISM contract. ### Related issues - Fixes #2417 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	1 year ago
Kunal Arora	445da4fb0d	Adding Optimism native bridge support (#2316 ) ### Description - Adds support for the native Optimism bridge (L1->L2) to send messageID to be verified by the custom ISM on the rollup. - Only the smart contract component. - Outside Mailbox and needs to be called separately. - Uses Openzeppelin's CrossChainEnabled pattern for ensuring the right cross chain sender address. ### Drive-by changes - None ### Related issues - Fixes https://github.com/hyperlane-xyz/issues/issues/379 - Opens https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2409 - Related to https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2381 ### Backward compatibility - Needs modifying the relayer to read OptimismISM's storage to wait for `receivedEmitters` mapping to get updated before retrying `process` on the mailbox. ### Testing - Unit Tests with Foundry forks and Optimism's L1-L2 messenger contracts. --------- Co-authored-by: Asa Oines <asaoines@gmail.com>	1 year ago
Yorke Rhodes	50f04db1fa	Make merkle proofs optional on multisig ISM (#2173 ) ### Description Validators currently sign `(root, index)` checkpoints and during verification, a `message` is passed as calldata, an `id()` is derived, and a `proof` of `id()` at `index` in `root` is verified This provides “all or nothing” censorship resistance guarantees because a validator can only sign roots to allow any contained messages to be processed. We have considered alternatives where validators sign `message` directly and we lose censorship resistance in exchange for eliminating merkle proof verification gas costs. However, if validators sign `(root, index, message)` tuples, we can skip merkle proof verification on the destination chain while still maintaining censorship resistance by providing two valid metadata formats: 1. existing validator signatures and merkle proof verification of inclusion 2. including merkle proof verification for pathway where validators are censoring `message` It’s worth noting the validator is required to index event data to produce this new signature format. However, this does not require historical indexing and new validators being spun up can simply begin indexing from tip. See https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2187 for validator changes See https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/2248 for relayer and e2e test changes ### Drive-by changes Merkle index also optional ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/2192 ### Backward compatibility - new ISM deployment is necessary (we could upgrade implementation in theory) - Validator and relayer upgrades ### Testing Unit (fuzz) Tests, E2E tests	2 years ago
Asa Oines	ec63ed19c5	Fix CI flakiness (#2269 ) ### Description - Don't panic if E2E test fails to fetch a metric - Run coverage commands sequentially ### Drive-by changes - Cleans up some lint errors in forge tests	2 years ago
Asa Oines	1e9d0be9b3	Fix DomainRoutingIsm tests (#2255 ) ### Description Fixes a bug in the DomainRoutingIsm tests that curiously only started showing in CI a few days ago. ### Drive-by changes None	2 years ago
Asa Oines	6b058e7014	Add checkConfig to HyperlaneRouterDeployer (#2156 ) ### Description Adds a pre-deploy check to HyperlaneDeployer, with an implementation for HyperlaneRouterDeployer that does a best-effort check that the ISM and IGP are properly configured for each chain. ### Drive-by changes - Move TestIsm to TestMultisigIsm for compatibility with pre-deploy checks ### Related issues - Fixes #2038 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Manual	2 years ago
Asa Oines	f8d645e580	Add RoutingIsm (#1985 ) ### Description This PR adds `IRoutingIsm` and three implementations: - AbstractRoutingIsm, which folks building RoutingIsms can inherit from - DomainRoutingIsm, which routes based on message origin - InterchainAccountIsm, which routes based on the ISM in the InterchainAccountMessage ### Drive-by changes - Some related testing changes ### Related issues - Fixes #1521 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Yorke Rhodes	55f40ad760	Merge audit v2 remediation to main (#1727 ) ### Description Merge [`audit-v2`](https://github.com/hyperlane-xyz/hyperlane-monorepo/releases/tag/audit-v2) into `main` See [changelog](`034e75b632`...audit-v2)	2 years ago
Asa Oines	96e03b1681	Remove Create2Factory and associated deployer code (#2064 ) ### Description As discussed offline, the complexity of maintaining consistent addresses across chains is no longer worth it, especially as consistent addresses cannot be maintained across PI chains. ### Drive-by changes - Move governors into infra/src/govern - Take initialization args list as opposed to abi encoded args in deployer - Do not initialize IGP in the constructor since we need to initialize the proxy ### Related issues - Fixes #2040 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ None	2 years ago
Asa Oines	63558af85d	Use interfaces in agents (#2022 ) ### Description Move agents to use contract interfaces artifacts rather than the artifacts themselves. This ensures we don't anything that we can't guarantee is in every implementation of that interface. Particularly relevant for IGPs and ISMs. ### Drive-by changes - Moves `solidity/interfaces` to `solidity/contracts/interfaces` so that their artifacts can be used in `update_abis.sh` ### Related issues - #1757 ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ None	2 years ago
Yorke Rhodes	6f7495320b	Regenerate test fixtures and unskip hardhat tests (#2035 )	2 years ago
Asa Oines	f8b04029ac	Fix flaky solidity test (#2013 ) ### Description It's failing during certain fuzzer conditions b/c the assertion is made before the assumption.	2 years ago
Asa Oines	e8d90775f7	Add Aggregation ISM (#1737 ) ### Description This PR introduces the Aggregation ISM, which requires interchain messages to be verified by an m-of-n ISM set. This PR also introduces a new MultisigISM, which does not make use of the "commitment" optimization in its metadata. The previous MultisigISM has been moved to LegacyMultisigISM. Both AggregationISM and MultisigISM have abstract contracts that require `valuesAndThreshold` implementations. This PR implements versions with static m-of-n sets, using the EIP-3448 MetaProxy standard. These implementations are intended to be combined with a future RoutingISM implementation to replace LegacyMultisigISM. ### Drive-by changes - genhtml in solidity code coverage ### Related issues - Fixes #1522 ### Backward compatibility _Are these changes backward compatible?_ Yes ### Testing _What kind of testing have these changes undergone? Unit Tests	2 years ago
Asa Oines	f5a74006ec	Add non-struct API for IQS and ICA middlewares (#1989 ) ### Description This PR adds functions to the ICA and IQS middlewares that do not take complex types. These simpler interfaces lower the barrier to entry for users, especially for those using tooling that does not support structs well (e.g. etherscan, tally) ### Drive-by changes - Rename destinationDomain -> destination - Remove messageId from InterchainCallDispatched, rename to RemoteCallDispatched ### Related issues None ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Asa Oines	7f5d50ee9c	Interoperable Interchain Accounts (#1832 ) ### Description This PR introduces a version of Interchain Accounts that is fully interoperable with any compatible contract deployed on a remote chain. Rather than follow the previous `Router` pattern in which destination contracts were hard coded by the deployer, this version allows the user to optionally specify which destination contract should receive the interchain account message. In order to make this secure, interchain accounts are additionally name spaced by ISM and origin router. Note that this is not feature-complete until paired with a RoutingISM that switches based on the ISM included in the message ### Drive-by changes - Creates the `IRouter` and `IHyperlaneConnectionClient` interfaces - Moves middleware interfaces into their own directory - Moves middleware libs into their own directory - Changes `InterchainCallMessage` -> `InterchainQueryMessage` now that it's unused by anything else ### Related issues - Fixes #1747 - Fixes #1969 ### Backward compatibility _Are these changes backward compatible?_ No _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Yorke Rhodes	4ac6290886	Use bytecode deployer for ICA auth (#1914 ) ### Description - Replaces `OwnableMulticall` (`owner` in storage) with `DeployerMulticall` (`deployer` in bytecode) for optimizing ICA deployment costs ### Backward compatibility No, bytecode changes implies new ICA addresses ### Testing Unit Tests	2 years ago
Trevor Porter	cd75c25f40	Check IGP ownership, transfer IGP ownership in the initializer (#1895 ) ### Description * Adds the IGP & DefaultIsmIgp to the HyperlaneCoreChecker's list of ownables * Transfers ownership in the `initialize` function of the IGP - this way we won't ever get in a scenario where the proxy admin is the owner for fresh deploys ### Drive-by changes * The provided default mumbai rpc `https://rpc-mumbai.maticvigil.com` was giving problems for eth_getStorageAt, so changed it * Removed the DefaultIsmInterchainGasPaymaster from the list of proxies because it's not proxied (this is in #1765, but made this change in here too) ### Related issues n/a ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Trevor Porter	07f91490fc	Fix flaky fuzz test (#1903 ) ### Description I believe this is the fix for the flaky fuzz tests we've been experiencing. My theory is that the IGP's balance was overflowing by there being 2 subsequent `payForGas` calls with each payment being > `type(uint256).max / 2`. I found that this test was the culprit by running specific fuzz tests we have. Then made the fix and ran it multiple times and never saw an overflow again ### Drive-by changes n/a ### Related issues n/a ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests	2 years ago
Trevor Porter	f5d1fbbd03	On chain gas oracles in the IGP (#1765 ) * Rough implementations of all gas oracles, done with StaticGasOracle & tests * more tests, beef up StorageGasOracle * Tests cleaned up, moved to Foundry test for IGP * rm StaticGasOracle, fix all tests * cleaning up * comment * yarn gas, better comments * Fix sdk test * Fix e2e * Rm LZ stuff * fix router test * Rm MockInterchainGasPaymaster * pr comments * Move to setGasConfigs instead of setGasConfig * fix test * nit * yarn gas * IGP deploy & checker tooling, script to update on-chain StorageGasOracle data (#1794) * Add IGP gas oracle to checker * Checker works * Support different gas oracle contracts in IGP deploy tooling too * Export some types * Build out set-storage-gas-oracle-values * nit * nit * rm comment * Add pricing data * nits * nearly there * haven't tested e2e yet, but added new proxy upgrade logic to set gas oracles in IGP in upgradeAndCall * pr comments * lots * Move away from upgradeAndCall for IGP upgrade, trying to debug annoying dependency issue * Got working, cleaned a little * Add test to ensure a new implementation is deployed * yarn hyperlane * nits * cleaning * Map in description * Dedupe submission type logic * yarn gas * Separate beneficiary in IGP (#1801) * Add IGP gas oracle to checker * Checker works * Support different gas oracle contracts in IGP deploy tooling too * Export some types * Build out set-storage-gas-oracle-values * nit * nit * Add separate beneficiary to IGP * Checker / govern / deploy tooling * nits * Add compare-storage-gas-oracle * successful test upgrade, minor changes * Nits * Fix tests * Performed testne3 upgrade. Need to clean up code, but should probably use this for the mainnet upgrade * nit * update prices * Update gas prices and token exchange rates for mainnet * mainnet upgrade. needs lots of cleaning, but here it is in all its glory * Starting to clean up * more cleanup * Use updated submodules * yarn gas * nit * PR comments * yarn hyperlane * yarn gas	2 years ago
Yorke Rhodes	655bee2da7	Allow value in ICAs (#1640 ) * ICA router changes * Add ICA tests with value * Use InterchainCallMessage lib * Simplify interfaces of middlewares * Avoid using for to improve library coverage * Tolerate 2% gas snapshot deviations * Address pr comments	2 years ago
Yorke Rhodes	aeb056336c	Implement GasRouter (#1621 ) * Implement GasRouter * Add gas router deployer * Add quote gas helper to gas router * Add coverage to GasRouter * Update gas snapshot	2 years ago
Asa Oines	0477ee11ef	Speed up CI (#1683 )	2 years ago

1 2

99 Commits (a9e8b17fce04db0619377e8825434cee0be6988f)