64 Commits (ded27f486de9610bbfc3664628fb4d8bc6ad7ab5)

Author	SHA1	Message	Date
Anna Carroll	25ec45659e	WIP: polish contract code (#680) ... * WIP: polish contract code: comments, variable naming, events, etc * Moar comments * Contract descriptions, Merkle and Queue * New TS * Upgrade beacon contracts * Fix: don't rename event parameters, remove @return for fallback * Fix expected revert strings * UpdaterManager + fix revert string * xApp Contracts (WIP) * rebase main / resolve conflicts * Address comments	3 years ago
Anna Carroll	567631e510	Remove nextToProcess from Replica (#629) ... * Remove nextToProcess from Replica * Get tests passing * package-lock * refactor: remove next_to_process from rust Co-authored-by: James Prestwich <james@prestwi.ch>	3 years ago
Anna Carroll	cc374c23d9	Add version 0 to contracts (#628) ... * Drive-by: specify imports * Add version 0 to contracts * Typescript * Remove whitespace	3 years ago
Erin Hales	4ecbdd1969	refactor: upgrade safety (#566) ... * refactor: GovernanceRouter is upgrade safe * refactor: Common inherits QueueManager * refactor: Home and Replica are OwnableUpgradeable * refactor: add storage gaps to home, replica, common and queue * refactor: add storage gaps * refactor: upgradability and initializers - move OwnableUpgradable to Home from Common - make internal initializers more consistently named - use __Contract_initialize() pattern * add: contract inheritance document file * document: initializer relationships * add: upgradeable.md * add: outside dependencies to documentation * fix: typo * bugs: solidity fixes - BridgeRouter now below size limit again - remove accidental doubled declaration of ProcessError event * chore: update inheritance graph Co-authored-by: James Prestwich <james@prestwi.ch>	3 years ago
James Prestwich	1cbbf77794	feature: add convenience events to Home and Replica (#583) ... * feature: add current root to Dispatch event * feature: emit message hash on process success/fail * test: assert emit ProcessSuccess event	3 years ago
James Prestwich	9d95cab1ba	Raise process gas and add tests/ (#560) ... * test: expose more utilities on test deploy * test: scaffold more transfer tests * test: remotely-originating roundtrip test * test: local token roundtrip test * test: local token unapproved and insufficient balance * test: basic prefill test * test: prefill test w/ local token * chore: clean unused imports * chore: regenerate typescript for core * bug: increase PROCESS_GAS further to better account for enqueue costs * deploy: aug-12 increased PROCESS_GAS * test: decrease allowed process gas to ensure buffer	3 years ago
James Prestwich	6f36a61fcf	Fresh deploy (#556) ... * bugs: fixed bridge deploy - update manual gas setting to 6_000_000 to account for chunky boy BridgeRouter contract - add overrides to EthHelper deploy - add logging to EthHelper deploy * deploy: aug 11 kovan-alfa deploy * feature: duplicate etherscan config from core to xapps * feature: verified bridge deploy * chore: regenerate package locks	3 years ago
James Prestwich	eebb834fe0	Prestwich/bridge test deploy (#540) ... * feature: first draft TestBridgeDeploy * docs: basic docs for the TestBridgeDeploy * bug: update import paths in config ts	3 years ago
Nam Chu Hoai	7ab55b3e16	Clarify Home#update notice (#535)	3 years ago
Erin Hales	9c9fb87b03	test: migrate tests and deploy process to ts (#400) ... * refactor: migrate js lib to ts * refactor: rewrite extendEnvironment in ts * add: sample tests * add: extend hre * refactor: ts deploy and signer type * refactor: devDeploy for tests * document: isTestDeploy param, add common.test.ts * add: common tests * fix: common tests * clean: remove sample script * refactor: remove Signer type and use ethers.Signer * refactor: typescript directory * build: generate typechain * refactor: typescript code (#399) * refactor: optics-tests/optics-deploy * fix: install typechain * fix * fix: ts errors * add: merkle tests (#417) * add: merkle tests * clean: remove commented code * fix: merkle tests * test: add queue tests (#422) * Add queue tests * fix: add await to fix nonce bug * test: home ts (#401) * add: home tests * add: home tests * add: deploy home (broken) * refactor: add num confirmations to config * refactor: clean up around ts tests (#424) - add testChain.ts with utility functions for making test Chain and Deploy - refactor the Optics hardhat extension - improve typing of enums in Optics lib - remove most references to waffle (prefer ethers) - remove isTestDeploy from deployment args in favor of a test? on Deploys * refactor: clean test deploy, home tests passing * refactor: deployOptics * fix: white space * lint: fix white space * refactor: testCase vectors and imports * fix: rust test vector generation * fix: missing await Co-authored-by: James Prestwich <10149425+prestwich@users.noreply.github.com> * test: add message test (#423) * test: add message test * fix: replace require with import * fix: import for queue.test.ts * enhance: add type check * fix: import conflicts * test: add upgrade tests (#443) * test: add upgrade tests * fix: missing arg * refactor: clean up code * remove: unused code * refactor: deploy proxy * fix: unsaved code * fix: ts conflicts * add: utils ts (#453) * draft * refactor: remove waffle from home tests * fix: types, remove waffle Co-authored-by: yoduyodu <wang7ong@gmail.com> * test: add XAppConnectionManager tests (#456) * test: add XAppConnectionManager tests * test: initial setup for XAppConnectionManager tests * test: most XAppConnectionManager tests passing * fix: failing test * test: SimpleMessage ts (#468) * test: add cross-chain test utils * test: simpleMessage, mostly passing * fix: prove and process test * test: add initial state test, clean up * test: recoverymanager ts (#473) * test: add recoveryManager initial tests * fix: set recoveryManager in ts deploy * fix: set governor * test: replica ts (#483) * test: add replica tests * debug: fix failing tests * WIP: test: governance router/upgrade ts (#470) * test: add governance router tests * debug: some tests * debug: Gov Router tests * refactor: upgradeUtils * fix: missing await * test: clean up ts tests (#484) * clean: imports * refactor: utils * refactor: remove logs during testing * fix: weird bug, ethers.getSigners messes up describe blocks * delete: solidity/optics-core/js * update: pre-commit script for ts * update: pre-commit and scripts * fix: test, update with main * clean: types * fix: bad recipient handle * add: todo for gov router test * add: add back verify deploy stuff in js for now * bug: fix the governance upgrade test (#490) * fix: gov router upgrade test * feature: use TS in both solidity packages * bug: install deps in typescript dir in tests * feature: enhanced github action install * chore: disable automerge, and move lint before test Co-authored-by: Tong Wang <wang7ong@gmail.com> Co-authored-by: James Prestwich <10149425+prestwich@users.noreply.github.com> Co-authored-by: James Prestwich <james@prestwi.ch>	3 years ago
James Prestwich	85ec60c287	Prestwich/no ordering (#476) ... * feature: implement processor allow and deny lists * refactor: remove sequence requirement in replica processing * bug: initialize re-entrancy guard * nit: remove initializer from reentrancy guard * chore: generate new ts	3 years ago
Anna Carroll	8e0a4f699e	Verify contract code after deploy script (#448) ... * Example script: verify contract code with hardhat * Add output from fresh deploy with verification JSON * New typescript * Write verificationInput during contract deploy * Add verifyLatestDeploy script * Generate package-lock * Pull Hardhat network & etherscan API key from .env * Refactor: verify for single network set in .env * Add npm deploy script that deploys and verifies * Remove example script * Refactor: make verify a hardhat task: * Get name from implementation.constructor * Remove network --hardhat * Setup env in env.js * Comment env.js * bug: set ETHERSCAN_API_KEY in github action (#472) * Add typescript for reading deploy outputs * Refactor: move file parsing to separate file to ease typescript transition * Move comment * Swallow envy errors again * chore: prettier * chore: remove deploy from package.json Co-authored-by: James Prestwich <10149425+prestwich@users.noreply.github.com> Co-authored-by: James Prestwich <james@prestwi.ch>	3 years ago
Anna Carroll	848d7f0414	Update ProcessError event (#441) ... * Update ProcessError event * Add typescript	3 years ago
Anna Carroll	f2cb415eec	fix: Use low-level call instead of contract call (#439) ... * Use low-level call instead of contract call * Add typescript	3 years ago
James Prestwich	e6becba053	refactor: several rust improvements (#414) ... * refactor: several rust improvements - add partials to latest deploy - fix the prefix iterator in db - run the core updater loop in the current span - correct a processor bug that would prevent startup after any proofs were cached - correct a processor bug that would prevent startup with the initial tree * feature: root acceptability checks - expose acceptableRoot in Replica.sol - check if the root is acceptable before dispatching a proof from the processor	3 years ago
James Prestwich	6487fcb3eb	Processing Refactor (#409) ... * refactor: have proversync cache proofs upon tree update * refactor: start introducing acceptableRoot into replica * refactor: set confirmAt to 1 for initial root * refactor: remove previous from replica trait * refactor: processor no longer bails on missing proof * tests: fix the tests * refactor: remove last use of tokio::time::interval * refactor: remove redundant condition in replica	3 years ago
Anna Carroll	d20438434c	feat: RecoveryManager role on GovernanceRouter (#353) ... * RecoveryManager role Fix inequality * Require recovery activated to exit recovery * Add RecoveryManager tests * Move utils & pass lint * Test transfer RecoveryManager role: * Refactor RecoveryManager tests * Change block.number -> timestamp * ran prettier * Add recovery manager to typescript * Fix comment * Re-arrange inRecovery check Co-authored-by: Conner Swann <me@connerswann.me>	3 years ago
Anna Carroll	5b2e48a358	Remove return values from `handle` (#404) ... * Remove return values from handle * Add test for reverting handle function * package-lock * package-lock again * Add tests for various 'bad' recipients * lint: prettier Co-authored-by: James Prestwich <james@prestwi.ch>	3 years ago
James Prestwich	41b19b70dd	refactor: add prove_and_process to replicas enum	3 years ago
James Prestwich	76ab2034d8	refactor: fix the annoying process bug. misc rust updates	4 years ago
James Prestwich	11573866e9	refactor: nextToProcess is now a uint32	4 years ago
James Prestwich	f00674ca25	refactor: home 0-indexes sequences (#397) ... * refactor: home 0-indexes sequences * fix: sequence Co-authored-by: Erin Hales <mcbridee093@gmail.com>	4 years ago
James Prestwich	ebe13489af	feature: semaphores and durations	4 years ago
James Prestwich	a5e91cedf4	bug: disable external common initializer (#373) ... * bug: disable external common initializer * chore: remove old code and unused lint comment	4 years ago
Erin Hales	ed4cda0dc3	fix: lastProcessed -> nextToProcess (#371) ... * fix: change lastProcessed to nextToProcess * fix: bugs * refactor: test-all script * fix: delete file, initialIndex 0 * bug: fix solidity tests with incorrect vector keys Co-authored-by: James Prestwich <james@prestwi.ch>	4 years ago
Erin Hales	81546c6a2b	test: GovernanceRouter upgrade and setUpdater calls (#334) ... * add: initial upgrade test * debug: upgrade callMessage test and isGovernorRouter * add: pre upgrade tests * remove: getUpgradeBeacon func * fix: variable declarations * fix: bug in test setup * lint * test: gov router can call UpdaterManager to change the Updater on Home * fix: rebase on main and fix conflicts * refactor: remove contracts.upgradeBeacon * refactor: DRY code, formatCallData * refactor: remove unused function * refactor: _isGovernorRouter func * refactor: remove mockRecipient from formatCallData * refactor: callLocal instead of process through Replica * refactor: get dataLen for calls internally * refactor: callLocal and expect event * refactor: rename formatCall * test: cross-chain upgrade message * test: prove and process upgrade message * fix: cross-chain upgrade test * test: prove and process cross-chain message * enhance: deployMultipleChains function * debug: merkle proof * fix: message leaf * fix: format calls and merkle proof * fix: broken test	4 years ago
Luke Tchang	ae28e02316	test/bug: verify Rust/Solidity OpticsMessage and leaf equivalence (#363) ... * feature: outputs hardcoded merkle proof * fix: wrong sender address * debug: print sender receiver for StampedMessage * prog: leaf check failing * fix: fixes message pack ordering bug and outputs correct message and leaf json * fix: add message and leaf output to precommit fn * fix: use hex string instead of hardcoded str * feature: adds output proof test function	4 years ago
Luke Tchang	f750437766	test: adds ConnectionManager unit tests (#336) ... * test: adds owner enroll/unenroll tests * test: creates WalletProvider class to simplify getting unused wallets * test: adds unpermissioned unenrollment test case * test: adds unenrollReplica revert test cases * test: asserts isReplica returns T/F * refactor: dry up wallet * fix: removes isOwner typo	4 years ago
James Prestwich	fee2f4cd7a	feature: Home rejects messages larger than 2KiB body (#333)	4 years ago
Luke Tchang	9ebd31e086	fix: remove proveAndProcess dependency on test ordering (#317) ... * fix: optics message sender and recipients determined in test/utils.js rather than in test file * fix: sender and mockRecipient init * fix: uses singleton object rather than awaiting promise explicitly * fix: rename MockRecipient test contract TestRecipient to avoid confusion w/ actual mocks	4 years ago
Erin Hales	7cdd461a34	test: cross chain governance (#312) ... * fix: OpticsIdentifier as_ref casts ethereum address conditionally * feature: adds GovernanceRouter test boilerplate and fixes ConnectionManager test setup * test: adds testProcess and revert message utility * test: adds test for handle revert with unenrolled replica * test: adds test for reverting in handle on nonGovernorRouter message * rename: formattedMessage --> opticsMessage * prog: blocked on incorrect setting of governorDomain = localDomain * fix: fix after domainHash rebase * test: adds success case transfer governor test * test: adds setRouter message success case * prog: Call message success case failing due to datalen mismatches * prog: storing in dynamic struct array reverts silently * add: initial setup * add: transfer governorship test * add: signUpdate * refactor: combine bridgerouter tests * fix: cast to address, set sequence * delete: old gov router tests * Fix transfer governor test * fix: debug call storage, get sequence * fix: bad merge rust code * revert: stale changes * refactor: nits, create thirdDomain/thirdRouter vars * refactor: extract some code into formatOpticsMessage * refactor: formatOpticsMessage * refactor: deployOptics and devDeployOptics * fix: bug, clean up code * lint * fix: add numCalls (#315) * fix: initial stab at adding numCalls * debugging: numCall type conversion * fix: read _numCalls from bytes29 * use MSG_PREFIX_LEN * clean: remove unused imports * fix: data bug, refactor a bit * add: Transaction reverted silently * fix: bug in formatCalls * refactor: formatCalls * add: check ret value for testProcess from GovernorRouter * enhance: more explicit naming * rename: BYTE_LEN to NUM_ITEMS * slow down turbo * enhance: assign _numCalls variable Co-authored-by: Luke Tchang <ltchang@stanford.edu> Co-authored-by: anna-caroll <anna.s.carroll@gmail.com>	4 years ago
James Prestwich	7bfe50bd5f	Prestwich/watcher unenroll (#324) ... * feature: adds xapp interface enum to optics-base * feature: adds xapp manager to watcher and has watcher unenroll replicas * refactor: adds Vec<ConnectionManagers> and separates double update handling from unenrollment * fix: watcher-partial config takes vec of ConnectionManager configs * fix: updates comment and adds tracing instrumentation * fix: bad ConnectionManager setup reports error instead of unwrap * fix: concurrently awaits double_update and unenroll tasks * fix: actually awaits two vec of futures concurrently * fix: signed failure notification uses home domain (fixing conflation of replica/home domain) * fix: remove origin_domain after rebase * fix: rename double_update_res double_update * refactor: always use full-length identifier in failure notification Co-authored-by: Luke Tchang <ltchang@stanford.edu>	4 years ago
Anna Carroll	af35686796	Initializable Ownable on Home (#305) ... * Remove owner from Home and add transfer UpdaterManager to current UpdaterManager * Update comment	4 years ago
Erin Hales	676c495668	refactor: rename domains rust (#306) ... * refactor: nuke origin_domain * refactor: rename domain_hash * refactor: rename update local_domain to match solidity * refactor: update local_domain to domain * refactor: rename replica destination_domain * fix: remames origin in home/replica and converts back to domain_hash * fix: rust json testcase output field renames * fix: renames contract domain hash functions homeDomainHash * rename: update.domain --> update.homeDomain * fix: variable names and casing * fix: minor things, delete extra vector file * fix: homeDomainHash test loop * enhance: move common functionality to _signatureHash * fix: rename internal homeDomainHash func * fix: lint * fix: sucky merge * fix: bad rebase * fix: domain field accidentally got deleted * fix: overwrite instead of append for updating precommit script (#311) * fix: rename remaining 'origin' references * fix: use origin for Rust and Solidity formatted messages Co-authored-by: Luke Tchang <ltchang@stanford.edu>	4 years ago
Luke Tchang	ddea9d9764	fix: OpticsIdentifier conditionally casts ethereum address (#296) ... * fix: OpticsIdentifier as_ref casts ethereum address conditionally * fix: fixes TestXAppConnection manager name * fix: creates as_ref_local to preserve normal as_ref	4 years ago
Anna Carroll	f63926c7dc	polish: use Initializable.sol from OpenZeppelin (#303) ... * Initializable Common * Initializable Home * Initializable GovernanceRouter * Initializable Replica	4 years ago
Erin Hales	5f04a62cfb	fix: domainHash (#289) ... * fix: domainHash * refactor: rename signatureDomain * fix: add remoteDomain * refactor: rename signatureDomain * fix: remoteDomain/localDomain Replica tests * fix: domainHash view function * fix: signatureDomain tests * fix: recoverWatcherFromSig * refactor: localDomain immutable * fix: initialize_common	4 years ago
Anna Carroll	d72def136d	Fix comment (#291) ... * Fix comment * Fix comment	4 years ago
Anna Carroll	bf58066f67	Ensure events are emitted whenever Updater and UpdaterManager are set (#290)	4 years ago
Erin Hales	45fbc4f7f3	refactor: rename internal funcs (#282)	4 years ago
Erin Hales	9320e06533	refactor: reorder functions (#280)	4 years ago
Erin Hales	5b9c5c614a	Solidity Refactor (#277) ... * refactor: rename originDomain and ownDomain * refactor: create libs folder * refactor: rename interfaces * fix: common tests * fix: bad sig error * fix: event name * fix: update abi * fix: XAppConnectionManager tests	4 years ago
Luke Tchang	03fa9bcded	feature: adds XAppConnectionManager interface (#273)	4 years ago
Anna Carroll	34dce892fc	test: cross-chain messaging w/ deploy script (#262) ... * Test deploy script + cross-chain message passing * Replicas start with empty queues * Track the latestRoot for each chain * Fix: ownDomain vs. originDomain mixup in Replica * Rename test file * Refactor tests to make cross-chain utils reusable * Make return values and naming better * Moar improve * Smaller TODO * Update naming for clarity * Document crossChainTestUtils.js * Fix docs for formatMessage * Document deployCrossChainTest.js * Document generateTestChainConfigs * Document deployOptics script * Move types to appropriate directory * Document SimpleMessage.test.js * Remove double asterisk * Fix rebase * fix imports	4 years ago
Luke Tchang	94fd095043	refactor: renames UsingOptics contract XappConnectionManager (#258) ... * refactor: renames UsingOptics contract XappConnectionManager * fix: Xapp --> XApp	4 years ago
Erin Hales	f004e58131	refactor: sortition --> updater manager (#226) ... * add: basic updater manager * add: setUpdater is ownable * refactor: remove sortition, update UpdateManager * fix: function calls * rename: current function to currentUpdater * refactor: Common doesn't inherit from UpdaterManager * add: permissioned setUpdater function on Home * add: TODO * refactor: move onlyUpdaterManager modifier below initialize * refactor: rename TestSortition * fix: updater.sol -> updaterManager.sol, pass in _updaterManager NOT _updater * remove unused import * refactor: updaterManager on Home, updaterManager contract does not set home on initialization * fix: call Home's setUpdater, get updaterManager's address * enhance: emit NewUpdater event * enhance: emit NewHome event, docs * enhance: emit UpdaterSlashed event * add: Governable contract * documentation: add dev note * fix: bad merge, TestUpdaterManager * fix: goodbye sortition * add: deploy updaterManager * fix: pass in updater, delete TestUpdaterManager * refactor: more explicit naming * refactor: currentUpdater to updater getter * add: isContract check, indexed params * refactor: delete Governable contract * rename: _updaterAddress	4 years ago
Luke Tchang	dc52d01882	feature: adds watcher support for UsingOptics unenrollment (#229) ... * fix: only takes domain and updater * fix: unenrollReplica reverts instead of silent failure and events emitted * feature: adds failure notification structs * feature: adds signer to watcher and produces signed failure notifications on fraud * fix: update after rebasing on main with watcher disk changes * fix: removes stale db_paths from updater and watcher * prog: adds test function in optics-core to produce signed updates for common test suite (broken) * fix: renames previousRoot oldRoot and fixes originDomain to match Common tests * test: adds test to verify watcher SignedFailureNotifications in Solidity * refactor: adds and uses Addresses enum to support 20 and 32 byte addresses * refactor: make an OpticsIdentifier type * feature: add function to cast identifier to ethereum * fix: fixes replica deployment in UsingOptics tests Co-authored-by: James Prestwich <prestwich@clabs.co>	4 years ago
Anna Carroll	769d6b1c28	Script to Deploy Contract Suite (#230) ... * Move GovernanceRouter to optics-core * Update deploy upgrade scripts * Add system deploy script * Fix issues with deploy script * set home on updaterManager * Fix booogs * chore: remove governance from workflow file Co-authored-by: James Prestwich <prestwich@clabs.co>	4 years ago
Luke Tchang	1490207c7d	feature: adds unrenroll permissioning to UsingOptics (#219) ... * feature: adds permissioned unenrollReplica to UsingOptics * feature: adds setWatcherPermission for owner * fix: add check that replica updater matches signed * fix: rename watcherPermissions * fix: only takes domain and updater * fix: adds domainHash to watcher signed data * refactor: recovers watcher from sig and checks permissions after * fix: unenrollReplica reverts instead of silent failure and events emitted	4 years ago
Anna Carroll	be4704e85a	Implement Controller (#224) ... * Minimal Controller * Remove deploy functionality from UpgradeBeacon - not necessary interface * Update tests to use controller to upgrade * fix rebase	4 years ago