31 Commits (e8ea331203857a617b1934b1de166c5deb61b023)

Author	SHA1	Message	Date
Erin Hales	9c9fb87b03	test: migrate tests and deploy process to ts (#400) ... * refactor: migrate js lib to ts * refactor: rewrite extendEnvironment in ts * add: sample tests * add: extend hre * refactor: ts deploy and signer type * refactor: devDeploy for tests * document: isTestDeploy param, add common.test.ts * add: common tests * fix: common tests * clean: remove sample script * refactor: remove Signer type and use ethers.Signer * refactor: typescript directory * build: generate typechain * refactor: typescript code (#399) * refactor: optics-tests/optics-deploy * fix: install typechain * fix * fix: ts errors * add: merkle tests (#417) * add: merkle tests * clean: remove commented code * fix: merkle tests * test: add queue tests (#422) * Add queue tests * fix: add await to fix nonce bug * test: home ts (#401) * add: home tests * add: home tests * add: deploy home (broken) * refactor: add num confirmations to config * refactor: clean up around ts tests (#424) - add testChain.ts with utility functions for making test Chain and Deploy - refactor the Optics hardhat extension - improve typing of enums in Optics lib - remove most references to waffle (prefer ethers) - remove isTestDeploy from deployment args in favor of a test? on Deploys * refactor: clean test deploy, home tests passing * refactor: deployOptics * fix: white space * lint: fix white space * refactor: testCase vectors and imports * fix: rust test vector generation * fix: missing await Co-authored-by: James Prestwich <10149425+prestwich@users.noreply.github.com> * test: add message test (#423) * test: add message test * fix: replace require with import * fix: import for queue.test.ts * enhance: add type check * fix: import conflicts * test: add upgrade tests (#443) * test: add upgrade tests * fix: missing arg * refactor: clean up code * remove: unused code * refactor: deploy proxy * fix: unsaved code * fix: ts conflicts * add: utils ts (#453) * draft * refactor: remove waffle from home tests * fix: types, remove waffle Co-authored-by: yoduyodu <wang7ong@gmail.com> * test: add XAppConnectionManager tests (#456) * test: add XAppConnectionManager tests * test: initial setup for XAppConnectionManager tests * test: most XAppConnectionManager tests passing * fix: failing test * test: SimpleMessage ts (#468) * test: add cross-chain test utils * test: simpleMessage, mostly passing * fix: prove and process test * test: add initial state test, clean up * test: recoverymanager ts (#473) * test: add recoveryManager initial tests * fix: set recoveryManager in ts deploy * fix: set governor * test: replica ts (#483) * test: add replica tests * debug: fix failing tests * WIP: test: governance router/upgrade ts (#470) * test: add governance router tests * debug: some tests * debug: Gov Router tests * refactor: upgradeUtils * fix: missing await * test: clean up ts tests (#484) * clean: imports * refactor: utils * refactor: remove logs during testing * fix: weird bug, ethers.getSigners messes up describe blocks * delete: solidity/optics-core/js * update: pre-commit script for ts * update: pre-commit and scripts * fix: test, update with main * clean: types * fix: bad recipient handle * add: todo for gov router test * add: add back verify deploy stuff in js for now * bug: fix the governance upgrade test (#490) * fix: gov router upgrade test * feature: use TS in both solidity packages * bug: install deps in typescript dir in tests * feature: enhanced github action install * chore: disable automerge, and move lint before test Co-authored-by: Tong Wang <wang7ong@gmail.com> Co-authored-by: James Prestwich <10149425+prestwich@users.noreply.github.com> Co-authored-by: James Prestwich <james@prestwi.ch>	3 years ago
Anna Carroll	8e0a4f699e	Verify contract code after deploy script (#448) ... * Example script: verify contract code with hardhat * Add output from fresh deploy with verification JSON * New typescript * Write verificationInput during contract deploy * Add verifyLatestDeploy script * Generate package-lock * Pull Hardhat network & etherscan API key from .env * Refactor: verify for single network set in .env * Add npm deploy script that deploys and verifies * Remove example script * Refactor: make verify a hardhat task: * Get name from implementation.constructor * Remove network --hardhat * Setup env in env.js * Comment env.js * bug: set ETHERSCAN_API_KEY in github action (#472) * Add typescript for reading deploy outputs * Refactor: move file parsing to separate file to ease typescript transition * Move comment * Swallow envy errors again * chore: prettier * chore: remove deploy from package.json Co-authored-by: James Prestwich <10149425+prestwich@users.noreply.github.com> Co-authored-by: James Prestwich <james@prestwi.ch>	3 years ago
James Prestwich	6487fcb3eb	Processing Refactor (#409) ... * refactor: have proversync cache proofs upon tree update * refactor: start introducing acceptableRoot into replica * refactor: set confirmAt to 1 for initial root * refactor: remove previous from replica trait * refactor: processor no longer bails on missing proof * tests: fix the tests * refactor: remove last use of tokio::time::interval * refactor: remove redundant condition in replica	3 years ago
Anna Carroll	d20438434c	feat: RecoveryManager role on GovernanceRouter (#353) ... * RecoveryManager role Fix inequality * Require recovery activated to exit recovery * Add RecoveryManager tests * Move utils & pass lint * Test transfer RecoveryManager role: * Refactor RecoveryManager tests * Change block.number -> timestamp * ran prettier * Add recovery manager to typescript * Fix comment * Re-arrange inRecovery check Co-authored-by: Conner Swann <me@connerswann.me>	3 years ago
Anna Carroll	5b2e48a358	Remove return values from `handle` (#404) ... * Remove return values from handle * Add test for reverting handle function * package-lock * package-lock again * Add tests for various 'bad' recipients * lint: prettier Co-authored-by: James Prestwich <james@prestwi.ch>	3 years ago
James Prestwich	a5e91cedf4	bug: disable external common initializer (#373) ... * bug: disable external common initializer * chore: remove old code and unused lint comment	4 years ago
Erin Hales	81546c6a2b	test: GovernanceRouter upgrade and setUpdater calls (#334) ... * add: initial upgrade test * debug: upgrade callMessage test and isGovernorRouter * add: pre upgrade tests * remove: getUpgradeBeacon func * fix: variable declarations * fix: bug in test setup * lint * test: gov router can call UpdaterManager to change the Updater on Home * fix: rebase on main and fix conflicts * refactor: remove contracts.upgradeBeacon * refactor: DRY code, formatCallData * refactor: remove unused function * refactor: _isGovernorRouter func * refactor: remove mockRecipient from formatCallData * refactor: callLocal instead of process through Replica * refactor: get dataLen for calls internally * refactor: callLocal and expect event * refactor: rename formatCall * test: cross-chain upgrade message * test: prove and process upgrade message * fix: cross-chain upgrade test * test: prove and process cross-chain message * enhance: deployMultipleChains function * debug: merkle proof * fix: message leaf * fix: format calls and merkle proof * fix: broken test	4 years ago
Luke Tchang	ae28e02316	test/bug: verify Rust/Solidity OpticsMessage and leaf equivalence (#363) ... * feature: outputs hardcoded merkle proof * fix: wrong sender address * debug: print sender receiver for StampedMessage * prog: leaf check failing * fix: fixes message pack ordering bug and outputs correct message and leaf json * fix: add message and leaf output to precommit fn * fix: use hex string instead of hardcoded str * feature: adds output proof test function	4 years ago
Luke Tchang	9ebd31e086	fix: remove proveAndProcess dependency on test ordering (#317) ... * fix: optics message sender and recipients determined in test/utils.js rather than in test file * fix: sender and mockRecipient init * fix: uses singleton object rather than awaiting promise explicitly * fix: rename MockRecipient test contract TestRecipient to avoid confusion w/ actual mocks	4 years ago
Erin Hales	7cdd461a34	test: cross chain governance (#312) ... * fix: OpticsIdentifier as_ref casts ethereum address conditionally * feature: adds GovernanceRouter test boilerplate and fixes ConnectionManager test setup * test: adds testProcess and revert message utility * test: adds test for handle revert with unenrolled replica * test: adds test for reverting in handle on nonGovernorRouter message * rename: formattedMessage --> opticsMessage * prog: blocked on incorrect setting of governorDomain = localDomain * fix: fix after domainHash rebase * test: adds success case transfer governor test * test: adds setRouter message success case * prog: Call message success case failing due to datalen mismatches * prog: storing in dynamic struct array reverts silently * add: initial setup * add: transfer governorship test * add: signUpdate * refactor: combine bridgerouter tests * fix: cast to address, set sequence * delete: old gov router tests * Fix transfer governor test * fix: debug call storage, get sequence * fix: bad merge rust code * revert: stale changes * refactor: nits, create thirdDomain/thirdRouter vars * refactor: extract some code into formatOpticsMessage * refactor: formatOpticsMessage * refactor: deployOptics and devDeployOptics * fix: bug, clean up code * lint * fix: add numCalls (#315) * fix: initial stab at adding numCalls * debugging: numCall type conversion * fix: read _numCalls from bytes29 * use MSG_PREFIX_LEN * clean: remove unused imports * fix: data bug, refactor a bit * add: Transaction reverted silently * fix: bug in formatCalls * refactor: formatCalls * add: check ret value for testProcess from GovernorRouter * enhance: more explicit naming * rename: BYTE_LEN to NUM_ITEMS * slow down turbo * enhance: assign _numCalls variable Co-authored-by: Luke Tchang <ltchang@stanford.edu> Co-authored-by: anna-caroll <anna.s.carroll@gmail.com>	4 years ago
James Prestwich	7bfe50bd5f	Prestwich/watcher unenroll (#324) ... * feature: adds xapp interface enum to optics-base * feature: adds xapp manager to watcher and has watcher unenroll replicas * refactor: adds Vec<ConnectionManagers> and separates double update handling from unenrollment * fix: watcher-partial config takes vec of ConnectionManager configs * fix: updates comment and adds tracing instrumentation * fix: bad ConnectionManager setup reports error instead of unwrap * fix: concurrently awaits double_update and unenroll tasks * fix: actually awaits two vec of futures concurrently * fix: signed failure notification uses home domain (fixing conflation of replica/home domain) * fix: remove origin_domain after rebase * fix: rename double_update_res double_update * refactor: always use full-length identifier in failure notification Co-authored-by: Luke Tchang <ltchang@stanford.edu>	4 years ago
Erin Hales	676c495668	refactor: rename domains rust (#306) ... * refactor: nuke origin_domain * refactor: rename domain_hash * refactor: rename update local_domain to match solidity * refactor: update local_domain to domain * refactor: rename replica destination_domain * fix: remames origin in home/replica and converts back to domain_hash * fix: rust json testcase output field renames * fix: renames contract domain hash functions homeDomainHash * rename: update.domain --> update.homeDomain * fix: variable names and casing * fix: minor things, delete extra vector file * fix: homeDomainHash test loop * enhance: move common functionality to _signatureHash * fix: rename internal homeDomainHash func * fix: lint * fix: sucky merge * fix: bad rebase * fix: domain field accidentally got deleted * fix: overwrite instead of append for updating precommit script (#311) * fix: rename remaining 'origin' references * fix: use origin for Rust and Solidity formatted messages Co-authored-by: Luke Tchang <ltchang@stanford.edu>	4 years ago
Luke Tchang	ddea9d9764	fix: OpticsIdentifier conditionally casts ethereum address (#296) ... * fix: OpticsIdentifier as_ref casts ethereum address conditionally * fix: fixes TestXAppConnection manager name * fix: creates as_ref_local to preserve normal as_ref	4 years ago
Erin Hales	5f04a62cfb	fix: domainHash (#289) ... * fix: domainHash * refactor: rename signatureDomain * fix: add remoteDomain * refactor: rename signatureDomain * fix: remoteDomain/localDomain Replica tests * fix: domainHash view function * fix: signatureDomain tests * fix: recoverWatcherFromSig * refactor: localDomain immutable * fix: initialize_common	4 years ago
Erin Hales	45fbc4f7f3	refactor: rename internal funcs (#282)	4 years ago
Erin Hales	9320e06533	refactor: reorder functions (#280)	4 years ago
Erin Hales	5b9c5c614a	Solidity Refactor (#277) ... * refactor: rename originDomain and ownDomain * refactor: create libs folder * refactor: rename interfaces * fix: common tests * fix: bad sig error * fix: event name * fix: update abi * fix: XAppConnectionManager tests	4 years ago
Anna Carroll	34dce892fc	test: cross-chain messaging w/ deploy script (#262) ... * Test deploy script + cross-chain message passing * Replicas start with empty queues * Track the latestRoot for each chain * Fix: ownDomain vs. originDomain mixup in Replica * Rename test file * Refactor tests to make cross-chain utils reusable * Make return values and naming better * Moar improve * Smaller TODO * Update naming for clarity * Document crossChainTestUtils.js * Fix docs for formatMessage * Document deployCrossChainTest.js * Document generateTestChainConfigs * Document deployOptics script * Move types to appropriate directory * Document SimpleMessage.test.js * Remove double asterisk * Fix rebase * fix imports	4 years ago
Luke Tchang	94fd095043	refactor: renames UsingOptics contract XappConnectionManager (#258) ... * refactor: renames UsingOptics contract XappConnectionManager * fix: Xapp --> XApp	4 years ago
Erin Hales	f004e58131	refactor: sortition --> updater manager (#226) ... * add: basic updater manager * add: setUpdater is ownable * refactor: remove sortition, update UpdateManager * fix: function calls * rename: current function to currentUpdater * refactor: Common doesn't inherit from UpdaterManager * add: permissioned setUpdater function on Home * add: TODO * refactor: move onlyUpdaterManager modifier below initialize * refactor: rename TestSortition * fix: updater.sol -> updaterManager.sol, pass in _updaterManager NOT _updater * remove unused import * refactor: updaterManager on Home, updaterManager contract does not set home on initialization * fix: call Home's setUpdater, get updaterManager's address * enhance: emit NewUpdater event * enhance: emit NewHome event, docs * enhance: emit UpdaterSlashed event * add: Governable contract * documentation: add dev note * fix: bad merge, TestUpdaterManager * fix: goodbye sortition * add: deploy updaterManager * fix: pass in updater, delete TestUpdaterManager * refactor: more explicit naming * refactor: currentUpdater to updater getter * add: isContract check, indexed params * refactor: delete Governable contract * rename: _updaterAddress	4 years ago
Luke Tchang	dc52d01882	feature: adds watcher support for UsingOptics unenrollment (#229) ... * fix: only takes domain and updater * fix: unenrollReplica reverts instead of silent failure and events emitted * feature: adds failure notification structs * feature: adds signer to watcher and produces signed failure notifications on fraud * fix: update after rebasing on main with watcher disk changes * fix: removes stale db_paths from updater and watcher * prog: adds test function in optics-core to produce signed updates for common test suite (broken) * fix: renames previousRoot oldRoot and fixes originDomain to match Common tests * test: adds test to verify watcher SignedFailureNotifications in Solidity * refactor: adds and uses Addresses enum to support 20 and 32 byte addresses * refactor: make an OpticsIdentifier type * feature: add function to cast identifier to ethereum * fix: fixes replica deployment in UsingOptics tests Co-authored-by: James Prestwich <prestwich@clabs.co>	4 years ago
Anna Carroll	769d6b1c28	Script to Deploy Contract Suite (#230) ... * Move GovernanceRouter to optics-core * Update deploy upgrade scripts * Add system deploy script * Fix issues with deploy script * set home on updaterManager * Fix booogs * chore: remove governance from workflow file Co-authored-by: James Prestwich <prestwich@clabs.co>	4 years ago
Anna Carroll	53f79d9964	Migrate from `constructor` to `initialize()` (#195) ... * Refactor constructors to initialize * Fix merge, fix lint * Move ownDomain to initialize; logically paired with instance, not implementation * Add initialize to Common * Solidity tests passing * Migrate GovernanceRouter to initialize * Fix GovernanceRouter * Integrate Replica and ProcessingReplica; fix function collision in abigen * Fix: rust syntax; remove commented line * Gate initialize() on state.UNINITIALIZED * Rename queue.init() -> queue.initialize()	4 years ago
Anna Carroll	f44e60a86a	refactor: interfaces directories (#157) ... * Rename Types -> BridgeMessage; Router -> BridgeRouter * Add BridgeTokenInterface.sol * Add MessageRecipientInterface.sol * Add SortitionInterface.sol * nit: rename Interface to I * nit: rename Interface to I Co-authored-by: Erin Hales <mcbridee093@gmail.com>	4 years ago
James Prestwich	3d4aa756d1	feature: a simple script to make a test deploy of a home contract (#150) ... * feature: a simple script to make a test deploy of a home contract * bug: fix madison gasprice	4 years ago
Luke Tchang	074a34c85d	test: increases core contract test coverage (#113) ... * test: adds tests for empty queues and ensures proveAndProcess reverts * test: ensures invalid double update does not fail home * test: adds queueLength helpers to TestReplica and TestHome * test: ensures queue dequeue many reverts if number exceeds length * test: adds test for batch updates to Home * test: adds successful proveAndProcess test case * fix: replaces assert statements with expect	4 years ago
Erin Hales	c6126431be	WIP/enhancement: linting and coverage (#106) ... * enhancement: linting * enhancement: pre-commit hooks with cargo-husky * enhancement: pre-commit hooks for solidity * fix: pre-commit script * ok to add package-lock.jsons * add: npm husky * format: README * add: bypass info to README * clean: remove husky script * configure: play nice, prettier and eslint * fix: lint settings * refactor: ethlint to solhint * lint: compiler version * lint: everything * lint: optics-bridge * lint: mark visibility of state * lint: TokenRegistry * enhancement: make pre-commit.sh executable * chore: clean code and dependencies * lint: optics-core tests * enhance: pre-commit.sh * fix: delete commented code, kathy/cargo.toml	4 years ago
Luke Tchang	2fbbcf7fc3	test/refactor: adds test for destinationAndSequence calculations + refactors domainHash test file creation (#110) ... * refactor: domain_hash util in optics-core outputs json file instead of printing hashes * test: adds Rust destinationAndSequence test to output vector * test: adds test case to Home tests for comparing Rust and Solidity destinationAndSequence calculations * fix: replaces & with | and fixes destinationAndSequence js utility * fix: removes #[test] tags on test case output functions * fix: asserts destinationAndSequence function args are capped at u32::MAX	4 years ago
Luke Tchang	7b2d9d7762	test: tests Dispatch event data and refactors enqueue message helper (#93) ... * feature: adds messageToLeaf and calcDestinationAndSequence utils * feature: adds currentLeafIndex getter to TestHome * test: adds test that checks Dispatch event and refactors enqueue message helper * fix: fixes package-lock.json * feature: adds dispatch event lookup util function on optics.Home * fix: renames TestHome function nextLeafIndex instead of currentLeafIndex	4 years ago
Luke Tchang	2dd857bbb8	feature: adds untested ProverSync struct to optics-core (#78) ... * feature: basic ProverSync setup * prog: basic setup for linking enqueuings to roots * refactor: modifies Dispatch event to contain treeSize field and condenses destination and sequence into single field * feature: adds leaf_by_tree_size methods to Home abi and logic for updating local tree in prover_sync * format: runs cargo fmt * prog: comments out unused code from previous design * fix: replaces slip44 references with domain * refactor: moves interval to parameter instead of ProverSync struct field * fix: deletes commented out code from NewLeaf design * refactor: modifies ProverSync error handling to bubble up ProverSyncError type * fix: removes slip44 reference * refactor: adds incremental merkle tree to ProverSync and batch updates prover on successful incremental update * fmt: runs cargo fmt * fix: fixes raw_message_by_sequence filtering after destination and sequence event fields were combined to single field in Home * fix: simplifies error handling, adds retry counter for failed api calls, and clones incremental merkle * fix: renames leaves_by_tree_size to leaves_by_tree_index * fix/docs: fixes Home Dispatch event to use leafIndex instead of treeSize and fixes docs to reflect change * fix: changes num_retries to u32 * refactor: cleans up error handling * docs: adds comment about why leafIndex is count() - 1 * fix: deletes old NewLeaf event from Home * fmt: runs cargo fmt * fix: removes num_retries field * refactor: simplifies destination_and_sequence util * fix: fixes typo in warning message * refactor: derives transparent errors * docs: improves comments for prover-sync/incremental merkle behavior * fix: restarts poll_updates loop if prover root was updated while we were building leaf vector from incremental merkle * feature: adds ProverSync::new function * fix: ProverSync stops polling updates on invalid local_root * fmt: runs cargo fmt	4 years ago
James Prestwich	9ff8490afd	basic token bridge design (#71) ... * wip: bridge messages * feature: add a WIP bridge contract for arbitrary tokens * ref: break out shared tools for devs into UsingOptics.sol * chore: add a type conversion util method * refactor: move token registry to its own contract * refactor: improve isNative using extcodsize * refactor: update slip44 to domain to match new nomenclature * doc: remove outdated TODO note * doc: add a note about the token registry's purpose * refactor: break out type casting to its own library * refactor: break Bridge code out into its own package * chore: make deps explicit in package.json files * refactor: improve clarity of mustHaveRemote * rename xfer to transfer (#89) * bug: fix a copy-paste error in bridge types Co-authored-by: Anna Carroll <anna-carroll@users.noreply.github.com>	4 years ago