The home for Hyperlane core contracts, sdk packages, and other infrastructure

blockchainhyperlaneinterchainmonorepo

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Daniel Savu efd438f9b2 chore: fix queue metric juggedness (#4689) ... ### Description See https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4068 for the problem description. In this fix, whenever an operation is moved from one queue to another, its metric count is decremented from the old queue and incremented for the new one. My initial implementation approach was to update these metrics inside `queue.push(op)`, but the metrics for the operation's previous queue aren't accessible there. #4068 suggests updating them in `op.set_status`, which can't be done for the same reason, even if `op` has a pointer to the current queue's metric internally. So the fix I went for does store a pointer to the current queue metric internally in `op`, but also adds a new `op.set_status_and_update_metrics(status, new_queue_metric)` method, which **must** be used if the queue metrics are to be correctly calculated. This works well except for when ops are removed from the confirm queue, because in the absence of a call to `set_status_and_update_metrics`, no metric decrementing is done. I considered using the `Drop` trait to decrement, but it'd have to be implemented individually for each `PendingOperation` type, which isn't very maintainable. I ended up decrementing the metric in `confirm_operation`, which is called for both batches and single submissions and, of course, all implementations of `PendingOperation`. Here's a screenshot of my local grafana server showing no jaggedness in the e2e run, with prometheus configured to scrape every 2s:  ### Drive-by changes Adds the `prepare_queue` arg of `submit_single_operation` to the `instrument(skip(...))` list so it no longer pollutes logs. ### Related issues - Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/4068 ### Backward compatibility Yes ### Testing Manually, by checking the queue length metric of an e2e run in grafana		2 weeks ago
..
.cargo	feat: Splitting `rust` workspace into `main` and `sealevel` (#4438)	2 months ago
.vscode	feat: Splitting `rust` workspace into `main` and `sealevel` (#4438)	2 months ago
client	chore: agave 2.x validator in sealevel e2e (#4643)	3 weeks ago
environments	chore: update Eclipse related gas oracles (#4591)	4 weeks ago
libraries	feat: Splitting `rust` workspace into `main` and `sealevel` (#4438)	2 months ago
programs	fix: sealevel unit tests flake (#4655)	3 weeks ago
.gitignore	Deploy eclipse testnet (#3172)	9 months ago
Cargo.lock	chore: fix queue metric juggedness (#4689)	2 weeks ago
Cargo.toml	feat: Splitting `rust` workspace into `main` and `sealevel` (#4438)	2 months ago
rust-toolchain	feat: Splitting `rust` workspace into `main` and `sealevel` (#4438)	2 months ago