hyperlane-monorepo

The home for Hyperlane core contracts, sdk packages, and other infrastructure

blockchain hyperlane interchain monorepo

History

Trevor Porter c7ad0f4433 Fix deploying validators when there's an empty validator set (#2565 ) ### Description Turns out when there aren't any validators in the set, which is the case for solanadevnet & zbctestnet on the RC context (https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/infra/config/environments/testnet3/validators.ts#L195), the helm value `hyperlane.validator.configs` wasn't being overridden with CLI value args. So the `configs` in values.yaml, which has a length of 1 with some keys and empty values to illustrate (part of) the expected format of the config, was being used. So then in the Helm template we'd end up iterate through the configs of len 1 :( The fix is to just set the default `configs` to `[]` I also considered adding a check to just skip the chain if the validator set is 0, because there's usually no use in deploying them anyways. But we may be deploying to a chain that used to have a non-zero validator set that we now want to be 0, so we may as well just deploy it and deal with the fact that there will be some helm releases relating to a validator set of 0 🤷 ### Drive-by changes n/a ### Related issues n/a ### Backward compatibility backward compatible ### Testing deployed	1 year ago
..
agent-common	Omniscient relayer infra (#2299 )	2 years ago
hyperlane-agent	Fix deploying validators when there's an empty validator set (#2565 )	1 year ago

Fix deploying validators when there's an empty validator set (#2565 )

### Description

Turns out when there aren't any validators in the set, which is the case
for solanadevnet & zbctestnet on the RC context
(https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/infra/config/environments/testnet3/validators.ts#L195),
the helm value `hyperlane.validator.configs` wasn't being overridden
with CLI value args. So the `configs` in values.yaml, which has a length
of 1 with some keys and empty values to illustrate (part of) the
expected format of the config, was being used. So then in the Helm
template we'd end up iterate through the configs of len 1 :(

The fix is to just set the default `configs` to `[]`

I also considered adding a check to just skip the chain if the validator
set is 0, because there's usually no use in deploying them anyways. But
we may be deploying to a chain that used to have a non-zero validator
set that we now want to be 0, so we may as well just deploy it and deal
with the fact that there will be some helm releases relating to a
validator set of 0 🤷

### Drive-by changes

n/a

### Related issues

n/a

### Backward compatibility

backward compatible

### Testing

deployed

1 year ago

agent-common

Omniscient relayer infra (#2299 )

2 years ago

hyperlane-agent

Fix deploying validators when there's an empty validator set (#2565 )

1 year ago