Merge pull request #14 from harmony-one/mattlockyer-patch-1

Fixes error when logs returns undefined
5 years ago · 87c8df983a
parent 0e1a4ba6e5 c5b154ed2b
commit 87c8df983a
1 changed files with 6 additions and 8 deletions
--- a/packages/harmony-network/src/subscriptions/LogSub.ts
+++ b/packages/harmony-network/src/subscriptions/LogSub.ts
@ -29,15 +29,13 @@ export class LogSub extends SubscriptionMethod {

        if (getPastLogs.isError()) {
          this.emitter.emit('error', getPastLogs.error.message);
+        } else {
+          const logs = getPastLogs.result;
+          logs.forEach((log: any) => {
+            const formattedLog = this.onNewSubscriptionItem(log);
+            this.emitter.emit('data', formattedLog);
+          });
        }
-
-        const logs = getPastLogs.result;
-
-        logs.forEach((log: any) => {
-          const formattedLog = this.onNewSubscriptionItem(log);
-          this.emitter.emit('data', formattedLog);
-        });
-
        delete this.options.fromBlock;
        // const sub = this.start();
        return this.start();