The core protocol of WoopChain
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
woop/staking/availability/measure_test.go

734 lines
21 KiB

package availability
import (
"errors"
"fmt"
"math/big"
"reflect"
"testing"
"github.com/harmony-one/harmony/crypto/bls"
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/rlp"
"github.com/harmony-one/harmony/numeric"
"github.com/harmony-one/harmony/shard"
"github.com/harmony-one/harmony/staking/effective"
staking "github.com/harmony-one/harmony/staking/types"
)
func TestBlockSigners(t *testing.T) {
tests := []struct {
numSlots int
verified []int
numPayable, numMissing int
}{
{0, []int{}, 0, 0},
{1, []int{}, 0, 1},
{1, []int{0}, 1, 0},
{8, []int{}, 0, 8},
{8, []int{0}, 1, 7},
{8, []int{7}, 1, 7},
{8, []int{1, 3, 5, 7}, 4, 4},
{8, []int{0, 2, 4, 6}, 4, 4},
{8, []int{0, 1, 2, 3, 4, 5, 6, 7}, 8, 0},
{13, []int{0, 1, 4, 5, 6, 9, 12}, 7, 6},
// TODO: add a real data test case given numSlots of a committee and
// number of payable of a certain block
}
for i, test := range tests {
cmt := makeTestCommittee(test.numSlots, 0)
bm, err := indexesToBitMap(test.verified, test.numSlots)
if err != nil {
t.Fatalf("test %d: %v", i, err)
}
pSlots, mSlots, err := BlockSigners(bm, cmt)
if err != nil {
t.Fatalf("test %d: %v", i, err)
}
if len(pSlots) != test.numPayable || len(mSlots) != test.numMissing {
t.Errorf("test %d: unexpected result: # pSlots %d/%d, # mSlots %d/%d",
i, len(pSlots), test.numPayable, len(mSlots), test.numMissing)
continue
}
if err := checkPayableAndMissing(cmt, test.verified, pSlots, mSlots); err != nil {
t.Errorf("test %d: %v", i, err)
}
}
}
func checkPayableAndMissing(cmt *shard.Committee, idxs []int, pSlots, mSlots shard.SlotList) error {
if len(pSlots)+len(mSlots) != len(cmt.Slots) {
return fmt.Errorf("slots number not expected: %d(payable) + %d(missings) != %d(committee)",
len(pSlots), len(mSlots), len(cmt.Slots))
}
pIndex, mIndex, iIndex := 0, 0, 0
for i, slot := range cmt.Slots {
if iIndex >= len(idxs) || i != idxs[iIndex] {
// the slot should be missings and we shall check mSlots[mIndex] == slot
if mIndex >= len(mSlots) || !reflect.DeepEqual(slot, mSlots[mIndex]) {
return fmt.Errorf("addr %v missed from missings slots", slot.EcdsaAddress.String())
}
mIndex++
} else {
// check pSlots[pIndex] == slot
if pIndex >= len(pSlots) || !reflect.DeepEqual(slot, pSlots[pIndex]) {
return fmt.Errorf("addr %v missed from payable slots", slot.EcdsaAddress.String())
}
pIndex++
iIndex++
}
}
return nil
}
func TestBlockSigners_BitmapOverflow(t *testing.T) {
tests := []struct {
numSlots int
numBitmap int
err error
}{
{16, 16, nil},
{16, 14, nil},
{16, 8, errors.New("bitmap size too small")},
{16, 24, errors.New("bitmap size too large")},
}
for i, test := range tests {
cmt := makeTestCommittee(test.numSlots, 0)
bm, _ := indexesToBitMap([]int{}, test.numBitmap)
_, _, err := BlockSigners(bm, cmt)
if (err == nil) != (test.err == nil) {
t.Errorf("Test %d: BlockSigners got err [%v], expect [%v]", i, err, test.err)
}
}
}
func TestBallotResult(t *testing.T) {
tests := []struct {
numStateShards, numShardSlots int
parVerified, chdVerified int
parShardID, chdShardID uint32
parBN, chdBN int64
expNumPayable, expNumMissing int
expErr error
}{
{1, 1, 1, 1, 0, 0, 10, 11, 1, 0, nil},
{5, 16, 10, 12, 3, 4, 100, 101, 12, 4, nil},
{5, 16, 10, 12, 5, 6, 100, 101, 12, 4, errors.New("cannot find shard")},
}
for i, test := range tests {
sstate := makeTestShardState(test.numStateShards, test.numShardSlots)
parHeader := newTestHeader(test.parBN, test.parShardID, test.numShardSlots, test.parVerified)
chdHeader := newTestHeader(test.chdBN, test.chdShardID, test.numShardSlots, test.chdVerified)
slots, payable, missing, err := BallotResult(parHeader, chdHeader, sstate, chdHeader.ShardID())
if err != nil {
if test.expErr == nil {
t.Errorf("Test %v: unexpected error: %v", i, err)
}
continue
}
expCmt, _ := sstate.FindCommitteeByID(test.chdShardID)
if !reflect.DeepEqual(slots, expCmt.Slots) {
t.Errorf("Test %v: Ballot result slots not expected", i)
}
if len(payable) != test.expNumPayable {
t.Errorf("Test %v: payable size not expected: %v / %v", i, len(payable), test.expNumPayable)
}
if len(missing) != test.expNumMissing {
t.Errorf("Test %v: missings size not expected: %v / %v", i, len(missing), test.expNumMissing)
}
}
}
func TestIncrementValidatorSigningCounts(t *testing.T) {
tests := []struct {
numHmySlots, numUserSlots int
verified []int
}{
{1, 0, []int{0}},
{0, 1, []int{0}},
{10, 6, []int{0, 2, 3, 4, 6, 8, 10, 12, 14}},
{10, 6, []int{1, 3, 5, 7, 9, 11, 13, 15}},
}
for _, test := range tests {
ctx, err := makeIncStateTestCtx(test.numHmySlots, test.numUserSlots, test.verified)
if err != nil {
t.Fatal(err)
}
if err := IncrementValidatorSigningCounts(nil, ctx.staked, ctx.state, ctx.signers,
ctx.missings); err != nil {
t.Fatal(err)
}
if err := ctx.checkResult(); err != nil {
t.Error(err)
}
}
}
func TestComputeCurrentSigning(t *testing.T) {
tests := []struct {
snapSigned, curSigned, diffSigned int64
snapToSign, curToSign, diffToSign int64
pctNum, pctDiv int64
isBelowThreshold bool
}{
{0, 0, 0, 0, 0, 0, 0, 1, true},
{0, 1, 1, 0, 1, 1, 1, 1, false},
{0, 2, 2, 0, 3, 3, 2, 3, true},
{0, 1, 1, 0, 3, 3, 1, 3, true},
{100, 225, 125, 200, 350, 150, 5, 6, false},
{100, 200, 100, 200, 350, 150, 2, 3, true},
{100, 200, 100, 200, 400, 200, 1, 2, true},
}
for i, test := range tests {
snapWrapper := makeTestWrapper(common.Address{}, test.snapSigned, test.snapToSign)
curWrapper := makeTestWrapper(common.Address{}, test.curSigned, test.curToSign)
computed := ComputeCurrentSigning(&snapWrapper, &curWrapper)
if computed.Signed.Cmp(new(big.Int).SetInt64(test.diffSigned)) != 0 {
t.Errorf("test %v: computed signed not expected: %v / %v",
i, computed.Signed, test.diffSigned)
}
if computed.ToSign.Cmp(new(big.Int).SetInt64(test.diffToSign)) != 0 {
t.Errorf("test %v: computed to sign not expected: %v / %v",
i, computed.ToSign, test.diffToSign)
}
expPct := numeric.NewDec(test.pctNum).Quo(numeric.NewDec(test.pctDiv))
if !computed.Percentage.Equal(expPct) {
t.Errorf("test %v: computed percentage not expected: %v / %v",
i, computed.Percentage, expPct)
}
if computed.IsBelowThreshold != test.isBelowThreshold {
t.Errorf("test %v: computed is below threshold not expected: %v / %v",
i, computed.IsBelowThreshold, test.isBelowThreshold)
}
}
}
func TestComputeAndMutateEPOSStatus(t *testing.T) {
tests := []struct {
ctx *computeEPOSTestCtx
expErr error
expStatus effective.Eligibility
}{
// active node
{
ctx: &computeEPOSTestCtx{
addr: common.Address{20, 20},
snapSigned: 100,
snapToSign: 100,
snapEli: effective.Active,
curSigned: 200,
curToSign: 200,
curEli: effective.Active,
},
expStatus: effective.Active,
},
// active -> inactive
{
ctx: &computeEPOSTestCtx{
addr: common.Address{20, 20},
snapSigned: 100,
snapToSign: 100,
snapEli: effective.Active,
curSigned: 200,
curToSign: 250,
curEli: effective.Active,
},
expStatus: effective.Inactive,
},
// active -> inactive
{
ctx: &computeEPOSTestCtx{
addr: common.Address{20, 20},
snapSigned: 100,
snapToSign: 100,
snapEli: effective.Active,
curSigned: 100,
curToSign: 200,
curEli: effective.Active,
},
expStatus: effective.Inactive,
},
// status unchanged: inactive -> inactive
{
ctx: &computeEPOSTestCtx{
addr: common.Address{20, 20},
snapSigned: 100,
snapToSign: 100,
snapEli: effective.Inactive,
curSigned: 200,
curToSign: 200,
curEli: effective.Inactive,
},
expStatus: effective.Inactive,
},
// status unchanged: inactive
{
ctx: &computeEPOSTestCtx{
addr: common.Address{20, 20},
snapSigned: 100,
snapToSign: 100,
snapEli: effective.Inactive,
curSigned: 200,
curToSign: 200,
curEli: effective.Active,
},
expStatus: effective.Active,
},
// nil validator wrapper in state
{
ctx: &computeEPOSTestCtx{
addr: common.Address{20, 20},
snapSigned: 100,
snapToSign: 100,
snapEli: effective.Active,
curEli: effective.Nil,
},
expErr: errors.New("nil validator wrapper in state"),
},
// nil validator wrapper in snapshot
{
ctx: &computeEPOSTestCtx{
addr: common.Address{20, 20},
snapEli: effective.Nil,
curSigned: 200,
curToSign: 200,
curEli: effective.Active,
},
expErr: errors.New("nil validator wrapper in snapshot"),
},
// banned node
{
ctx: &computeEPOSTestCtx{
addr: common.Address{20, 20},
snapSigned: 100,
snapToSign: 200,
snapEli: effective.Active,
curSigned: 100,
curToSign: 200,
curEli: effective.Banned,
},
expStatus: effective.Banned,
},
}
for i, test := range tests {
ctx := test.ctx
ctx.makeStateAndReader()
err := ComputeAndMutateEPOSStatus(ctx.reader, ctx.state, ctx.addr)
if err != nil {
if test.expErr == nil {
t.Errorf("Test %v: unexpected error: %v", i, err)
}
continue
}
if err := ctx.checkWrapperStatus(test.expStatus); err != nil {
t.Errorf("Test %v: %v", i, err)
}
}
}
// incStateTestCtx is the helper structure for test case TestIncrementValidatorSigningCounts
type incStateTestCtx struct {
// Initialized fields
snapState, state testStateDB
cmt *shard.Committee
staked *shard.StakedSlots
signers, missings shard.SlotList
// computedSlotMap is parsed map for result checking, which maps from Ecdsa address
// to the expected behaviour of the address.
// typeIncSigned - 0: increase both toSign and signed
// typeIncMissing - 1: increase to sign
// typeIncHmyNode - 2: keep the code field unchanged
computedSlotMap map[common.Address]int
}
const (
typeIncSigned = iota
typeIncMissing
typeIncHmyNode
)
// makeIncStateTestCtx create and initialize the test context for TestIncrementValidatorSigningCounts
func makeIncStateTestCtx(numHmySlots, numUserSlots int, verified []int) (*incStateTestCtx, error) {
cmt := makeTestMixedCommittee(numHmySlots, numUserSlots, 0)
staked := cmt.StakedValidators()
bitmap, _ := indexesToBitMap(verified, numUserSlots+numHmySlots)
signers, missing, err := BlockSigners(bitmap, cmt)
if err != nil {
return nil, err
}
state := newTestStateDBFromCommittee(cmt)
snapState := state.snapshot()
return &incStateTestCtx{
snapState: snapState,
state: state,
cmt: cmt,
staked: staked,
signers: signers,
missings: missing,
}, nil
}
// checkResult checks the state change result for incStateTestCtx
func (ctx *incStateTestCtx) checkResult() error {
ctx.computeSlotMaps()
for addr, typeInc := range ctx.computedSlotMap {
if err := ctx.checkAddrIncStateByType(addr, typeInc); err != nil {
return err
}
}
return nil
}
// computeSlotMaps compute for computedSlotMap for incStateTestCtx
func (ctx *incStateTestCtx) computeSlotMaps() {
ctx.computedSlotMap = make(map[common.Address]int)
for _, signer := range ctx.signers {
ctx.computedSlotMap[signer.EcdsaAddress] = typeIncSigned
}
for _, missing := range ctx.missings {
ctx.computedSlotMap[missing.EcdsaAddress] = typeIncMissing
}
for _, slot := range ctx.cmt.Slots {
if slot.EffectiveStake == nil {
ctx.computedSlotMap[slot.EcdsaAddress] = typeIncHmyNode
}
}
}
// checkAddrIncStateByType checks whether the state behaviour of a given address follows
// the expected state change rule given typeInc
func (ctx *incStateTestCtx) checkAddrIncStateByType(addr common.Address, typeInc int) error {
var err error
switch typeInc {
case typeIncSigned:
if err = ctx.checkWrapperChangeByAddr(addr, checkIncWrapperVerified); err != nil {
err = fmt.Errorf("verified address %s: %v", addr, err)
}
case typeIncMissing:
if err = ctx.checkWrapperChangeByAddr(addr, checkIncWrapperMissing); err != nil {
err = fmt.Errorf("missing address %s: %v", addr, err)
}
case typeIncHmyNode:
if err = ctx.checkHmyNodeStateChangeByAddr(addr); err != nil {
err = fmt.Errorf("harmony node address %s: %v", addr, err)
}
default:
err = errors.New("unknown typeInc")
}
return err
}
// checkHmyNodeStateChangeByAddr checks the state change for hmy nodes. Since hmy nodes does not
// have wrapper, it is supposed to be unchanged in code field
func (ctx *incStateTestCtx) checkHmyNodeStateChangeByAddr(addr common.Address) error {
snapCode := ctx.snapState.GetCode(addr)
curCode := ctx.state.GetCode(addr)
if !reflect.DeepEqual(snapCode, curCode) {
return errors.New("code not expected")
}
return nil
}
// checkWrapperChangeByAddr checks whether the wrapper of a given address
// before and after the state change is expected defined by compare function f.
func (ctx *incStateTestCtx) checkWrapperChangeByAddr(addr common.Address,
f func(w1, w2 *staking.ValidatorWrapper) bool) error {
Resolve harmony-one/bounties#90: Add revert mechanism for UpdateValidatorWrapper (#3939) * Add revert mechanism for UpdateValidatorWrapper Closes harmony-one/bounties#90 (1) Use LRU for ValidatorWrapper objects in stateDB to plug a potential memory leak (2) Merge ValidatorWrapper and ValidatorWrapperCopy to let callers ask for either a copy, or a pointer to the cached object. Additionally, give callers the option to not deep copy delegations (which is a heavy process). Copies need to be explicitly committed (and thus can be reverted), while the pointers are committed when Finalise is called. (3) Add a UpdateValidatorWrapperWithRevert function, which is used by staking txs `Delegate`, `Undelegate`, and `CollectRewards`. Other 2 types of staking txs and `db.Finalize` continue to use UpdateValidateWrapper without revert, again, to save memoery (4) Add unit tests which check a) Revert goes through b) Wrapper is as expected after revert c) State is as expected after revert * Change back to dictionary for stateValidators Since the memory / CPU usage saved is not significantly different when using an LRU + map structure, go back to the original dictionary structure to keep code easy to read and have limited modifications. * Add tests for validator wrapper reverts As requested by @rlan35, add tests beyond just adding and reverting a delegation. The tests are successive in the sense that we do multiple modifications to the wrapper, save a snapshot before each modification and revert to each of them to confirm everything works well. This change improves test coverage of statedb.go to 66.7% from 64.8% and that of core/state to 71.9% from 70.8%, and covers all the code that has been modified by this PR in statedb.go. For clarity, the modifications to the wrapper include (1) creation of wrapper in state, (2) adding a delegation to the wrapper, (3) increasing the blocks signed, and (4) a change in the validator Name and the BlockReward. Two additional tests have been added to cover the `panic` and the `GetCode` cases.
3 years ago
snapWrapper, err := ctx.snapState.ValidatorWrapper(addr, true, false)
if err != nil {
return err
}
Resolve harmony-one/bounties#90: Add revert mechanism for UpdateValidatorWrapper (#3939) * Add revert mechanism for UpdateValidatorWrapper Closes harmony-one/bounties#90 (1) Use LRU for ValidatorWrapper objects in stateDB to plug a potential memory leak (2) Merge ValidatorWrapper and ValidatorWrapperCopy to let callers ask for either a copy, or a pointer to the cached object. Additionally, give callers the option to not deep copy delegations (which is a heavy process). Copies need to be explicitly committed (and thus can be reverted), while the pointers are committed when Finalise is called. (3) Add a UpdateValidatorWrapperWithRevert function, which is used by staking txs `Delegate`, `Undelegate`, and `CollectRewards`. Other 2 types of staking txs and `db.Finalize` continue to use UpdateValidateWrapper without revert, again, to save memoery (4) Add unit tests which check a) Revert goes through b) Wrapper is as expected after revert c) State is as expected after revert * Change back to dictionary for stateValidators Since the memory / CPU usage saved is not significantly different when using an LRU + map structure, go back to the original dictionary structure to keep code easy to read and have limited modifications. * Add tests for validator wrapper reverts As requested by @rlan35, add tests beyond just adding and reverting a delegation. The tests are successive in the sense that we do multiple modifications to the wrapper, save a snapshot before each modification and revert to each of them to confirm everything works well. This change improves test coverage of statedb.go to 66.7% from 64.8% and that of core/state to 71.9% from 70.8%, and covers all the code that has been modified by this PR in statedb.go. For clarity, the modifications to the wrapper include (1) creation of wrapper in state, (2) adding a delegation to the wrapper, (3) increasing the blocks signed, and (4) a change in the validator Name and the BlockReward. Two additional tests have been added to cover the `panic` and the `GetCode` cases.
3 years ago
curWrapper, err := ctx.state.ValidatorWrapper(addr, true, false)
if err != nil {
return err
}
if isExpected := f(snapWrapper, curWrapper); !isExpected {
return errors.New("validatorWrapper not expected")
}
return nil
}
// checkIncWrapperVerified is the compare function to check whether validator wrapper
// is expected for nodes who has verified a block.
func checkIncWrapperVerified(snapWrapper, curWrapper *staking.ValidatorWrapper) bool {
snapSigned := snapWrapper.Counters.NumBlocksSigned
curSigned := curWrapper.Counters.NumBlocksSigned
if curSigned.Cmp(new(big.Int).Add(snapSigned, common.Big1)) != 0 {
return false
}
snapToSign := snapWrapper.Counters.NumBlocksToSign
curToSign := curWrapper.Counters.NumBlocksToSign
Merge master to t3 0523 (#3085) * fix signers share computation to use only non-harmony nodes (#3008) * Add LastEpochInCommittee at prestaking epoch too (#3014) * write validator stats at the end of prestaking epoch (#3021) * write validator stats at the end of prestaking epoch * also need to write block reward accumulator * [build] enable static build by default (#2885) scripts/go_executable_build.sh -s (static build, default) scripts/go_executable_build.sh -S (non-static build) Signed-off-by: Leo Chen <leo@harmony.one> * Code formatting fix based on `staticcheck` (#3023) * fix some static check issues * more fixes according to staticcheck * add nil check on getHeader * Add more log info * [rpc] Revert change to v2 GetBalance RPC (#3037) * Cherrypick crosslink related fixes from t3 to master. (#3045) * Optimize crosslink verification logic and add more cache (#3032) * make crosslink broadcast smarter and more efficient (#3036) * adjust catch up speed to be a sane number * Fix crosslink broadcast condition (#3041) * Tx pool error report fix & local build fix (#3046) * [tx_list] Add transaction after you can fetch tx cost * [tx_pool] Add error sink reports for removed tx * Correct log levels for known transactions * Remove redundant hash to `enqueue` and `add` signatures * Update tests for signature changes * [build] Fix local build for MacOs * [tx_pool] Correct typo & logging level for known tx * [config] Create Testnet config * [node.sh] update testnet network config * [config] correct testnet config * [main] Enable beacon sync for explorer nodes (#3059) * [apr] should not use snapshot from last epoch, use current epoch snapshot (#3051) * use snapshot total delegation instead of current total delegation * should not use snapshot from last epoch, use current epoch snapshot (#3049) Co-authored-by: Rongjian Lan <rongjian.lan@gmail.com> Co-authored-by: Rongjian Lan <rongjian.lan@gmail.com> * cherrypick log level change * [rpc] Add active status back to Validator information [validator] Fix typo for ValidatorRPCEnhanced [Makefile] Change make exe to build non-static by default * [network] Added caching to node server (#3048) * [network] Added caching to node server * [network] renamed two singleflight.Group * [network] added two error handling * [network] added forget logic for single flight * [network] changed single flight to lru cache solution * [network] adjusted the cache size * [network] changed cache size to 10000 * Transaction api improvements (#3057) * [node] Add option to broadcast invalid tx (on by default) * update main args to take in broadcast invalid tx * update node.sh for new broadcast invalid tx option * [rpc] Do not submit transaction if tx has been finalized * Support legacy behavior and not return errors on tx submission * [main] make broadcasting invalid tx default false * [node] Fix formatting * Add timeouts for the explorer HTTP service * [test] State trans unit test (#3043) * completing create-validator tests generalizing create validator tests, started with edit validator tests one round completed before major refactor * [test] finished coding test TestCheckDuplicateFields * [test] finished debug TestCheckDuplicateFields * [test] Added TestDescription_EnsureLength * [test] added test in validator_test.go TestUpdateDescription * [test] Added test TestComputed_String * [test] refactored TestValidatorSanityCheck and added some message in error message returned from sanity check * [test] removed test index for debugging * [test] Added test TestValidatorWrapper_SanityCheck. Added value check for TestMarshalUnmarshalValidator. Fixed rlp usage defect in UnmarshalValidator * [test] added test TestVerifyBLSKeys * [test] added test TestContainsHarmonyBLSKeys * [test] added test TestCreateValidatorFromNewMsg * [test] fixed some tests errors * [test] added test TestUpdateValidatorFromEditMsg, last editted the test file, finished testing validator_test.go * [staking] added numeric.Dec.Copy method * [staking] added CommissionRates.Copy * [staking] add nil case handle to copy method and related test case * [test] added nil case for commissionRates.Copy test * [staking] finished CreateValidator.Copy and related test case * [staking] added EditValidator.Copy method and related test case * [test] added zero test cases for Copy method * [staking] implemented Delegate.Copy and related unit test case * [staking] added Undelegate.Copy and CollectReward.Copy method. Implemented corresponding test cases * [test] added two more simple unit tests * [test] solving the merge conflict with deep copy fix * [test] added schedule for sharding * [test] refactored double_sign_test.go * [test] comment out all test cases for now. * [test] added record Copy method for testing * [test] added the first test case in TestVerify * [test] finished test TestVerify * [test] Added test TestVerify, TestApplySlashRate, TestSetDifference * [test] half through TestDelegatorSlashApply * [test] fix the problem cause by unsafe usage of big.Int * [staking] added the copy methods to validatorWrapper * [test] added test cases for copy method for staking/validatorWrapper * [test] added test case TestApply * [test] added test case TestRate * [test] fix the golint errors * [test] removed commented out unit test code * [test] remote the empty line in imports * [test] moved copy methods to stake_testing module * [test] removed usage of interface stateDB * [test] removed empty lines in imports * [test] fixed golint package name issues * [test] removed a todo when writing code * [test] moved record.Copy to staking/slash/test * [test] add some changes * [test] added prototypes in staketest module * [test] fix the golint issue in staketest * [test] make prototype more beautiful * [test] refactored test TestCheckDuplicateFields * [test] add createValidator test data * [test] added positive test case for VerifyAndCreateValidatorFromMsg * [test] added create validator test * [test] added the positive test case for TestVerifyAndEditValidatorFromMsg * [test] added the tests case TestVerifyAndEditValidatorFromMsg * [test] fix one of the error is not triggered as expected * [test] more changes in test * [test] fix the positive test data for TestVerifyAndDelegateFromMsg * [test] Fixed two comment golint errors * [test] added delegate tests * [test] added a make function. WIP * [test] added undelegate positive test * [test] added negative test cases for undelegate * [test] added positive test. not passed. Need to add assert method in test suites * [test] added equal function to check Validator Equality * [test] added equals for staketest * [test] replaced deep equal with new equal methods: * [test] removed unused codes * [test] Finishing touch * [test] fix comment golint issue * [test] removed dead code in staking_verifier_test.go Co-authored-by: Ganesha Upadhyaya <ganeshrvce@gmail.com> * changed the sync port to dns port in flag * [network] Limit client sync connection (#3071) * [network] limit client connected peers * Changed signature and added tests * Set secure permissions on generated blskey pass file in node.sh * Fix spellin gtypo in node.sh * fix latest param handling in api v1 * added comment for the isGreaterThanLatestBlockNum check * fix a nil pointer crash due to previous revert Signed-off-by: Leo Chen <leo@harmony.one> * fix nil pointer crash Signed-off-by: Leo Chen <leo@harmony.one> * fix nil pointer of block Signed-off-by: Leo Chen <leo@harmony.one> * [rpc] add viewID and epoch to RPCMarshalBlock (#3009) * [rpc] add viewID and epoch to RPCMarshalBlock * add apt-get update * Do not rollback current block on failed block sync (#3101) Co-authored-by: Ganesha Upadhyaya <ganeshrvce@gmail.com> Co-authored-by: Rongjian Lan <rongjian.lan@gmail.com> Co-authored-by: Jacky Wang <jackyw.se@gmail.com> Co-authored-by: Janet Liang <56005637+janet-harmony@users.noreply.github.com> Co-authored-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> Co-authored-by: Janet Liang <janet@harmony.one> Co-authored-by: Sebastian Johnsson <sebastian.johnsson@gmail.com> Co-authored-by: hsiung <hsiung@pinterest.com> Co-authored-by: Dennis Won <jhwon0820@gmail.com> Co-authored-by: Yishuang Chen <34232522+ivorytowerdds@users.noreply.github.com>
5 years ago
return curToSign.Cmp(new(big.Int).Add(snapToSign, common.Big1)) == 0
}
// checkIncWrapperMissing is the compare function to check whether validator wrapper
// is expected for nodes who has missed a block.
func checkIncWrapperMissing(snapWrapper, curWrapper *staking.ValidatorWrapper) bool {
snapSigned := snapWrapper.Counters.NumBlocksSigned
curSigned := curWrapper.Counters.NumBlocksSigned
if curSigned.Cmp(snapSigned) != 0 {
return false
}
snapToSign := snapWrapper.Counters.NumBlocksToSign
curToSign := curWrapper.Counters.NumBlocksToSign
Merge master to t3 0523 (#3085) * fix signers share computation to use only non-harmony nodes (#3008) * Add LastEpochInCommittee at prestaking epoch too (#3014) * write validator stats at the end of prestaking epoch (#3021) * write validator stats at the end of prestaking epoch * also need to write block reward accumulator * [build] enable static build by default (#2885) scripts/go_executable_build.sh -s (static build, default) scripts/go_executable_build.sh -S (non-static build) Signed-off-by: Leo Chen <leo@harmony.one> * Code formatting fix based on `staticcheck` (#3023) * fix some static check issues * more fixes according to staticcheck * add nil check on getHeader * Add more log info * [rpc] Revert change to v2 GetBalance RPC (#3037) * Cherrypick crosslink related fixes from t3 to master. (#3045) * Optimize crosslink verification logic and add more cache (#3032) * make crosslink broadcast smarter and more efficient (#3036) * adjust catch up speed to be a sane number * Fix crosslink broadcast condition (#3041) * Tx pool error report fix & local build fix (#3046) * [tx_list] Add transaction after you can fetch tx cost * [tx_pool] Add error sink reports for removed tx * Correct log levels for known transactions * Remove redundant hash to `enqueue` and `add` signatures * Update tests for signature changes * [build] Fix local build for MacOs * [tx_pool] Correct typo & logging level for known tx * [config] Create Testnet config * [node.sh] update testnet network config * [config] correct testnet config * [main] Enable beacon sync for explorer nodes (#3059) * [apr] should not use snapshot from last epoch, use current epoch snapshot (#3051) * use snapshot total delegation instead of current total delegation * should not use snapshot from last epoch, use current epoch snapshot (#3049) Co-authored-by: Rongjian Lan <rongjian.lan@gmail.com> Co-authored-by: Rongjian Lan <rongjian.lan@gmail.com> * cherrypick log level change * [rpc] Add active status back to Validator information [validator] Fix typo for ValidatorRPCEnhanced [Makefile] Change make exe to build non-static by default * [network] Added caching to node server (#3048) * [network] Added caching to node server * [network] renamed two singleflight.Group * [network] added two error handling * [network] added forget logic for single flight * [network] changed single flight to lru cache solution * [network] adjusted the cache size * [network] changed cache size to 10000 * Transaction api improvements (#3057) * [node] Add option to broadcast invalid tx (on by default) * update main args to take in broadcast invalid tx * update node.sh for new broadcast invalid tx option * [rpc] Do not submit transaction if tx has been finalized * Support legacy behavior and not return errors on tx submission * [main] make broadcasting invalid tx default false * [node] Fix formatting * Add timeouts for the explorer HTTP service * [test] State trans unit test (#3043) * completing create-validator tests generalizing create validator tests, started with edit validator tests one round completed before major refactor * [test] finished coding test TestCheckDuplicateFields * [test] finished debug TestCheckDuplicateFields * [test] Added TestDescription_EnsureLength * [test] added test in validator_test.go TestUpdateDescription * [test] Added test TestComputed_String * [test] refactored TestValidatorSanityCheck and added some message in error message returned from sanity check * [test] removed test index for debugging * [test] Added test TestValidatorWrapper_SanityCheck. Added value check for TestMarshalUnmarshalValidator. Fixed rlp usage defect in UnmarshalValidator * [test] added test TestVerifyBLSKeys * [test] added test TestContainsHarmonyBLSKeys * [test] added test TestCreateValidatorFromNewMsg * [test] fixed some tests errors * [test] added test TestUpdateValidatorFromEditMsg, last editted the test file, finished testing validator_test.go * [staking] added numeric.Dec.Copy method * [staking] added CommissionRates.Copy * [staking] add nil case handle to copy method and related test case * [test] added nil case for commissionRates.Copy test * [staking] finished CreateValidator.Copy and related test case * [staking] added EditValidator.Copy method and related test case * [test] added zero test cases for Copy method * [staking] implemented Delegate.Copy and related unit test case * [staking] added Undelegate.Copy and CollectReward.Copy method. Implemented corresponding test cases * [test] added two more simple unit tests * [test] solving the merge conflict with deep copy fix * [test] added schedule for sharding * [test] refactored double_sign_test.go * [test] comment out all test cases for now. * [test] added record Copy method for testing * [test] added the first test case in TestVerify * [test] finished test TestVerify * [test] Added test TestVerify, TestApplySlashRate, TestSetDifference * [test] half through TestDelegatorSlashApply * [test] fix the problem cause by unsafe usage of big.Int * [staking] added the copy methods to validatorWrapper * [test] added test cases for copy method for staking/validatorWrapper * [test] added test case TestApply * [test] added test case TestRate * [test] fix the golint errors * [test] removed commented out unit test code * [test] remote the empty line in imports * [test] moved copy methods to stake_testing module * [test] removed usage of interface stateDB * [test] removed empty lines in imports * [test] fixed golint package name issues * [test] removed a todo when writing code * [test] moved record.Copy to staking/slash/test * [test] add some changes * [test] added prototypes in staketest module * [test] fix the golint issue in staketest * [test] make prototype more beautiful * [test] refactored test TestCheckDuplicateFields * [test] add createValidator test data * [test] added positive test case for VerifyAndCreateValidatorFromMsg * [test] added create validator test * [test] added the positive test case for TestVerifyAndEditValidatorFromMsg * [test] added the tests case TestVerifyAndEditValidatorFromMsg * [test] fix one of the error is not triggered as expected * [test] more changes in test * [test] fix the positive test data for TestVerifyAndDelegateFromMsg * [test] Fixed two comment golint errors * [test] added delegate tests * [test] added a make function. WIP * [test] added undelegate positive test * [test] added negative test cases for undelegate * [test] added positive test. not passed. Need to add assert method in test suites * [test] added equal function to check Validator Equality * [test] added equals for staketest * [test] replaced deep equal with new equal methods: * [test] removed unused codes * [test] Finishing touch * [test] fix comment golint issue * [test] removed dead code in staking_verifier_test.go Co-authored-by: Ganesha Upadhyaya <ganeshrvce@gmail.com> * changed the sync port to dns port in flag * [network] Limit client sync connection (#3071) * [network] limit client connected peers * Changed signature and added tests * Set secure permissions on generated blskey pass file in node.sh * Fix spellin gtypo in node.sh * fix latest param handling in api v1 * added comment for the isGreaterThanLatestBlockNum check * fix a nil pointer crash due to previous revert Signed-off-by: Leo Chen <leo@harmony.one> * fix nil pointer crash Signed-off-by: Leo Chen <leo@harmony.one> * fix nil pointer of block Signed-off-by: Leo Chen <leo@harmony.one> * [rpc] add viewID and epoch to RPCMarshalBlock (#3009) * [rpc] add viewID and epoch to RPCMarshalBlock * add apt-get update * Do not rollback current block on failed block sync (#3101) Co-authored-by: Ganesha Upadhyaya <ganeshrvce@gmail.com> Co-authored-by: Rongjian Lan <rongjian.lan@gmail.com> Co-authored-by: Jacky Wang <jackyw.se@gmail.com> Co-authored-by: Janet Liang <56005637+janet-harmony@users.noreply.github.com> Co-authored-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> Co-authored-by: Janet Liang <janet@harmony.one> Co-authored-by: Sebastian Johnsson <sebastian.johnsson@gmail.com> Co-authored-by: hsiung <hsiung@pinterest.com> Co-authored-by: Dennis Won <jhwon0820@gmail.com> Co-authored-by: Yishuang Chen <34232522+ivorytowerdds@users.noreply.github.com>
5 years ago
return curToSign.Cmp(new(big.Int).Add(snapToSign, common.Big1)) == 0
}
type computeEPOSTestCtx struct {
// input arguments
addr common.Address
snapSigned, snapToSign int64
snapEli effective.Eligibility
curSigned, curToSign int64
curEli effective.Eligibility
// computed fields
state testStateDB
reader testReader
}
// makeStateAndReader compute for state and reader given the input arguments
func (ctx *computeEPOSTestCtx) makeStateAndReader() {
ctx.reader = newTestReader()
if ctx.snapEli != effective.Nil {
wrapper := makeTestWrapper(ctx.addr, ctx.snapSigned, ctx.snapToSign)
wrapper.Status = ctx.snapEli
ctx.reader.updateValidatorWrapper(ctx.addr, &wrapper)
}
ctx.state = newTestStateDB()
if ctx.curEli != effective.Nil {
wrapper := makeTestWrapper(ctx.addr, ctx.curSigned, ctx.curToSign)
wrapper.Status = ctx.curEli
ctx.state.UpdateValidatorWrapper(ctx.addr, &wrapper)
}
}
func (ctx *computeEPOSTestCtx) checkWrapperStatus(expStatus effective.Eligibility) error {
Resolve harmony-one/bounties#90: Add revert mechanism for UpdateValidatorWrapper (#3939) * Add revert mechanism for UpdateValidatorWrapper Closes harmony-one/bounties#90 (1) Use LRU for ValidatorWrapper objects in stateDB to plug a potential memory leak (2) Merge ValidatorWrapper and ValidatorWrapperCopy to let callers ask for either a copy, or a pointer to the cached object. Additionally, give callers the option to not deep copy delegations (which is a heavy process). Copies need to be explicitly committed (and thus can be reverted), while the pointers are committed when Finalise is called. (3) Add a UpdateValidatorWrapperWithRevert function, which is used by staking txs `Delegate`, `Undelegate`, and `CollectRewards`. Other 2 types of staking txs and `db.Finalize` continue to use UpdateValidateWrapper without revert, again, to save memoery (4) Add unit tests which check a) Revert goes through b) Wrapper is as expected after revert c) State is as expected after revert * Change back to dictionary for stateValidators Since the memory / CPU usage saved is not significantly different when using an LRU + map structure, go back to the original dictionary structure to keep code easy to read and have limited modifications. * Add tests for validator wrapper reverts As requested by @rlan35, add tests beyond just adding and reverting a delegation. The tests are successive in the sense that we do multiple modifications to the wrapper, save a snapshot before each modification and revert to each of them to confirm everything works well. This change improves test coverage of statedb.go to 66.7% from 64.8% and that of core/state to 71.9% from 70.8%, and covers all the code that has been modified by this PR in statedb.go. For clarity, the modifications to the wrapper include (1) creation of wrapper in state, (2) adding a delegation to the wrapper, (3) increasing the blocks signed, and (4) a change in the validator Name and the BlockReward. Two additional tests have been added to cover the `panic` and the `GetCode` cases.
3 years ago
wrapper, err := ctx.state.ValidatorWrapper(ctx.addr, true, false)
if err != nil {
return err
}
if wrapper.Status != expStatus {
return fmt.Errorf("wrapper status unexpected: %v / %v", wrapper.Status, expStatus)
}
return nil
}
// testHeader is the fake Header for testing
type testHeader struct {
number *big.Int
shardID uint32
lastCommitBitmap []byte
}
func newTestHeader(number int64, shardID uint32, numSlots, numVerified int) *testHeader {
indexes := make([]int, 0, numVerified)
for i := 0; i != numVerified; i++ {
indexes = append(indexes, i)
}
bitmap, _ := indexesToBitMap(indexes, numSlots)
return &testHeader{
number: new(big.Int).SetInt64(number),
shardID: shardID,
lastCommitBitmap: bitmap,
}
}
func (th *testHeader) Number() *big.Int {
return th.number
}
func (th *testHeader) ShardID() uint32 {
return th.shardID
}
func (th *testHeader) LastCommitBitmap() []byte {
return th.lastCommitBitmap
}
// testStateDB is the fake state db for testing
type testStateDB map[common.Address]*staking.ValidatorWrapper
// newTestStateDB return an empty testStateDB
func newTestStateDB() testStateDB {
state := make(testStateDB)
return state
}
// newTestStateDBFromCommittee creates a testStateDB given a shard committee.
// The validator wrappers are only set for user nodes.
func newTestStateDBFromCommittee(cmt *shard.Committee) testStateDB {
state := make(testStateDB)
for _, slot := range cmt.Slots {
if slot.EffectiveStake == nil {
continue
}
var wrapper staking.ValidatorWrapper
wrapper.Address = slot.EcdsaAddress
wrapper.SlotPubKeys = []bls.SerializedPublicKey{slot.BLSPublicKey}
wrapper.Counters.NumBlocksSigned = new(big.Int).SetInt64(1)
wrapper.Counters.NumBlocksToSign = new(big.Int).SetInt64(1)
state[slot.EcdsaAddress] = &wrapper
}
return state
}
// snapshot returns a deep copy of the current test state
func (state testStateDB) snapshot() testStateDB {
res := make(map[common.Address]*staking.ValidatorWrapper)
for addr, wrapper := range state {
wrapperCpy := staking.ValidatorWrapper{
Validator: staking.Validator{
Address: addr,
SlotPubKeys: make([]bls.SerializedPublicKey, 1),
},
}
copy(wrapperCpy.SlotPubKeys, wrapper.SlotPubKeys)
wrapperCpy.Counters.NumBlocksToSign = new(big.Int).Set(wrapper.Counters.NumBlocksToSign)
wrapperCpy.Counters.NumBlocksSigned = new(big.Int).Set(wrapper.Counters.NumBlocksSigned)
res[addr] = &wrapperCpy
}
return res
}
Resolve harmony-one/bounties#90: Add revert mechanism for UpdateValidatorWrapper (#3939) * Add revert mechanism for UpdateValidatorWrapper Closes harmony-one/bounties#90 (1) Use LRU for ValidatorWrapper objects in stateDB to plug a potential memory leak (2) Merge ValidatorWrapper and ValidatorWrapperCopy to let callers ask for either a copy, or a pointer to the cached object. Additionally, give callers the option to not deep copy delegations (which is a heavy process). Copies need to be explicitly committed (and thus can be reverted), while the pointers are committed when Finalise is called. (3) Add a UpdateValidatorWrapperWithRevert function, which is used by staking txs `Delegate`, `Undelegate`, and `CollectRewards`. Other 2 types of staking txs and `db.Finalize` continue to use UpdateValidateWrapper without revert, again, to save memoery (4) Add unit tests which check a) Revert goes through b) Wrapper is as expected after revert c) State is as expected after revert * Change back to dictionary for stateValidators Since the memory / CPU usage saved is not significantly different when using an LRU + map structure, go back to the original dictionary structure to keep code easy to read and have limited modifications. * Add tests for validator wrapper reverts As requested by @rlan35, add tests beyond just adding and reverting a delegation. The tests are successive in the sense that we do multiple modifications to the wrapper, save a snapshot before each modification and revert to each of them to confirm everything works well. This change improves test coverage of statedb.go to 66.7% from 64.8% and that of core/state to 71.9% from 70.8%, and covers all the code that has been modified by this PR in statedb.go. For clarity, the modifications to the wrapper include (1) creation of wrapper in state, (2) adding a delegation to the wrapper, (3) increasing the blocks signed, and (4) a change in the validator Name and the BlockReward. Two additional tests have been added to cover the `panic` and the `GetCode` cases.
3 years ago
func (state testStateDB) ValidatorWrapper(addr common.Address, readOnly bool, copyDelegations bool) (*staking.ValidatorWrapper, error) {
wrapper, ok := state[addr]
if !ok {
return nil, fmt.Errorf("addr not exist in validator wrapper: %v", addr.String())
}
return wrapper, nil
}
func (state testStateDB) UpdateValidatorWrapper(addr common.Address, wrapper *staking.ValidatorWrapper) error {
state[addr] = wrapper
return nil
}
func (state testStateDB) GetCode(addr common.Address) []byte {
wrapper, ok := state[addr]
if !ok {
return nil
}
b, _ := rlp.EncodeToBytes(wrapper)
return b
}
// testReader is the fake Reader for testing
type testReader map[common.Address]staking.ValidatorWrapper
// newTestReader creates an empty test reader
func newTestReader() testReader {
reader := make(testReader)
return reader
}
func (reader testReader) ReadValidatorSnapshot(addr common.Address) (*staking.ValidatorSnapshot, error) {
wrapper, ok := reader[addr]
if !ok {
return nil, errors.New("not a valid validator address")
}
return &staking.ValidatorSnapshot{
Validator: &wrapper,
}, nil
}
func (reader testReader) updateValidatorWrapper(addr common.Address, val *staking.ValidatorWrapper) {
reader[addr] = *val
}
func makeTestShardState(numShards, numSlots int) *shard.State {
state := &shard.State{
Epoch: new(big.Int).SetInt64(0),
Shards: make([]shard.Committee, 0, numShards),
}
for shardID := uint32(0); shardID != uint32(numShards); shardID++ {
cmt := makeTestCommittee(numSlots, shardID)
state.Shards = append(state.Shards, *cmt)
}
return state
}
func makeTestCommittee(n int, shardID uint32) *shard.Committee {
slots := make(shard.SlotList, 0, n)
for i := 0; i != n; i++ {
slots = append(slots, makeHmySlot(i, shardID))
}
return &shard.Committee{
ShardID: shardID,
Slots: slots,
}
}
func makeHmySlot(seed int, shardID uint32) shard.Slot {
addr := common.BigToAddress(new(big.Int).SetInt64(int64(seed) + int64(shardID*1000000)))
var blsKey bls.SerializedPublicKey
copy(blsKey[:], bls.RandPrivateKey().GetPublicKey().Serialize())
return shard.Slot{
EcdsaAddress: addr,
BLSPublicKey: blsKey,
}
}
const testStake = int64(100000000000)
// makeTestMixedCommittee makes a committee with both harmony nodes and user nodes
func makeTestMixedCommittee(numHmySlots, numUserSlots int, shardID uint32) *shard.Committee {
slots := make(shard.SlotList, 0, numHmySlots+numUserSlots)
for i := 0; i != numHmySlots; i++ {
slots = append(slots, makeHmySlot(i, shardID))
}
for i := numHmySlots; i != numHmySlots+numUserSlots; i++ {
slots = append(slots, makeUserSlot(i, shardID))
}
return &shard.Committee{
ShardID: shardID,
Slots: slots,
}
}
func makeUserSlot(seed int, shardID uint32) shard.Slot {
slot := makeHmySlot(seed, shardID)
stake := numeric.NewDec(testStake)
slot.EffectiveStake = &stake
return slot
}
// indexesToBitMap convert the indexes to bitmap. The conversion follows the little-
// endian order.
func indexesToBitMap(idxs []int, n int) ([]byte, error) {
bSize := (n + 7) >> 3
res := make([]byte, bSize)
for _, idx := range idxs {
byt := idx >> 3
if byt >= bSize {
return nil, fmt.Errorf("overflow index when converting to bitmap: %v/%v", byt, bSize)
}
msk := byte(1) << uint(idx&7)
res[byt] ^= msk
}
return res, nil
}
func makeTestWrapper(addr common.Address, numSigned, numToSign int64) staking.ValidatorWrapper {
var val staking.ValidatorWrapper
val.Address = addr
val.Counters.NumBlocksToSign = new(big.Int).SetInt64(numToSign)
val.Counters.NumBlocksSigned = new(big.Int).SetInt64(numSigned)
return val
}