From 49eca7903a29ad820386dbbf37dcbcfc0f35bf1d Mon Sep 17 00:00:00 2001
From: Edgar Aroutiounian <edgar.factorial@gmail.com>
Date: Thu, 19 Mar 2020 22:14:19 -0700
Subject: [PATCH] [shard] singleflight on committees bls public keys (#2546)

---
 shard/shard_state.go | 56 ++++++++++++++++++++++++++++++++++----------
 1 file changed, 44 insertions(+), 12 deletions(-)

diff --git a/shard/shard_state.go b/shard/shard_state.go
index e0d0d5142..246940b5b 100644
--- a/shard/shard_state.go
+++ b/shard/shard_state.go
@@ -7,14 +7,17 @@ import (
 	"errors"
 	"math/big"
 	"sort"
+	"time"
 
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/rlp"
 	"github.com/harmony-one/bls/ffi/go/bls"
+	"github.com/harmony-one/harmony/crypto/hash"
 	common2 "github.com/harmony-one/harmony/internal/common"
 	"github.com/harmony-one/harmony/internal/ctxerror"
 	"github.com/harmony-one/harmony/numeric"
 	"golang.org/x/crypto/sha3"
+	"golang.org/x/sync/singleflight"
 )
 
 var (
@@ -382,23 +385,52 @@ func (c *Committee) DeepCopy() Committee {
 	return r
 }
 
+// Hash ..
+func (c *Committee) Hash() common.Hash {
+	return hash.FromRLPNew256(c)
+}
+
+var (
+	blsKeyCache singleflight.Group
+)
+
+func lookupBLSPublicKeys(
+	c *Committee,
+) ([]*bls.PublicKey, error) {
+	key := c.Hash().Hex()
+	results, err, _ := blsKeyCache.Do(
+		key, func() (interface{}, error) {
+			slice := make([]*bls.PublicKey, len(c.Slots))
+			for j := range c.Slots {
+				committerKey := &bls.PublicKey{}
+				if err := c.Slots[j].BlsPublicKey.ToLibBLSPublicKey(
+					committerKey,
+				); err != nil {
+					return nil, err
+				}
+				slice[j] = committerKey
+			}
+			// Only made once
+			go func() {
+				time.Sleep(25 * time.Minute)
+				blsKeyCache.Forget(key)
+			}()
+			return slice, nil
+		},
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	return results.([]*bls.PublicKey), nil
+}
+
 // BLSPublicKeys ..
 func (c *Committee) BLSPublicKeys() ([]*bls.PublicKey, error) {
 	if c == nil {
 		return nil, ErrSubCommitteeNil
 	}
-
-	slice := make([]*bls.PublicKey, len(c.Slots))
-	for j := range c.Slots {
-		committerKey := &bls.PublicKey{}
-		if err := c.Slots[j].BlsPublicKey.ToLibBLSPublicKey(
-			committerKey,
-		); err != nil {
-			return nil, err
-		}
-		slice[j] = committerKey
-	}
-	return slice, nil
+	return lookupBLSPublicKeys(c)
 }
 
 var (