[core] fix cache introduced by getHashByNumber (#3814)

3 years ago · 7b0f6ac8d5
parent ab5be8f413
commit 7b0f6ac8d5
1 changed files with 3 additions and 1 deletions
--- a/core/headerchain.go
+++ b/core/headerchain.go
@ -454,7 +454,9 @@ func (hc *HeaderChain) getHashByNumber(number uint64) common.Hash {
 		return hash.(common.Hash)
 	}
 	hash := rawdb.ReadCanonicalHash(hc.chainDb, number)
-	hc.canonicalCache.Add(number, hash)
+	if hash != (common.Hash{}) {
+		hc.canonicalCache.Add(number, hash)
+	}
 	return hash
 }